Michael added a comment.
In T249717#6079266 <https://phabricator.wikimedia.org/T249717#6079266>, @Lucas_Werkmeister_WMDE wrote: > The implementation for this might be interesting, I think. Currently, `ErrorWrapper` has a lot of getters in its own class, for processing the list of errors from the store: `permissionErrors`, `unsupportedDatatypeError`, etc. The straightforward approach (to me) would be to add something similar for `saveErrors`, and mount the `ErrorSaving` if that list is not empty. > But it looks like we’ll also need some similar logic in the store itself, for the store getter that indicates whether the “back” button should be shown or not (T249718 <https://phabricator.wikimedia.org/T249718>). So maybe some of this logic to filter the errors should move from `ErrorWrapper` into the store itself? What do you think, @Michael? I'm fine with that logic moving (partly) back into the store. Probably in form of a getter `isSavingError()`? Maybe that could then also be used by the `canGoBackToPreviousState()` getter 🤔 TASK DETAIL https://phabricator.wikimedia.org/T249717 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
