[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-15 Thread Volker_E
Volker_E added a subscriber: SCherukuwada. Volker_E added a comment. @karapayneWMDE jfyi @Jdlrobson is on vacation this and next week. Defer to @SCherukuwada and @nray for possible feedback here in the meantime. In T275251#7504118 ,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-15 Thread karapayneWMDE
karapayneWMDE added a comment. @Jdlrobson, there's movement for option 3, but will the timeline for it match the requirement? Above you mentioned that you may be unable to support the current version past November. Do we need to decide on an in-between step or are we confident that we'll be

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-09 Thread Michael
Michael changed the task status from "Open" to "Stalled". Michael added a comment. This is currently waiting on T291526: Make a plan for TypeaheadSearch's inclusion in the new Vue component library TASK DETAIL

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-03 Thread karapayneWMDE
karapayneWMDE added a comment. Great! Added this to our task board. We'll review the level of effort for the codex implementation tomorrow and, assuming the codex element doesn't bloat the scope to an absurd degree, let the DS team know this is happening TASK DETAIL

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-03 Thread karapayneWMDE
karapayneWMDE edited projects, added Wikidata-Campsite (Team A Hearth ); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Michael,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-03 Thread Jdlrobson
Jdlrobson added a comment. Awesome! Regarding the UI, 3 sounds like the best approach if you have capacity. We eventually need to port this to Codex anyway, so any work you do towards this would be super helpful. Rethinking this component from the Wikimedia DE perspective would also be

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-11-03 Thread karapayneWMDE
karapayneWMDE added a comment. @jdlrobson, apologies for the delay in response! We now have capacity in the team and this task is top of our list. After reviewing, our proposal would be this: Update the search box, adding in - language support - a match alias as a new element

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-10-07 Thread LGoto
LGoto edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog (Tracking). TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: LGoto Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-22 Thread Jdlrobson
Jdlrobson added a comment. The feature is feature flagged, so I'm assuming you could do the work that isn't blocked by product so we can at least make a little bit of progress here? As noted in T275251#7325272 my team cannot guarantee

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-21 Thread Addshore
Addshore moved this task from To Prioritize to Blocked on the wdwb-tech board. Addshore added a comment. We put this through our tech track prioritization session today and then realized that in order for us to be able to tackle it via this track (which means we have to keep product happy /

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-17 Thread Jdlrobson
Jdlrobson added a comment. I'm happy to help with code review etc. > I would hope then that swapping out which client should be used based on if Wikibase is loaded or not would be fairly trivial? And that should either live in WVUI or in Wikibase as some kind of override? My

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-17 Thread Addshore
Addshore added a comment. So it looks like the only thing we would need to implement to enable a different API format to work would be https://github.com/wikimedia/wvui/blob/d77d02ac54ca2ba9a22e93ffe20debf36fc2e37b/src/components/typeahead-search/http/restSearchClient.ts#L11 This seems to

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-16 Thread Jdlrobson
Jdlrobson added a subscriber: Volker_E. Jdlrobson added a comment. > So we would want to provide a separate API (which you say is fine) Yep new API is fine and the path of least resistance, > So we do not want to confuse things by adding entity search to rest.php/v1/search/title

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-16 Thread Addshore
Addshore added a comment. Hi @Jdlrobson So initially highlighting what is currently displayed in our results 1. Label of matched entity with fallback in user language 2. Matched string, which can include fallback, would be one of label, alias, or Qid (item ID) 3. Description

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-09 Thread Jdlrobson
Jdlrobson added a comment. @karapayneWMDE I've setup T290688 with the proposed next step in case you want to test the implications on Wikidata for the modern Vector skin. I'd like to either merge this within the next 2 weeks, or at the latest

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-01 Thread Jdlrobson
Jdlrobson added a comment. Hi @karapayneWMDE later today, I'm making a config change which will mean Wikidata is the only Wikimedia project that does not use the Vue search. I think the timeline is dependent on you. Ideally, I would like to drop support for the old search now, which

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-01 Thread karapayneWMDE
karapayneWMDE added a comment. @Jdlrobson Hello! new EM for wd here  By when would you need a response on what to do in order to not jeopardize the porting process? TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-09-01 Thread GreenReaper
GreenReaper added a comment. Regarding the ranking discussion, I would've thought you're more likely to want a Lexeme if you're on a page about a Lexeme already, and so it should be prioritized in the results list (but not to the extent of excluding other results). That should perhaps

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-07-28 Thread Jdlrobson
Jdlrobson added a comment. Has any progress been made with this API? We (the web team) will be beginning the process for porting the mobile site to this component and without this API we will need to consider one of two options, neither of which is great: 1. disabling the

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-06-30 Thread Addshore
Addshore added a project: Wikibase Release Strategy. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-05-10 Thread Jdlrobson
Jdlrobson added a parent task: T282473: [GOAL] Use the wvui search widget inside the mobile site. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: darthmon_wmde, WMDE-leszek, daniel,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-04-27 Thread Jdlrobson
Jdlrobson added a parent task: T281318: [EPIC] Enable new WVUI search on Wikidata.org. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-04-26 Thread ovasileva
ovasileva edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog (Kanbanana-FY-2020-21). TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ovasileva Cc: darthmon_wmde,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-04-22 Thread Addshore
Addshore added a comment. > For the "same UI, different backend" solution, that would work. The big question is whether Wikidata is OK with "same UI", loosing the extra fatures. Sounds like we need to create a comparison of what the current Wikidata search UI does and what the current /

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-26 Thread daniel
daniel added a comment. In T275251#6949064 , @Jdlrobson wrote: >> One long standing issue with the search box on commons is that namespace prefixes do not work. You can't type in "User:..." to search user pages. Since the search box

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-26 Thread Jdlrobson
Jdlrobson added a comment. > One long standing issue with the search box on commons is that namespace prefixes do not work. You can't type in "User:..." to search user pages. Since the search box always hits entitysearch, it won't find anything. To fix this, there has to be code somewhere

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-26 Thread daniel
daniel added a comment. Another fun wrinkle to all this: One long standing issue with the search box on commons is that namespace prefixes do not work. You can't type in "User:..." to search user pages. Since the search box always hits entitysearch, it won't find anything. To fix this,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-26 Thread daniel
daniel added a comment. In T275251#6947445 , @Jdlrobson wrote: > I understand and I'm saying that this could be implemented using an abstracted PHP interface which provides a contract for the format in the response, without having any

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-25 Thread Jdlrobson
Jdlrobson added a comment. > My concern is from the perspective of the core API: it has a specific contract, and it should not be used for things that do not match that contract. The contract is: "Searches wiki page titles, and returns pages with titles that begin with the provided search

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-25 Thread daniel
daniel added a comment. In T275251#6945709 , @Jdlrobson wrote: > Please no more UI components.. that would be a maintenance disaster as Wikidata would need to do this for every skin (we plan to use this same Vue component inside the

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-25 Thread Jdlrobson
Jdlrobson added a comment. > In my mind, it should be a different UI component, backed by a dedicated API. The way we hacked this into the skin in the past was rather nasty, perhaps a better mechanism can be found. Please no more UI components.. that would be a maintenance disaster as

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-25 Thread daniel
daniel added a comment. I'm unconvinced that hooking into SearchHandler is the Right Thing. The endpoint is `/v1/search/title`, making that do anything but title auto-completion would be confusing, it would break the contract. I'd also argue that we will still want title auto-completion for

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-20 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.  TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-19 Thread Addshore
Addshore added a project: Wikidata-Campsite. Addshore added a comment. It sounds like the "right" thing to do for now would be to return everything here, starting with items, then properties, then lexemes (as a starting point). We could probably use our search code that powered

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-18 Thread MPhamWMF
MPhamWMF added a comment. @Addshore, I talked with the Search Platform team about ranking results, i.e. the Tree example, and I think the consensus is unfortunately that there's not a single correct answer to this in the general case. Realistically we'd have to dig more into what Wikidata

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-17 Thread LGoto
LGoto moved this task from Needs Analysis to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board. LGoto added a comment. Web team would like to discuss the status of this with the associated teams. TASK DETAIL https://phabricator.wikimedia.org/T275251 WORKBOARD

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-17 Thread LGoto
LGoto added a project: Readers-Web-Backlog (Kanbanana-FY-2020-21). TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: LGoto Cc: Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-17 Thread Jdlrobson
Jdlrobson added a comment. > @Jdlrobson could you provide a screenshot of the look and feel of the new results view (or somewhere to see it) @addshore you can test this out on https://wikidata.beta.wmflabs.org/ F34166151: Screen Shot 2021-03-17 at 9.23.30 AM.png

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

2021-03-17 Thread TJones
TJones renamed this task from "Rest Search API is not wikidata aware (only accepts queries beginning with Q" to "Rest Search API is not wikidata aware (only accepts queries beginning with Q)". TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-17 Thread Addshore
Addshore added subscribers: MPhamWMF, Yair_rand. Addshore added a comment. So right now the fact that the searchbox is only searching items is not good. This makes it hard to find lexeme,s project pages etc. So the current state is not ideal for us. We don't have any great ideas about

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-09 Thread BPirkle
BPirkle edited projects, added Platform Engineering; removed Platform Team Workboards. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-06 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. In T275251#6884087 , @Addshore wrote: > Current behaviour is that we only override the search box in the top right, and other search (special:search and apis etc) remain the same. > @Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-05 Thread Jdlrobson
Jdlrobson added a project: WVUI. TASK DETAIL https://phabricator.wikimedia.org/T275251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, caldera, maantietaja, Naike,

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-05 Thread Jdlrobson
Jdlrobson added a comment. Another problem here is going to be that for instrumentation details, the url of suggestions is https://www.wikidata.org/w/index.php?search=Universe+%28Q1%29 On wikipedia such a query would redirect directly to the title e.g.

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-04 Thread Addshore
Addshore added a comment. > While the new search UI works, as mentioned its only searching across titles. We will need to do more that title search for Wikidata / Wikibases. > Perhaps all that's needed is a hook for Wikidata to change where the search looks. It sounds like

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-02-24 Thread Jdlrobson
Jdlrobson added a project: Platform Team Workboards. Jdlrobson added a comment. Yeh, we are moving away from the jquery autocomplete implementation and will no longer be supporting it inside Vector (and at some point Minerva). The new version of the search is built via Vue.js and uses

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-02-23 Thread Addshore
Addshore added subscribers: Lydia_Pintscher, Addshore. Addshore moved this task from Incoming to Research on the wdwb-tech-focus board. Addshore added a comment. > This means in future Wikidata will become useless with the roll out of the latest version of Vector and will stall further

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-02-19 Thread Jdlrobson
Jdlrobson created this task. Jdlrobson added projects: Desktop Improvements, Wikidata, RESTBase-API, Technical-Debt. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech-focus. TASK DESCRIPTION The existing search API only works with queries