[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Volker_E]

Volker_E added a subscriber: SCherukuwada.
Volker_E added a comment.


  @karapayneWMDE jfyi @Jdlrobson is on vacation this and next week. Defer to 
@SCherukuwada and @nray for possible feedback here in the meantime.
  
  In T275251#7504118 , 
@karapayneWMDE wrote:
  
  > @Jdlrobson, there's movement for option 3, but will the timeline for it 
match the requirement? Above you mentioned that you may be unable to support 
the current version past November. Do we need to decide on an in-between step 
or are we confident that we'll be able to get this into codex before our 
current version can no longer be supported?
  >
  > In T275251#7372590 , 
@Jdlrobson wrote:
  >
  >> ... As noted in T275251#7325272 
 my team cannot guarantee 
support for the existing code in the new opt-in Vector skin beyond November.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Volker_E
Cc: SCherukuwada, nray, Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, 
karapayneWMDE, GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, 
daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[karapayneWMDE]

karapayneWMDE added a comment.


  @Jdlrobson, there's movement for option 3, but will the timeline for it match 
the requirement? Above you mentioned that you may be unable to support the 
current version past November. Do we need to decide on an in-between step or 
are we confident that we'll be able to get this into codex before our current 
version can no longer be supported?
  
  In T275251#7372590 , 
@Jdlrobson wrote:
  
  > ... As noted in T275251#7325272 
 my team cannot guarantee 
support for the existing code in the new opt-in Vector skin beyond November.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: nray, Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Michael]

Michael changed the task status from "Open" to "Stalled".
Michael added a comment.


  This is currently waiting on T291526: Make a plan for TypeaheadSearch's 
inclusion in the new Vue component library 


TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: nray, Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[karapayneWMDE]

karapayneWMDE added a comment.


  Great! Added this to our task board. We'll review the level of effort for the 
codex implementation tomorrow and, assuming the codex element doesn't bloat the 
scope to an absurd degree, let the DS team know this is happening

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[karapayneWMDE]

karapayneWMDE edited projects, added Wikidata-Campsite (Team A Hearth ); 
removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  Awesome!
  
  Regarding the UI, 3 sounds like the best approach if you have capacity. We 
eventually need to port this to Codex anyway, so any work you do towards this 
would be super helpful. Rethinking this component from the Wikimedia DE 
perspective would also be an invaluable exercise!
  
  In terms of integrating it into MediaWiki, inside Vector, the configuration 
$wgVectorWvuiSearchOption can be used to turn on any Wikidata specific 
behaviours eg. match alias/language support.
  
  If we end up with a lot of code that's Wikidata perspective, you might want 
to consider allowing Vector to disable the search widget altogether so that 
Wikidata can provide its own variant/setup code. Note, that in future we'll be 
using this same component in the mobile site so that's worth considering when 
thinking about how best to architect this right now.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[karapayneWMDE]

karapayneWMDE added a comment.


  @jdlrobson, apologies for the delay in response! We now have capacity in the 
team and this task is top of our list. After reviewing, our proposal would be 
this:
  
  Update the search box, adding in
  
  - language support
  - a match alias as a new element
  
  To this end there are three implementation options
  
  1. Build on top/modify existing WVUI typeahead search component
  2. Creating a WB variant of the existing WVUI typeahead component
  3. Creating the Codex (vue3) typeahead component
  
  As our proposal involves working on topics normally outside of WMDE's scope, 
please let me know if the proposal is fine and which of the implementation 
options would work best for y'all. We can also arrange a call if you'd like to 
discuss it all in more detail.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Volker_E, Manuel, karapayneWMDE, 
GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Romain, Patafisik_WMF, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, WDoranWMF, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, 
Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[LGoto]

LGoto edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog 
(Tracking).

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LGoto
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Romain, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  The feature is feature flagged, so I'm assuming you could do the work that 
isn't blocked by product so we can at least make a little bit of progress here?
  
  As noted in T275251#7325272 
 my team cannot guarantee 
support for the existing code in the new opt-in Vector skin beyond November.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore moved this task from To Prioritize to Blocked on the wdwb-tech board.
Addshore added a comment.


  We put this through our tech track prioritization session today and then 
realized that in order for us to be able to tackle it via this track (which 
means we have to keep product happy / not negatively change user experience) we 
would need to fix the WVUI part mentioned in T275251#7359339 

  
  > 4. Add "continue" functionality to API
  > 5. Expand WVUI to support more functionality.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3532/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  I'm happy to help with code review etc.
  
  > I would hope then that swapping out which client should be used based on if 
Wikibase is loaded or not would be fairly trivial? And that should either live 
in WVUI or in Wikibase as some kind of override?
  
  My expectation is ideally this would be a config only change .
  Ideally Wikidata would set `wgVectorSearchApi = 
'/w/rest.php/v1/wikidata-search/title?q=$1=$2.` and it would just work.
  
  However, here's an approach that can be used right now to demonstrate a 
potential short-term client that could live inside wikibase using the old API. 
Paste this code into your JS console on 
https://en.wikipedia.org/?useskinversion=2=vector to see in action.
  
mw.config.set('wgVectorSearchClient', {
fetchByTitle: function ( query, domain, limit = 10 ) {
var abort = function () {
// not implemented
};
var fetched = fetch( 
'https://www.wikidata.org/w/api.php?origin=*=wbsearchentities=json=plaintext=en=en=item='
 + query )
.then( function ( res ) {
console.log('hi', res);
return res.json();
} ).then( function (data) {
var result = {
query: query,
results: data.search.map( function ( 
search ) {
return {
id: search.pageid,
key: search.id,
title: search.label + ' 
(' + search.title + ')',
description: 
search.description
// thumbnail: TODO
}
} )
};
return result;
} );

return {
abort : abort,
fetch: fetched
};
}
})

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore added a comment.


  So it looks like the only thing we would need to implement to enable a 
different API format to work would be 
https://github.com/wikimedia/wvui/blob/d77d02ac54ca2ba9a22e93ffe20debf36fc2e37b/src/components/typeahead-search/http/restSearchClient.ts#L11
  This seems to be the place where the API definition of what a Search Result 
Object 
 
switch to being a `RestResult` in WVUI.
  It looks like this could also be the place to tidy up some terminology if 
this is meant to be a generic search, such a fetchByTitle 

 etc.
  As mentioned in the directory structure, this should probably be a generic 
`typeahead-search` not tied to MediaWiki or MediaWIki concepts.
  
  I would hope then that swapping out which client should be used based on if 
Wikibase is loaded or not would be fairly trivial? And that should either live 
in WVUI or in Wikibase as some kind of override?
  
  If that is the case I see no reason that when we have some free resources we 
couldn't quickly implement this TS client for the slightly different format.
  And then also implement the REST api.
  I'd advocate for an API in core that uses a less mediawikiy, more generic 
type ahead focused format too.
  That would also open up this #WUVI component for use in other contexts!

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a subscriber: Volker_E.
Jdlrobson added a comment.


  > So we would want to provide a separate API (which you say is fine)
  
  Yep new API is fine and the path of least resistance,
  
  > So we do not want to confuse things by adding entity search to 
rest.php/v1/search/title that is specifically meant to search for titles
  
  We'd need to make some tweaks to the #WVUI 
 and #Vector 
 to allow configuration of the 
API path. We have wgVectorSearchHost for changing the host, so I'd take care of 
things that side making sure this configuration evolves to include path.
  
  > Can we provide a different API format, that is more generic for a search 
usecase, rather than one that it tightly bound to MediaWiki concepts? (this 
would probably need some changes in JS, but probably small ones?)
  
  One of the problems with the existing search is we had lots of client code 
JavaScript specific to Wikibase or configuration code to support Wikibase.  For 
example this code in MobileFrontend: 
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/src/mobile.startup/extendSearchParams.js#L28
 I really want us to get away from that in the new search by handling this 
stuff on the server side.
  
  I think it would be okay to expand the existing format but I'd rather not 
deviate too much from it e.g. we should keep the "pages" entry in the response, 
"title" to mean the search title we display in suggestions, description for 
description and thumbnail to mean thumbnail. I think it's okay to add new 
fields though if that's what you mean?
  
  WVUI is in control of rendering, so we could expand WVUI to render those 
additional properties in some way. You'd need to work with the #wvui 
  team (I'd suggest @Volker_E) to  
incorporate those UI changes but I don't see why not.
  
{
"id":3012251,
"key":"Q3153277",
// label
"title":"International Journal of Molecular Sciences",
// Description with fallback of the entity
description":"peer-reviewed scientific journal",
"thumbnail":null

// Wikidata specific entry
// Add new item to API entry for matched string, which can include 
fallback, would be one of label, alias, or Qid (item ID)
"fallback":
},
  
  > Is there a way to add functionality to the search to allow this More 
expansion bar?
  
  There isn't right now. It sounds like this would be a request for a 2nd page 
of results? The API could be expanded to have a "continue" parameter, and you'd 
need to talk to @Volker_E and a designer about how that would be incorporated 
in the UI.
  
  My suggestion would be:
  
  [ ] 1) current UI searching and displaying labels rather than Q codes
  [ ] 2) Expand API to include new parameters
  [ ] 3) Expand WVUI/Vector to support rendering the new optional API data
  [ ] 4) Add "continue" functionality to API
  [ ] 5) Expand WVUI to support more functionality.
  
  Note new Vector is currently planned for Wikipedias in 2022, but the timeline 
for Wikidata.org doesn't need to be that. We can make it default when all the 
above is done.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Volker_E, Manuel, karapayneWMDE, GreenReaper, R4356th, despens, 
darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, 
Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Niedzielski, Izno, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore added a comment.


  Hi @Jdlrobson
  
  So initially highlighting what is currently displayed in our results
  
  1. Label of matched entity with fallback in user language
  2. Matched string, which can include fallback, would be one of label, alias, 
or Qid (item ID)
  3. Description with fallback of the entity
  
  F34644686: image.png 
  
  > The main blocker for this is having a functioning search API that returns 
results for queries such as 
https://wikidata.org/w/rest.php/v1/search/title?q=Q3=10. It's also 
acceptable for Wikidata to provide its own API if that is preferred - the 
search API is configurable and we can point to any service you want to, 
provided the response is consistent with that APIs specification.
  
  So we do not want to confuse things by adding entity search to 
`rest.php/v1/search/title` that is specifically meant to search for titles, the 
functionality there should remain the same and just be provided by MediaWiki, 
as also expressed by daniel in T275251#6944581 
, this would break the 
contract.
  So we would want to provide a separate API (which you say is fine)
  However we don't really want to have to provide an API response that is again 
confusing if people were to ever look at it (with title etc).
  Is there some way we could provide some sort of API adapter or a second 
format that this JS code can deal with?
  
  Taking inspiration from 
https://www.mediawiki.org/wiki/API:REST_API/Reference#Search_result_object
  We would want to return:
  
  - **Page title**, or just **URL to link to** for the result. Thinking ahead 
for possible future cases we may want to consider, URL would be preferred
  - **Display line 1** - Which in our case would be something like `LABEL 
(MATCH)` where LABEL is a fall back enabled label for user display and MATCH is 
the string that actually matched, if different from that label
  - **Display line 2** - This would be our description with language fallback
  - **Image url** - We wouldn't provide this initially, but would want to in 
the future, and would ideally like to hide the image doesn't exist part of the 
result
  
  But we don't want to introduce a confusing situation of miss using the API, 
or format.
  Perhaps this is even something that should change in the main REST spec?
  
  The other key part of the experience that we don't want to loose is the 
`More` bar.
  
  F34644680: image.png 
  
  Clicking this expands the existing results without navigating to another page
  
  F34644682: image.png 
  
  So some concrete questions:
  
  1. Can we provide a different API format, that is more generic for a search 
usecase, rather than one that it tightly bound to MediaWiki concepts? (this 
would probably need some changes in JS, but probably small ones?)
  2. Is there a way to add functionality to the search to allow this `More` 
expansion bar?

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Manuel, karapayneWMDE, GreenReaper, R4356th, despens, darthmon_wmde, 
WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, 
ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Patafisik_WMF, 
Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, 
holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, GWicke, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  @karapayneWMDE I've setup T290688  
with the proposed next step in case you want to test the implications on 
Wikidata for the modern Vector skin. I'd like to either merge this within the 
next 2 weeks, or at the latest December 1st, if 3 months is a reasonable 
timeline to address this issue. Please let me know your preference.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Manuel, karapayneWMDE, GreenReaper, R4356th, despens, darthmon_wmde, 
WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, 
ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Patafisik_WMF, 
Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, 
holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, GWicke, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  Hi @karapayneWMDE later today, I'm making a config change which will mean 
Wikidata is the only Wikimedia project that does not use the Vue search.
  
  I think the timeline is dependent on you.
  
  Ideally, I would like to drop support for the old search now, which would 
mean that Wikidata for the modern Vector skin would have no autocomplete 
functionality. This might be okay, as Wikidata currently doesn't have the new 
Vector set as the default skin, but I want to double-check that with you. If 
you want more time, I can offer 3 months maximum at this point, after which I'd 
feel uncomfortable maintaining the old search with the new skin.
  
  According to https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements, 
we are looking to make the new skin the default on all wikis by the end of the 
year, so ideally we need to make the search compatible with Wikidata before the 
end of the year.
  
  The main blocker for this is having a functioning search API that returns 
results for queries such as 
https://wikidata.org/w/rest.php/v1/search/title?q=Q3=10. It's also 
acceptable for Wikidata to provide its own API if that is preferred - the 
search API is configurable and we can point to any service you want to, 
provided the response is consistent with that APIs specification.
  
  Let me know if you want to chat through this in a video call with a WMDE 
Engineer

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: karapayneWMDE, GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, 
daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Patafisik_WMF, Invadibot, Selby, caldera, 
maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, EvanProdromou, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, 
Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[karapayneWMDE]

karapayneWMDE added a comment.


  @Jdlrobson  Hello! new EM for wd here 
  
  By when would you need a response on what to do in order to not jeopardize 
the porting process?

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, 
daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Patafisik_WMF, Invadibot, Selby, caldera, 
maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, EvanProdromou, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, 
Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[GreenReaper]

GreenReaper added a comment.


  Regarding the ranking discussion, I would've thought you're more likely to 
want a Lexeme if you're on a page about a Lexeme already, and so it should be 
prioritized in the results list (but not to the extent of excluding other 
results).
  
  That should perhaps be split off into a separate task, though. The priority 
//here// seems to be "make a hook that can return a search engine for results".
  
  From a user perspective, I think many consumers would actually want 
Wikidata's "identifier matched somewhere" as a result. But I appreciate that it 
might break things if results are returned that do not correspond to title 
prefix matches.
  
  If the search title contract is not to be altered, maybe the change needed is 
a hook for the endpoint used to make queries, that the UI code uses, as well as 
an implementation of such an endpoint? Maybe Wikibase could hook the search 
content 
 API 
and add data to it, and the UI component could be directed to use that, rather 
than creating a whole new endpoint? Conceptually the content being matched is 
similar to page content.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: GreenReaper
Cc: GreenReaper, R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, 
alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, 
Lydia_Pintscher, Aklapper, Jdlrobson, Patafisik_WMF, Invadibot, Selby, caldera, 
maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, EvanProdromou, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, 
Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  Has any progress been made with this API?
  
  We (the web team) will be beginning the process for porting the mobile site 
to this component and without this API we will  need to consider one of two 
options, neither of which is great:
  
  1. disabling the JavaScript enhancement for search on Wikidata.
  
  OR
  
  2. Moving the frontend code to a Wikidata extension as technical debt to be 
tackled at a later date.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, 
LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, 
Demian, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore added a project: Wikibase Release Strategy.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: R4356th, despens, darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, 
LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Patafisik_WMF, Invadibot, Selby, caldera, maantietaja, Akuckartz, 
Demian, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Volker_E, 
Niedzielski, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a parent task: T282473: [GOAL] Use the wvui search widget 
inside the mobile site.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a parent task: T281318: [EPIC] Enable new WVUI search on 
Wikidata.org.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[ovasileva]

ovasileva edited projects, added Readers-Web-Backlog (Tracking); removed 
Readers-Web-Backlog (Kanbanana-FY-2020-21).

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore added a comment.


  > For the "same UI, different backend" solution, that would work. The big 
question is whether Wikidata is OK with "same UI", loosing the extra fatures.
  
  Sounds like we need to create a comparison of what the current Wikidata 
search UI does and what the current / new MediaWiki search UI allows.
  Then from that comparison we can see if either:
  
  1. Wikibase / Wikidata is willing to drop any of the data that is displayed / 
functionality
  2. See if the new UI is able to deal with the differences that would not be 
dropped.
  
  This can then decide the question of 1 UI that is generic and meets all 
cases, or 2 UIs, one for MediaWiki and one for Wikibase search.
  
  > For wikibase, it's a conceptual issue, since "User:Foo" can be a user page 
and also the label of an item, and the search should find both.
  
  Indeed

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[daniel]

daniel added a comment.


  In T275251#6949064 , 
@Jdlrobson wrote:
  
  >> One long standing issue with the search box on commons is that namespace 
prefixes do not work. You can't type in "User:..." to search user pages. Since 
the search box always hits entitysearch, it won't find anything. To fix this, 
there has to be code somewhere that recognizes namespace prefixes, and based on 
that decides whether to do a title search or an entity search. Doing this on 
the client side would be more flexible (e.g. could show both results in 
separate sections).
  >
  > That's tracked in T277363 .
  
  Not exactly the same issue... or rather, another instance of the same issue. 
Wikidata has had this problem forever, since searchentities doesn't know about 
namespaces at all.
  
  I'm bringing it up here because the solution to this ticket should somehow 
address the question of how title-based search in some namespaces might be 
combined with label based search in other namespaces. Both in the UI and in the 
API.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  > One long standing issue with the search box on commons is that namespace 
prefixes do not work. You can't type in "User:..." to search user pages. Since 
the search box always hits entitysearch, it won't find anything. To fix this, 
there has to be code somewhere that recognizes namespace prefixes, and based on 
that decides whether to do a title search or an entity search. Doing this on 
the client side would be more flexible (e.g. could show both results in 
separate sections).
  
  That's tracked in T277363 .

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[daniel]

daniel added a comment.


  Another fun wrinkle to all this:
  
  One long standing issue with the search box on commons is that namespace 
prefixes do not work. You can't type in "User:..." to search user pages. Since 
the search box always hits entitysearch, it won't find anything. To fix this, 
there has to be code somewhere that recognizes namespace prefixes, and based on 
that decides whether to do a title search or an entity search. Doing this on 
the client side would be more flexible (e.g. could show both results in 
separate sections).

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[daniel]

daniel added a comment.


  In T275251#6947445 , 
@Jdlrobson wrote:
  
  > I understand and I'm saying that this could be implemented using an 
abstracted PHP interface which provides a contract for the format in the 
response, without having any knowledge of the implementation.
  
  That is possible, but I don't see the point. Why add another layer of 
indirection in order to make the same endpoint to two different things?
  
  > When I mean spec, I'm referring to the output API.
  
  The format of the output is one part of the contract. The other part is the 
relationship between the input and the output, which is defined as "title 
prefix".  To accommodate the Wikibase use case, it would have to be softened to 
"some kind of match to an identifier of the page" (doesn't have to be the 
title, but it's not full text either).
  
  I'd rather not weaken the contract of the existing endpoint. I'd prefer a 
separate endpoint, that has a compatible output format.
  
  > If an API was created that returned data in the same format, the search UI 
would mostly function.
  
  Yes, mostly. The question is whether that's good enough. I recall that we 
invested quite a bit of work into getting additional information into the 
search popup.
  
  For example, if I type "تهران" into the search box on wikidata.org, the API 
responds with entries like this:
  
{
   "id":"Q643031",
   "title":"Q643031",
   "pageid":605069,
   "repository":"wikidata",
   "url":"//www.wikidata.org/wiki/Q643031",
   "concepturi":"http://www.wikidata.org/entity/Q643031;,
   "label":"Tehran County",
   "description":"county in Tehran, Iran",
   "match":{
  "type":"label",
  "language":"ps",
  "text":"\u062a\u0647\u0631\u0627\u0646 
\u0648\u0644\u0633\u0648\u0627\u0644\u06cd"
   },
   "aliases":[
  "\u062a\u0647\u0631\u0627\u0646 
\u0648\u0644\u0633\u0648\u0627\u0644\u06cd"
   ]
},
  
  Note the "match" and "aliases" keys, and note the rendering of the matched 
alias in the popup, separate from the disambiguating description, with correct 
LTR orientation:
  
  F34191649: Bildschirmfoto von 2021-03-26 11-32-54.png 

  
  Extra info like this can be added to the search/title endpoint, the output is 
extensible. It could also be returned from a separate endpoint. But the UI 
would also need to use it, that's why I was suggesting a separate UI component. 
Anyway, assessing the importance of this is up to the Wikidata folks. I'm more 
concerned with the contract of the `search/title` endpoint.
  
  > The implementation can be completely different, living in Wikidata if 
necessary. Right now, we allow configuration on the host level, but if this is 
the direction we want to take, we can make the path configurable our side to to 
support this.
  
  For the "same UI, different backend" solution, that would work. The big 
question is whether Wikidata is OK with "same UI", loosing the extra fatures.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  > My concern is from the perspective of the core API: it has a specific 
contract, and it should not be used for things that do not match that contract. 
The contract is: "Searches wiki page titles, and returns pages with titles that 
begin with the provided search terms."
  
  I understand and I'm saying that this could be implemented using an 
abstracted PHP interface which provides a contract for the format in the 
response, without having any knowledge of the implementation.
  
  > The problem is that Wikibase can't really use the same spec
  
  When I mean spec, I'm referring to the output API.
  
  For example, 
https://en.wikipedia.org/w/rest.php/v1/search/title?q=Spongebob%20Squarepants%20=10
 responds with :
  
{
  "pages": [
{
  "id": 2655089,
  "key": "SpongeBob_SquarePants",
  "title": "SpongeBob SquarePants",
  "excerpt": "SpongeBob SquarePants",
  "description": "American animated television series",
  "thumbnail": {
"mimetype": "image/svg+xml",
"size": 25839,
"width": 200,
"height": 107,
"duration": null,
"url": 
"//upload.wikimedia.org/wikipedia/en/thumb/2/22/SpongeBob_SquarePants_logo_by_Nickelodeon.svg/200px-SpongeBob_SquarePants_logo_by_Nickelodeon.svg.png"
  }
}
..
  ]
}
  
  If an API was created that returned data in the same format, the search UI 
would mostly function.
  
{
  "pages": [
{
  "key": "Q935079",
  "title": "SpongeBob SquarePants (Q935079)",
  "excerpt": "main character of the animated television show SpongeBob 
SquarePants",
  "description": null,
  "thumbnail": {
"mimetype": "image/svg+xml",
"size": 25839,
"width": 200,
"height": 107,
"duration": null,
"url": 
"//upload.wikimedia.org/wikipedia/en/thumb/2/22/SpongeBob_SquarePants_logo_by_Nickelodeon.svg/200px-SpongeBob_SquarePants_logo_by_Nickelodeon.svg.png"
  }
  ]
}

The implementation can be completely different, living in Wikidata if 
necessary. Right now, we allow configuration on the host level, but if this is 
the direction we want to take, we can make the path configurable our side to to 
support this.

I honestly don't see any other way to get this to work, without disabling 
the JavaScript search experience altogether and relying on a gadget.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[daniel]

daniel added a comment.


  In T275251#6945709 , 
@Jdlrobson wrote:
  
  > Please no more UI components.. that would be a maintenance disaster as 
Wikidata would need to do this for every skin (we plan to use this same Vue 
component inside the Minerva skin).
  
  I don't have super strong feelings about that, I just remember that Wikibase 
search shows a lot more info than what the "normal" search popup shows. The  
data fields are not the same (label, matched alias, description, matches in 
different languages potentially using different directionality), and it seems 
like additional structuring will be needed to accommodate Lexemes etc.
  
  If I recall correctly, the main problem was that the custom search box was 
hacked into the skin in a horrible way. Perhaps that could be improved.
  
  > The API used by the existing UI component is configurable so theoretically, 
Wikidata could have its own API which returns data using the same spec with the 
right level of abstraction. I think this might be a better approach then 
rebuilding the UI and all the complexity that would go with it.
  
  The problem is that Wikibase can't really use the same spec. It needs quite a 
bit of extra info from the search backend in order to do what it does. At 
least, that's what I recall from shoehorning this in many years ago.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: darthmon_wmde, WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, 
MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, 
Selby, caldera, maantietaja, Akuckartz, Demian, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  > In my mind, it should be a different UI component, backed by a dedicated 
API. The way we hacked this into the skin in the past was rather nasty, perhaps 
a better mechanism can be found.
  
  Please no more UI components.. that would be a maintenance disaster as 
Wikidata would need to do this for every skin. The API used by the existing UI 
component is configurable so theoretically Wikidata could have its own API 
which returns data using the same spec with the right level of abstraction. I 
think this might be a better approach then rebuilding the UI and all the 
complexity that would go with it.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: WMDE-leszek, daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, 
ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, Selby, 
caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, WDoranWMF, 
holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[daniel]

daniel added a comment.


  I'm unconvinced that hooking into SearchHandler is the Right Thing. The 
endpoint is `/v1/search/title`, making that do anything but title 
auto-completion would be confusing, it would break the contract. I'd also argue 
that we will still want title auto-completion for some namespaces.
  
  The desired behavior for the search box in Wikidata differs significantly 
from the expected behavior for vanilla MediaWiki. The behavior could even 
depend on the namespace the user is currently in, or offer results from 
different namespaces in sections or side by side. In my mind, it should be a 
different UI component, backed by a dedicated API. The way we hacked this into 
the skin in the past was rather nasty, perhaps a better mechanism can be found.
  
  Alternatively, Wikibase can hook into search index generation to change what 
the "page title" is for items. But the multi-lingual nature of Wikibase labels 
makes that hard.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, sdkim, alexhollender, LGoto, Yair_rand, MPhamWMF, ovasileva, 
Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Invadibot, Selby, caldera, 
maantietaja, Akuckartz, Demian, darthmon_wmde, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Jonas, Volker_E, Niedzielski, Izno, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Invadibot, Selby, caldera, maantietaja, Akuckartz, Demian, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Volker_E, 
Niedzielski, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Addshore]

Addshore added a project: Wikidata-Campsite.
Addshore added a comment.


  It sounds like the "right" thing to do for now would be to return everything 
here, starting with items, then properties, then lexemes (as a starting point).
  We could probably use our search code that powered wbsearchentities, and just 
loop through entity types in some order so that we prioritize items etc.
  
  In T275251#6858213 , 
@Jdlrobson wrote:
  
  > Code:
  > 
https://github.com/wikimedia/mediawiki/blob/master/includes/Rest/Handler/SearchHandler.php
  >
  > Looks like there are hooks for thumbnail and description.
  > A hook would likely be needed in 
https://github.com/wikimedia/mediawiki/blob/master/includes/Rest/Handler/SearchHandler.php#L102
  
  It looks like we would also need a hook to override the `title` itself?
  This would allow us to add both the label and description of items for 
example to the result.
  Once we figure this bit out I think this would be ready for us to work on as 
long as @Lydia_Pintscher agrees with just trying this as a first attempt.
  
  F34172458: image.png 
  
  I like the look of this bottom option and I wonder if there might also be a 
way to hook in and add more options / a different option here?
  This would allow us for example to more easily search for other types of 
entities for other usecases?

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Volker_E, 
Niedzielski, Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[MPhamWMF]

MPhamWMF added a comment.


  @Addshore, I talked with the Search Platform team about ranking results, i.e. 
the Tree example, and I think the consensus is unfortunately that there's not a 
single correct answer to this in the general case. Realistically we'd have to 
dig more into what Wikidata users find valuable and relevant when searching and 
adapt our relevance ranking from there.
  
  My own hot take on Tree the Item vs Tree the Lexeme (besides sounding like an 
epic rap battle I want to listen to) is that if we think that one can be very 
relevant to one search at the exclusion of the other, and vice versa, then this 
could be motivation to split out the Lexeme graph.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: MPhamWMF
Cc: LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, 
Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[LGoto]

LGoto moved this task from Needs Analysis to Blocked on Others on the 
Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
LGoto added a comment.


  Web team would like to discuss the status of this with the associated teams.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4882/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LGoto
Cc: LGoto, Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, 
Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[LGoto]

LGoto added a project: Readers-Web-Backlog (Kanbanana-FY-2020-21).

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LGoto
Cc: Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, Winter, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, 
Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[Jdlrobson]

Jdlrobson added a comment.


  > @Jdlrobson could you provide a screenshot of the look and feel of the new 
results view (or somewhere to see it)
  
  @addshore you can test this out on https://wikidata.beta.wmflabs.org/
  F34166151: Screen Shot 2021-03-17 at 9.23.30 AM.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, abian, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q)

[TJones]

TJones renamed this task from "Rest Search API is not wikidata aware (only 
accepts queries beginning with Q" to "Rest Search API is not wikidata aware 
(only accepts queries beginning with Q)".

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TJones
Cc: Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, abian, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Addshore]

Addshore added subscribers: MPhamWMF, Yair_rand.
Addshore added a comment.


  So right now the fact that the searchbox is only searching items is not good.
  This makes it hard to find lexeme,s project pages etc.
  So the current state is not ideal for us.
  
  We don't have any great ideas about ranking these different entity types 
together etc, and making sense of what users would end up seeing. (even along 
side regular pages).
  How do you find out if Tree the item should be ranked higher or lower than 
Tree the lexeme, or some other project page called Tree?
  If we figure out the answers to these questions then we could probably move 
toward making use of the new search UI for Wikidata / Wikibase and ditching the 
old thing..
  The search team might have some thoughts on this? CC: @MPhamWMF
  
  There is quite a big difference in behaviour currently between what is served 
up through Special:Search and the entity suggester box for Wikidata right now
  This can be seen in the screenshot below:
  
  F34165916: image.png 
  
  Related would also be:
  
  - T194968: Enable search in all wikidata namespaces combined 

  - T190454: Display entity & article namespace completion search together 

  - T48251: [Task] Make search suggestions work for pages outside the main 
namespace on Wikidata 
  
  A quote from that last ticket
  
  In T48251#1355685 , 
@Yair_rand wrote:
  
  > Mixing together mainspace items and pages from other namespaces could 
result in some confusion. For example, if a user is searching for 
"Template:Support", there would be two items with that label, along with the 
local template itself titled "Template:Support". If these are to be mixed, 
there needs to be some way to clearly indicate whether a page is a Wikidata 
item or not.
  
  @Jdlrobson could you provide a screenshot of the look and feel of the new 
results view (or somewhere to see it)

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Yair_rand, MPhamWMF, ovasileva, Addshore, Lydia_Pintscher, Aklapper, 
Jdlrobson, Selby, caldera, maantietaja, Akuckartz, Demian, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, abian, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[BPirkle]

BPirkle edited projects, added Platform Engineering; removed Platform Team 
Workboards.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, caldera, 
maantietaja, Akuckartz, Demian, darthmon_wmde, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, abian, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g, Naike, eprodromou
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T275251#6884087 , 
@Addshore wrote:
  
  > Current behaviour is that we only override the search box in the top right, 
and other search (special:search and apis etc) remain the same.
  > @Lydia_Pintscher would need to say if it is okay for a larger behaviour 
change or if we want to continue only changing the search box.
  
  Could we clarify what would change how? Currently it's not clear to me so I 
can't assses if we can/should do this and with how much announcement or 
consultation.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, caldera, 
maantietaja, Naike, Akuckartz, Demian, eprodromou, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Niedzielski, 
Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Jdlrobson]

Jdlrobson added a project: WVUI.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, caldera, 
maantietaja, Naike, Akuckartz, Demian, eprodromou, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Niedzielski, 
Izno, abian, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Jdlrobson]

Jdlrobson added a comment.


  Another problem here is going to be that for instrumentation details, the url 
of suggestions is https://www.wikidata.org/w/index.php?search=Universe+%28Q1%29
  
  On wikipedia such a query would redirect directly to the title e.g. 
https://www.wikipedia.org/w/index.php?search=Universe
  
  Code:
  
  
https://github.com/wikimedia/wvui/blob/master/src/components/typeahead-suggestion/UrlGenerator.ts#L45

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, maantietaja, Naike, 
Akuckartz, Demian, eprodromou, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Volker_E, Izno, abian, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Addshore]

Addshore added a comment.


  > While the new search UI works, as mentioned its only searching across 
titles.
  
  We will need to do more that title search for Wikidata / Wikibases.
  
  > Perhaps all that's needed is a hook for Wikidata to change where the search 
looks.
  
  It sounds like that could work.
  If we can hook in and then output something like this
  
  F34137037: image.png 
  
  Current behaviour is that we only override the search box in the top right, 
and other search (special:search and apis etc) remain the same.
  @Lydia_Pintscher would need to say if it is okay for a larger behaviour 
change or if we want to continue only changing the search box.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, maantietaja, Naike, 
Akuckartz, Demian, eprodromou, Hasley, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Izno, abian, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Jdlrobson]

Jdlrobson added a project: Platform Team Workboards.
Jdlrobson added a comment.


  Yeh, we are moving away from the jquery autocomplete implementation and will 
no longer be supporting it inside Vector (and at some point Minerva).
  
  The new version of the search is built via Vue.js and uses new API recently 
created by the platform team. While the old jquery autocomplete does still work 
it's not being actively tested and won't benefit from thumbnails and wikidata 
descriptions like other wikis. I think Minerva is the more pressing challenge 
here as we'd like to eventually port the code in mobile to vue.js and this 
would potentially block it (unless we're okay with not having JavaScript 
powered search results on Wikidata.org)
  
  While the new search UI works, as mentioned its only searching across titles. 
Perhaps all that's needed is a hook for Wikidata to change where the search 
looks.
  
  Tagging platform team who might be able to help provide some advice.
  
  You should be able to try this out on Vector  locally with just the following 
3 lines of config (no need to install wikidata extensions):
  
$wgVectorSearchHost = 'www.wikidata.org';
$wgVectorDefaultSkinVersion = '2';
$wgVectorUseWvuiSearch = true;

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, Naike, Akuckartz, 
Demian, eprodromou, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Volker_E, Izno, Wikidata-bugs, aude, GWicke, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Addshore]

Addshore added subscribers: Lydia_Pintscher, Addshore.
Addshore moved this task from Incoming to Research on the wdwb-tech-focus board.
Addshore added a comment.


  > This means in future Wikidata will become useless with the roll out of the 
latest version of Vector and will stall further adoption efforts of the 
wikimedia wvui library.
  
  We override the default search box in Wikibase for an entity selector.
  It sounds like we will need to make that change in a slightly different way 
for the new Vector skin before rollout?
  Though the behaviour of the search API is probably correct? / same as it was 
in the action api?

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3532/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, Akuckartz, Demian, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Volker_E, Izno, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

[Jdlrobson]

Jdlrobson created this task.
Jdlrobson added projects: Desktop Improvements, Wikidata, RESTBase-API, 
Technical-Debt.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: wdwb-tech-focus.

TASK DESCRIPTION
  The existing search API only works with queries containing "Q" and returns 
results without the correct display title
  https://wikidata.org/w/rest.php/v1/search/title?q=Q3=10
  
  This means in future Wikidata will become useless with the roll out of the 
latest version of Vector and will stall further adoption efforts of the 
wikimedia wvui library.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Aklapper, Jdlrobson, Selby, Akuckartz, Demian, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, pmiazga, LawExplorer, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Izno, 
Wikidata-bugs, aude, GWicke, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs