[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-25 Thread Ladsgroup
Ladsgroup added a comment. Yeah makes sense. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT, Ladsgroup Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo,

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-22 Thread Sarai-WMDE
Sarai-WMDE added a comment. Thanks for sharing your experience and recommendation, @Ladsgroup! Regarding lists and menus specifically, that occasional interruption of the reading pattern that generates a more pronounced zigzag is something that I believe we should try to avoid. I lack

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-21 Thread Ladsgroup
Ladsgroup added a comment. Bidi behavior in internet doesn't follow a pattern. This is an example from my daily experience: - Some just doesn't care, if your interface language is LTR, you see text as LTR and other way around. - Telegram text editor cares about the first character, if

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-21 Thread Lydia_Pintscher
Lydia_Pintscher added a subscriber: Ladsgroup. Lydia_Pintscher added a comment. In T305091#7869125 , @Sarai-WMDE wrote: > Tried some searches, translations, and language combinations in RTL/LTR, and everything works nicely! I agree that

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-20 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo,

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-20 Thread Sarai-WMDE
Sarai-WMDE added a comment. Tried some searches, translations, and language combinations in RTL/LTR, and everything works nicely! I agree that the inverse order of the label and alias actually makes sense in the RTL context. Still, would like to wait to get a thumbs up from @Michael and

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-20 Thread gerritbot
gerritbot added a comment. Change 775952 **merged** by jenkins-bot: [design/codex@main] MenuItem: Support language attributes https://gerrit.wikimedia.org/r/775952 TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-15 Thread STHart
STHart changed the task status from "Open" to "In Progress". STHart triaged this task as "Medium" priority. STHart edited projects, added Design-Systems-Team (Design-Systems-Sprint); removed Design-Systems-team-20200324-20220430 (Design-Systems-Active-Sprint). TASK DETAIL

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-05 Thread AnneT
AnneT added a comment. Thanks, everyone, for your thoughtful comments, examples, and suggestions! I think we should move forward with keeping all menu items justified according to the interface direction, given the feedback here. We can always reevaluate if we get more feedback from RTL

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

2022-04-04 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT, Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo,