[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Ladsgroup]

Ladsgroup added a comment.


  Yeah makes sense.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Ladsgroup
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, 
bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Thanks for sharing your experience and recommendation, @Ladsgroup!
  
  Regarding lists and menus specifically, that occasional interruption of the 
reading pattern that generates a more pronounced zigzag is something that I 
believe we should try to avoid. I lack any RTL native experience, but speaking 
strictly from a design perspective, keeping the content of list items aligned 
and ordered consistently is a recommended practice to make lists more easily 
scannable. If we considered ordered list instead, it becomes really clear that 
a consistent, status quo alignment would facilitate skimming through the 
elements. I think we should apply the same logic to unordered cases: the 
position of repeated elements within items should be maintained in order to 
avoid the layout from disrupting the user focus, which should be on the content 
as much as possible.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Sarai-WMDE
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, 
bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Ladsgroup]

Ladsgroup added a comment.


  Bidi behavior in internet doesn't follow a pattern. This is an example from 
my daily experience:
  
  - Some just doesn't care, if your interface language is LTR, you see text as 
LTR and other way around.
  - Telegram text editor cares about the first character, if it's RTL, the 
whole line will be RTL
  - Gmail editor makes the text RTL if you have even one RTL strong[1] 
character in that line.
  - Twitter has a majority system, if number of RTL characters reaches a 
certain threshold in that line, the text suddenly jumps to the other side.
  
  From what I've seen in most places, each line gets judged individually (like 
Gmail/Twitter)
  
  If we want to bring that to here, my suggestion would be to make the text LTR 
in the RTL env if it's all components are LTR (label, desc and alias) which 
would make the list jump between left and right and I hope it should be fine 
given the small width of the search menu but if the width is large enough, 
it'll make the reader's eye to zigzag and that's not that good and all being 
RTL (status quo) would be my second choice.
  
  HTH

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Ladsgroup
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, 
bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Lydia_Pintscher]

Lydia_Pintscher added a subscriber: Ladsgroup.
Lydia_Pintscher added a comment.


  In T305091#7869125 , 
@Sarai-WMDE wrote:
  
  > Tried some searches, translations, and language combinations in RTL/LTR, 
and everything works nicely! I agree that the inverse order of the label and 
alias actually makes sense in the RTL context. Still, would like to wait to get 
a thumbs up from @Michael and @Lydia_Pintscher.
  
  I'd like to defer to someone who actually uses a RTL language :P @Ladsgroup, 
maybe?

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Lydia_Pintscher
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, 
bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331, 
Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Tried some searches, translations, and language combinations in RTL/LTR, and 
everything works nicely! I agree that the inverse order of the label and alias 
actually makes sense in the RTL context. Still, would like to wait to get a 
thumbs up from @Michael and @Lydia_Pintscher.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Sarai-WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[gerritbot]

gerritbot added a comment.


  Change 775952 **merged** by jenkins-bot:
  
  [design/codex@main] MenuItem: Support language attributes
  
  https://gerrit.wikimedia.org/r/775952

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, gerritbot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[STHart]

STHart changed the task status from "Open" to "In Progress".
STHart triaged this task as "Medium" priority.
STHart edited projects, added Design-Systems-Team (Design-Systems-Sprint); 
removed Design-Systems-team-20200324-20220430 (Design-Systems-Active-Sprint).

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, STHart
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, 
Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Mbch331, R4356th, Demian, darthmon_wmde, egardner, holger.knust, 
Niedzielski, Jdlrobson, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[AnneT]

AnneT added a comment.


  Thanks, everyone, for your thoughtful comments, examples, and suggestions!
  
  I think we should move forward with keeping all menu items justified 
according to the interface direction, given the feedback here. We can always 
reevaluate if we get more feedback from RTL readers.
  
  In terms of mixed directionality, the screenshot @Michael posted is fairly 
close to what will happen if we wrap the label, match, and description in 
`` tags. One minor difference is that, in the Wikidata example, the 
label's language is added as an attribute to an element that wraps both the 
label and the match, so there's no differentiation there. You can see this with 
the "Liebfrauenkirche" result. This label comes back with the language code 
`en` (presumably because this is the label's value in English and English is a 
fallback for Farsi while German is not), so the whole line is wrapped in an 
element with `lang="en"` and is therefore all readable left-to-right:
  
  F35040242: image.png 
  
  However, in this screenshot of the Codex TypeaheadSearch component, you can 
see that the label and match maintain the same order no matter what the 
languages are, so they arguably appear "backward" for this specific item:
  
  F35040209: Screen Shot 2022-04-05 at 4.00.55 PM.png 

  
  I suppose we could check to see if the language and match have the same lang 
code, and wrap them together if that's true. But you could also argue that the 
consistency of the current state is better.
  
  I've updated the patch associated with this task to include `` tags 
around each piece of text within a Menuitem. Please let me know if you have 
further feedback, either here or in the patch!

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, 
R4356th, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Demian, Hook696, darthmon_wmde, Kent7301, egardner, holger.knust, 
joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, NatHillard, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Volker_E, Niedzielski, Wikidata-bugs, Jdlrobson, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component

[Lydia_Pintscher]

Lydia_Pintscher added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T305091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, 
Sarai-WMDE, Aklapper, STHart, AnneT, Michael, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, 
R4356th, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Demian, Hook696, darthmon_wmde, Kent7301, egardner, holger.knust, 
joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, NatHillard, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Volker_E, Niedzielski, Wikidata-bugs, Jdlrobson, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org