[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2023-02-06 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.
Lucas_Werkmeister_WMDE added a comment.


  (Removing misleading #patch-for-review 
, AFAICT all the 
existing patches were merged. If anything is still left to do it will need new 
patches, not just review.)

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-12-07 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  My take to try to unblock this task sooner than later would be to eliminate 
the Codex migration from the equation for now, and instead apply contextual 
adjustments to the WiKit component. The reason for this being that, as we know, 
the available Codex Lookup component currently misses the features required to 
solve these issues (see also T322684 
). The DST will need to first reach 
alignment and define a design solution before we can attempt at contributing 
(the MVP of) a new component to the system (either Label, or Field). I think 
that implementing the required temporary solution shouldn't involve a lot of 
effort, which contributes to justify this approach, but please let me know if 
you disagree.
  
  What would need to change? Let's 1. Increase the font-size of the asterisk 
span that accompanies the label to 1.5em (`font-size-xxlarge`, to bypass 
Vector's default font-size), and 2. Override the gap between the label and the 
asterisk (only in context), reducing it to 0.25em.
  
  F35844844: Screenshot 2022-12-07 at 14.43.51.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-28 Thread Lydia_Pintscher 
Lydia_Pintscher edited projects, added Wikidata Dev Team; removed Wikidata Dev 
Team (Sprint-∞).
Lydia_Pintscher added a comment.


  Makes sense. Thanks.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-28 Thread Michael 
Michael added a comment.


  In T322683#8425283 , 
@Lydia_Pintscher wrote:
  
  > Ah ok.
  > So back to todo?
  
  No, back to "Needs work, and we need to figure some other things out first."
  
  Specifically, now that we have Codex in a stable state, it does become a 
viable alternative for dealing with T322684 
. We should make that decision there 
first and that then has implications for how to best move forward here.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-28 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  Ah ok.
  So back to todo?

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-23 Thread Michael 
Michael added a comment.


  (so far this only accounts for the "has no tooltip" item from the 
description. That this is fixed should be verifiable on beta: 
https://wikidata.beta.wmflabs.org/wiki/Special:NewLexeme )

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-22 Thread Lydia_Pintscher 
Lydia_Pintscher moved this task from Unified prioritized backlog to Sprint-∞ on 
the Wikidata Dev Team board.
Lydia_Pintscher edited projects, added Wikidata Dev Team (Sprint-∞); removed 
Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-21 Thread gerritbot 
gerritbot added a comment.


  Change 859008 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Shorten 
wikibaselexeme-form-field-required message
  
  https://gerrit.wikimedia.org/r/859008

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-21 Thread gerritbot 
gerritbot added a comment.


  Change 858636 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Bump special new lexeme to 
include required asterisk title
  
  https://gerrit.wikimedia.org/r/858636

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-21 Thread gerritbot 
gerritbot added a comment.


  Change 859008 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexeme@master] Shorten 
wikibaselexeme-form-field-required message
  
  https://gerrit.wikimedia.org/r/859008

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858636 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  
  [mediawiki/extensions/WikibaseLexeme@master] Bump special new lexeme to 
include required asterisk title
  
  https://gerrit.wikimedia.org/r/858636

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858584 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Add 
wikibaselexeme-form-field-required message
  
  https://gerrit.wikimedia.org/r/858584

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858584 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  
  [mediawiki/extensions/WikibaseLexeme@master] Add 
wikibaselexeme-form-field-required message
  
  https://gerrit.wikimedia.org/r/858584

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  
  
  > I'm sorry, for using a shorthand. I'm referring to the messages in the core 
MediaWiki repository, specifically in languages/i18n/en.json 
 
There it can be found with the key `htmlform-required`. However, now that I 
looked into how it is actually used, it seems to be only used as a 
//validation// message. So maybe this is not the message we actually want there 

  
  Thanks so much for the clarification! Really appreciate it 
  
  > Then I'll create a new WikibaseLexeme message for that! Easy as pie 不
  
  Osom! Thanks again, Michael 

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread Michael 
Michael added a comment.


  In T322683#8405491 , 
@Sarai-WMDE wrote:
  
  > What are "core messages" btw, and where are they stored?
  
  I'm sorry, for using a shorthand. I'm referring to the messages in the core 
MediaWiki repository, specifically in languages/i18n/en.json 
 
There it can be found with the key `htmlform-required`. However, now that I 
looked into how it is actually used, it seems to be only used as a 
//validation// message. So maybe this is not the message we actually want there 

  
  > Looks great! I think the copy would be clearer if it said "This field is 
required" – no full stop needed. (I actually wanted to update my comment to 
this version, but then forgot ). I think it sounds more natural.
  
  Then I'll create a new WikibaseLexeme message for that! Easy as pie 不

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  In T322683#8405170 , 
@Michael wrote:
  
  > In T322683#8403690 , 
@Sarai-WMDE wrote:
  >
  >>> That's a simple change, we just need the copy.
  >>
  >> Copy: Required
  >
  > Thanks! I looked if we already have a message with that copy, and instead I 
found the respective core message to have the copy: "This value is required."
  > Would that also be acceptable? If you prefer plain "Required", then adding 
that to our Lexeme message is also very little effort. Just say the word :)
  >
  > You can have a look here 
https://6a654d83f58b8501512434ee88d135bf3fed--new-lexeme-special-page.netlify.app/
 (from #330 )
  
  Looks great! I think it would be clearer if we said "This field is required" 
(wanted to update my comment with that version, and then forgot ). Sounds more 
natural.
  What are "core messages" and where are they stored?

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-18 Thread Michael 
Michael added a comment.


  In T322683#8403690 , 
@Sarai-WMDE wrote:
  
  >> That's a simple change, we just need the copy.
  >
  > Copy: Required
  
  Thanks! I looked if we already have a message with that copy, and instead I 
found the respective core message to have the copy: "This value is required."
  Would that also be acceptable? If you prefer plain "Required", then adding 
that to our Lexeme message is also very little effort. Just say the word :)
  
  You can have a look here 
https://6a654d83f58b8501512434ee88d135bf3fed--new-lexeme-special-page.netlify.app/
 (from #330 )

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-17 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  > Mh, the reasoning given in that blog-post for using an icon instead of an 
asterisk is that the `aria-hidden` is not respected in focus mode. Sadly, it 
doesn't specify what screen reader or "focus mode" that refers to. But that 
article is from 2018, we should verify if this bug indeed still exists in 2022, 
over 4 years later.
  
  The article was only linked as a (probably redundant) reminder to, in case we 
included and icon, make it/keep it non-focusable. I didn't mean to bring it up 
as a case study comparing text v. icon. I also don't think the issue described 
by the article still persists, but it'd be good to keep it in mind.
  I was very hesitant about suggesting the use of an icon (due to both design 
and tech reasons). I thought it might be the easiest (?) way to control the 
size of this indicator in its current position (and avoid the inheritance 
issues derived from using text). Plus, it also allows triggering the tooltip 
(although I guess the label could also do this). Now, I agree to this:
  
  > //If// we want to use an icon instead, we should probably implement it only 
after we decided whether we want to go for the Codex Lookup.
  
  Makes sense. I'll have to search for validation and alignment with the DST 
again over the whole thing. They consented about the use of the asterisk, but 
this even contradicts the most recent state of the conversation about 
required/optional indicators (see T306427 
). 
  Of course, I'd be all up for replacing WiKit once a decision is made: in that 
case, we would probably have to contribute (the MVP of) a new component (either 
Label, or Field – see list of planned components 
 for more information).
  
  > This space comes from Wikit and was probably designed for the tooltip-icon 
in Query Builder . We can override 
that Wikit style in a somewhat hacky and brittle way like this:
  >
  >   .wbl-snl-lemma-input.wikit .wikit-TextInput__label-wrapper {
  > gap: 0.25em; /* we could also use a token here */
  >   }
  >
  > But it would probably also make sense to have clarity on whether we want to 
switch to the Codex Lookup for this.
  
  Let's put a hold on modifying the spacing until we agree on the nature and 
size of the visual element (and the component) we're going to use: increasing 
the size of the indicator might require keeping the current separation in 
relation to the label.
  
  >> This is a very commonly extended pattern, so I'm unsure that a tooltip 
would be essential to ensure understanding. Nevertheless, I've found some 
recommendations that encourage this practice for extra clarification. The 
browser default on hover will do.
  >
  > That's a simple change, we just need the copy.
  
  Copy: Required
  
  All in all: there are two paths we can follow, the DS friendly one, or the 
fastest track. The first, characterized by having to contribute to Codex and 
replace WiKit components, we will have to walk sometime. 
   If we followed the latter, then I agree to opt for the least costly changes: 
we could apply contextual overrides to modify the size and spacing of/around 
the existing text asterisk.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-17 Thread Michael 
Michael added a comment.


  In T322683#8389816 , 
@Sarai-WMDE wrote:
  
  >> it is tiny
  >
  > Absolutely agreed. My suggestion: let's use a 12px* non-focusable icon 

 instead of plain text. *This size might be too big indeed, so let's keep our 
minds open for a smaller, potentially 8px icon. This approach might also 
require altering the Label mixin in WiKit: to be validated with engineers.
  
  Mh, the reasoning given in that blog-post for using an icon instead of an 
asterisk is that the `aria-hidden` is not respected in focus mode. Sadly, it 
doesn't specify what screen reader or "focus mode" that refers to. But that 
article is from 2018, we should verify if this bug indeed still exists in 2022, 
over 4 years later.
  
  //If// we want to use an icon instead, we should probably implement it only 
after we decided whether we want to go for the Codex Lookup.
  
  >> it has a large gap before it
  >
  > Agreed again. The spacing between the label and the required icon should be 
reduced by half (to 0.25em).
  
  This space comes from Wikit and was probably designed for the tooltip-icon in 
Query Builder . We can override that 
Wikit style in a somewhat hacky and brittle way like this:
  
.wbl-snl-lemma-input.wikit .wikit-TextInput__label-wrapper {
gap: 0.25em; /* we could also use a token here */
}
  
  But it would probably also make sense to have clarity on whether we want to 
switch to the Codex Lookup for this.
  
  >> it has no tooltip
  >
  > This is a very commonly extended pattern, so I'm unsure that a tooltip 
would be essential to ensure understanding. Nevertheless, I've found some 
recommendations that encourage this practice for extra clarification. The 
browser default on hover will do.
  
  That's a simple change, we just need the copy.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-15 Thread Lydia_Pintscher 
Lydia_Pintscher moved this task from Sprint-∞ to Unified prioritized backlog on 
the Wikidata Dev Team board.
Lydia_Pintscher edited projects, added Wikidata Dev Team; removed Wikidata Dev 
Team (Sprint-∞).

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-15 Thread Lydia_Pintscher 
Lydia_Pintscher moved this task from Unified prioritized backlog to Sprint-∞ on 
the Wikidata Dev Team board.
Lydia_Pintscher edited projects, added Wikidata Dev Team (Sprint-∞); removed 
Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-11 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Providing some inline clarifications and recommendations about the required 
symbol:
  
  > It is not following the style used by MediaWiki elsewhere
  
  While working on the new unified design system for Wikimedia (Codex), it was 
tentatively decided to actually abandon the current style of required forms. 
This is due to the fact that, in the current approach, the indicator placement 
would vary depending on input type (e.g. inside of a text input field v. 
outside of a select) complicating understanding and quick scanning, in some 
cases. The new design hasn't been created yet, but using a simple asterisk 
beside the label appeared to be the most likely decision.
  
  > it is tiny
  
  Absolutely agreed. My suggestion: let's use a 12px* non-focusable icon 

 instead of plain text. *This size might be too big indeed, so let's keep our 
minds open for a smaller, potentially 8px icon.
  
  > it has a large gap before it
  
  Agreed again. The spacing between the label and the required icon should be 
reduced by half (to 0.25em).
  
  > it has no tooltip
  
  This is a very commonly extended pattern. I'm unsure that a tooltip would be 
essential to ensure understanding, but it doesn't hurt anyone, and I've found 
some recommendations that encourage the use of tooltips on hover for extra 
clarification. A browser default will do.
  
  > it does nothing if you click on it
  
  It shouldn't, it's simply an indicator.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-08 Thread Lydia_Pintscher 
Lydia_Pintscher triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

WORKBOARD
  https://phabricator.wikimedia.org/project/board/2292/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-08 Thread Lydia_Pintscher 
Lydia_Pintscher added a subscriber: Sarai-WMDE.
Lydia_Pintscher added a comment.


  @Sarai-WMDE Could you have a look at this feedback from nikki?

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322683: issues with the required marker for the required fields on Special:NewLexeme

2022-11-08 Thread Lydia_Pintscher 
Lydia_Pintscher created this task.
Lydia_Pintscher added projects: Wikidata Lexicographical data, 
Special:NewLexeme revival, Wikidata Dev Team, Wikidata.

TASK DESCRIPTION
  **Problem:**
  The marker that marks a field as required on Special:NewLexeme is problematic:
  
  - it is not following the style used by MediaWiki elsewhere
  - it is tiny
  - it has a large gap before it
  - it has no tooltip
  - it does nothing if you click on it
  
  **Screenshots/mockups:**
  F35722141: image.png 
  
  **Acceptance criteria:**
  
  [ ]
  
  **Open questions:**
  
  - How exactly do we change it?

TASK DETAIL
  https://phabricator.wikimedia.org/T322683

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org