User Nikerabbit posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15686
Comment:
You sure didn't give a lot of time to fix this...
___
MediaWiki-CodeReview mailing list
User Siebrand posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15687
Comment:
Isn't it good practice to support this without warnings for at least one
release (1.18), have it whine the next release (1.19), and remove it in the 3rd
User Tim Starling posted a comment on MediaWiki.r79108.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15688
Comment:
I get
pre
Running test Interlanguage link, with prefix links... A database error has
occurred. Did you forget to run maintenance/update.php after
In the beginning, there was Article.php. And the Article class had methods
like Article::view(), Article::delete(), Article::protect(), etc. And the
fundamental codeflow of Mediawiki consisted of something along the lines of:
$article = new Article( $title );
$action =
On 04/04/2011 11:28 PM, Happy-melon wrote:
For either case in the backend I would think we'd want to create an
ActionPage base class and an EditActionPage from that, which looks
internally rather like a SpecialPage construct, might even subclass it.
We had this discussion in January. That's
On Mon, Apr 4, 2011 at 9:28 AM, Happy-melon happy-me...@live.com wrote:
If people think it would be
better as a special page we'd make
http://foo.example.com/w/index.php?title=Baraction=edit a hard redirect to
Special:Edit/Bar; that has the significant advantage of being able to be
formed as
User Raymond changed the status of MediaWiki.r85327.
Old Status: new
New Status: fixme
User Raymond also posted a comment on MediaWiki.r85327.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15689
Comment:
Seen on Translatewiki and on my local wiki:
Warning:
On 2 Apr 2011 at 16:08, Ryan Kaldari wrote:
What do you guys think would be more useful:
1. Helping sister projects write up proposals for the Berlin Hackathon
If it is going to get selected and have outcome for my favourite wiki, then yes
;-)
2. Creating The Complete Idiot's Guide to
On 3 Apr 2011 at 10:56, Brion Vibber wrote:
(Breaking this out from 'Focus on sister projects' thread.)
I just want to give an official shout out, as Lead Software Architect for
the Wikimedia Foundation, that Wikipedia's sister projects are important and
that they need more love. Not only
User Happy-melon changed the status of MediaWiki.r85302.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85302.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15691
Comment:
Heaven knows tt:D/tt Should be fixed in r85332 though.
User ^demon changed the status of MediaWiki.r85211.
Old Status: fixme
New Status: new
User ^demon also posted a comment on MediaWiki.r85211.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85211#c15692
Comment:
Merged the first 3.
The last two look merged to me, The regexes in
Maybe my brain just made a leap here, but is there a plan for
implementing a web-based Javascript editor for MediaWiki?? This would be
a hugely awesome feature. I've used jsFiddle (http://jsfiddle.net/)
which is really slick - syntax color-coding, tabbing that works, a Tidy
button(!),
User ^demon posted a comment on MediaWiki.r85080.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85080#c15693
Comment:
Grabbed the ones mentioned in this rev, see r85343
___
MediaWiki-CodeReview mailing list
User Tbleher posted a comment on MediaWiki.r83080.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83080#c15695
Comment:
This change breaks the CommentBox extension, which has a special page to add
comments to pages. The special page creates a FauxRequest which it submits to
User ^demon changed the status of MediaWiki.r85151.
Old Status: fixme
New Status: new
User ^demon also posted a comment on MediaWiki.r85151.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85151#c15696
Comment:
Yay for followups :D
I had a bit of a documentation challenge approaching the problem of
writing phpunit test for extensions, mostly because many of the
extensions do this very differently and the manual did not have any
recommendations.
It appears many extension have custom bootstraping code ( somewhat hacky
path
Hi Tim,
I have no problem running foo.php and test.php that you sent in hphpi, but
also it compiles and run without any problems with hphp. What command
exactly do you use to compile and then execute?
Inez
On Sun, Apr 3, 2011 at 5:38 PM, Tim Starling tstarl...@wikimedia.orgwrote:
On
User ^demon changed the status of MediaWiki.r85358.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85358#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Catrope changed the status of MediaWiki.r84929.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84929#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r84627.
Old Status: new
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84627#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85144.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85144#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r84637.
Old Status: new
New Status: resolved
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84637#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85276.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85276#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85328.
Old Status: new
New Status: deferred
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85328#c0
___
MediaWiki-CodeReview mailing list
User Catrope changed the status of MediaWiki.r85048.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85048#c0
___
MediaWiki-CodeReview mailing list
User Nikerabbit posted a comment on MediaWiki.r85361.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15699
Comment:
Did you add or remove BOM in
trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php?
___
User Mdale posted a comment on MediaWiki.r85361.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15700
Comment:
not intentionally... What is BOM?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Nikerabbit posted a comment on MediaWiki.r85361.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15701
Comment:
[[wikipedia:Byte order mark]] - and PHP doesn't like it.
___
MediaWiki-CodeReview mailing list
User Platonides changed the status of MediaWiki.r85302.
Old Status: new
New Status: fixme
User Platonides also posted a comment on MediaWiki.r85302.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15702
Comment:
parserTests.php creates a new OutputPage.
User Platonides changed the status of MediaWiki.r85317.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85317#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User ^demon posted a comment on MediaWiki.r85373.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85373#c15703
Comment:
Did you check it first? If so, you should bump the version in the README.
___
MediaWiki-CodeReview mailing list
User Reedy changed the status of MediaWiki.r85376.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85376#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r39635.
Old Status: ok
New Status: fixme
User Reedy also posted a comment on MediaWiki.r39635.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39635#c15704
Comment:
Line 251 now in trunk has an undefined $name usage
Michael Dale wrote:
Eventually it would be ideal to be able to 'just test your extension'
from the core bootstraper (ie dynamically generate our suite.xml and
namespace the registration of extension tests) ... but for now at least
not having to wait for all the core tests as you write you
User Brion VIBBER posted a comment on MediaWiki.r85177.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85177#c15707
Comment:
Passing a string doesn't work either -- the timezone parameter needs to be a
DateTimeZone object.
___
On 04/04/2011 02:20 PM, Platonides wrote:
Michael Dale wrote:
Eventually it would be ideal to be able to 'just test your extension'
from the core bootstraper (ie dynamically generate our suite.xml and
namespace the registration of extension tests) ... but for now at least
not having to wait
I think the source of the problems is the decentralizated process that
wikimedia javascript have followed.
Medium-size wikis will have 2-3 tech people. Small wikis will be lucky
to have 1 js-savy sysop.
Even wikis with no local expert may have just forked the Monobook.js
from its mother project
User Reedy changed the status of MediaWiki.r85385.
Old Status: new
New Status: fixme
User Reedy also posted a comment on MediaWiki.r85385.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15709
Comment:
empty? :P
Also, should have more spaces on your if statement ;)
User Brion VIBBER posted a comment on MediaWiki.r85385.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15710
Comment:
Oh poop, I still haven't retrained my muscle memory for our space style. ;) The
empty() should be fine for arrays, but if it makes you feel better change
Very interesting! :-)
I'm a beginner in js stuff, but I realized how much js can be useful in a
number of ways (presently I am a very simple gadgets maker t help users
engaged into proofreading into wikisource). I'm a little worried about
additional server load coming from AJAX, and I suggest
User Reedy changed the status of MediaWiki.r85385.
Old Status: fixme
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Tim Starling posted a comment on MediaWiki.r79108.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15711
Comment:
I'm not sure. It's stopped happening now.
___
MediaWiki-CodeReview mailing list
User Happy-melon posted a comment on MediaWiki.r85402.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85402#c15712
Comment:
This is half of r79542. Is it worth merging the rest of that rev?
___
MediaWiki-CodeReview mailing list
User Dantman posted a comment on MediaWiki.r85403.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15715
Comment:
You can also drop code$wgUser-getSkin( $wgTitle ); // set skin title/code
it's not needed.
___
On Mon, Apr 4, 2011 at 6:22 PM, Platonides platoni...@gmail.com wrote:
Some steps to take:
* Finally create global gadgets.
* Create a central wiki for javascript sharing [1]
It seems like this always comes up for a number of different things --
global pages for interwiki transclusion and
User Happy-melon changed the status of MediaWiki.r85302.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85302.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15714
Comment:
Fixed in r85403
User Reedy posted a comment on MediaWiki.r85402.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85402#c15713
Comment:
Making it private and the whitespace? Probably not
___
MediaWiki-CodeReview mailing list
On 11-04-04 02:40 PM, Platonides wrote:
I like it. Specially the Linker change. It really looks the way to have it.
I'm considering
making the Parser get it's linker via $po-getLinker(); (either
ParserOutput or ParserOptions, I need another look)
The linker would be an input parameter, so it
I second the idea of the static Linker class. It's far better than the
subclass system. Skin modification of links should focus on CSS anyway,
rather than trying to overload link generating code.
Daniel Friesen-4 wrote:
On 11-04-04 02:40 PM, Platonides wrote:
I like it. Specially the Linker
Continuing with my changes to $wgOut, $wgUser, Skin, and SpecialPage
patterns.
The Linker is now static, $sk-link will still work, however you should
not be requiring a Skin anymore to use linker methods. Please use
Linker::link directly.
The only exception is the method to create an
User Tim Starling posted a comment on MediaWiki.r84782.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84782#c15716
Comment:
pre
total processing time: 188 days 4520h 57m 51.00s
gained time: 2 days 62h 32m 52.859375s
/pre
Too many hours!
Brion Vibber wrote:
I'd be kind of inclined to separate out the Skin and Linker worlds a bit
further; really, the HTML formatting of links and such doesn't depend on the
user (except in some edge cases like stub links which could in principle be
done differently). The surrounding *skin*
On Mon, Apr 4, 2011 at 9:05 PM, K. Peachey p858sn...@gmail.com wrote:
I don't see why we need to spilt it off to another list No reason
not to do it here on wikitech-l.
Did you realize that that list already exists? There's also no reason
not to use both of them, with the ambassadors list
Aryeh Gregor wrote:
On Mon, Apr 4, 2011 at 9:28 AM, Happy-melon happy-me...@live.com wrote:
If people think it would be
better as a special page we'd make
http://foo.example.com/w/index.php?title=Baraction=edit a hard redirect to
Special:Edit/Bar; that has the significant advantage of being
On 11-04-04 08:12 PM, MZMcBride wrote:
Aryeh Gregor wrote:
On Mon, Apr 4, 2011 at 9:28 AM, Happy-melonhappy-me...@live.com wrote:
If people think it would be
better as a special page we'd make
http://foo.example.com/w/index.php?title=Baraction=edit a hard redirect to
Special:Edit/Bar; that
On 03/30/2011 09:22 AM, Magnus Manske wrote:
Plus, free C++ MediaWiki parser ;-)
Seriously, there should be a way to turn the entire package into a
(huge) library; maybe transpile it and then replace the C++ code for
index.php with a manually written library interface?
HipHop has a library
Daniel Friesen wrote:
What IS so evil about actions? Besides the implementation details
which are just that... something we can make better. In fact something
we could potentially make work better than SpecialPages would in this
context.
Personally, I like tacking on ?action=edit and
Hello,
I was encouraged (hello, Sumana) to post a Google Summer of Code idea
and solicit comments. So here goes.
Perhaps entirely outside of the scope of GSOC, I think it would be a
fun project to make wikipedia.org and wikimedia.org accessible over
IPv6.
Also, while creating an account to
On Tue, Apr 5, 2011 at 1:07 PM, Michael Costello mc3...@columbia.edu wrote:
Perhaps entirely outside of the scope of GSOC, I think it would be a
fun project to make wikipedia.org and wikimedia.org accessible over
IPv6.
I noticed that my login was insecure, and that there was no SSL
option.
User Kaldari posted a comment on MediaWiki.r85417.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85417#c15717
Comment:
This is a less clunky fix for bug 27424. The other rev (r85415) was overkill.
___
MediaWiki-CodeReview mailing
User MaxSem changed the status of MediaWiki.r85387.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85387#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
I need to get back to work on reviews and deployments and other such
strategic things. I hope the work I've done on HipHop support is
enough to get the project started.
Initial benchmarks are showing a 5x speedup for article parsing, which
is better than we had hoped for. So there are big
62 matches
Mail list logo
