User Siebrand changed the status of MediaWiki.r85403.
Old Status: new
New Status: fixme
User Siebrand also posted a comment on MediaWiki.r85403.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15719
Comment:
FIXME:
+var_dump('foo');
User Tbleher changed the status of MediaWiki.r85296.
Old Status: new
New Status: fixme
User Tbleher also posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15720
Comment:
Surely getSkin() should return a skin object rather than a Linker
User Tim Starling posted a comment on MediaWiki.r82778.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c15721
Comment:
In EditPage::showEditForm:fields, you should do what you are doing already. Use
$parser-mOutput-setProperty() in the parser hook, remove the
User Dantman posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15722
Comment:
Why do we have to support old versions of extensions in new versions of core?
___
MediaWiki-CodeReview mailing
User Tim Starling changed the status of MediaWiki.r84997.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84997#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On 05/04/11 04:47, Tim Starling wrote:
Speaking of fast, I did a quick benchmark of the [[Barack Obama]]
article with templates pre-expanded. It took 22 seconds in HipHop and
112 seconds in Zend, which is not bad, for a first attempt. I reckon
it would do better if a few of the regular
On 04/05/2011 04:45 PM, Ashar Voultoiz wrote:
On 05/04/11 04:47, Tim Starling wrote:
Speaking of fast, I did a quick benchmark of the [[Barack Obama]]
article with templates pre-expanded. It took 22 seconds in HipHop and
112 seconds in Zend, which is not bad, for a first attempt. I
User Siebrand posted a comment on MediaWiki.r85296.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15726
Comment:
This is not a reason for marking an issue as FIXME. If the change broke the
trunk version of an extension, it might be.
Leaving this at FIXME because of
User Bryan changed the status of MediaWiki.r85354.
Old Status: new
New Status: fixme
User Bryan also posted a comment on MediaWiki.r85354.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85354#c15727
Comment:
pre
+* (bug 27018) Added action=filerevert to revert files to an old
On Tue, Apr 5, 2011 at 4:41 AM, Daniel Friesen
li...@nadir-seen-fire.com wrote:
Personally, I like tacking on ?action=edit and especially purge.
Prefixing Special:Edit/ doesn't sound nice to me.
I know I fixed the issues with things like Special:Movepage not sharing
the same UI tabs as the
2011/4/4 MZMcBride z...@mzmcbride.com:
Brion Vibber wrote:
I'm not a real MediaWiki developer, so it may be a silly question: How
hard it is to convert a gadget into an extension? If it's not too
hard, wouldn't it be better to redo useful gadgets as extensions?
Unless i miss something very
User Happy-melon changed the status of MediaWiki.r85403.
Old Status: fixme
New Status: new
User Happy-melon also posted a comment on MediaWiki.r85403.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15728
Comment:
Lol.
___
User ^demon posted a comment on MediaWiki.r85354.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85354#c15729
Comment:
Do you mean it should be and I missed it, or that I botched the REL-NOTES merge?
___
MediaWiki-CodeReview mailing
On 04/05/2011 05:47 AM, Tim Starling wrote:
Speaking of fast, I did a quick benchmark of the [[Barack Obama]]
article with templates pre-expanded. It took 22 seconds in HipHop and
112 seconds in Zend, which is not bad, for a first attempt. I reckon
it would do better if a few of the regular
Hi!
I am looking for static HTML Dumps of the English Wikipedia, but I have
found only this page: http://static.wikipedia.org/
This page contains almost three years old dumps!
Do you know other pages, where I could download recent HTML dumps from, or
do you have any idea, how could I get them?
On 04/05/2011 02:42 AM, Tim Starling wrote:
On 04/05/2011 07:31 AM, Platonides wrote:
Having to create a reflection class and look for exceptions just to
check for class existance is really ugly.
However, looking at https://github.com/facebook/hiphop-php/issues/314 it
seems to be a
Hello,
The HTML dump proces isn't running anymore according to the message on the
downloads page.
The most recent en.wiki dump is in XML and here:
http://dumps.wikimedia.org/enwiki/20110317/
Best,
Huib Laurens
___
Wikitech-l mailing list
On Tue, Apr 5, 2011 at 7:45 AM, Ashar Voultoiz hashar+...@free.fr wrote:
On 05/04/11 04:47, Tim Starling wrote:
Speaking of fast, I did a quick benchmark of the [[Barack Obama]]
article with templates pre-expanded. It took 22 seconds in HipHop and
112 seconds in Zend, which is not bad,
User Bryan changed the status of MediaWiki.r85354.
Old Status: fixme
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85354#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On Tue, Apr 5, 2011 at 12:58 AM, Tim Starling tstarl...@wikimedia.org wrote:
I need to get back to work on reviews and deployments and other such
strategic things. I hope the work I've done on HipHop support is
enough to get the project started.
Initial benchmarks are showing a 5x speedup for
User ^demon posted a comment on MediaWiki.r82413.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82413#c15731
Comment:
I couldn't get this to merge cleanly to REL1_17.
___
MediaWiki-CodeReview mailing list
2011/4/5 Magnus Manske magnusman...@googlemail.com:
For comparison: WYSIFTW parses [[Barak Obama]] in 3.5 sec on my iMac,
and in 4.4 sec on my MacBook (both Chrome 12).
Yes, it doesn't do template/variable replacing, and it's probably full
of corner cases that break; OTOH, it's JavaScript
On Tue, Apr 5, 2011 at 3:30 PM, Paul Copperman
paul.copper...@googlemail.com wrote:
2011/4/5 Magnus Manske magnusman...@googlemail.com:
For comparison: WYSIFTW parses [[Barak Obama]] in 3.5 sec on my iMac,
and in 4.4 sec on my MacBook (both Chrome 12).
Yes, it doesn't do template/variable
User ^demon posted a comment on MediaWiki.r85202.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85202#c15732
Comment:
r84918 was never merged, so r84924 isn't needed in 1.17. findFileFromKey() and
new newFileFromKey() are both in 1.17 as they should be.
User Platonides changed the status of MediaWiki.r85430.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85430#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Platonides changed the status of MediaWiki.r85410.
Old Status: new
New Status: fixme
User Platonides also posted a comment on MediaWiki.r85410.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85410#c15733
Comment:
AbortAutoAccount description should use more than one line
On Mon, 4 Apr 2011 23:19:54 -0400
Jelle Zijlstra jelle.zijls...@gmail.com wrote:
However, making https://www.mediawiki.org would be another useful
project.
That would be useful from a privacy point of view, though just making
all logins secure by default would be good first start. Making the
2011/4/5 Magnus Manske magnusman...@googlemail.com:
So is the time spent with the actual expansion (replacing variables),
or getting the wikitext for n-depth template recursion? Or is it the
parser functions?
Well, getting the wikitext shouldn't be very expensive as it is cached
in several
User Bawolff posted a comment on MediaWiki.r85247.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c15734
Comment:
One potential use case for not making the Linker static, is consider how sites
that have multiple urls (aka http://secure.wikimedia.org/wikipedia/en/wiki/ vs
User Happy-melon posted a comment on MediaWiki.r85247.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c15735
Comment:
Sites having multiple urls is itself black magic/hackish. The most we should
ever have to change is the protocol.
User Reedy changed the status of MediaWiki.r85439.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85439#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy posted a comment on MediaWiki.r85438.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85438#c15736
Comment:
Can you make days longer?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r85443.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85443#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Reedy changed the status of MediaWiki.r85442.
Old Status: new
New Status: resolved
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85442#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User MZMcBride posted a comment on MediaWiki.r85441.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85441#c15737
Comment:
Is this problem limited to this extension?
___
MediaWiki-CodeReview mailing list
User Reedy posted a comment on MediaWiki.r85441.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85441#c15738
Comment:
Very likely not. I think Cite (maybe!?) has already been fixed. I'd be highly
surprised if it's not a wider problem
User Krinkle posted a comment on MediaWiki.r85327.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15739
Comment:
I haven't read all the diffs, but I noticed a few changes that may not be
obvious and/or are conflicting with our current conventions.
Since HipHop is
User MaxSem posted a comment on MediaWiki.r85441.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85441#c15740
Comment:
Most likely, there are dozens of broken extensions. Oh well.
___
MediaWiki-CodeReview mailing list
User Nikola Smolenski posted a comment on MediaWiki.r82778.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c15741
Comment:
OK, in r85456 I am using LinksUpdate. If it is patched the extension should
work with the patch, and if not the extension should still work, without
I recently fixed a bug (14901) and attached some patches to the bug
ticket. Included were some changes to languages/messages/MessagesEn.php.
Following the directions given at http://www.mediawiki.org/wiki/
Localisation#Changing_existing_messages, I contacted #mediawiki-i18n and
asked them for
User MZMcBride posted a comment on MediaWiki.r85441.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85441#c15742
Comment:
Reedy fixed up other extensions in r85450, r85451, and r85452.
___
MediaWiki-CodeReview mailing list
Paul Houle wrote:
I did a substantial project that worked from the XML dumps. I
designed a recursive descent parser in C# that, with a few tricks,
almost decodes wikipedia markup correctly. Getting it right is tricky,
for a number of reasons, however, my approach preserved some
Interesting. That would be an -ops project, not a software development one.
It seems a riskier deliverable, although certainly interesting for WMF.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
On Tue, Apr 5, 2011 at 9:02 AM, Magnus Manske
magnusman...@googlemail.com wrote:
Yes, it doesn't do template/variable replacing, and it's probably full
of corner cases that break; OTOH, it's JavaScript running in a
browser, which should make it much slower than a dedicated server
setup running
User Simetrical posted a comment on MediaWiki.r82413.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82413#c15743
Comment:
Unsurprising. It's probably not a big deal, it can be left out unless we get
complaints. The changes are only going to even potentially affect bots that
Hi,
Today, some users on ro.wp reported that the citations used more than
once in the text had changed appeareance. Instead of ^a,b, we now
have something like ↑ 34,0 34,1. This was considered disturbing by
some users. Furthermore, the backlinks from the notes section to the
article are not
On 4/5/2011 4:00 PM, Platonides wrote
I think he is better parsing the articles, though.
For a linguistic research you don't need things such as the contents of
templates, so a simple wikitext stripping would do. And it will be much,
much, much, much faster than parsing the whole wiki.
On Tue, Apr 5, 2011 at 11:33 AM, Dan Nessett dness...@yahoo.com wrote:
I understand I need to fix these problems. However, before proceeding I
wonder if there are other constraints that I must observe. I have read
the material at http://www.mediawiki.org/wiki/Localisation, but did not
find
User Krinkle changed the status of MediaWiki.r85468.
Old Status: new
New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85468#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On 5 April 2011 21:29, Aryeh Gregor simetrical+wikil...@gmail.com wrote:
To the contrary, I'd expect JavaScript in the most recent version of
any browser (even IE) to be *much* faster than PHP, maybe ten times
faster on real-world tasks. All browsers now use JIT compilation for
JavaScript,
User Dantman posted a comment on MediaWiki.r85247.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85247#c15744
Comment:
That's not a good reason for the linker not to be static, that has nothing to
do with a skin overloading parts of the linker.
That's more of a use case for a
On Mon, Apr 4, 2011 at 6:06 PM, Daniel Friesen li...@nadir-seen-fire.comwrote:
Continuing with my changes to $wgOut, $wgUser, Skin, and SpecialPage
patterns.
The Linker is now static, $sk-link will still work, however you should
not be requiring a Skin anymore to use linker methods. Please
On 11-04-05 02:16 PM, Brion Vibber wrote:
On Mon, Apr 4, 2011 at 6:06 PM, Daniel
Friesenli...@nadir-seen-fire.comwrote:
Continuing with my changes to $wgOut, $wgUser, Skin, and SpecialPage
patterns.
The Linker is now static, $sk-link will still work, however you should
not be requiring a
When Roan Kattouw reviewed, and then rewrote most of the Narayam extension, I
reviewed his code, and found many things about the user interface that could
be, and need to be improved. I have both some observations and some
suggestions, expressed in the attached PDF.
The exact design I'm
Hoi,
Where can this PDF be found ?
Thanks,
GerardM
On 5 April 2011 23:44, Trevor Parscal tpars...@wikimedia.org wrote:
When Roan Kattouw reviewed, and then rewrote most of the Narayam extension,
I reviewed his code, and found many things about the user interface that
could be, and need
OK, not an attachment...
File:Narayam-proposal.pdf
File:Narayam-proposal-annotated.pdf
- Trevor
On Apr 5, 2011, at 2:44 PM, Trevor Parscal wrote:
When Roan Kattouw reviewed, and then rewrote most of the Narayam extension, I
reviewed his code, and found many things about the user interface
And by that I meant...
http://www.mediawiki.org/wiki/File:Narayam-proposal.pdf
http://www.mediawiki.org/wiki/File:Narayam-proposal-annotated.pdf
(I need to stop clicking send so fast... waiting a minute... OK, this one looks
good.)
- Trevor
On Apr 5, 2011, at 2:55 PM, Trevor Parscal wrote:
User Platonides changed the status of MediaWiki.r85450.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85450#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On Tue, Apr 5, 2011 at 10:07 PM, David Gerard dger...@gmail.com wrote:
On 5 April 2011 21:29, Aryeh Gregor simetrical+wikil...@gmail.com wrote:
To the contrary, I'd expect JavaScript in the most recent version of
any browser (even IE) to be *much* faster than PHP, maybe ten times
faster on
User Platonides changed the status of MediaWiki.r68358.
Old Status: fixme
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68358#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
Strainu wrote:
Hi,
Today, some users on ro.wp reported that the citations used more than
once in the text had changed appeareance. Instead of ^a,b, we now
have something like ↑ 34,0 34,1. This was considered disturbing by
some users. Furthermore, the backlinks from the notes section to the
User Platonides posted a comment on MediaWiki.r79108.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15745
Comment:
Maybe you were running with an old parserTEst.inc version where
$wgMemc = wfGetMainCache();
$messageMemc =
Implemented the workaround. Should be fixed now.
Ryan Kaldari
On 4/5/11 3:42 PM, Platonides wrote:
Strainu wrote:
Hi,
Today, some users on ro.wp reported that the citations used more than
once in the text had changed appeareance. Instead of ^a,b, we now
have something like ↑ 34,0 34,1.
Well it fixed the functionality of the links, but they still look weird.
Ryan Kaldari
On 4/5/11 4:02 PM, Ryan Kaldari wrote:
Implemented the workaround. Should be fixed now.
Ryan Kaldari
On 4/5/11 3:42 PM, Platonides wrote:
Strainu wrote:
Hi,
Today, some users on ro.wp reported that
User Platonides changed the status of MediaWiki.r85403.
Old Status: new
New Status: fixme
User Platonides also posted a comment on MediaWiki.r85403.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15746
Comment:
$ php tests/parserTests.php
PHP Fatal error: Call to a
Message: 1
Date: Tue, 5 Apr 2011 23:35:00 +0300
From: Strainu strain...@gmail.com
Subject: [Wikitech-l] Need some help with a problem with the Cite
extension
To: Wikimedia developers wikitech-l@lists.wikimedia.org
Message-ID: BANLkTik6Lbr=oc1sgcpbmhy0qjnwt6m...@mail.gmail.com
User Jack Phoenix changed the status of MediaWiki.r85492.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85492#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix changed the status of MediaWiki.r85500.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85500#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix changed the status of MediaWiki.r85503.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85503#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix changed the status of MediaWiki.r85505.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85505#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User Jack Phoenix changed the status of MediaWiki.r85506.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85506#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
On Tue, Apr 5, 2011 at 2:56 PM, Trevor Parscal tpars...@wikimedia.orgwrote:
And by that I meant...
http://www.mediawiki.org/wiki/File:Narayam-proposal.pdf
http://www.mediawiki.org/wiki/File:Narayam-proposal-annotated.pdf
Some nice thoughts; I definitely like having a more compact trigger at
User Jack Phoenix changed the status of MediaWiki.r85507.
Old Status: deferred
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85507#c0
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
User NeilK posted a comment on MediaWiki.r85465.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85465#c15747
Comment:
When I loaded this for the first time on prototype, I managed to get the
spinner spinning above the UploadWizard. The spinner didn't go away.
On Wed, April 6, 2011 3:26 am, Trevor Parscal wrote:
And by that I meant...
http://www.mediawiki.org/wiki/File:Narayam-proposal.pdf
http://www.mediawiki.org/wiki/File:Narayam-proposal-annotated.pdf
The positioning of IME looks good. It does not make much space and showing
it on hover of the
User MaxSem changed the status of MediaWiki.r85504.
Old Status: new
New Status: fixme
User MaxSem also posted a comment on MediaWiki.r85504.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85504#c15748
Comment:
Misses the .js file.
76 matches
Mail list logo
