[MediaWiki-CodeReview] [MediaWiki r106744]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Bawolff changed the status of MediaWiki.r106744 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106744 Old status: new New status: ok Commit summary for MediaWiki.r106744: Reverted r101014 per CR. Added comment. The sooner RL2 kills this the better...

[MediaWiki-CodeReview] [MediaWiki r106668]: New comment added

2011-12-20 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r106668. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106668#c28053 Commit summary for MediaWiki.r106668: * Use Language::userTimeAndDate() and related instead of Language::timeanddate() when using user preferences to display dates * Use local

[MediaWiki-CodeReview] [MediaWiki r106668]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106668 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106668 Old status: new New status: ok Commit summary for MediaWiki.r106668: * Use Language::userTimeAndDate() and related instead of Language::timeanddate() when using user

[MediaWiki-CodeReview] [MediaWiki r106756]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106756 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106756 Old status: new New status: ok Commit summary for MediaWiki.r106756: Correct the css rule. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r106755]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Bawolff changed the status of MediaWiki.r106755 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106755 Old status: new New status: ok Commit summary for MediaWiki.r106755: $reqArr is an ambiguous variable name - req can mean required or request. Changing to an unambiguous

[MediaWiki-CodeReview] [MediaWiki r106680]: New comment added

2011-12-20 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106680. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106680#c28054 Commit summary for MediaWiki.r106680: Follow up to r106673; rem dead code and fix obtaining of caller class name, which is not what __class__ does in methods called using

[MediaWiki-CodeReview] [MediaWiki r106672]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Bawolff changed the status of MediaWiki.r106672 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106672 Old status: new New status: ok Commit summary for MediaWiki.r106672: Followup r106619, mark said method public due to callers ___

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28055 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28056 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28057 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change

[MediaWiki-CodeReview] [MediaWiki r106766]: New comment added

2011-12-20 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r106766. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106766#c28058 Commit summary for MediaWiki.r106766: Don't re-use allinnamespace as the header for special:prefixindex. instead introduce new message prefixindex-namespace Hopefully

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Bawolff posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28059 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change

[MediaWiki-CodeReview] [MediaWiki r102417]: New comment added

2011-12-20 Thread MediaWiki Mail
Bawolff posted a comment on MediaWiki.r102417. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102417#c28060 Commit summary for MediaWiki.r102417: * Changed OutputPage's handling of subtitles to use an array and implode it with br / so that callers don't have to bother whether there's

[MediaWiki-CodeReview] [MediaWiki r106770]: New comment added

2011-12-20 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106770. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106770#c28061 Commit summary for MediaWiki.r106770: FU r106752: unbreak other sizes links on File: pages by working around the suck /media system. Aaron Schulz's comment: This also

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r106752 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28062 Old Status: fixme New Status: new Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only

[MediaWiki-CodeReview] [MediaWiki r106765]: New comment added

2011-12-20 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106765. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106765#c28063 Commit summary for MediaWiki.r106765: Set deleted zone container in UploadFromUrlTestSuite Aaron Schulz's comment: This doesn't fix the root problem of globals not being

[MediaWiki-CodeReview] [MediaWiki r106771]: New comment added

2011-12-20 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r106771. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106771#c28064 Commit summary for MediaWiki.r106771: Set deleted zone container in parserTest.inc Aaron Schulz's comment: This doesn't fix the root problem of globals not being restored

[MediaWiki-CodeReview] [MediaWiki r106682]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106682 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106682 Old status: new New status: ok Commit summary for MediaWiki.r106682: stylize; insert messages for qqq ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106686]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106686 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106686 Old status: new New status: ok Commit summary for MediaWiki.r106686: Use local context to get message ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106687]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106687 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106687 Old status: new New status: ok Commit summary for MediaWiki.r106687: 1.18wmf1: Update ArticleFeedbackv5 to trunk state again to pick up r106685

[MediaWiki-CodeReview] [MediaWiki r106688]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106688 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106688 Old status: new New status: ok Commit summary for MediaWiki.r106688: r106682: Consistency tweaks in preparation for adding extension to translatewiki.net: * Change

[MediaWiki-CodeReview] [MediaWiki r106694]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106694 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106694 Old status: new New status: ok Commit summary for MediaWiki.r106694: 1.18wmf1: Update AFTv5 to trunk state to pick up r106693

[MediaWiki-CodeReview] [MediaWiki r106699]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106699 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106699 Old status: new New status: ok Commit summary for MediaWiki.r106699: 1.18wmf1: Update ArticleFeedback to trunk state to pick up r106698

[MediaWiki-CodeReview] [MediaWiki r102116]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r102116 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102116#c28065 Old Status: ok New Status: fixme Commit summary for MediaWiki.r102116: * Only call Title::getPageLanguage() when necessary, i.e. after

[MediaWiki-CodeReview] [MediaWiki r102116]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
IAlex changed the status of MediaWiki.r102116 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102116#c28066 Old Status: fixme New Status: new Commit summary for MediaWiki.r102116: * Only call Title::getPageLanguage() when necessary, i.e. after

[MediaWiki-CodeReview] [MediaWiki r106773]: Revision status changed

2011-12-20 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r106773 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106773 Old status: new New status: ok Commit summary for MediaWiki.r106773: Fix for r102116: link feed to Special:Recentchanges, not current page

[MediaWiki-CodeReview] [MediaWiki r102116]: Revision status changed

2011-12-20 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r102116 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102116 Old status: new New status: resolved Commit summary for MediaWiki.r102116: * Only call Title::getPageLanguage() when necessary, i.e. after !$wgDisableLangConversion

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28067 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change

[MediaWiki-CodeReview] [MediaWiki r106708]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106708 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106708#c28068 Old Status: new New Status: ok Commit summary for MediaWiki.r106708: fix inf recursion fail Nikerabbit's comment: Or just 'SpecialPage',

[MediaWiki-CodeReview] [MediaWiki r106709]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106709 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106709 Old status: new New status: ok Commit summary for MediaWiki.r106709: fix inf recursion fail ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r106710]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106710 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106710 Old status: new New status: ok Commit summary for MediaWiki.r106710: fix inf recursion fail ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r106718]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106718 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106718#c28069 Old Status: new New Status: ok Commit summary for MediaWiki.r106718: Prepare for internationalisation Nikerabbit's comment: You should wrap the

[MediaWiki-CodeReview] [MediaWiki r106722]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106722 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106722 Old status: new New status: ok Commit summary for MediaWiki.r106722: [RELEASE-NOTES] Fix typo * typo: mw.util.getScript should be mw.util.wikiScript, it was and is not

[MediaWiki-CodeReview] [MediaWiki r106726]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106726 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106726 Old status: new New status: ok Commit summary for MediaWiki.r106726: Add some braces and also some documentation ___

[MediaWiki-CodeReview] [MediaWiki r106727]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106727 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106727 Old status: new New status: ok Commit summary for MediaWiki.r106727: Fix spaces to tabs Trim trailing whitespace ___

[MediaWiki-CodeReview] [MediaWiki r106729]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106729 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106729 Old status: new New status: ok Commit summary for MediaWiki.r106729: More space to tab stuff ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r106730]: New comment added

2011-12-20 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106730. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106730#c28070 Commit summary for MediaWiki.r106730: adding core js methods and css for MarkAsHelpful, addition to r106664 Nikerabbit's comment: mah-helpful-state gave me a laugh.

[MediaWiki-CodeReview] [MediaWiki r106736]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106736 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106736 Old status: new New status: ok Commit summary for MediaWiki.r106736: jslint pass (vars still redeclared, but fixed the browser-breaking stuff)

[MediaWiki-CodeReview] [MediaWiki r106737]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106737 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106737 Old status: new New status: ok Commit summary for MediaWiki.r106737: Fix syntax error ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r106738]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106738 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106738 Old status: new New status: ok Commit summary for MediaWiki.r106738: jslint pass, fixed critical-seeming stuff. ___

[MediaWiki-CodeReview] [MediaWiki r106739]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106739 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106739 Old status: new New status: ok Commit summary for MediaWiki.r106739: Updated stream file calls :) ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106743]: New comment added

2011-12-20 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r106743. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106743#c28071 Commit summary for MediaWiki.r106743: adding some initial language support and documentation Nikerabbit's comment: pre + 'mah-someone-marked-text' = '$1 thinks this

[MediaWiki-CodeReview] [MediaWiki r106751]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106751 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106751 Old status: new New status: ok Commit summary for MediaWiki.r106751: Removed var_dump() ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r106754]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106754 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106754#c28072 Old Status: new New Status: ok Commit summary for MediaWiki.r106754: adding sectiontitle/wgSectionTitle as a new parameter for page editing (so

[MediaWiki-CodeReview] [MediaWiki r106762]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106762 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106762 Old status: new New status: ok Commit summary for MediaWiki.r106762: and ... ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r106766]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106766 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106766 Old status: new New status: ok Commit summary for MediaWiki.r106766: Don't re-use allinnamespace as the header for special:prefixindex. instead introduce new message

[MediaWiki-CodeReview] [MediaWiki r106768]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106768 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106768 Old status: new New status: ok Commit summary for MediaWiki.r106768: Remove trailing whitespace and a few superfluous empty lines.

[MediaWiki-CodeReview] [MediaWiki r106772]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106772 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106772 Old status: new New status: ok Commit summary for MediaWiki.r106772: mw.util.addCSS will make IE version = 8 crash if the css is a fontface definition. Reverting to the

[MediaWiki-CodeReview] [MediaWiki r106775]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106775 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106775 Old status: new New status: ok Commit summary for MediaWiki.r106775: r106718: Consistency tweaks in preparation for adding extension to translatewiki.net: * i18n file: **

[MediaWiki-CodeReview] [MediaWiki r106776]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106776 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106776 Old status: new New status: ok Commit summary for MediaWiki.r106776: r106718: Adding extension to translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r106777]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106777 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106777 Old status: new New status: ok Commit summary for MediaWiki.r106777: FU r106776: Ignore this key ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106778]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106778 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106778 Old status: new New status: ok Commit summary for MediaWiki.r106778: r106664 : Consistency tweaks in preparation for adding extension to translatewiki.net: * i18n file:

[MediaWiki-CodeReview] [MediaWiki r106779]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106779 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106779 Old status: new New status: ok Commit summary for MediaWiki.r106779: r106664: Adding extension to translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r104684]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r104684 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104684#c28073 Old Status: fixme New Status: new Commit summary for MediaWiki.r104684: )bug 15521) Use new section summary when the action of adding a new section

[MediaWiki-CodeReview] [MediaWiki r106731]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106731 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106731 Old status: new New status: ok Commit summary for MediaWiki.r106731: Bug fix: revision select rollups had the ignore option set, but page rollups didn't

[MediaWiki-CodeReview] [MediaWiki r104684]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r104684 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104684 Old status: new New status: resolved Commit summary for MediaWiki.r104684: )bug 15521) Use new section summary when the action of adding a new section also happens to

[MediaWiki-CodeReview] [MediaWiki r106741]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106741 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106741 Old status: new New status: ok Commit summary for MediaWiki.r106741: AFTv5 Fix bug introduced in r106733. ___

[MediaWiki-CodeReview] [MediaWiki r106733]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Catrope changed the status of MediaWiki.r106733 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106733#c28074 Old Status: new New Status: ok Commit summary for MediaWiki.r106733: AFTv5 - turns out stuffing a DB result object in mcache was less than

[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added

2011-12-20 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106752. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28075 Commit summary for MediaWiki.r106752: Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change

[MediaWiki-CodeReview] [MediaWiki r94242]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r94242 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94242#c28076 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r94242: importing SemanticSignup extension Reedy's comment: Use of $this in a

Re: [Wikitech-l] Performance roadmap update

2011-12-20 Thread Mike Dupont
Well thanks for sharing this, I will also put my efforts on HPHP on hold for now as well. mike On Thu, Dec 15, 2011 at 3:26 PM, Jay Ashworth j...@baylink.com wrote: - Original Message - From: Tim Starling tstarl...@wikimedia.org So we've decided to defer our HipHop deployment until

[MediaWiki-CodeReview] [MediaWiki r106796]: New comment added

2011-12-20 Thread MediaWiki Mail
Catrope posted a comment on MediaWiki.r106796. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106796#c28077 Commit summary for MediaWiki.r106796: r106752: Add block comments Catrope's comment: pre + 'lockmanger-errors' = 'Lock manager', /pre Is this a typo?

[MediaWiki-CodeReview] [MediaWiki r106796]: New comment added

2011-12-20 Thread MediaWiki Mail
Raymond posted a comment on MediaWiki.r106796. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106796#c28078 Commit summary for MediaWiki.r106796: r106752: Add block comments Raymond's comment: Yes, fixed with r106802. ___

[MediaWiki-CodeReview] [MediaWiki r105855]: New comment added

2011-12-20 Thread MediaWiki Mail
SPQRobin posted a comment on MediaWiki.r105855. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105855#c28079 Commit summary for MediaWiki.r105855: Replaced the core message 'sectionlink' with getArrow, which is cleaner and does the right thing in mixed RTL/LTR environment. Removed

[MediaWiki-CodeReview] [MediaWiki r106793]: New comment added

2011-12-20 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r106793. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106793#c28080 Commit summary for MediaWiki.r106793: * ABC conversion support * Updating README regarding ABC support * Added auto-rendering exceptions * Automated LilyPond version

[MediaWiki-CodeReview] [MediaWiki r94242]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r94242 to deferred and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94242#c28081 Old Status: fixme New Status: deferred Commit summary for MediaWiki.r94242: importing SemanticSignup extension Jeroen De Dauw's comment:

[MediaWiki-CodeReview] [MediaWiki r106006]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r106006 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106006#c28082 Old Status: new New Status: reverted Commit summary for MediaWiki.r106006: Partly revert r105985 for now: Flooding of translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r106793]: New comment added

2011-12-20 Thread MediaWiki Mail
MarkAHershberger posted a comment on MediaWiki.r106793. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106793#c28083 Commit summary for MediaWiki.r106793: * ABC conversion support * Updating README regarding ABC support * Added auto-rendering exceptions * Automated LilyPond

[MediaWiki-CodeReview] [MediaWiki r106680]: New comment added

2011-12-20 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r106680. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106680#c28084 Commit summary for MediaWiki.r106680: Follow up to r106673; rem dead code and fix obtaining of caller class name, which is not what __class__ does in methods called

[MediaWiki-CodeReview] [MediaWiki r105855]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r105855 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105855#c28085 Old Status: ok New Status: fixme Commit summary for MediaWiki.r105855: Replaced the core message 'sectionlink' with getArrow, which is cleaner and

[Wikitech-l] Wikipedia SSL certs changed before expiration

2011-12-20 Thread Michael Becker
I'm running a firefox plugin called certpartol which alerts me to unusual ssl cert changes. The existing cert signed by GeoTrust, Inc. wasn't set to expire until 2016-07-19 02:17:12. The new cert is signed by DigiCert Inc. I just want to make sure this is an intentional change and not a fake

Re: [Wikitech-l] Wikipedia SSL certs changed before expiration

2011-12-20 Thread OQ
On Tue, Dec 20, 2011 at 9:18 AM, Michael Becker spa...@gmail.com wrote: I just want to make sure this is an intentional change and not a fake cert. 01:04 Ryan_Lane: switching ssl certificate to digicert certificate for wikipedia 00:46 Ryan_Lane: enabling https for *.m.wikipedia.org 00:46

Re: [Wikitech-l] Wikipedia SSL certs changed before expiration

2011-12-20 Thread Platonides
On 20/12/11 16:18, Michael Becker wrote: I'm running a firefox plugin called certpartol which alerts me to unusual ssl cert changes. The existing cert signed by GeoTrust, Inc. wasn't set to expire until 2016-07-19 02:17:12. The new cert is signed by DigiCert Inc. I just want to make sure

Re: [Wikitech-l] Wikipedia caching (invalidation?) problems

2011-12-20 Thread Platonides
On 20/12/11 03:16, Bjoern Hoehrmann wrote: Hi, I am looking for some bug tracking thing where I could keep track of how the various caching issues on Wikipedia are being addressed. (...) Well, the bug tracking thing is bugzilla itself. If there's not a bug for the problems you experience,

[MediaWiki-CodeReview] [MediaWiki r106796]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106796 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106796 Old status: new New status: resolved Commit summary for MediaWiki.r106796: r106752: Add block comments ___

[MediaWiki-CodeReview] [MediaWiki r106802]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106802 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106802 Old status: new New status: ok Commit summary for MediaWiki.r106802: Fix typo spotted by Roan. Originated in r106752, cp error in r106796.

[MediaWiki-CodeReview] [MediaWiki r106808]: New comment added

2011-12-20 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r106808. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106808#c28086 Commit summary for MediaWiki.r106808: Do some refactoring to allow easy subclassing stuffs Reedy's comment: Prerequisite for (bug 28747) AntiSpoof should also check global

[MediaWiki-CodeReview] [MediaWiki r106812]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106812 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106812 Old status: new New status: ok Commit summary for MediaWiki.r106812: Followup r106809, don't use class_exists, use MWInit::classExists() (I think we need to, right?

[MediaWiki-CodeReview] [MediaWiki r106809]: New comment added

2011-12-20 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r106809. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106809#c28087 Commit summary for MediaWiki.r106809: Followup r106808 *(bug 28747) AntiSpoof should also check global accounts from CentralAuth TODO: Need to do something with batchAntiSpoof

[Wikitech-l] Successor to wikibits.js::ts_makeSortable?

2011-12-20 Thread Daniel Barrett
Now that skins/common/wikibits.js is gone, so is the function ts_makeSortable. What is the equivalent call to ts_makeSortable(table) in MediaWiki 1.18? Here is our code we need to convert: function makesortable( context ) { $('table.sortable', context) .each(function(index, table){

Re: [Wikitech-l] Missing wiki redirect script

2011-12-20 Thread Roan Kattouw
On Sun, Dec 18, 2011 at 4:06 PM, Robin Pepermans robinp.1...@gmail.com wrote: So I would like to ask if someone can review deploy this (Commits are here: https://www.mediawiki.org/wiki/Special:Code/MediaWiki?path=/trunk/tools/web-scripts/missing.phpbut it may be easier to just review current

Re: [Wikitech-l] Successor to wikibits.js::ts_makeSortable?

2011-12-20 Thread Bergi
Daniel Barrett schrieb: Now that skins/common/wikibits.js is gone, so is the function ts_makeSortable. What is the equivalent call to ts_makeSortable(table) in MediaWiki 1.18? The tablesorter is available as a jQuery plugin function, see

[MediaWiki-CodeReview] [MediaWiki r106743]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r106743 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106743 Old status: new New status: fixme Commit summary for MediaWiki.r106743: adding some initial language support and documentation

[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added

2011-12-20 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r106706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28088 Commit summary for MediaWiki.r106706: [WebFonts] Code quality clean up * Various good practices, white space conventions (Thanks JSLint) * Such as: -- JavaScript does not have

[MediaWiki-CodeReview] [MediaWiki r106682]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r106682 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106682#c28089 Old Status: ok New Status: fixme Commit summary for MediaWiki.r106682: stylize; insert messages for qqq Siebrand's comment: +

[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added

2011-12-20 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r106706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28090 Commit summary for MediaWiki.r106706: [WebFonts] Code quality clean up * Various good practices, white space conventions (Thanks JSLint) * Such as: -- JavaScript does not have

[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added

2011-12-20 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r106706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28091 Commit summary for MediaWiki.r106706: [WebFonts] Code quality clean up * Various good practices, white space conventions (Thanks JSLint) * Such as: -- JavaScript does not have

Re: [Wikitech-l] Wikipedia SSL certs changed before expiration

2011-12-20 Thread Leslie Carr
On Tue, Dec 20, 2011 at 7:37 AM, Platonides platoni...@gmail.com wrote: On 20/12/11 16:18, Michael Becker wrote: I'm running a firefox plugin called certpartol which alerts me to unusual ssl cert changes. The existing cert signed by GeoTrust, Inc. wasn't set to expire until 2016-07-19

Re: [Wikitech-l] Wikipedia SSL certs changed before expiration

2011-12-20 Thread Leslie Carr
On Tue, Dec 20, 2011 at 10:15 AM, Leslie Carr lc...@wikimedia.org wrote: On Tue, Dec 20, 2011 at 7:37 AM, Platonides platoni...@gmail.com wrote: On 20/12/11 16:18, Michael Becker wrote: I'm running a firefox plugin called certpartol which alerts me to unusual ssl cert changes. The existing

[MediaWiki-CodeReview] [MediaWiki r106829]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106829 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106829 Old status: new New status: deferred Commit summary for MediaWiki.r106829: Return the Title object or URL to redirect to the hook instead of calling

[MediaWiki-CodeReview] [MediaWiki r82498]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r82498 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82498#c28092 Old Status: ok New Status: fixme Commit summary for MediaWiki.r82498: bug 27146 Brion VIBBER's comment: Did not fix the bug.

[MediaWiki-CodeReview] [MediaWiki r75041]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r75041 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75041#c28093 Old Status: ok New Status: fixme Commit summary for MediaWiki.r75041: Add an option option to not perform a global login (bug 20852). This also

[MediaWiki-CodeReview] [MediaWiki r106801]: New comment added

2011-12-20 Thread MediaWiki Mail
Brion VIBBER posted a comment on MediaWiki.r106801. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106801#c28094 Commit summary for MediaWiki.r106801: * (bug 30671) CentralAuth should globally autologin user on account creation Fixed per Jeroens comment on the bug Problem was

[MediaWiki-CodeReview] [MediaWiki r106745]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Khorn (WMF) changed the status of MediaWiki.r106745 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106745 Old status: new New status: ok Commit summary for MediaWiki.r106745: Switching message to be explictly that we also accept debit cards

[MediaWiki-CodeReview] [MediaWiki r106742]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Khorn (WMF) changed the status of MediaWiki.r106742 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106742 Old status: new New status: ok Commit summary for MediaWiki.r106742: Making monthly donation text actually be monthly ___

[MediaWiki-CodeReview] [MediaWiki r75041]: New comment added, and revision status changed

2011-12-20 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r75041 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75041#c28095 Old Status: fixme New Status: reverted Commit summary for MediaWiki.r75041: Add an option option to not perform a global login (bug 20852).

[MediaWiki-CodeReview] [MediaWiki r106801]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Brion VIBBER changed the status of MediaWiki.r106801 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106801 Old status: new New status: reverted Commit summary for MediaWiki.r106801: * (bug 30671) CentralAuth should globally autologin user on account creation Fixed per

[MediaWiki-CodeReview] [MediaWiki r106839]: Revision status changed

2011-12-20 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106839 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106839 Old status: new New status: ok Commit summary for MediaWiki.r106839: Revert r75041: adds extra do what you should always do 100% of the time checkbox that makes no

[MediaWiki-CodeReview] [MediaWiki r106801]: New comment added

2011-12-20 Thread MediaWiki Mail
Brion VIBBER posted a comment on MediaWiki.r106801. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106801#c28096 Commit summary for MediaWiki.r106801: * (bug 30671) CentralAuth should globally autologin user on account creation Fixed per Jeroens comment on the bug Problem was

[MediaWiki-CodeReview] [MediaWiki r106839]: New comment added

2011-12-20 Thread MediaWiki Mail
Jeroen De Dauw posted a comment on MediaWiki.r106839. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106839#c28097 Commit summary for MediaWiki.r106839: Revert r75041: adds extra do what you should always do 100% of the time checkbox that makes no sense, caused regression on account

  1   2   3   >