[MediaWiki-CodeReview] [MediaWiki r103260]: New comment added

2011-12-22 Thread MediaWiki Mail
G.Hagedorn posted a comment on MediaWiki.r103260. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103260#c28286 Commit summary for MediaWiki.r103260: (follow-up r100023; bug 32438) $pagesCount is total number of members a category has, not the number that are normal pages.

[MediaWiki-CodeReview] [MediaWiki r103260]: New comment added

2011-12-22 Thread MediaWiki Mail
G.Hagedorn posted a comment on MediaWiki.r103260. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103260#c28287 Commit summary for MediaWiki.r103260: (follow-up r100023; bug 32438) $pagesCount is total number of members a category has, not the number that are normal pages.

[MediaWiki-CodeReview] [MediaWiki r107014]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107014 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107014 Old status: new New status: ok Commit summary for MediaWiki.r107014: [mediawiki.api] bug fixes * error callback of some convenience functions was broken. Second argument

[MediaWiki-CodeReview] [MediaWiki r107036]: New comment added

2011-12-22 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r107036. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107036#c28288 Commit summary for MediaWiki.r107036: Adding support for managing puppet classes and variables through the interface, rather than LocalSettings.php. Resolves bug 32221 and bug

[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added

2011-12-22 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r106706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28289 Commit summary for MediaWiki.r106706: [WebFonts] Code quality clean up * Various good practices, white space conventions (Thanks JSLint) * Such as: -- JavaScript

[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28290 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The

[MediaWiki-CodeReview] [MediaWiki r106992]: New comment added

2011-12-22 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r106992. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106992#c28291 Commit summary for MediaWiki.r106992: [Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText * Fixes bug 33305 Santhosh.thottingal's comment: I

[MediaWiki-CodeReview] [MediaWiki r107021]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107021 Old status: new New status: ok Commit summary for MediaWiki.r107021: call_user_func_array() is not actually necessary ___

[MediaWiki-CodeReview] [MediaWiki r106706]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106706 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706 Old status: new New status: resolved Commit summary for MediaWiki.r106706: [WebFonts] Code quality clean up * Various good practices, white space

[MediaWiki-CodeReview] [MediaWiki r107023]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107023 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107023 Old status: new New status: ok Commit summary for MediaWiki.r107023: Update documentation on params method of Message class to indicate it can either be varags, or it can

[MediaWiki-CodeReview] [MediaWiki r107026]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107026 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107026 Old status: new New status: ok Commit summary for MediaWiki.r107026: Followup r106817 If in doubt, add more .. ___

[MediaWiki-CodeReview] [MediaWiki r107027]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107027 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107027 Old status: new New status: resolved Commit summary for MediaWiki.r107027: Update paths from r106787 And also, use more newer/familiar code for inclusion of

[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100535 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: new New status: resolved Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on

[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100535 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: resolved New status: reverted Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based

[MediaWiki-CodeReview] [MediaWiki r101117]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r101117 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101117 Old status: new New status: reverted Commit summary for MediaWiki.r101117: FU r100535: * Thumb handler can now also work without cURL * Combined related config vars into

[MediaWiki-CodeReview] [MediaWiki r101117]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r101117 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101117 Old status: reverted New status: resolved Commit summary for MediaWiki.r101117: FU r100535: * Thumb handler can now also work without cURL * Combined related config vars

[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100535 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: reverted New status: resolved Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based

[MediaWiki-CodeReview] [MediaWiki r100782]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100782 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100782 Old status: new New status: resolved Commit summary for MediaWiki.r100782: FU r100535: * Added thumb-handler.php5 file * Moved 404.php to thumb-handler.php as

[MediaWiki-CodeReview] [MediaWiki r100577]: New comment added

2011-12-22 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r100577. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100577#c28292 Commit summary for MediaWiki.r100577: FU r100535: * Changed custom functions to work via a $thgThumbCallbacks variable * Added 'checkCache' and 'fillCache' hooks to

[MediaWiki-CodeReview] [MediaWiki r107029]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107029 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107029 Old status: new New status: ok Commit summary for MediaWiki.r107029: Followup r107027, require_once will work much better ___

[MediaWiki-CodeReview] [MediaWiki r100610]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100610 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100610 Old status: new New status: ok Commit summary for MediaWiki.r100610: * (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current

[MediaWiki-CodeReview] [MediaWiki r100610]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r100610. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100610#c28293 Commit summary for MediaWiki.r100610: * (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview Hashar's comment:

[MediaWiki-CodeReview] [MediaWiki r100445]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r100445 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100445 Old status: new New status: resolved Commit summary for MediaWiki.r100445: Use local context to get messages ___

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
Marooned posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28294 Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they do happen and modern browsers support them. This

[MediaWiki-CodeReview] [MediaWiki r106948]: New comment added

2011-12-22 Thread MediaWiki Mail
Marooned posted a comment on MediaWiki.r106948. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106948#c28295 Commit summary for MediaWiki.r106948: tests for r94881 which interprets relative Location: headers Marooned's comment: As I've answered you under 94881, I stumbled upon some

[MediaWiki-CodeReview] [MediaWiki r107050]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107050 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107050#c28296 Old Status: new New Status: ok Commit summary for MediaWiki.r107050: Add gender support for two messages. Uncertain yet if this is properly done

[MediaWiki-CodeReview] [MediaWiki r105645]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r105645. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105645#c28297 Commit summary for MediaWiki.r105645: Add a configuration variable to work around the issue that has been reported at least twice on IRC: pages from MW with a 404 status code

[MediaWiki-CodeReview] [MediaWiki r107051]: New comment added

2011-12-22 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r107051. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051#c28298 Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303 Siebrand's comment: Can we make the help URL configurable in a

[MediaWiki-CodeReview] [MediaWiki r107048]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107048 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107048 Old status: new New status: ok Commit summary for MediaWiki.r107048: Typo in CommonsHelper English ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107049]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107049 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107049 Old status: new New status: ok Commit summary for MediaWiki.r107049: Better help icon. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104392]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r104392 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104392 Old status: new New status: resolved Commit summary for MediaWiki.r104392: Correct the pointer behavior on the menu items.

[MediaWiki-CodeReview] [MediaWiki r106432]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106432 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106432 Old status: new New status: ok Commit summary for MediaWiki.r106432: it is not possible to stop propagation of live events. changed to delegage. Merged the two live

[MediaWiki-CodeReview] [MediaWiki r106435]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106435 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106435 Old status: new New status: ok Commit summary for MediaWiki.r106435: Updated the Tamil bamini keymap. Ref Bug 31904 ___

[MediaWiki-CodeReview] [MediaWiki r107045]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107045 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107045 Old status: new New status: ok Commit summary for MediaWiki.r107045: Moved SQLite test .sql files to the common test data directory

[MediaWiki-CodeReview] [MediaWiki r106945]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106945 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106945 Old status: new New status: ok Commit summary for MediaWiki.r106945: profiling ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r106944]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106944 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106944 Old status: new New status: ok Commit summary for MediaWiki.r106944: Added 2 new feeds: Did you know? and Quote of the day; message documentation

[MediaWiki-CodeReview] [MediaWiki r106930]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106930 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106930 Old status: new New status: ok Commit summary for MediaWiki.r106930: Renamed parameter 'channel' into 'feed' for clarity ___

[MediaWiki-CodeReview] [MediaWiki r106824]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106824 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106824 Old status: new New status: ok Commit summary for MediaWiki.r106824: Made todaysStart() honor local time zone ___

[MediaWiki-CodeReview] [MediaWiki r106814]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r106814 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106814 Old status: new New status: resolved Commit summary for MediaWiki.r106814: Roughly done. Needs i18n review, messages 'ffeed-*-page' should be left untranslated

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28299 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is

[MediaWiki-CodeReview] [MediaWiki r107047]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107047 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107047 Old status: new New status: ok Commit summary for MediaWiki.r107047: remove bug 31921 from 1.19 RN Fix was merged in REL1_18 by r107046

[MediaWiki-CodeReview] [MediaWiki r107054]: Revision status changed

2011-12-22 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r107054 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054 Old status: new New status: ok Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is

[MediaWiki-CodeReview] [MediaWiki r107046]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107046 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107046 Old status: new New status: ok Commit summary for MediaWiki.r107046: MFT to REL1_18 r100610, bug 31921 This is a regression in REL1_18: (bug 31921) Magic words

[MediaWiki-CodeReview] [MediaWiki r107044]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107044 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107044 Old status: new New status: ok Commit summary for MediaWiki.r107044: adding Wikinaut ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107051]: New comment added

2011-12-22 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r107051. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051#c28301 Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303 Santhosh.thottingal's comment: Help link made

[MediaWiki-CodeReview] [MediaWiki r106764]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106764 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106764 Old status: new New status: ok Commit summary for MediaWiki.r106764: FU r106752: Fixed directory b/c for ForeignAPIRepo, which was moved to Setup.php

[MediaWiki-CodeReview] [MediaWiki r106765]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106765 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106765#c28302 Old Status: new New Status: ok Commit summary for MediaWiki.r106765: Set deleted zone container in UploadFromUrlTestSuite Tim Starling's

[MediaWiki-CodeReview] [MediaWiki r106771]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106771 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106771 Old status: new New status: ok Commit summary for MediaWiki.r106771: Set deleted zone container in parserTest.inc ___

[MediaWiki-CodeReview] [MediaWiki r107042]: New comment added

2011-12-22 Thread MediaWiki Mail
Moejoe000 posted a comment on MediaWiki.r107042. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107042#c28303 Commit summary for MediaWiki.r107042: Make apibase of $wgForeignFileRepos (InstantCommons) protocol relative too Moejoe000's comment: AFIAK, this is used by MediaWiki itself

[MediaWiki-CodeReview] [MediaWiki r106834]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106834 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106834 Old status: new New status: ok Commit summary for MediaWiki.r106834: FU r106752: added b/c code to FSRepo to make things easy for extensions (like ConfirmAccount)

[MediaWiki-CodeReview] [MediaWiki r106841]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106841 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106841 Old status: new New status: ok Commit summary for MediaWiki.r106841: Cleaned up some references to FSRepo in code and comments. This should have no noticeable

[MediaWiki-CodeReview] [MediaWiki r106894]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106894 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106894 Old status: new New status: ok Commit summary for MediaWiki.r106894: FU r106752: use media- instead of images- in container names. Long live books, video, 3D meshes,

[MediaWiki-CodeReview] [MediaWiki r106978]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106978 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106978 Old status: new New status: ok Commit summary for MediaWiki.r106978: * Added FileRepo::SKIP_LOCKING constant and made storeBatch() check it. * Made

[MediaWiki-CodeReview] [MediaWiki r107056]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107056. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107056#c28304 Commit summary for MediaWiki.r107056: Get the help link from messages based on content language. Nikerabbit's comment: You don't need to load webfonts-help-page in resource

[MediaWiki-CodeReview] [MediaWiki r106597]: New comment added

2011-12-22 Thread MediaWiki Mail
Toniher posted a comment on MediaWiki.r106597. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106597#c28305 Commit summary for MediaWiki.r106597: added UserFunction Toniher's comment: I've already addressed, at least partially, some of the concerns that were raised in this review.

[MediaWiki-CodeReview] [MediaWiki r106982]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106982 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106982#c28306 Old Status: new New Status: ok Commit summary for MediaWiki.r106982: * FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28307 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28308 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to

[MediaWiki-CodeReview] [MediaWiki r107055]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r107055 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107055#c28309 Old Status: new New Status: ok Commit summary for MediaWiki.r107055: Fixed a typo in r107054 Hashar's comment: I need to make an infograph out of

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28310 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to

[MediaWiki-CodeReview] [MediaWiki r106982]: New comment added

2011-12-22 Thread MediaWiki Mail
Peachey88 posted a comment on MediaWiki.r106982. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106982#c28311 Commit summary for MediaWiki.r106982: * FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no longer uses bogus public root URL/thumb default for the

[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added

2011-12-22 Thread MediaWiki Mail
GrafZahl posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28312 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The error

[MediaWiki-CodeReview] [MediaWiki r107058]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107058 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107058 Old status: new New status: ok Commit summary for MediaWiki.r107058: bind temp file and purge after encoding to prevent deletion/race condition on the temp file name.

[MediaWiki-CodeReview] [MediaWiki r106956]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r106956 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106956 Old status: fixme New status: resolved Commit summary for MediaWiki.r106956: Encode videos in temp and only add to FileRepo once done.

[MediaWiki-CodeReview] [MediaWiki r106459]: New comment added

2011-12-22 Thread MediaWiki Mail
Tim Starling posted a comment on MediaWiki.r106459. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106459#c28313 Commit summary for MediaWiki.r106459: Commit Lilypond replacement from https://github.com/TheCount/score See

[MediaWiki-CodeReview] [MediaWiki r107020]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r107020 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107020 Old status: new New status: ok Commit summary for MediaWiki.r107020: FU r105512: urldecode() the file and thumb name in wfExtractThumbParams() for 404 handling as

[MediaWiki-CodeReview] [MediaWiki r107028]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r107028 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107028 Old status: new New status: ok Commit summary for MediaWiki.r107028: * FU r106752: de-uglified Setup.php by moving most of the b/c code into FileBackendGroup. Deferred

[MediaWiki-CodeReview] [MediaWiki r106770]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r106770 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106770 Old status: new New status: ok Commit summary for MediaWiki.r106770: FU r106752: unbreak other sizes links on File: pages by working around the suck /media system.

[MediaWiki-CodeReview] [MediaWiki r97022]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Tim Starling changed the status of MediaWiki.r97022 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022 Old status: new New status: ok Commit summary for MediaWiki.r97022: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28314 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
Marooned posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28315 Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they do happen and modern browsers support them. This

[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28316 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The

[MediaWiki-CodeReview] [MediaWiki r107056]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107056 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107056 Old status: new New status: ok Commit summary for MediaWiki.r107056: Get the help link from messages based on content language.

[MediaWiki-CodeReview] [MediaWiki r107057]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107057 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107057 Old status: new New status: ok Commit summary for MediaWiki.r107057: Remove webfonts-help-page from resourceloader. Follow up r107056

[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28317 Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they do happen and modern browsers support them. This function

[MediaWiki-CodeReview] [MediaWiki r106948]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r106948. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106948#c28318 Commit summary for MediaWiki.r106948: tests for r94881 which interprets relative Location: headers Hashar's comment: Yeah it is a bit surprising to have multiple headers. A

[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added

2011-12-22 Thread MediaWiki Mail
SPQRobin posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28319 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. SPQRobin's comment: If it is

[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28320 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. Nikerabbit's comment: Does it

[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added

2011-12-22 Thread MediaWiki Mail
SPQRobin posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28321 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. SPQRobin's comment: Yes, it

[MediaWiki-CodeReview] [MediaWiki r107065]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107065 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107065 Old status: new New status: ok Commit summary for MediaWiki.r107065: Adding basic support for translatable workflow states.

[MediaWiki-CodeReview] [MediaWiki r81074]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Petrb changed the status of MediaWiki.r81074 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81074 Old status: new New status: deferred Commit summary for MediaWiki.r81074: (bug 235) parser function for conversion of units of measurement. [[Template:Convert]] on enwiki

[MediaWiki-CodeReview] [MediaWiki r94421]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r94421 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94421 Old status: new New status: resolved Commit summary for MediaWiki.r94421: (bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages

[MediaWiki-CodeReview] [MediaWiki r107067]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107067 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107067 Old status: new New status: ok Commit summary for MediaWiki.r107067: Use ⌘ in for Mac keyboard shortcuts Looks better to the eye when playing with your User:foo/style.css

[MediaWiki-CodeReview] [MediaWiki r107066]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107066. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107066#c28322 Commit summary for MediaWiki.r107066: apply CSS::Janus when user preview its CSS style follow up r94421 Nikerabbit's comment: This doesn't cause any problems wrt the order

[MediaWiki-CodeReview] [MediaWiki r107065]: New comment added

2011-12-22 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r107065. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107065#c28323 Commit summary for MediaWiki.r107065: Adding basic support for translatable workflow states. Siebrand's comment: I was wondering if we should maybe add basic workflow states

Re: [Wikitech-l] Documentation on logging code

2011-12-22 Thread Niklas Laxström
On 15 December 2011 00:46, Niklas Laxström niklas.laxst...@gmail.com wrote: On 14 December 2011 19:08, Daniel Barrett d...@vistaprint.com wrote: I also noticed the lack of documentation on LogPage so I just wrote this on mediawiki.org: http://www.mediawiki.org/wiki/Logging_to_Special:Log

[MediaWiki-CodeReview] [MediaWiki r107051]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107051 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051 Old status: new New status: ok Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303

[MediaWiki-CodeReview] [MediaWiki r107063]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107063 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063 Old status: new New status: ok Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28324 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to

[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28325 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28326 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is

[MediaWiki-CodeReview] [MediaWiki r107068]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107068 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107068 Old status: new New status: ok Commit summary for MediaWiki.r107068: fix case of addInLineScript Use the correct case wich is: addInlineScript Follow r95435

[MediaWiki-CodeReview] [MediaWiki r95435]: New comment added, and revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r95435 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95435#c28327 Old Status: fixme New Status: new Commit summary for MediaWiki.r95435: add inline comments to the diff output This patch rely on various previous

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-22 Thread Jay Ashworth
- Original Message - From: Peter Kaminski kamin...@istori.com I don't have anything particular against Lua and no particular love for JavaScript, but JS seems more web-native; plus code and skills developed can accrue to both client- and server-side of the web. Just so I'm clear:

[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added

2011-12-22 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28328 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table

[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added

2011-12-22 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28329 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp

[MediaWiki-CodeReview] [MediaWiki r107071]: New comment added

2011-12-22 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r107071. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107071#c28330 Commit summary for MediaWiki.r107071: r107056: This key is optinal for translatewiki.net Siebrand's comment: Please make it ignored.

[MediaWiki-CodeReview] [MediaWiki r95680]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r95680. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95680#c28331 Commit summary for MediaWiki.r95680: (bug 30617) inline comments forms cannot be closed On clicking a line, a javascript insert a tr element containg the form. That tr did not get

[MediaWiki-CodeReview] [MediaWiki r95680]: Revision status changed

2011-12-22 Thread MediaWiki Mail
Hashar changed the status of MediaWiki.r95680 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95680 Old status: fixme New status: new Commit summary for MediaWiki.r95680: (bug 30617) inline comments forms cannot be closed On clicking a line, a javascript insert a tr element

[MediaWiki-CodeReview] [MediaWiki r107074]: New comment added

2011-12-22 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r107074. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107074#c28332 Commit summary for MediaWiki.r107074: make sure the line ID is an integer before injecting it Might prevents a CSS attack of some sort. I am not an expert on this topic. That

  1   2   3   >