Re: [Wikitech-l] Barkeep code review tool

2012-07-01 Thread Antoine Musso
Roan Kattouw wrote: Yes, ops essentially uses a post-commit workflow right now, and that makes sense for them. ops also uses pre-commit review for non-ops people :-] -- Antoine hashar Musso ___ Wikitech-l mailing list

Re: [Wikitech-l] Barkeep code review tool

2012-07-01 Thread Roan Kattouw
On Sat, Jun 30, 2012 at 11:53 PM, Antoine Musso hashar+...@free.fr wrote: Roan Kattouw wrote: Yes, ops essentially uses a post-commit workflow right now, and that makes sense for them. ops also uses pre-commit review for non-ops people :-] Yeah, that's right. What I meant to say (and thought

Re: [Wikitech-l] Speed up tests, make @group Database smarter

2012-07-01 Thread Christian Aistleitner
Hi Platonides, On Sat, Jun 30, 2012 at 03:45:14PM +0200, Platonides wrote: On 30/06/12 14:24, Christian Aistleitner wrote: [ Mocking the database ] [...] One would have to abstract database access above the SQL layer (separate methods for select, insert, ...) [...] You still need

[Wikitech-l] Handling deletion using the latest revision

2012-07-01 Thread Jeroen De Dauw
Hey, I am writing some code that needs to be executed on every article deletion and which needs the latest revision of the article that was deleted. Is there any place (hook) where I can put this without doing a db read for the revision? And if not, is there any place where I can put this where I

Re: [Wikitech-l] Barkeep code review tool

2012-07-01 Thread Ryan Lane
Yeah, that's right. What I meant to say (and thought I had said in some form later in that message) was that the puppet repo has post-commit review for most changes by ops staff, and pre-commit review for everything else (non-ops staff, volunteers, and certain changes by ops staff in some

[Wikitech-l] git commit history

2012-07-01 Thread Subramanya Sastry
One thing I just noticed when looking at the git history via gitk (on Ubuntu) is that the history looks totally spaghetti and it is hard to make sense of the history. This seems to have happened since the switch to git and post-commit review workflow. It might be worth considering this as

Re: [Wikitech-l] Date Formatting

2012-07-01 Thread Andrew Garrett
I think I once added a parser function that formats dates according to a user's preferences. It might be called {{#dateformat}}. You could possibly steal the code that it uses. On Tue, Jun 26, 2012 at 2:45 AM, Derric Atzrott datzr...@alizeepathology.com wrote: How do you format dates according

Re: [Wikitech-l] Extension Skeleton Program

2012-07-01 Thread Andrew Garrett
Ooh, I like this. On Thu, Jun 28, 2012 at 7:37 AM, Ori Livneh o...@wikimedia.org wrote: On Monday, June 25, 2012 at 9:06 AM, Derric Atzrott wrote: Would anyone be interested in a program that generates Skeletons for new extensions? I've noticed that when I make extensions I generally go

Re: [Wikitech-l] [Wmfall] Announcement: Matt Walker joins Wikimedia as Fundraising Engineer

2012-07-01 Thread Andrew Garrett
I'm looking forward to meeting you when I get back from Wikimania! On Sat, Jun 30, 2012 at 5:45 AM, Terry Chay tc...@wikimedia.org wrote: Hello everyone, It’s with great pleasure that I’m announcing that Matt Walker has joined the Wikimedia Foundation as a Fundraising Engineer. Before

[Wikitech-l] Bugzilla Weekly Report

2012-07-01 Thread reporter
MediaWiki Bugzilla Report for June 25, 2012 - July 02, 2012 Status changes this week Bugs NEW : 266 Bugs ASSIGNED : 81 Bugs REOPENED : 33 Bugs RESOLVED

Re: [Wikitech-l] git commit history

2012-07-01 Thread Roan Kattouw
On Sun, Jul 1, 2012 at 5:30 PM, Subramanya Sastry ssas...@wikimedia.org wrote: One thing I just noticed when looking at the git history via gitk (on Ubuntu) is that the history looks totally spaghetti and it is hard to make sense of the history. This seems to have happened since the switch to