Re: [Wikitech-l] Declaring methods final in classes

2019-08-27 Thread Máté Szabó
Hey, My understanding is that mocking final methods and types is a limitation that is not specific to just PHPUnit, or indeed to PHP itself. Mockery, another established PHP mock object framework, relies on a workaround for mocking final methods and types that prevents testing code with type

Re: [Wikitech-l] Declaring methods final in classes

2019-08-27 Thread Daimona
Personally, I don't like these limitations in PHPUnit and the like. IMHO, they should never be a reason for changing good code. And sometimes, methods have to be final. I don't know about the specific case, though. Anyway, some time ago I came across [1], which allows mocking final methods and

[Wikitech-l] Declaring methods final in classes

2019-08-27 Thread Aryeh Gregor
I see that in some classes, like WANObjectCache, most methods are declared final. Why is this? Is it an attempt to optimize? The problem is that PHPUnit mocks can't touch final methods. Any ->method() calls that try to do anything to them silently do nothing. This makes writing tests harder. If

Re: [Wikitech-l] [Train] 1.34.0-wmf.20 status update

2019-08-27 Thread Željko Filipin
Hi! # TLDR 1.34.0-wmf.20 is at group 0, but blocked https://phabricator.wikimedia.org/T220745 # Blockers Train will not move forward until the following tasks are resolved or removed from blockers: * DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code

[Wikitech-l] Discovery Weekly Update for the week starting 2019-08-05

2019-08-27 Thread Chris Koerner
Hello, This is the weekly update from the Search Platform team for the week starting 2019-08-05. As always, feedback and questions are welcome. == Discussions == === Search === * Erik discovered that Prometheus was not collecting cloudelastic metrics...so, he defined cloudelastic as a cluster

Re: [Wikitech-l] Phabricator monthly statistics - 2019-07

2019-08-27 Thread Daniel Zahn
On Tue, Aug 27, 2019 at 5:59 PM Zppix wrote: > Why are we receiving this now? > Because i ran it after https://gerrit.wikimedia.org/r/c/operations/puppet/+/532711 for https://phabricator.wikimedia.org/T231320 and mail delivery is delayed a bit. ___

Re: [Wikitech-l] Phabricator monthly statistics - 2019-07

2019-08-27 Thread Zppix
Why are we receiving this now? -- Devin “Zppix” CCENT Volunteer Wikimedia Developer Africa Wikimedia Developers Member and Mentor Volunteer Mozilla Support Team Member (SUMO) Quora.com Partner Program Member enwp.org/User:Zppix **Note: I do not work for Wikimedia Foundation, or any of its

[Wikitech-l] Phabricator monthly statistics - 2019-07

2019-08-27 Thread communitymetrics
Hi Community Metrics team, This is your automatic monthly Phabricator statistics mail. Accounts created in (2019-07): 290 Active Maniphest users (any activity) in (2019-07): 967 Task authors in (2019-07): 521 Users who have closed tasks in (2019-07): 293 Projects which had at least one task

[Wikitech-l] Looking for a senior full-stack developer (Contractor) for Scribe (Wikimedia-funded project)

2019-08-27 Thread Lucie Kaffee
Hello everyone, We are looking for a senior full-stack developer to work with us as a contractor on Scribe. Scribe is a Wikimedia Foundation funded software and research project. We are building a tool to support newcomer Wikipedia editors in creating new articles in under-resourced languages

[Wikitech-l] Wednesday: Technical Advice IRC Meeting

2019-08-27 Thread Raz Shuty
Sorry for cross-posting! Reminder: Technical Advice IRC meeting this week **Wednesday 3-4 pm UTC** on #wikimedia-tech. Questions can be asked in English! The Technical Advice IRC Meeting (TAIM) is a weekly support event for volunteer developers. Every Wednesday, two full-time developers are

Re: [Wikitech-l] [Train] 1.34.0-wmf.20 status update

2019-08-27 Thread Željko Filipin
I would like to thank everybody that worked on resolving train blockers. These tasks are now resolved. * L10n cache is completely broken https://phabricator.wikimedia.org/T231183 I've found more problems that are blocking the train from even starting. * RevisionBasedEntityLookup.php: Revision