User Nikerabbit posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24960
Commit summary:
user configuration
fixed db
Comment:
pre+ array( 'username' = strtolower($wgUser-getID()) ),
/pre
Why are you lower casing user
User Petrb posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24979
Commit summary:
user configuration
fixed db
Comment:
why is this fixme?
I lowercase it because when someone login as bob while his name is Bob it's
possible that
User Nikerabbit posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24980
Commit summary:
user configuration
fixed db
Comment:
User object is guaranteed to return the user name in correct capitalization.
Now you cannot for example do a
User Petrb posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24981
Commit summary:
user configuration
fixed db
Comment:
also lowercase should be only in mediawiki hooks which work in db, otherwise it
isn't necessary on User:bob it
User Petrb posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24982
Commit summary:
user configuration
fixed db
Comment:
I don't see a reason to do join, anyway, user object may return correct name,
but there are other ways used than
User Nikerabbit posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24983
Commit summary:
user configuration
fixed db
Comment:
If the user name comes from some other source, I would pass it through the user
object to get the correct
User Petrb posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24984
Commit summary:
user configuration
fixed db
Comment:
I removed tolower now I hope it never fail because of that...
___
User TheDJ posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c25030
Commit summary:
user configuration
fixed db
Comment:
r100973
___
MediaWiki-CodeReview mailing list
User Raymond changed the status of MediaWiki.r100835.
Old Status: new
New Status: fixme
User Raymond also posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24895
Commit summary:
user configuration
fixed db
Comment:
This is a dupe
User Petrb posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24896
Commit summary:
user configuration
fixed db
Comment:
renamed
___
MediaWiki-CodeReview mailing list
User TheDJ posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24897
Commit summary:
user configuration
fixed db
Comment:
in r100848
___
MediaWiki-CodeReview mailing list
User Petrb changed the status of MediaWiki.r100835.
Old Status: deferred
New Status: fixme
User Petrb also posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24899
Commit summary:
user configuration
fixed db
Comment:
could you tell
User TheDJ posted a comment on MediaWiki.r100835.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24900
Commit summary:
user configuration
fixed db
Comment:
See
13 matches
Mail list logo