[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24960 Commit summary: user configuration fixed db Comment: pre+ array( 'username' = strtolower($wgUser-getID()) ), /pre Why are you lower casing user

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24979 Commit summary: user configuration fixed db Comment: why is this fixme? I lowercase it because when someone login as bob while his name is Bob it's possible that

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24980 Commit summary: user configuration fixed db Comment: User object is guaranteed to return the user name in correct capitalization. Now you cannot for example do a

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24981 Commit summary: user configuration fixed db Comment: also lowercase should be only in mediawiki hooks which work in db, otherwise it isn't necessary on User:bob it

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24982 Commit summary: user configuration fixed db Comment: I don't see a reason to do join, anyway, user object may return correct name, but there are other ways used than

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24983 Commit summary: user configuration fixed db Comment: If the user name comes from some other source, I would pass it through the user object to get the correct

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24984 Commit summary: user configuration fixed db Comment: I removed tolower now I hope it never fail because of that... ___

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-27 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c25030 Commit summary: user configuration fixed db Comment: r100973 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r100835. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24895 Commit summary: user configuration fixed db Comment: This is a dupe

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User Petrb posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24896 Commit summary: user configuration fixed db Comment: renamed ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24897 Commit summary: user configuration fixed db Comment: in r100848 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added, and revision status changed

2011-10-26 Thread MediaWiki Mail
User Petrb changed the status of MediaWiki.r100835. Old Status: deferred New Status: fixme User Petrb also posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24899 Commit summary: user configuration fixed db Comment: could you tell

[MediaWiki-CodeReview] [MediaWiki r100835]: New comment added

2011-10-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r100835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100835#c24900 Commit summary: user configuration fixed db Comment: See