Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-29 Thread Tony Thomas
We will have to make Jenkins bot run composer install before running tests for a start. Currently, jenkins wont be able to find the libraries and the test fails ref: https://gerrit.wikimedia.org/r/#/c/135290. Thanks, Tony Thomas FOSS@Amrita where there is a wifi, there is a way On Wed, May 28,

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-28 Thread Tony Thomas
Yes. we will have the third party code kept in a separate repo though. Currently, mw users have to run : sudo apt-get install php-pear sudo pear install mail sudo pear install Net_SMTP to install the pear and mail package to get mail working. After this patch, and composer loded with the

[Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Tony Thomas
Hi, We were having discussions regarding putting the new SwiftMailer[1] lib in/out of core, after the merge of the change https://gerrit.wikimedia.org/r/#/c/135290. Tyler recommends to add the installer code to the composer.json and not to add the SwiftMailer code to the core. This

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Bryan Davis
On Tue, May 27, 2014 at 2:56 AM, Tony Thomas 01tonytho...@gmail.com wrote: Hi, We were having discussions regarding putting the new SwiftMailer[1] lib in/out of core, after the merge of the change https://gerrit.wikimedia.org/r/#/c/135290. Tyler recommends to add the installer code

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Mark A. Hershberger
Tony Thomas 01tonytho...@gmail.com writes: We were having discussions regarding putting the new SwiftMailer[1] lib in/out of core, after the merge of the change https://gerrit.wikimedia.org/r/#/c/135290. Tyler recommends to add the installer code to the composer.json and not to add

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Tony Thomas
That sounds great Bryan. I think we should create a new repository in gerrit (mediawiki/core/contrib? waiting for that repo to show up in gerrit. On Tue, May 27, 2014 at 7:38 PM, Mark A. Hershberger m...@nichework.com wrote: Thank you! I think the more use we make of composer, the better. I

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Trevor Parscal
Also, please note that includes/lib is meant to be a place for external libraries. Some of the libraries are ones we have ported or written ourselves, but we should continue using this space as external libraries increase in number and change in nature. - Trevor On Tue, May 27, 2014 at 9:12 AM,

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Tyler Romeo
Thomas 01tonytho...@gmail.com Reply: Wikimedia developers wikitech-l@lists.wikimedia.org Date: May 27, 2014 at 12:13:16 To: Wikimedia developers wikitech-l@lists.wikimedia.org Subject:  Re: [Wikitech-l] Adding external libraries to core (SwiftMailer) So, if we can have the swiftmailer repo added

Re: [Wikitech-l] Adding external libraries to core (SwiftMailer)

2014-05-27 Thread Matthew Flaschen
On 05/27/2014 11:57 AM, Bryan Davis wrote: I think we should create a new repository in gerrit (mediawiki/core/contrib? Bikeshed as needed) where composer is used to manage importing specific versions of external libraries that are needed for the wiki[mp]edia cluster deployments. Is the idea