Re: [Wikitech-l] Help remove unused wmf-config code

2018-07-08 Thread Krinkle
On Sun, Jul 8, 2018 at 12:49 PM, Adam Wight wrote: > Strange--the "UseContributionTracking" variable is still a thing, although > it's reported as unused by the script. See > https://github.com/wikimedia/operations-mediawiki-config/ > blob/master/wmf-config/CommonSettings.php#L2098 > > I get

Re: [Wikitech-l] Help remove unused wmf-config code

2018-07-08 Thread Adam Wight
Strange--the "UseContributionTracking" variable is still a thing, although it's reported as unused by the script. See https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L2098 I get correct results when querying manually:

Re: [Wikitech-l] Help remove unused wmf-config code

2018-07-08 Thread Gergo Tisza
On Sun, Jul 8, 2018 at 5:41 AM Stas Malyshev wrote: > > Open for review: > > > https://gerrit.wikimedia.org/r/#/q/project:operations/mediawiki-config+topic:cleanup+is:open > > This one produces 404. > Unfortunately search URLs are not compatible between the old and new Gerrit interface. The

Re: [Wikitech-l] Help remove unused wmf-config code

2018-07-07 Thread Stas Malyshev
Hi! > I wrote a script to detect unused wmf-config code. [1] Specifically, unused > settings and conditional blocks for configuration that no longer exists in > MediaWiki. > > The script cross-references any wg- identifiers in wmf-config with > Legoktm's Codesearch tool [2] and reports those

[Wikitech-l] Help remove unused wmf-config code

2018-07-07 Thread Krinkle
TL;DR: Check https://wikitech.wikimedia.org/wiki/User:Krinkle/Unused_config and help remove variables. Hi, I wrote a script to detect unused wmf-config code. [1] Specifically, unused settings and conditional blocks for configuration that no longer exists in MediaWiki. The script