Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Bart Humphries
I favor deprecating functions. I'm sure you're familiar with https://xkcd.com/1172/ Have a great day, Bart Humphries bart.humphr...@gmail.com (909)529-BART(2278) <9095292278> On Tue, Jul 31, 2018 at 3:16 PM, Alex Winkler wrote: > So to give my perspective as an "outsider": > > My day to day

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Alex Winkler
So to give my perspective as an "outsider": My day to day job is to write MediaWiki extensions for a wiki-farm called Liquipedia. We are mostly hopping LTS version, so even deprecation for two versions doesn't necessarily mean much to us here. Generally I just install a new MediaWiki version

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Aryeh Gregor
On Tue, Jul 31, 2018 at 3:46 PM, Stephan Gambke wrote: > I agree that there is a trade-off to be done. > I disagree about expecting code to be put where it is visible to core > developers. I do appreciate that you go and look for where the > functionality that you are working on is used outside

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Stephan Gambke via Wikitech-l
> So we have to make a trade-off between the burden on extension > developers and on core developers. When it seems likely that > basically no non-public extension/skin uses the feature, I think it's > reasonable to say that we should do what's easiest for core > developers. If a few people out

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Aryeh Gregor
On Tue, Jul 31, 2018 at 10:43 AM, Stephan Gambke wrote: > There are three "probability qualifiers" in that sentence (seems, probable, > basically). You just don't know if somebody now has to fix their code. Correct -- I can't know, because they didn't put their code in a place where code search

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I don't have a strong opinion about the specific function in this case, but I did want to discuss a few things about the policy itself. On 07/30/2018 06:28 AM, Stephan Gambke via Wikitech-l wrote: > I know it is annoying as heck to keep

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-31 Thread Stephan Gambke via Wikitech-l
> of work they have to do. The deprecation policy is just to give > extension maintainers a bit of breathing room so they don't have to > scramble to update their extension before it breaks. Exactly. It also makes it easier for them to maintain their extensions for more than the last version of

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-30 Thread Aryeh Gregor
On Mon, Jul 30, 2018 at 4:28 PM, Stephan Gambke via Wikitech-l wrote: > There have been several proposals for removal without deprecation in the past > few days, each with more impact on existing code - from "virtually certain > nobody ever used" to "the fix is trivial". > > I know it is

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-30 Thread Stephan Gambke via Wikitech-l
There have been several proposals for removal without deprecation in the past few days, each with more impact on existing code - from "virtually certain nobody ever used" to "the fix is trivial". I know it is annoying as heck to keep outdated code, but if you ask me, unless there is an

[Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

2018-07-30 Thread Aryeh Gregor
Patch to remove: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447647 Bug: https://phabricator.wikimedia.org/T200247 Existing uses: https://codesearch.wmflabs.org/search/?q=MagicWord%3A%3AclearCache=nope== I'm in the middle of creating a MagicWordFactory service to replace the MagicWord