Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-17 Thread Steinsplitter Wiki
Apologies if I'm missing something but is there any reason why we can't do image rotation on the client using the canvas JavaScript api? Client side rotation takes ages, especially with big files. Agreed! Most of that probably should be non-destructive editing that keeps the original and

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-17 Thread Jon Robson
Apologies if I'm missing something but is there any reason why we can't do image rotation on the client using the canvas JavaScript api? On Thu, Jul 16, 2015 at 3:45 PM, MZMcBride z...@mzmcbride.com wrote: Brion Vibber wrote: Allowing override of the thumb rotation would provide you real time

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Steinsplitter Wiki
You would still need to rewrite the bot though, even if there was a rotation API, wouldn't you? No need to rewrite then because Rillke will fix the rotate link java-script. :-) Date: Thu, 16 Jul 2015 12:21:10 -0500 From: gti...@wikimedia.org To: wikitech-l@lists.wikimedia.org Subject: Re:

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brion Vibber
Out of curiosity what is the problem with the bot that prevents it from working? It's entirely possible that fixing the bot is easier than hacking an internal rotate and reupload feature that runs on the image scalers. Or... Just making it possible to mark images as needing to be rotated

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Pine W
Perhaps this should go to Community Tech or Multimedia. Copying to the Multimedia list. Pine On Jul 16, 2015 6:27 AM, Steinsplitter Wiki steinsplitter-w...@live.com wrote: Hi, I am not sure if this is the correct mailinglist to write. Every week on commons a bot is rotating hunderts of

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brad Jorsch (Anomie)
On Thu, Jul 16, 2015 at 8:26 AM, Steinsplitter Wiki steinsplitter-w...@live.com wrote: I am wonder if it is possible to enable and code review this feature asap. For clarification, it's not just a matter of enable and code review. The existing code, if enabled, will run the rotation on the

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Dan Garry
Hi Steinsplitter, On 16 July 2015 at 09:00, Steinsplitter Wiki steinsplitter-w...@live.com wrote: Out of curiosity what is the problem with the bot that prevents it from working? It is very old and bad written and needs a complete rewrite. That doesn't really answer Brion's question. What

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brion Vibber
On Thu, Jul 16, 2015 at 9:00 AM, Steinsplitter Wiki steinsplitter-w...@live.com wrote: Out of curiosity what is the problem with the bot that prevents it from working? It is very old and bad written and needs a complete rewrite. That can be said of many things in our stack. ;) What made

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Steinsplitter Wiki
Out of curiosity what is the problem with the bot that prevents it from working? It is very old and bad written and needs a complete rewrite. It's entirely possible that fixing the bot is easier than hacking an internal rotate and reupload feature that runs on the image scalers. It would be

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Steinsplitter Wiki
That doesn't really answer Brion's question. What would prevent it from continuing to run while it is being rewritten? lack of time. Date: Thu, 16 Jul 2015 09:05:11 -0500 From: dga...@wikimedia.org To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] Provide a well-performing API to

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Gergo Tisza
You would still need to rewrite the bot though, even if there was a rotation API, wouldn't you? On Thu, Jul 16, 2015 at 11:19 AM, YiFei zhuyifei1...@gmail.com wrote: That doesn't really answer Brion's question. What would prevent it from continuing to run while it is being rewritten? lack

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brion Vibber
Ok, I've thrown together a preliminary patch to move the actual rotation for ApiImageRotate to the job queue: https://gerrit.wikimedia.org/r/#/c/225097/ Haven't had a chance to test it yet, so there's probably a typo or two still hiding in there. Steinsplitter, will there be a (more limited)

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread YiFei
That doesn't really answer Brion's question. What would prevent it from continuing to run while it is being rewritten? lack of time. (commenting on this as I tried to debug the code previously) The code currently: * is independent from any maintained mw api libraries * use self defined api

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread MZMcBride
Brion Vibber wrote: Allowing override of the thumb rotation would provide you real time rotation... I'm not sure about the need to rotate the original file; ideally original files should be left as-is and kept archival. In my opinion, we need to solve image rotation as part of a larger project

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brion Vibber
On Thu, Jul 16, 2015 at 3:45 PM, MZMcBride z...@mzmcbride.com wrote: Brion Vibber wrote: Allowing override of the thumb rotation would provide you real time rotation... I'm not sure about the need to rotate the original file; ideally original files should be left as-is and kept archival.

Re: [Wikitech-l] Provide a well-performing API to rotate an image

2015-07-16 Thread Brion Vibber
Updated https://gerrit.wikimedia.org/r/225097 with some partial infrastructure for tracking the status of pending updates (not quite done yet). ... also a little prep work for future crop and trim transformations. Comments on the patch or the attached phab ticket please. :D -- brion On Thu, Jul