[MediaWiki-CodeReview] [MediaWiki r96270]: New comment added

2011-09-08 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r96270. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96270#c22151 Commit summary: (bug 26470) add checkered background on files pages Comment: Thanks for the review! ___

[MediaWiki-CodeReview] [MediaWiki r95921]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r95921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95921#c22152 Commit summary: (bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped Comment: Code is written once, but read many times. Currently it is

[MediaWiki-CodeReview] [MediaWiki r96516]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96516. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r96516. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96516#c22153 Commit summary: split out the inside of File::transform() to

[MediaWiki-CodeReview] [MediaWiki r96547]: New comment added

2011-09-08 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96547. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96547#c22154 Commit summary: Followup r96489: add WikimediaMaintenance to make-wmf-branch Comment: Maybe a little pre-emptive, as it won't be needed till 1.19.. Will this fail

[MediaWiki-CodeReview] [MediaWiki r96547]: New comment added

2011-09-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96547. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96547#c22155 Commit summary: Followup r96489: add WikimediaMaintenance to make-wmf-branch Comment: Oh, bah, you're right. Reverting.

[MediaWiki-CodeReview] [MediaWiki r96547]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96547. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96547 Commit summary: Followup r96489: add WikimediaMaintenance to make-wmf-branch ___

[MediaWiki-CodeReview] [MediaWiki r96550]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r96550. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96550 Commit summary: Revert r96547 per CR: not needed until 1.19 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96541]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r96541. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96541 Commit summary: Rm old options from commandLine.inc days ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96517]: New comment added

2011-09-08 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r96517. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96517#c22156 Commit summary: Merge r90266 to trunk Fixes fixme on r75341, r75343 Comment: Tim said on the original Unfortunately wfMsgNoDB() doesn't do what it says anymore. So if

[MediaWiki-CodeReview] [MediaWiki r96517]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96517. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96517#c22157 Commit summary: Merge r90266 to trunk Fixes fixme on r75341, r75343 Comment: I don't know, but there shouldn't be any unused messages in MessagesEn.php

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
I just commited many changes to logging code. There is more to come, but I think this is suitable place to write in more detail what is going on. I'd also like to request code review and testing :) Thus far I have committed new formatting code and small cleanups. Both LogEventsList and

[MediaWiki-CodeReview] [MediaWiki r96471]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96471. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96471 Commit summary: Renamed LogEntry class to SpecialLogEntry to avoid conflict with core interface Small untested fixes to the code while

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Aaron Schulz
Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. I'll toss these revs onto my review queue. Bugzilla from niklas.laxst...@gmail.com wrote: I just commited many changes to logging code. There is more to come, but I think this is suitable place to

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Max Semenik
On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though data in those fields is small enough, can serialize()/unserialize() be used instead? It's faster and doesn't

[MediaWiki-CodeReview] [MediaWiki r80116]: New comment added

2011-09-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r80116. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80116#c22158 Commit summary: Fixed IE bug, you must use html:msg for the msg elements that jquery.localize uses to translate things otherwise IE chokes when you insert them cause it

[Wikitech-l] OpenID, OAuth ... -- http://accountchooser.com/

2011-09-08 Thread Thomas Gries
http://openidsummitsept2011.eventbrite.com/ http://accountchooser.com/ I have just been informed about the new initiative of the OpenID foundation: There are many technical protocols support by identity providers (OpenID v2, SAML, OAuth2, OpenIDConnect, etc.) The Account Chooser is not specific

[MediaWiki-CodeReview] [MediaWiki r80116]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r80116. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80116#c22159 Commit summary: Fixed IE bug, you must use html:msg for the msg elements that jquery.localize uses to translate things otherwise IE chokes when you insert them cause

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though data in those fields is small enough, can

[MediaWiki-CodeReview] [MediaWiki r96534]: New comment added

2011-09-08 Thread MediaWiki Mail
User Svemir Brkic posted a comment on MediaWiki.r96534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96534#c22160 Commit summary: Added support for intitle:, incategory:, and prefix: searches Updated defatult matching mode to SPH_MATCH_EXTENDED2, cleaned up Comment: Good

[MediaWiki-CodeReview] [MediaWiki r96474]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96474. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96474 Commit summary: Backport r95340, partial r94773 from trunk for bug 30485: set override styles for hieroglyphic layout tables to avoid

[MediaWiki-CodeReview] [MediaWiki r96482]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96482. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96482 Commit summary: Followup r96477 -- .css file didn't get committed :P ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96477]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96477. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96477 Commit summary: Backport r95340, partial r94773 from trunk for bug 30485: set override styles for hieroglyphic layout tables to avoid

[MediaWiki-CodeReview] [MediaWiki r96481]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96481 Commit summary: Merge r96474 from 1.17 -- Backport r95340, partial r94773 from trunk for bug 30485: set override styles for hieroglyphic

[MediaWiki-CodeReview] [MediaWiki r96555]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96555. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96555#c22161 Commit summary: streamlined preparePrefixRegexp and used preg_quote when building a regexp Comment: You should also pass the delimiter character to preg_quote. In

[MediaWiki-CodeReview] [MediaWiki r96555]: New comment added

2011-09-08 Thread MediaWiki Mail
User Svemir Brkic posted a comment on MediaWiki.r96555. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96555#c22162 Commit summary: streamlined preparePrefixRegexp and used preg_quote when building a regexp Comment: Fixed in r96558

[MediaWiki-CodeReview] [MediaWiki r96559]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96559. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96559 Commit summary: MFT r92422, r93520, r93563, r94107, r94433, r95042, r95332, r95451, r96386 Tests excluded (due to movements etc)

[MediaWiki-CodeReview] [MediaWiki r96400]: New comment added

2011-09-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96400. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22163 Commit summary: Fix for total extension breakage due to protocol relative URLs Comment: Should be addressed properly in r96560.

[MediaWiki-CodeReview] [MediaWiki r96462]: New comment added

2011-09-08 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r96462. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96462#c22164 Commit summary: added cancel button to survey edit page and added default header and thanks messages Comment: Why FIXME? It's not UI text, it doesn't cause

[MediaWiki-CodeReview] [MediaWiki r96397]: New comment added

2011-09-08 Thread MediaWiki Mail
User Svemir Brkic posted a comment on MediaWiki.r96397. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96397#c22165 Commit summary: Removing files and globals that will not be needed in version 0.8 SphinxMWSeach is now the default mode of operation Use 127.0.0.1 instead of

[MediaWiki-CodeReview] [MediaWiki r96558]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96558. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r96558. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96558#c22166 Commit summary: pass the delimiter to preg_quote Comment: Great! If

[MediaWiki-CodeReview] [MediaWiki r96555]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96555. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96555 Commit summary: streamlined preparePrefixRegexp and used preg_quote when building a regexp

[MediaWiki-CodeReview] [MediaWiki r95921]: New comment added

2011-09-08 Thread MediaWiki Mail
User Johnduhart posted a comment on MediaWiki.r95921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95921#c22168 Commit summary: (bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped Comment: It's my understanding that with magic_quotes in PHP5 the

[MediaWiki-CodeReview] [MediaWiki r96142]: New comment added

2011-09-08 Thread MediaWiki Mail
User Catrope posted a comment on MediaWiki.r96142. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96142#c22169 Commit summary: Change position of Narayam controls to personal tools/menu area as proposed by Trevor Pascal, codes with help from Santhosh. Tested in FF, Chrome and

[MediaWiki-CodeReview] [MediaWiki r96143]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96143. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96143 Commit summary: essage=Mistakenly forgot to add in rev96142. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96181]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96181. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96181 Commit summary: Fix javascript error. $('input.narayam-scheme')[0] does not give jquery object. Use $('input.narayam-scheme:first') instead.

[MediaWiki-CodeReview] [MediaWiki r96185]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96185. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96185 Commit summary: Use hasClass instead of .is . And small cleanup of the code with oneliner. ___

[MediaWiki-CodeReview] [MediaWiki r96186]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96186. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96186 Commit summary: Refactor the code for building the menu to buildMenu. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96412]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96412. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96412 Commit summary: Stoppin further actions if no schemes, fix for r96186 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96423]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96423. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96423 Commit summary: Updating Tamil transliteration rules as requested in bug 29816. ___

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Daniel Friesen
On 11-09-08 04:25 AM, Niklas Laxström wrote: On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though

[MediaWiki-CodeReview] [MediaWiki r96190]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96190. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r96190. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96190#c22170 Commit summary: Make the labels of input method menu clickable. Comment: pre

[MediaWiki-CodeReview] [MediaWiki r96190]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96190. Old Status: ok New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96190 Commit summary: Make the labels of input method menu clickable. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96566]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96566. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96566 Commit summary: Followup r96142: add @embed ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96204]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96204. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r96204. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96204#c22171 Commit summary: workaround for IE bug - activex components like input fields

[MediaWiki-CodeReview] [MediaWiki r96567]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96567. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96567 Commit summary: JSHint and whitespace fixes, mostly missing semicolons and missing 'var's. Code introduced in a variety of revs but mostly

[MediaWiki-CodeReview] [MediaWiki r96569]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96569. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96569 Commit summary: Show a more useful message when someone tries enabling profileinfo but hasn't created the table yet

[MediaWiki-CodeReview] [MediaWiki r96573]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96573. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96573 Commit summary: More style fixes, mostly for r96204 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96574]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96574. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96574 Commit summary: Fix regression in r96204: IME was not turned on and icon not shown if you didn't have a cookie with the currently enabled

[MediaWiki-CodeReview] [MediaWiki r81473]: New comment added

2011-09-08 Thread MediaWiki Mail
User Umherirrender posted a comment on MediaWiki.r81473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81473#c22172 Commit summary: Merge REL1_17 r81465, r81471 in 1.17wmf1: * MFT r81455, r81461, r81463: updates for core special pages aliases, magic words and namespace names. *

[MediaWiki-CodeReview] [MediaWiki r96440]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96440. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96440 Commit summary: merge r96434 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r94836]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r94836. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94836 Commit summary: MFT r94690, r94829 with backported compatible translations. ___

[MediaWiki-CodeReview] [MediaWiki r96219]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96219. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96219 Commit summary: Update r94836 per r94831 ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-08 Thread Ashar Voultoiz
On 06/09/11 08:27, Daniel Friesen wrote: snip So, I'd love to see other peoples ideas on the best syntax for our skin system. Or ideas or comments on how to fix the problem with the syntax I came up with. Can you possibly have a look at HAML? It is a basic language that makes HTML 'simpler'

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
On 8 September 2011 17:57, Daniel Friesen li...@nadir-seen-fire.com wrote: On 11-09-08 04:25 AM, Niklas Laxström wrote: On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was

[MediaWiki-CodeReview] [MediaWiki r96580]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96580. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96580 Commit summary: followup r96549: Add the 'display:none' to the existing section instead of opening a new one.

[MediaWiki-CodeReview] [MediaWiki r96581]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96581#c22173 Commit summary: Added (slightly modified) patch from LY Meng to allow multiple-instance templates to be embedded within another template call Comment: Garbled

[MediaWiki-CodeReview] [MediaWiki r96586]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96586. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96586 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22174 Commit summary: Switch JSON to (un)serialize Comment: Why the switch? How easy would it be for non-PHP scripts scanning the DB tables (or dumps) to unserialize

[MediaWiki-CodeReview] [MediaWiki r96587]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96587. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96587 Commit summary: No need to use an extension function to define a new log type ___

[MediaWiki-CodeReview] [MediaWiki r96588]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r96588. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96588 Commit summary: fix typo from r96498 that was breaking Parser tests ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added

2011-09-08 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22175 Commit summary: Switch JSON to (un)serialize Comment: On wikitech it was pointed out that we already use serialized data on many database fields. I don't believe

[MediaWiki-CodeReview] [MediaWiki r96437]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96437. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96437 Commit summary: Actually fix bug 30792, despite my earlier claims. SquidUpdate::purge('//upload.wikimedia.org/foo') would return

[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22176 Commit summary: Switch JSON to (un)serialize Comment: Are those fields that people might be interested in for offline purposes? Are there stand-alone PHP

[MediaWiki-CodeReview] [MediaWiki r96261]: New comment added

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r96261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96261#c22177 Commit summary: * Mark underline css as !important. It should override other css (such as the css added in r91432) if the user specifically selected that option. *

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-08 Thread Trevor Parscal
My main complaint with Haml and Sass are that they introduce yet another syntax, all while trying to simplify things. On the other extreme XSLT uses XML syntax, but can get pretty complex, usually unnecessarily so - it also introduces XPath, which some developers may not know. Ideally we should

[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added

2011-09-08 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22178 Commit summary: Switch JSON to (un)serialize Comment: Join the ML discussion. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r94461]: New comment added

2011-09-08 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r94461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94461#c22179 Commit summary: Fix r94429 : Left and right side are still nearly the same color for 7% of the population. When I wrote to the list a while ago, no one argued for

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-08 Thread Daniel Friesen
Aye, there's absolutely no way HAML is going to fly with the majority of people building skins. Instead of Why the hell do I have to insert all this junk just to make my skin work right? I'm going back to WordPress. kind of issue we had before I cleaned up the skin system we'll end up with a What

[MediaWiki-CodeReview] [MediaWiki r96581]: New comment added

2011-09-08 Thread MediaWiki Mail
User Yaron Koren posted a comment on MediaWiki.r96581. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96581#c22181 Commit summary: Added (slightly modified) patch from LY Meng to allow multiple-instance templates to be embedded within another template call Comment: That's

[MediaWiki-CodeReview] [MediaWiki r96584]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96584. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96584 Commit summary: Got synth (the great refactoring of 2011) working! ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r96399]: New comment added

2011-09-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96399#c22182 Commit summary: restore proper operation of getArchive{Path|Url} Comment: This was a followup to r96373. ___

Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system

2011-09-08 Thread Russell N. Nelson - rnnelson
How about http://en.wikipedia.org/wiki/TRAC_%28programming_language%29 ? It has the benefit that simple things are simple, but you can create complicated things because it's a full programming language. ___ Wikitech-l mailing list

[MediaWiki-CodeReview] [MediaWiki r59048]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r59048. Old Status: fixme New Status: resolved User ^demon also posted a comment on MediaWiki.r59048. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/59048#c22183 Commit summary: add trailing zeroes for MW_TIMESTAMP format Comment:

[MediaWiki-CodeReview] [MediaWiki r87936]: New comment added

2011-09-08 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87936. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87936#c22184 Commit summary: Corrects a small bug causing math\sin/math to return an unknown function error Comment: Still the right fix though :D

[MediaWiki-CodeReview] [MediaWiki r96399]: New comment added

2011-09-08 Thread MediaWiki Mail
User RussNelson posted a comment on MediaWiki.r96399. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96399#c22185 Commit summary: restore proper operation of getArchive{Path|Url} Comment: Reverting only part of it. I didn't understand that possibly, someone somewhere is

[MediaWiki-CodeReview] [MediaWiki r73498]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r73498. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73498 Commit summary: Initial import of the new ArticleEmblems extension which adds support for emblem tags, of which the contents are

[MediaWiki-CodeReview] [MediaWiki r96593]: New comment added

2011-09-08 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r96593. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96593#c22189 Commit summary: Remove mw- prefix from WikiHiero styles. A 7kb saving on Special:Hieroglyphs :D Comment: Isn't this prefix is for core only?

[MediaWiki-CodeReview] [MediaWiki r96593]: New comment added

2011-09-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96593. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96593#c22190 Commit summary: Remove mw- prefix from WikiHiero styles. A 7kb saving on Special:Hieroglyphs :D Comment: I don't know if that rule is only for core or extensions too.

[MediaWiki-CodeReview] [MediaWiki r96602]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r96602. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96602 Commit summary: Deleting SearchLog per concerns on r82829 that neither the author or committer show any interest in fixing.

[MediaWiki-CodeReview] [MediaWiki r84395]: New comment added

2011-09-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r84395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84395#c22191 Commit summary: (bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is

[MediaWiki-CodeReview] [MediaWiki r94655]: New comment added

2011-09-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r94655. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94655#c22192 Commit summary: adding changes for Hooks related to PageSchema extension. Comment: That and about half a dozen other things. Hardcoded english, XSS...

[MediaWiki-CodeReview] [MediaWiki r86166]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86166. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86166 Commit summary: attachment process wasnt working if upload warning happened ___

[MediaWiki-CodeReview] [MediaWiki r86105]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86105. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86105 Commit summary: Useful extension by Milan allowing files to be attached to pages ___

[MediaWiki-CodeReview] [MediaWiki r96593]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r96593. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r96593. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96593#c22193 Commit summary: Remove mw- prefix from WikiHiero styles. A 7kb

[MediaWiki-CodeReview] [MediaWiki r91947]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r91947. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91947 Commit summary: escape brackets before using in regex for filtering matching records by field

[MediaWiki-CodeReview] [MediaWiki r96611]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Meno25 changed the status of MediaWiki.r96611. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96611 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r96610]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96610. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96610 Commit summary: f'up r96606: register new message key to maintenance script ___

[MediaWiki-CodeReview] [MediaWiki r96599]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96599. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96599 Commit summary: Fix for r96516: undefined variable $flags ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r96516]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r96516. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96516 Commit summary: split out the inside of File::transform() to avoid copying all of transform for SwiftMedia

[MediaWiki-CodeReview] [MediaWiki r96462]: New comment added

2011-09-08 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r96462. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96462#c22194 Commit summary: added cancel button to survey edit page and added default header and thanks messages Comment: [http://p.defau.lt/?ZptxI1GyAhszxPVU_KVS0w Wouldn't this

[MediaWiki-CodeReview] [MediaWiki r96561]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96561. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96561 Commit summary: Removing unused i18n messages ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96397]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96397. Old Status: fixme New Status: resolved User ^demon also posted a comment on MediaWiki.r96397. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96397#c22195 Commit summary: Removing files and globals that will not be needed in

[MediaWiki-CodeReview] [MediaWiki r93271]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r93271. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93271 Commit summary: merge r93269 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r96614]: New comment added, and revision status changed

2011-09-08 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r96614. Old Status: new New Status: ok User Siebrand also posted a comment on MediaWiki.r96614. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96614#c22196 Commit summary: Revert r93271 (merging r93269 from trunk). Trunk rev is

[MediaWiki-CodeReview] [MediaWiki r96615]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r96615. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96615 Commit summary: Removed duplicate extension ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r81473]: New comment added

2011-09-08 Thread MediaWiki Mail
User Siebrand posted a comment on MediaWiki.r81473. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81473#c22197 Commit summary: Merge REL1_17 r81465, r81471 in 1.17wmf1: * MFT r81455, r81461, r81463: updates for core special pages aliases, magic words and namespace names. *

[MediaWiki-CodeReview] [MediaWiki r92279]: New comment added

2011-09-08 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r92279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279#c22198 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normaliseParams().

[MediaWiki-CodeReview] [MediaWiki r84395]: New comment added

2011-09-08 Thread MediaWiki Mail
User Mdale posted a comment on MediaWiki.r84395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84395#c22199 Commit summary: (bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in

[MediaWiki-CodeReview] [MediaWiki r96617]: Revision status changed

2011-09-08 Thread MediaWiki Mail
User Catrope changed the status of MediaWiki.r96617. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96617 Commit summary: Follow-up r81473: Remove special page aliases for non-existing PermanentLink. Apparently API exposes this, and adding it in

Re: [Wikitech-l] Ramping up to MobileFrontend production switch over

2011-09-08 Thread Tomasz Finc
Thanks to Patrick and various community members we've been able to take care off all of our major blockers. Baring any large issues were still on track to finalize the deployment this week. Come join us on irc (#wikimedia-mobile) in case you have any questions. --tomasz On Thu, Aug 25, 2011 at

  1   2   >