[Wikitech-l] Thank you Tuesday

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's still Tuesday in my timezone, so here's this week's thread. Noticed something neat or cool that someone did? Or is someone just being awesome in general? Say thanks! * Thanks to Krinkle and Krenair for cleaning up user JavaScript across Wi

[Wikitech-l] Discovery Weekly Update for the week starting 2019-01-14

2019-01-22 Thread Chris Koerner
Hello, This is the weekly update from the Search Platform team for the week starting 2019-01-14. As always, feedback and questions welcome. == Discussions == === Search === * Trey updated TextCat with models for detecting Russian typed on an English keyboard and vice-versa, and UTF-8 Russian tex

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Tyler Cipriani
Hi all! This plugin has been removed entirely from Wikimedia Gerrit[0]. I know of no one who intended to experiment with the plugin in its current form so it is now removed. I have created a task to track suggestions for this plugin's improvement[1]. This task's scope is to track suggestions

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Antoine Musso
On 18/01/2019 23:12, Pine W wrote: I'm glad that this problematic change to communications was reverted. I would like to suggest that this is the type of change that, when being planned, should get a design review from a third party before coding starts, should go through at least one RFC before

Re: [Wikitech-l] Unsubscription Request

2019-01-22 Thread Lucas Werkmeister
There’s an “unsubscribe” section on this link (which should be in the footer of each email, though your client may hide it or make it less prominent, not sure): https://lists.wikimedia.org/mailman/listinfo/wikitech-l Cheers, Lucas Am Di., 22. Jan. 2019 um 14:18 Uhr schrieb Ayushi Jain via Wikitec

[Wikitech-l] Unsubscription Request

2019-01-22 Thread Ayushi Jain via Wikitech-l
I want to unsubscribe. Can't find any link on the emails sent by you. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Cormac Parle
+1 to Niharika - the initial iteration caused some inconvenience, but I expect subsequent iterations to be useful. Thank you Paladox! > On 22 Jan 2019, at 13:09, Niharika Kohli wrote: > > On Tue, Jan 22, 2019 at 6:12 PM Paladox via Wikitech-l < > wikitech-l@lists.wikimedia.org> wrote: > >>

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Niharika Kohli
On Tue, Jan 22, 2019 at 6:12 PM Paladox via Wikitech-l < wikitech-l@lists.wikimedia.org> wrote: > What your saying is making me think I’m wasting my time on improving this > extension. > Also other users that have spoken to me have thought this extension is > great but could do with improvements

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Thiemo Kreuz
> […] "people who have worked on this code before" is an excellent metric by > which to find people to review your code. Sure. But this is neither what I wrote, nor what the plugin does, nor what can be done programmatically in the first place, as you conveniently pointed out yourself: > […] we

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Physikerwelt
I suggest discussing the implementation details on phabricator. Moreover, I second Lucas point on the tone. physikerwelt https://www.mediawiki.org/wiki/Code_of_Conduct physikerwelt https://www.mediawiki.org/wiki/Code_of_Conduct On Tue, Jan 22, 2019 at 1:43 PM Lucas Werkmeister wrote: > > Am Di.,

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Lucas Werkmeister
Am Di., 22. Jan. 2019 um 13:25 Uhr schrieb Chad : > Dumb straw man. > can we avoid this tone? thanks Who said these people have too much workload? Um, Thiemo himself has said this? Are you going to tell him that he’s wrong about his own workload? The blame attribution has zero insight into ho

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Paladox via Wikitech-l
What your saying is making me think I’m wasting my time on improving this extension. Also other users that have spoken to me have thought this extension is great but could do with improvements which I am doing. We need to think of new users and how to improve there experence. The task was opene

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Chad
On Tue, Jan 22, 2019 at 4:05 AM Thiemo Kreuz wrote: > > Fundamentally broken sounds like a bit of a stretch. > > A process that annoys people based on nothing but the fact that they > happened to be the last one touching a file *is* fundamentally broken. > This is not how anyone should look for r

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Thiemo Kreuz
> Fundamentally broken sounds like a bit of a stretch. A process that annoys people based on nothing but the fact that they happened to be the last one touching a file *is* fundamentally broken. This is not how anyone should look for reviewers, neither manually nor automatically. Here is a though

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/22/19 12:24 AM, Amir E. Aharoni wrote: > Yes, it's installed, but it doesn't seem to be actually used. The > English Wikivoyage has a bunch of log entries of its usage, the > last in 2015. Other Wikimedia sites have very few entries, or non

Re: [Wikitech-l] Gerrit now automatically adds reviewers

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 1:11 AM, Jaime Crespo wrote: > One member of my team sadly left. Now he is pinged every time I > upload a change, passively aggressive reminding him he used to work > on this. > > Don't get me wrong, I think this is great to get atte

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Kunal Mehta
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 6:11 AM, Tyler Cipriani wrote: > In the interim, project-owners are able to opt-in to using the > reviewers-by-blame plugin on a per-project basis on their project > admin page in Gerrit. I'm happy to volunteer any of the projects I

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Gergo Tisza
This discussion could do with less theatrics IMO. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Paladox via Wikitech-l
No, I added in a config so that it would disable automatically adding reviewers instead relying on users to press “Suggest Reviewers” button. On Tuesday, 22 January 2019, 08:11:23 GMT, Thiemo Kreuz wrote: > […] im adding that functionality to reviewers-by-blame. I'm afraid I don't und

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread Amir E. Aharoni
Yes, it's installed, but it doesn't seem to be actually used. The English Wikivoyage has a bunch of log entries of its usage, the last in 2015. Other Wikimedia sites have very few entries, or none at all. My guess, and please do correct me if I'm wrong, is that it was used on Wikitravel or Wikivoy

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Chad
Fundamentally broken sounds like a bit of a stretch. In fact, it was probably working quite well for our less-trafficked repositories. But the issues identified must be fixed and decent file exclusion rules written before it goes back on for the active ones. -Chad On Jan 22, 2019 12:11 AM, "Thie

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread Vi to
AFAIR it was at very risk of breaking the Internet, so it went into a limbo of being installed but never used. Vito Il giorno mar 22 gen 2019 alle ore 08:46 Amir E. Aharoni < amir.ahar...@mail.huji.ac.il> ha scritto: > Hi, > > Is the UserMerge extension actually used on Wikimedia sites? > > As f

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread MA
Hello, UserMerge as it is right now is unusable for Wikimedia sites, and thus no user (bureaucrats, etc.) is allowed to use it. The extension is now up for a Code Stewarship Review to decide what to do with it < https://phabricator.wikimedia.org/T204747>, and I am proposing to undeploy the extensi

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

2019-01-22 Thread Thiemo Kreuz
> Is the UserMerge extension actually used on Wikimedia sites? I don't know if people *use* it, but according to https://wikiapiary.com/wiki/Extension:UserMerge it is installed on more than a thousand wikis, including all Wikimedia wikis. Best Thiemo _

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

2019-01-22 Thread Thiemo Kreuz
> […] im adding that functionality to reviewers-by-blame. I'm afraid I don't understand. Does this mean all the issues that make the plugin send passive-aggressive, misattributed spam will still be in place, possibly hitting peoples inboxes again any time somebody decides it would be a good idea t