Re: [Wikitech-l] Making code review happen in 1.18

2011-02-15 Thread Platonides
Roan Kattouw wrote: 2011/2/14 Mark A. Hershberger mhershber...@wikimedia.org: If we have a 1.18 branch that is, as Brion has noted (and supported), a day or two behind trunk at most, is there a reason that the we couldn't branch wmfN from the rolling 1.18 branch? Or even just tag it when we

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-14 Thread Roan Kattouw
2011/2/13 Bryan Tong Minh bryan.tongm...@gmail.com: I agree... a bit. We should branch 1.18wmf1 immediately from trunk once things have calmed down a bit. However, this 1.18wmf1 does not necessarily need to be the base for 1.18. We can branch 1.18wmf2 from trunk again and so on, until the time

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-14 Thread Jay Ashworth
- Original Message - From: Jeroen De Dauw jeroended...@gmail.com +1 to migrate to a DVCS Unless I'm mistaken no one has actually suggested doing that. 0 + 1 = 1, right? :-) Cheers, -- jra ___ Wikitech-l mailing list

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-14 Thread Roan Kattouw
2011/2/14 Mark A. Hershberger mhershber...@wikimedia.org: If we have a 1.18 branch that is, as Brion has noted (and supported), a day or two behind trunk at most, is there a reason that the we couldn't branch wmfN from the rolling 1.18 branch?  Or even just tag it when we wanted to mark a WMF

[Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Mark A. Hershberger
The problem with our current VCS is the sort of work-flow that has developed around it. But we can solve the work-flow problem without introducing an entirely new VCS and disrupting everything for a month or so while people adjust to the new system. The solution I'm proposing is that we branch

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Brion Vibber
On Sun, Feb 13, 2011 at 2:29 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: The problem with our current VCS is the sort of work-flow that has developed around it. But we can solve the work-flow problem without introducing an entirely new VCS and disrupting everything for a

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Bryan Tong Minh
Hi Mark, It is good to see people thinking about 1.18 already! On Sun, Feb 13, 2011 at 11:29 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: The problem with our current VCS is the sort of work-flow that has developed around it. But we can solve the work-flow problem without

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread K. Peachey
Well, if you want 1.18 released before 2012... ;) Bryan Well of course, Where would we be if we let the world end without a new(ish) mediawiki release? -Peachey ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Mark A. Hershberger
Bryan Tong Minh bryan.tongm...@gmail.com writes: The problem with our current VCS is the sort of work-flow that has developed around it. Can you be a bit more specific? What problems are you implying? I think of some problems, but I don't know how they are consequences from our workflow and

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Mark A. Hershberger
mhershber...@wikimedia.org (Mark A. Hershberger) writes: The solution I'm proposing is that we branch 1.18 immediately after the release of the 1.17 tarball. I want to give credit where it is due. Although I haven't seen him propose it here, this is, in fact, Robla's idea. He and I were

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Diederik van Liere
+1 to migrate to a DVCS On Sun, Feb 13, 2011 at 8:38 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: mhershber...@wikimedia.org (Mark A. Hershberger) writes: The solution I'm proposing is that we branch 1.18 immediately after the release of the 1.17 tarball. I want to give

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Jeroen De Dauw
+1 to migrate to a DVCS Unless I'm mistaken no one has actually suggested doing that. -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Making code review happen in 1.18

2011-02-13 Thread Aryeh Gregor
On Sun, Feb 13, 2011 at 8:11 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: This workflow is different from a DVCS.  Take Linux, for example.  Linus pulls code from several lieutenants.  Anyone can set up a branch of the Linux source code and commit to it, but to get Linus to ship