Re: [Wikitech-l] OOUI v0.28.0 released
I grepped a bunch and at least the following projects still use the removed icons: mediawiki/extensions/BlueSpiceBlog Uses 'newspaper' icon in resources/ve/ve.ui.BlogInspectorTool.js. It needs a dependency on 'oojs-ui.styles.icons-editing-citation' to continue displaying the icon. (Filed T202336.) mediawiki/extensions/ProofreadPage Uses 'clip' icon in modules/ve/node/ve.ui.MWPagequalityInspectorTool.js. (Filed T202337.) mediawiki/extensions/VisualEditor Uses 'settings' icon in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js. (Apparently this has already been spotted by our excellent QA engineers and reported in T202101. Thank you!) oojs/ui Heh, we still use the 'settings' icon in demos and documentation. Oops… (Filed T202338.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OOUI v0.28.0 released
Thanks for that question, Thiemo. We've been aware of that naming weakness and we're already underway of resolving it.[0] In the mid-term 'advanced' will be turned into 'settings', but we had to deprecate and rename former 'settings' to 'pageSettings' before. [0] https://phabricator.wikimedia.org/T190581 Best, Volker On Thu, Aug 16, 2018 at 11:42 PM Thiemo Kreuz wrote: > > Final code cleanup step after major icon refinement […] > > Congratulations on that! I especially love how the identifiers for > many icons describe more how they look, and less what their intended > purpose is. E.g. "die" and "funnel" being called like this, and not > "random" and "filter". > > However, one pair of icons still leaves me puzzled: There are two > settings cogs, one in a dark rectangle called "pageSettings", and one > without called "advanced". I never got what "advancements" the later > refers to. How is it meant to be used? > > Best > Thiemo > > ___ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OOUI v0.28.0 released
> Final code cleanup step after major icon refinement […] Congratulations on that! I especially love how the identifiers for many icons describe more how they look, and less what their intended purpose is. E.g. "die" and "funnel" being called like this, and not "random" and "filter". However, one pair of icons still leaves me puzzled: There are two settings cogs, one in a dark rectangle called "pageSettings", and one without called "advanced". I never got what "advancements" the later refers to. How is it meant to be used? Best Thiemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OOUI v0.28.0 released
Here's the complete list of renamed, moved or removed icons in each icon pack. Your code will need updates if you're using any of them: (I generated this with `git diff v0.27.6 v0.28.0 -- src/themes/wikimediaui/*.json` and some manual editing.) icons-alerts: * 'comment' – Use 'speechBubble' instead. icons-content: * 'book' – Moved to the 'editing-citation' pack. * 'citeArticle' – Moved and renamed. Use 'reference' from 'editing-citation' pack. * 'journal' – Moved to the 'editing-citation' pack. * 'newspaper' – Moved to the 'editing-citation' pack. icons-editing-advanced: * 'find' – Use 'articleSearch' of 'content' pack instead. icons-interactions: * 'settings' – Use 'pageSettings' instead. icons-moderation: * 'clip' – Use 'bookmarkOutline' instead. * 'unClip' – Use 'bookmark' instead. icons-user: * 'userActive' – Use 'userAvatar' instead. * 'userInactive' – Use 'userAnonymous' instead. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] OOUI v0.28.0 released
Hello everyone, I'm pleased to announce that we've released OOUI v0.28.0 this Tuesday. Key highlights of this release: - New OOUI “Tutorials” section[0] Special thanks to GSOC student Hagar Shilo, who has provided us an excellent addition to our documentation. The tutorials simplify stepping into development with the library. - Final code cleanup step after major icon refinement[1], see below. Possible breaking changes: The following changes might cause breaking of your interface, please carefully consider if they affect your code. - Drop 'find' icon, deprecated in v0.26.2 - Drop 'settings' icon, deprecated in v0.27.0 - Drop cite icons, renamed and deprecated in v0.27.0 - Remove 'clip' & 'unClip', deprecated in v0.26.1 - Remove 'comment', deprecated in v0.26.1 - Remove deprecated 'userActive'/'userInactive', deprecated in v0.26.2 All six icon changes above have been deprecated and announced in former versions. With this release we've removed them completely. You can find details on additional new features, code-level and accessibility changes, styling and interaction design amendments, and all improvements since v0.27.0 in the full changelog[2]. I'd also like to give a shoutout to Alangi Derick and Tim Eulitz for their contributions. If you have any further queries or need help dealing with breaking changes, please let me know. As always, library documentation is available on mediawiki.org[3], there is comprehensive generated code-level documentation and interactive demos and tutorials hosted on doc.wikimedia.org[4]. OOUI version: 0.28.0 MediaWiki version: 1.32.0-wmf.18 Date of deployment to production: Regular train, starting Thursday 16 August [0] - https://doc.wikimedia.org/oojs-ui/master/demos/tutorials/index.html [1] - https://phabricator.wikimedia.org/T177432 [2] - https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md [3] - https://www.mediawiki.org/wiki/OOUI [4] - https://doc.wikimedia.org/oojs-ui/master/ Best, Volker -- Senior UX Engineer Wikimedia Foundation volke...@wikimedia.org | @Volker_E ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
