Re: [Wikitech-l] Re quests about log system

2011-09-11 Thread Roan Kattouw
On Sat, Sep 10, 2011 at 8:28 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: Another point came up in IRC discussions: JSON converts UTF-8 characters to unicode escape sequences. serialize() does not. This effectively negates any size advantages JSON might have. I noticed JSON is used

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Thomas Gries
Am 10.09.2011 07:20, schrieb Chad: - json in php requires a mess of code and potentially a 3rd party libraries because: -- the bulit-in json json_{en,de}code library functions may not be installed -- the bulit-in json library in some cases actually has a bug that makes it encode/decode json

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Chad
On Sat, Sep 10, 2011 at 2:30 AM, Thomas Gries m...@tgries.de wrote: Am 10.09.2011 07:20, schrieb Chad: - json in php requires a mess of code and potentially a 3rd party libraries because: -- the bulit-in json json_{en,de}code library functions may not be installed -- the bulit-in json

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Daniel Friesen
On 11-09-09 10:00 PM, Daniel Friesen wrote: On 11-09-09 06:22 PM, Andrew Garrett wrote: On Thu, Sep 8, 2011 at 8:36 PM, Max Semenik maxsem.w...@gmail.com wrote: Even though data in those fields is small enough, can serialize()/unserialize() be used instead? It's faster and doesn't require the

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Chad
On Sat, Sep 10, 2011 at 3:13 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: On 11-09-09 10:00 PM, Daniel Friesen wrote: On 11-09-09 06:22 PM, Andrew Garrett wrote: On Thu, Sep 8, 2011 at 8:36 PM, Max Semenik maxsem.w...@gmail.com wrote: Even though data in those fields is small enough,

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Roan Kattouw
On Sat, Sep 10, 2011 at 9:13 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Here's another kick: - Using JSON in php, when you decode what you encoded you don't always get the same thing back (serialize you of course do) Even serialize() doesn't round-trip cleanly in certain cases:

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Greg Sabino Mullane
- Using JSON in php, when you decode what you encoded you don't always get the same thing back (serialize you of course do) How is PHP's YAML support? I prefer YAML to JSON, as it's even easier to read and parse. May not be best here, but could be an option if the interface is less broken

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Niklas Laxström
On 10 September 2011 18:00, Greg Sabino Mullane g...@endpoint.com wrote: - Using JSON in php, when you decode what you encoded you don't always get the same thing back (serialize you of course do) How is PHP's YAML support? I prefer YAML to JSON, as it's even easier to read and parse. May not

Re: [Wikitech-l] Re quests about log system

2011-09-10 Thread Niklas Laxström
On 10 September 2011 12:23, Roan Kattouw roan.katt...@gmail.com wrote: On Sat, Sep 10, 2011 at 9:13 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Here's another kick: - Using JSON in php, when you decode what you encoded you don't always get the same thing back (serialize you of course

Re: [Wikitech-l] Re quests about log system

2011-09-09 Thread Niklas Laxström
Big thank you for everyone who already looked and tested the code, especially to Aaron. I have fixed the few issues that have come up. Have we reached to an agreement to serialize the parameters instead of formatting them with JSON? I am going commit code that actually creates log entries using

Re: [Wikitech-l] Re quests about log system

2011-09-09 Thread Aaron Schulz
I'd still prefer JSON for offline/non-PHP use. I'm not sure it's a huge deal though. Bugzilla from niklas.laxst...@gmail.com wrote: Big thank you for everyone who already looked and tested the code, especially to Aaron. I have fixed the few issues that have come up. Have we reached to an

Re: [Wikitech-l] Re quests about log system

2011-09-09 Thread Andrew Garrett
On Thu, Sep 8, 2011 at 8:36 PM, Max Semenik maxsem.w...@gmail.com wrote: Even though data in those fields is small enough, can serialize()/unserialize() be used instead? It's faster and doesn't require the mess of ServicesJSON to work correctly. I'd prefer JSON. I don't care about the speed,

Re: [Wikitech-l] Re quests about log system

2011-09-09 Thread Daniel Friesen
On 11-09-09 06:22 PM, Andrew Garrett wrote: On Thu, Sep 8, 2011 at 8:36 PM, Max Semenik maxsem.w...@gmail.com wrote: Even though data in those fields is small enough, can serialize()/unserialize() be used instead? It's faster and doesn't require the mess of ServicesJSON to work correctly. I'd

Re: [Wikitech-l] Re quests about log system

2011-09-09 Thread Chad
On Sat, Sep 10, 2011 at 1:00 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: - json in php requires a mess of code and potentially a 3rd party libraries because: -- the bulit-in json json_{en,de}code library functions may not be installed -- the bulit-in json library in some cases actually

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
I just commited many changes to logging code. There is more to come, but I think this is suitable place to write in more detail what is going on. I'd also like to request code review and testing :) Thus far I have committed new formatting code and small cleanups. Both LogEventsList and

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Aaron Schulz
Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. I'll toss these revs onto my review queue. Bugzilla from niklas.laxst...@gmail.com wrote: I just commited many changes to logging code. There is more to come, but I think this is suitable place to

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Max Semenik
On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though data in those fields is small enough, can serialize()/unserialize() be used instead? It's faster and doesn't

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though data in those fields is small enough, can

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Daniel Friesen
On 11-09-08 04:25 AM, Niklas Laxström wrote: On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was thinking JSON would be appropriate here, so I'm glat to see that. Even though

Re: [Wikitech-l] Re quests about log system

2011-09-08 Thread Niklas Laxström
On 8 September 2011 17:57, Daniel Friesen li...@nadir-seen-fire.com wrote: On 11-09-08 04:25 AM, Niklas Laxström wrote: On 8 September 2011 13:36, Max Semenik maxsem.w...@gmail.com wrote: On Thu, Sep 8, 2011 at 2:18 PM, Aaron Schulz aschulz4...@gmail.com wrote: Yay for log_params. I was

Re: [Wikitech-l] Re quests about log system

2011-09-04 Thread Aaron Schulz
It would be nice to have standard functions that supports storing associative arrays in log_params rather than fragile ordered lists. I ended up hacking up a quick function in FlaggedRevs for this. Newer log types could make use of this and existing ones could if they had some b/c code.