Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-06 Thread Jeroen De Dauw
Hey, Sounds reasonable to me -- https://gerrit.wikimedia.org/r/124130 \o/ Thanks. This will save extension maintainers quite some hassle. Couldn't you just create a MyExtensionNameSpecialPage class like below and extend that for your special pages instead of regular SpecialPage You sure can,

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread Jeroen De Dauw
Hey, Is anyone working on resolving this issue? The current state means that extension authors need to either * use if-else checks based on MediaWiki versions * live with having deprecation notices on 1.23 * break compatibility with 1.22 and earlier Or am I missing something? Cheers -- Jeroen

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread James Forrester
On 5 April 2014 08:17, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, Is anyone working on resolving this issue? ​What issue?​ The current state means that ​ ​ extension authors need to either * use if-else checks based on MediaWiki versions * live with having deprecation notices

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread Jeroen De Dauw
Hey, Yes. You're meant to: - write your extension for $CURRENTVERSION; So does this mean extension authors are not supposed to write extensions compatible with multiple MediaWiki versions? If you *also* want to backport bug fixes and new functionality to older branched versions, that's

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread Brian Wolff
On Apr 5, 2014 1:09 PM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, Yes. You're meant to: - write your extension for $CURRENTVERSION; So does this mean extension authors are not supposed to write extensions compatible with multiple MediaWiki versions? Well lots of people

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread Max Semenik
On 05.04.2014, 21:27 Jeroen wrote: Hey, Are you simply looking for a revert Not of the whole commit. Just the wfDeprecated call. I seem to remember that at one point the policy was to add a @deprecated tag, and then two releases later or so add the wfDeprecated call. Actually I made some

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-04-05 Thread Bartosz Dziewoński
I know the wfDeprecated() has already been removed, but anyway… Couldn't you just create a MyExtensionNameSpecialPage class like below and extend that for your special pages instead of regular SpecialPage, which would let you always call the non-deprecated getPageTitle() instead of getTitle()

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-03-03 Thread Krinkle
On 1 Mar 2014, at 22:35, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, Regarding https://github.com/wikimedia/mediawiki-core/blob/793f17481ea937275898c91b9ba3c92c5a3e908b/includes/specialpage/SpecialPage.php#L467-488 So now all extensions that want to retain compatibility with

[Wikitech-l] SpecialPage::getTitle deprecated?!

2014-03-01 Thread Jeroen De Dauw
Hey, Regarding https://github.com/wikimedia/mediawiki-core/blob/793f17481ea937275898c91b9ba3c92c5a3e908b/includes/specialpage/SpecialPage.php#L467-488 So now all extensions that want to retain compatibility with MediaWiki 1.22 and at the same time not have deprecation notices on 1.23 need to do

Re: [Wikitech-l] SpecialPage::getTitle deprecated?!

2014-03-01 Thread Tyler Romeo
On Sat, Mar 1, 2014 at 4:35 PM, Jeroen De Dauw jeroended...@gmail.com wrote: And for what? The old method is just forwarding to the new one. All this hassle for a rename? If you read the commit, the purpose is that this function is planned to be removed entirely. The end goal is to get