Re: [Wikitech-l] Unit tests scream for attention

2013-01-02 Thread Chris McMahon
On Sat, Dec 29, 2012 at 1:47 PM, Bryan Tong Minh bryan.tongm...@gmail.comwrote: This is an annoyance to me as well. So, I went triaging, and finally found the issues that failed the unit tests for me. I have committed fixes for them to gerrit: https://gerrit.wikimedia.org/r/#/c/41362/

Re: [Wikitech-l] Unit tests scream for attention

2012-12-29 Thread Bryan Tong Minh
On Sat, Dec 29, 2012 at 8:57 AM, bawolff bawolff...@gmail.com wrote: When I used to run unit tests, there were quite regularly issues where the unit tests assumed you had the default configuration, where they really should not assume such a thing. (That was of course a while ago, so things

Re: [Wikitech-l] Unit tests scream for attention

2012-12-28 Thread bawolff
On Thu, Dec 27, 2012 at 11:48 PM, Sumana Harihareswara suma...@wikimedia.org wrote: On 12/07/2012 01:13 PM, Niklas Laxström wrote: Now that tests need +2 to be run, at least temporarily, I'm going to point out that I've not been able to run tests on my development environment in ages. I

Re: [Wikitech-l] Unit tests scream for attention

2012-12-27 Thread Sumana Harihareswara
On 12/07/2012 01:13 PM, Niklas Laxström wrote: Now that tests need +2 to be run, at least temporarily, I'm going to point out that I've not been able to run tests on my development environment in ages. I mentioned broken unit tests in Oct 4 on this list.

Re: [Wikitech-l] Unit tests scream for attention

2012-12-08 Thread Platonides
They mostly run for me. Those failing are: - PreferencesTest and TitleMethodsTest requiring a DB but not in Database group. - SanitizerTest::testRemovehtmltagsOnHtml5Tags skipping the closing tag an data, mark and time (???) - IPTCTest::testIPTCParseForcedUTFButInvalid with php 5.4. Reported in

Re: [Wikitech-l] Unit tests scream for attention

2012-12-08 Thread Niklas Laxström
On 8 December 2012 21:22, Platonides platoni...@gmail.com wrote: They mostly run for me. Yep, mostly: Tests: 4653, Assertions: 556494, Failures: 119, Errors: 17, Incomplete: 3, Skipped: 15. I've not even looked at most of these failures because of the fatal errors. Thanks to Jeroen and Brad

[Wikitech-l] Unit tests scream for attention

2012-12-07 Thread Niklas Laxström
Now that tests need +2 to be run, at least temporarily, I'm going to point out that I've not been able to run tests on my development environment in ages. I mentioned broken unit tests in Oct 4 on this list. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/64390 There are

Re: [Wikitech-l] Unit tests scream for attention

2012-12-07 Thread Antoine Musso
Le 07/12/12 19:13, Niklas Laxström a écrit : Now that tests need +2 to be run, at least temporarily, I'm going to point out that I've not been able to run tests on my development environment in ages. I mentioned broken unit tests in Oct 4 on this list.

Re: [Wikitech-l] Unit tests scream for attention

2012-12-07 Thread Brad Jorsch
On Fri, Dec 7, 2012 at 1:13 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: There are multiple fatal bugs (not to mention the numerous test failures), that halt test runs without any info expect the error. Some bugs I've reported: * https://bugzilla.wikimedia.org/41491 While that unit

Re: [Wikitech-l] Unit tests scream for attention

2012-12-07 Thread Niklas Laxström
On 7 December 2012 22:51, Brad Jorsch bjor...@wikimedia.org wrote: While that unit test mentioned there does seem screwed up, why is your PHPUnit installation not respecting convertErrorsToExceptions=true and related settings in MediaWiki's provided suite.xml? I honestly don't know. I barely