Re: [Wikitech-l] What would you like to see in gerrit?

2019-04-30 Thread Derick Alangi
Hi Lucas, Thanks a lot for the update. I just tried this on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Newsletter/+/501019 and I confirm that it's working. :) *--* *https://www.mediawiki.org/wiki/User:X-Savitar>>* On Tue, Apr 30, 2019 at 2:06 PM Lucas Werkmeister <

Re: [Wikitech-l] What would you like to see in gerrit?

2019-04-30 Thread Lucas Werkmeister
FYI, the improvement suggested in this thread back in January – I wonder if it would be possible to allow comments with “recheck” commands? > +1 to Lucas' proposal, it should be possible to blame Jenkins within recheck > comments. > – has now been implemented. You can add additional comments

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-27 Thread Kosta Harlan
It would be nice to be able to add screenshots / images in comments. As it is, I put a screenshot in phab and link to that from Gerrit, but it’s cumbersome. Kosta > On Feb 26, 2019, at 7:25 PM, Paladox via Wikitech-l > wrote: > > PolyGerrit now supports cherry picking changes onto of other

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-26 Thread Paladox via Wikitech-l
PolyGerrit now supports cherry picking changes onto of other changes (as of 2.16.6 (not released yet)) (i did that change!). PolyGerrit is also gaining support for cherry picking changes even with merge conflicts (also done by me)! Also we are making CI comments pretty in PolyGerrit, see 

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Gergo Tisza
Here's a quickie: Alt-Shift+F (or Alt-F or whatever your browser uses for accesskeys) works in MediaWiki and Phabricator but not in Gerrit. On Fri, Feb 8, 2019 at 11:35 AM Daniel Kinzler wrote: > * clicking on the name of a repo in a change should take me to a place > where i > can browse that

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Paladox via Wikitech-l
ci comments can be made pretty again with  https://phabricator.wikimedia.org/T215658#4940198 (ill be working on getting it added to gerrit.wikimedia.org) I just want to play to see if we can make it more prettier then through GWTUI. Looks like https://phabricator.wikimedia.org/F28163501 (from 

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Nick Wilson (Quiddity)
> Am 08.02.19 um 14:42 schrieb James Forrester: > > I gave up on gerrit's personal dashboard years ago, and instead have pinned > > browser tabs with specific gerrit searches, which are very powerful. > > > >

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Paladox via Wikitech-l
I've created https://phabricator.wikimedia.org/T215659 - support cherry picking commits even with merge conflicts in the ui (polygerrit). I've already created a commit for this support upstream but was stalled by the old polygerrit team. So im going to implement this in a plugin. On

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Stas Malyshev
Hi! One thing still missing for me is better ability to indicate which kind of attention the item needs from me. Right now, to improve it, I used custom scripts with this colorization scheme: - paint items with test failures and -1's red (these need work from me if they're outgoing, and probably

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Daniel Kinzler
Oh. Oooohhh. Thank you James, you just made my life so much easier! Am 08.02.19 um 14:42 schrieb James Forrester: > On Fri, 8 Feb 2019 at 11:35, Daniel Kinzler wrote: > >> Am 28.01.19 um 19:25 schrieb Paladox via Wikitech-l: >>> Hi, what would you like to see in gerrit or improved? >> >> * I

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Paladox via Wikitech-l
For James F: You could use the "menu" from /settings/ to add additional links which will be added under "your". Though project dashboards is supported in PolyGerrit from 2.16+ For danial k's points: point 1: you can use age:2week in the query. point 2: can be done wikibugs. (i did do that for

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread James Forrester
On Fri, 8 Feb 2019 at 11:35, Daniel Kinzler wrote: > Am 28.01.19 um 19:25 schrieb Paladox via Wikitech-l: > > Hi, what would you like to see in gerrit or improved? > > * I would like to be able to set a cut-off date for my dashboard. E.g. > "show > only things touched in the last 2 weeks".

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-08 Thread Daniel Kinzler
Am 28.01.19 um 19:25 schrieb Paladox via Wikitech-l: > Hi, what would you like to see in gerrit or improved? * I would like to be able to set a cut-off date for my dashboard. E.g. "show only things touched in the last 2 weeks". Ideally, I would be able to make things sticky by starring them, so

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-06 Thread Paladox via Wikitech-l
You should be able to do the same in PolyGerrit only that your looking for something more specific as polygerrit uses dom-modules. On Tuesday, 5 February 2019, 14:30:27 GMT, Stephen Niedzielski wrote: > filtering out CI messages from Gerrit comments. I use a hacky bookmarklet to hide

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-05 Thread Stephen Niedzielski
> filtering out CI messages from Gerrit comments. I use a hacky bookmarklet to hide jenkins-bot comments: javascript:Array.from(document.querySelectorAll('[class*=messageBox]')).filter(box => box.querySelector('[class*=name]').textContent === 'jenkins-bot').forEach(box => box.style.display =

Re: [Wikitech-l] What would you like to see in gerrit?

2019-02-04 Thread Gergo Tisza
On Mon, Jan 28, 2019 at 4:26 PM Paladox via Wikitech-l < wikitech-l@lists.wikimedia.org> wrote: > Hi, what would you like to see in gerrit or improved? Thanks for all your work on Gerrit! Some things that IMO would be useful: * filtering out CI messages from Gerrit comments. This is something

Re: [Wikitech-l] What would you like to see in gerrit?

2019-01-29 Thread Lucas Werkmeister
Thanks for the guidance! I’ve submitted a config change at https://gerrit.wikimedia.org/r/487037. (And also thanks for all your other Gerrit work of course!) Cheers, Lucas Am Di., 29. Jan. 2019 um 13:32 Uhr schrieb Paladox via Wikitech-l < wikitech-l@lists.wikimedia.org>: > I believe that

Re: [Wikitech-l] What would you like to see in gerrit?

2019-01-29 Thread Paladox via Wikitech-l
I believe that requires a regex  change in layout.yaml of integration/config. Also second thing that’s likely a bug in the zuul plugin. On Tuesday, 29 January 2019, 10:38:54 GMT, Daimona wrote: +1 to Lucas' proposal, it should be possible to blame Jenkins within recheck comments.

Re: [Wikitech-l] What would you like to see in gerrit?

2019-01-29 Thread Daimona
+1 to Lucas' proposal, it should be possible to blame Jenkins within recheck comments. There's also another minor bug I encountered several times, and I'm unsure if it's already been fixed in 2.16. Have 2 different changes, A and B. If I write A's change ID in the commit message of B, then the UI

Re: [Wikitech-l] What would you like to see in gerrit?

2019-01-29 Thread Lucas Werkmeister
I wonder if it would be possible to allow comments with “recheck” commands? Often I want to do something like “recheck because CI failed due to T”, but if I send it as one review then it will not be recognized as a recheck. Triggering a recheck any time the word “recheck” appears anywhere in a

[Wikitech-l] What would you like to see in gerrit?

2019-01-28 Thread Paladox via Wikitech-l
Hi, what would you like to see in gerrit or improved? I've been working been working on developing a plugin that pull's in zuul's status into PolyGerrit. See the running demo at https://imgur.com/a/uBk2oxQ . Im also planning on adding "recheck" and "check experimental" as buttons to