Re: [Wikitech-l] Declaring methods final in classes

2019-08-30 Thread Krinkle
On Thu, Aug 29, 2019 at 1:46 PM Aryeh Gregor wrote: > On Thu, Aug 29, 2019 at 1:02 AM Krinkle wrote: > > What did you want to assert in this test? > > In a proper unit test, I want to completely replace all non-value > classes with mocks, so that they don't call the actual class' code. > This

[Wikitech-l] Wikimedia production excellence (July 2019)

2019-08-30 Thread Krinkle
 Read on Phabricator at https://phabricator.wikimedia.org/phame/post/view/164 --- How’re we doing on that strive for operational excellence? Read this first anniversary edition to find out!  Month in numbers - 5 documented incidents. [1] - 53 new Wikimedia-prod-error reports. [2] -

Re: [Wikitech-l] m1 (etherpad, bacula, librenms, rt, racktables) db primary master switchover: 10th Sept 16:00 UTC

2019-08-30 Thread Pine W
Hi Manuel, I'm not familiar with User-Notice tags, but I'll trust your judgment. Perhaps you could also mention the planned outage of Etherpad in Tech News. It sounds like this will be a low impact outage, but there is a small chance that someone will be taking notes on Etherpad during a meeting

Re: [Wikitech-l] Code of Conduct committee meeting at Wikimania

2019-08-30 Thread Pine W
+1 on the thanks for the update. I have some ideas regarding modifications that I would like to propose to the CoC but I am already stretched among too many tasks, so I am holding these proposals. I do not want anarchy in technical spaces, and in general I think that having some version of a code