I was digging and I found that commit you sent - eefe1b13a but you can
see that this commit modified 2 functions: both open and closeElement,
however for some reason the code was removed from closeElement so now
calling openElement('html') would produce empty string, while
closeElement('html')
On Wed, Feb 18, 2015 at 1:23 PM, Petr Bena benap...@gmail.com wrote:
Can someone explain the point of these lines to me?
https://github.com/wikimedia/mediawiki/blob/master/includes/Html.php#L269
Someone thought it would be clever to reduce page size by a few bytes here
and there. :)
In
I think it's the other way, omiting the html tags is probably correct,
as long as both opening and ending tags are omitted :P so I think the
closeElement function needs a fix
On Wed, Feb 18, 2015 at 10:42 PM, Ricordisamoa
ricordisa...@openmailbox.org wrote:
Uploaded
That patch you made even breaks tests:
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-HEAD/13002/console
:)
so either remove a unit test for that feature, or just fix the
closeElement but I don't even know if it's really broken, maybe there
is some more magic on behing that would
Most of browsers would probably handle it OK, but validators not.
On Wed, Feb 18, 2015 at 10:45 PM, Petr Bena benap...@gmail.com wrote:
Yep
That makes me feel like this is bug which everyone overlooked because
it's true by default. If you set it to false mediawiki would likely
write out
Uploaded https://gerrit.wikimedia.org/r/191473/ for consistency with
closeElement.
Thanks for reporting.
Il 18/02/2015 22:38, Petr Bena ha scritto:
I was digging and I found that commit you sent - eefe1b13a but you can
see that this commit modified 2 functions: both open and closeElement,
On Wed, Feb 18, 2015 at 1:38 PM, Petr Bena benap...@gmail.com wrote:
(Perhaps wgWellFormedXml is true by default?)
It is: https://www.mediawiki.org/wiki/Manual:$wgWellFormedXml
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
Yep
That makes me feel like this is bug which everyone overlooked because
it's true by default. If you set it to false mediawiki would likely
write out syntactically wrong code.
On Wed, Feb 18, 2015 at 10:43 PM, Gergo Tisza gti...@wikimedia.org wrote:
On Wed, Feb 18, 2015 at 1:38 PM, Petr Bena
On 19/02/15 08:43, Gergo Tisza wrote:
On Wed, Feb 18, 2015 at 1:38 PM, Petr Bena benap...@gmail.com wrote:
(Perhaps wgWellFormedXml is true by default?)
It is: https://www.mediawiki.org/wiki/Manual:$wgWellFormedXml
There was a Bugzilla report and Gerrit change requesting that it be
set
I would also recommend against actively trying to emit barely parsing
output. Any savings after compression should be rather small, and if only
end tags are omitted the DOM will of course still be the same size after
parsing.
In Parsoid we went to some modest lengths
10 matches
Mail list logo
