Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Brad Jorsch (Anomie)
On Wed, Dec 11, 2013 at 2:54 PM, Matthew Walker mwal...@wikimedia.org wrote: I'm totally cool with the idea of code review for Gadgets so forth, just not using Gerrit. We considered it for Scribunto (and heck, I wrote half of a proof of concept) but shot it down because the idea totally

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Chad
On Wed, Dec 11, 2013 at 12:00 PM, Brad Jorsch (Anomie) bjor...@wikimedia.org wrote: On Wed, Dec 11, 2013 at 2:54 PM, Matthew Walker mwal...@wikimedia.org wrote: I'm totally cool with the idea of code review for Gadgets so forth, just not using Gerrit. We considered it for Scribunto (and

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Matthew Walker
Ah; so it's actually slightly different use cases then. My thought is that it's on the developers to merge changes that come from the wiki. I've thought of two ways this could work: * For every new merge touching a documentation file; we reject changes via a jenkins job when there are still

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Jeroen De Dauw
Hey, Has there been thought on how GitHub can potentially help here? I'm not sure it fits the workflow well, though can make the following observations: * People can click an edit button on GH to edit the code, much like on wiki. * If the GH web UI is used, people do not have to install git *

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Ryan Lane
On Wed, Dec 11, 2013 at 3:21 PM, Jeroen De Dauw jeroended...@gmail.comwrote: Hey, Has there been thought on how GitHub can potentially help here? I'm not sure it fits the workflow well, though can make the following observations: Unless you're implying that github writes some code for us,

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Matthew Walker
It's not a bad thought; but I don't think it'll work for a couple of reasons: * It causes people to leave the site * GItHub for various reasons requires an account (which most likely they wont have and it doesn't seem correct to require one given our editing philosophy) * The editing interface is

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Jon Robson
I'm not Chad, but one of the big issues is this: Consider the trouble that some of us as developers have using Git and Gerrit. Now think about trying to get non-developer JS and CSS coders to be able to use Git and Gerrit, much less to *want* to use Git and Gerrit rather than torches and

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Matthew Walker
Heh; wrong thread to discuss that in Jon -- this one is about non-developers helping out writing documentation for configuration variables and what not without having to modify the source file in gerrit. The OTHER thread, which I forked from, is the one about what we already allow (users to

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Bartosz Dziewoński
On Wed, 11 Dec 2013 23:35:43 +0100, Jon Robson jdlrob...@gmail.com wrote: I'm confused.. non-developers writing JS and CSS? This scares the bejesus outta me. There's so many movements urging people to learn to code right now, I don't see how this is surprising anymore. Yes, physicians and

Re: [Wikitech-l] Wiki - Gerrit was Re: FWD: [Bug 58236] New: No longer allow gadgets to be turned on by default for all users on Wikimedia sites

2013-12-11 Thread Daniel Friesen
On 2013-12-11 4:52 PM, Bartosz Dziewoński wrote: On Wed, 11 Dec 2013 23:35:43 +0100, Jon Robson jdlrob...@gmail.com wrote: And it's not very easy to cause a major security bug when writing code that runs client-side and usually only in response to user action. Most gadgets don't, say, parse