On 6/1/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
One thought that has recently crossed my mind: Building off his framework and
putting much of the code in the server may not have been a great idea, since
the only real need for the server is to get the unix pid of the thread.
Nah, I think
Jeremy White [EMAIL PROTECTED] writes:
My driving concern is that I think we need to welcome the Mac
community to the Wine Project and do all that we can to
enable the Mac developers and users to use mainstream Wine resources.
I don't think anyone wants www.winehq.org to be perceived as
a
I have started work on an openal driver for wine...
So far I have playback and recording working (with minor issues)
(for some reason the DSound HEL is unhappy with my driver)
OpenAL seems to have enough functionality to do the job.
Are there any problems with using OpenAL for such a purpose?
Detlef Riekenberg [EMAIL PROTECTED] writes:
+if (ret) {
+needed = WideCharToMultiByte( CP_ACP, 0, InfoW, -1, (LPSTR)Info,
cbBuf, NULL, NULL);
+if (pcbNeeded) *pcbNeeded = needed;
+ret = (needed cbBuf) ? FALSE : TRUE;
This check is wrong, WideCharToMultiByte
lack of comments in the code
+1, I think it's horrifying.
void the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
Horrifying, yes :)
Mike
Hi,
SUSE Linux 10.1 contains fontconfig 2.3.94, which
changed the FcPatternGetString() function from return
path names to return only the filenames.
We received this bugreport:
https://bugzilla.novell.com/show_bug.cgi?id=179457
However, Bernd Rosenkraenzer reported this problem already
and the
Huw Davies wrote:
There's a bug in this code, let's try this:
/* change by Huw Davies 02-Jun-2006, to fix the return type of the function */
int the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
On Friday, June 02, 2006 07:25, Mike McCormack wrote:
lack of comments in the code
+1, I think it's horrifying.
void the_function_that_adds_one_to_i(int i)
{
/* this adds one to i */
i = i + 1;
/* this returns i to the caller */
return i;
}
Horrifying, yes :)
There is precious little Why in the comments of a lot of projects - Why
does this function exist, why would I call it, why does it return what it
does, etc.
BS comments like those within the function don't help, obviously - but
sometimes a comment block describing WHY a given chunk of code
David D. Hagood wrote:
ARRRG! This whole thing is just a bullshit strawman.
Indeed.
However my strawman demonstrates that it's difficult to enforce code
commenting, as you'll just end up with a bunch of bs.
You also can't comment somebody else's code properly, obvious things
don't
Am Freitag, den 02.06.2006, 11:30 +0200 schrieb Alexandre Julliard:
Detlef Riekenberg [EMAIL PROTECTED] writes:
+if (ret) {
+needed = WideCharToMultiByte( CP_ACP, 0, InfoW, -1, (LPSTR)Info,
cbBuf, NULL, NULL);
+if (pcbNeeded) *pcbNeeded = needed;
+ret =
Joshua Root wrote:
C.W. Betts wrote:
If you could have it so that wine-macos is instantly sent to
darwine-devel, and vice-versa.
That seems rather redundant. Might as well just migrate all the
darwine-devel subscribers over to wine-macos and discontinue the former,
rather than have two
Mike McCormack wrote:
/* My tests reveal that it's done this way */
/* FIXME: this is broken */
/* go forward in the array */
Then you've got the whole issue of maintaining the
comments in synchronization with the code.
You've gravely misunderstood what good code commenting is?
Good
If what you really want is code that's easier to understand we're better
off scrapping all comments, then enforcing good coding style, so that
the code is readable without comments. If the functions are kept small,
things are well named, and the complexity confined (eg. no 7 level
indent),
If you could have it so that wine-macos is instantly sent to darwine-devel,
and vice-versa.
Hello,
I ran across the need to do memory allocations across processes and came upon
Alexander Yaworsky's patch at
http://www.winehq.org/pipermail/wine-devel/2004-September/029953.html and took
a different approach. Instead of waiting for the target process to check a fd,
I changed the
Mike McCormack wrote:
If what you really want is code that's easier to understand we're better
off scrapping all comments...
And we can encourage safe driving by removing airbags and seatbelts, and
installing big shiny sharp metal spikes on the steering wheel, and
executing anybody who
Mike M. wrote:
[America's Army install crashes, see
http://bugs.winehq.org/show_bug.cgi?id=5139 ]
This is as close as I will be able to come to including a test case, as
this is how I obtained my results.
If you want me to fix the problem, please submit a regression test to
wine-patches with
I was disappointed to see that dynamic drive
configuration
(http://www.winehq.org/?issue=313#Dynamic%20Drive%20Configuration)
amounts to a few HAL functions in wine's explorer.
Windows has been using device notifications for at
least 11 years now (since Windows 95), and neither
wine nor ReactOS
Damjan Jovanovic [EMAIL PROTECTED] writes:
I was disappointed to see that dynamic drive
configuration
(http://www.winehq.org/?issue=313#Dynamic%20Drive%20Configuration)
amounts to a few HAL functions in wine's explorer.
What's disappointing about that?
I would be interested in implementing
James Hawkins and I think we should come up with a list
of installers that need to run before we release Wine 1.0.
Looking at
http://www.winehq.org/pipermail/wine-devel/2006-March/045634.html
and
Andrey wrote:
My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86
would restore vm86 registers correctly. I think i know what is the
problem; however, I lack experience to fix it myself :)
I need help; any hints would be appreciated.
How about writing a conformance test that
On 6/2/06, Dan Kegel [EMAIL PROTECTED] wrote:
http://bugs.winehq.org/show_bug.cgi?id=3590 ActiveState python msi (see 5237?)
http://bugs.winehq.org/show_bug.cgi?id=3972 .NET framework 2.0
http://bugs.winehq.org/show_bug.cgi?id=4227 QuickTest Pro
http://bugs.winehq.org/show_bug.cgi?id=4280 J2SE
Dan Kegel wrote:
Andrey wrote:
My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86
would restore vm86 registers correctly. I think i know what is the
problem; however, I lack experience to fix it myself :)
I need help; any hints would be appreciated.
How about writing a
Damjan Jovanovic wrote:
I was disappointed to see that dynamic drive
configuration
(http://www.winehq.org/?issue=313#Dynamic%20Drive%20Configuration)
amounts to a few HAL functions in wine's explorer.
Windows has been using device notifications for at
least 11 years now (since Windows 95), and
Molle Bestefich [EMAIL PROTECTED] wrote:
Teaching people to write good comments is infinitely easier - it's a
simple case of banging 'em on the head and forcing them to write a
comment every time they've done a piece of code that they know
required cunning skill for whatever reason. You may
Thats a good one, since its on the Top 25 of the App DB, ranked #2 i
believe, and freely available. The sudden of influx of people testing
Americas Army in wine came from the America's Army community, after
America's Army announced they would no longer support a linux port for the
client,
On 6/2/06, Andrey Turkin [EMAIL PROTECTED] wrote:
How about writing a conformance test that demonstrates
the problem?
I would be happy to do it. Unfortunely, I cannot imagine how to
implement such test:
1) DOS code needed - it would need binary or some sort of source to be
compiled prior to
Mike McCormack wrote:
Add all the great comments you like, but you still actually have to read
the code and understand it to figure out how to fix it.
Often the goal is not to fix it, the goal is to understand it in order
to fix something else.
So, IMO, you're better off striving for the
Thomas Weidenmueller [EMAIL PROTECTED] wrote:
LoadString() cannot be used to measure the length of a string resource.
It will not return the length of the string if no buffer is provided,
instead it will return 0! This patch fixes the broken property sheet code.
It would be appropriate to
I think the general approach is good.
The way you handle the built in implementation seems odd to me. I think
setting the registry key to make the freedesktop.org version as the default
would be good enough.
I'm not convinced we need IWineShellIntegration. I think it would be
cleaner to directly
grep Bestefich documentation/ChangeLog.ALPHA | wc -l
0
grep Bestefich ChangeLog | wc -l
0
And this is exactly the kind of comment and attitude
that pushes people away from being Wine developers.
This was a thread that asked the question:
What would get more developers
KR style brack placements
was what i was referring to when I commented about coding style. They are an
eyesore and make things difficult to read.
A number of people said:
The code is too hard to read because it's
completely unmovitated and uncommented.
Especially the code that is
That being the case, why not clear up the name? Call
the list [EMAIL PROTECTED] This makes clear it is for
the ppc version, not the Intel version. The currently
proposed name makes me think that the project refers
to both Intel and PPC.
Dave
--- Jim White [EMAIL PROTECTED] wrote:
Joshua
I'm a heavy user of Ecco Pro on Windows, and am trying to port myself as
completely as possible to Linux (Ubuntu currently). Wine does a good
job of supporting most of Ecco's features, but there are a couple of
places (unfortunately important ones) where it hangs up tight. I've
just
EA Durbin wrote:
KR style brack placements
They are an eyesore and make things difficult to read.
Highly subjective.
I think KR has distinct advantages, namely it unites the scope begin
token with the relevant control statement. For me, this makes code
easier and faster to read, since I can
Especially the code that is responded to as , I know it's a mess to
look at, but I didn't write it.
Can you give us examples?
Mostly Wine attempts to follow how Windows works, so MSDN provides a lot
of the documentation. This is becoming increasingly true, with kernel32
being implemented on
Hello
Carsten Niehaus ([EMAIL PROTECTED]) over on wine-users gets a page fault
when he tries to print with this app:
http://www.learn-line.nrw.de/angebote/gefahrstoffdb/Gefahrstoffe.zip
He's posted a backtrace:
fixme:commdlg:PRINTDLG_SetUpPrinterListComboA Can't find '(null)' in printer
list
I think the general approach is good.
The way you handle the built in implementation seems odd to me. I think
setting the registry key to make the freedesktop.org version as the default
would be good enough.
If we don't have built-in trash etc. objects then when we add a new
object we will
I'm just nitpicky I guess. If I use K R style, or not enough white space,
or don't align things perfectly at work my boss will kindly print off a copy
of the companies acceptable coding standards policy and bring it over. I
guess I'm just used to having things that way, and the shifting coding
Molle Bestefich wrote:
Hello
Carsten Niehaus ([EMAIL PROTECTED]) over on wine-users gets a page fault
when he tries to print with this app:
http://www.learn-line.nrw.de/angebote/gefahrstoffdb/Gefahrstoffe.zip
He's posted a backtrace:
fixme:commdlg:PRINTDLG_SetUpPrinterListComboA Can't find
Mikołaj Zalewski [EMAIL PROTECTED] writes:
The main idea is not to hard-code one implementation of things like
the Trash into shell32 - not everything is standardized by the
freedesktop and even if it would this might not work on other systems
like MacOS X. We should allow for many
I think you can just compile and run it with visual C++ as a standalone app,
with the right commandline options to the compiler. Let's see: try
the instructions here:
http://www.winehq.com/hypermail/wine-devel/2005/05/0865.html
You can also build with the wine build system and then
run the
--- EA Durbin [EMAIL PROTECTED] wrote:
If I use K R style, or not enough white space,
or don't align things perfectly at work my boss will kindly print off a
copy of the companies acceptable coding standards policy and bring it
over.
Ah, so it's the lack of a defined style guideline that's
On 6/2/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
The problem here is that you don't control at what point you interrupt
the process, so you can't do anything in it except system calls, and
that won't be enough.
Why isn't a call to mmap enough?
(We're trying to support techniques like the
Dan Kegel [EMAIL PROTECTED] writes:
On 6/2/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
The problem here is that you don't control at what point you interrupt
the process, so you can't do anything in it except system calls, and
that won't be enough.
Why isn't a call to mmap enough?
You
On 6/2/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
Why isn't a call to mmap enough?
You need to build the proper structures on the client side, just like
a normal VirtualAlloc would, otherwise the process won't know about
that memory area.
OK, new plan: how about we preallocate a memory
Dan Kegel [EMAIL PROTECTED] writes:
OK, new plan: how about we preallocate a memory
area just big enough for the common case, with the
structures all set up, and let the server hand it
out to the first process to ask for it? I don't think
it needs to be very big.
Well, that may work for
Am Freitag, den 02.06.2006, 08:03 -0500 schrieb Jeremy White:
But there are plenty of places in Wine where the code does
something screwball or out of the ordinary (hell, the API
itself is screwball), and those places deserve more comments.
IMHO, more comment's help to teach someone, who read
EA Durbin wrote:
KR style brack placements
was what i was referring to when I commented about coding style. They
are an eyesore and make things difficult to read.
Oh, NO NO NO. KR style IS the one and only true pure C style. As mutch
as GNU did good work for OSS they did very wrong with the
On Tue, May 30, 2006 at 05:32:26PM -0700, Dan Kegel wrote:
On 5/30/06, Scott Ritchie [EMAIL PROTECTED] wrote:
It might be, but the heavy hitters I know of who have taken a look at
it in detail have concluded that an X change really is needed.]
Is this really a problem? Another version
On 6/2/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
OK, new plan: how about we preallocate a memory
area just big enough for the common case, with the
structures all set up, and let the server hand it
out to the first process to ask for it? I don't think
it needs to be very big.
Well,
Lionel,
Where can I learn more about ohsix's idea (i.e. thread in which mail list)?
Thanks,
W.
From: Lionel Ulmer [EMAIL PROTECTED]
To: Dan Kegel [EMAIL PROTECTED]
CC: wine-devel@winehq.org, [EMAIL PROTECTED]
[EMAIL PROTECTED],[EMAIL PROTECTED]
Subject: Re: Re: Wine 1.0 Tasks
Date: Fri, 2
Michael Stefaniuc wrote:
can somebody more familiar with this code confirm that on the error
paths the CriticalSection should be released? I'm not sure about it as
the function is supposed to keep the lock held when exiting without
error; there is a d3ddevice_unlock_update() function that
Alexandre Julliard wrote:
I think using COM for that sort of thing is overkill.
If we want to allow multiple implementations then using a structure with
callback functions is probably the easiest way. If we are using
structures with callback functions then why not to make it COM
interfaces
Lionel Ulmer [EMAIL PROTECTED] writes:
But ohsix's idea to use 'real' X windows 'overlaid' over the single Wine X
window would be the easiest idea to investigate (because it would not only
fixes this issue but also the mutiple windows with multiple pixel formats
problem that the former
Dan Kegel [EMAIL PROTECTED] writes:
How about this: we combine the original sychronous approach
with the small preallocated cache as a fallback for when
no threads are waiting?
You need to have a thread waiting one way or another, since you need
to perform operations on the client side that
Michael == Michael Stefaniuc [EMAIL PROTECTED] writes:
Michael P.S.: Let the flame war begin. ;)
Isn't it already raginh ;-)
--
Uwe Bonnes[EMAIL PROTECTED]
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
- Tel. 06151 162516 Fax. 06151
On 6/2/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
How about this: we combine the original sychronous approach
with the small preallocated cache as a fallback for when
no threads are waiting?
You need to have a thread waiting one way or another, since you need
to perform operations on
I believe the Freetype configure checks are backward.
First we check for the library being present, and only then do we
check for the freetype-config problem:
AC_SUBST(FREETYPELIBS,)
AC_SUBST(FREETYPEINCL,)
AC_CHECK_LIB(freetype,FT_Init_FreeType,ft_lib=yes,ft_lib=no,$X_LIBS)
if test
That said, I don't care what people do, I can read both...
In my perfect world though, my SCM client would convert source code to
my preferred format on checkout, and to whatever universal format the
repository uses on checkin. Ho hum...
(Personally I hate KR because I want to be able to
On 6/2/06, Aneurin Price [EMAIL PROTECTED] wrote:
How about setting a standard that will be used in the repository, and
providing the indent commands to set it that way, then indenting *every
file* in the repository to that standard. Then every developer can use
indent or whatever equivalent
From the viewpoint of a new developer (Summer of Code), having a few
The purpose of this function comments would have been / still would
be very useful!
It's painfully having to figure out what exactly a function does, that
calls five other functions that you have to look into, which each call
On 6/2/06, Dan Kegel [EMAIL PROTECTED] wrote:
You need to have a thread waiting one way or another, since you need
to perform operations on the client side that require a thread
context. No, it's not an easy problem to solve, that's why it has not
been done yet...
Are you willing to accept
... is now at http://wiki.winehq.org/DanKegel
I'm willing to focus some effort on these tasks, too,
so it's not just pie-in-the-sky wishing.
I can help debug some of these, and maybe contribute to the code/test cases.
I haven't coded much in C in the last few years, I took some in college, but
I've never used it yet in my career path, but I'm working on refreshing my
memory, and working on trying to understand the most commonly used
What is broken in MingW installer?, Upon testing I was able to install 5.0.2
Mingw just fine, and selected all of the components and it installed fine. I
also was able to install gdb, as the bug suggests you're not able.
From: Dan Kegel [EMAIL PROTECTED]
To: wine-devel wine-devel@winehq.org
Jeremy White [EMAIL PROTECTED] wrote:
grep Bestefich documentation/ChangeLog.ALPHA | wc -l
0
grep Bestefich ChangeLog | wc -l
0
And this is exactly the kind of comment and attitude
that pushes people away from being Wine developers.
This was a thread that asked the question:
68 matches
Mail list logo
