Re: Deadlock under Supreme Commander in d3d9 main.c

2009-06-06 Thread Henri Verbeet
2009/6/6 James McKenzie jjmckenzi...@earthlink.net: This appears to be a revisit of the deadlocking issue as reported in bug 14746, but according to another triage person, this is not so.  I would like to know if code has been moved from x11drv.c to d3d9_main.c that would cause this error

Re: website: mention bugzilla registration on sending_patches

2009-06-06 Thread Henri Verbeet
2009/6/6 Jeff Zaroyko jeffzaro...@gmail.com: + liRegister an account on the Wine bugzilla with the email address you use to send patches. Why would I do that?

Re: website: mention bugzilla registration on sending_patches

2009-06-06 Thread Jeff Zaroyko
On Sat, Jun 6, 2009 at 7:00 PM, Henri Verbeethverb...@gmail.com wrote: 2009/6/6 Jeff Zaroyko jeffzaro...@gmail.com: + liRegister an account on the Wine bugzilla with the email address you use to send patches. Why would I do that? Just so that persons who follow the regression testing

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Paul Vriens
Joel Holdsworth wrote: I've run your new tests on Win95, Win98 and NT4 (all VMware): Is there another way you can detect whether some XP (and up) tests can be run? We generally try not to use GetVersion() in our tests. It turns out that the reason for the Win95 errors is that it calculates

RE: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Rolf Kalbermatter
Joel Holdsworth [mailto:j...@airwebreathe.org.uk] However, you're saying GetVersion is a problem. Why is that? And how else is one supposed to cope with GdiAlphaBlend not being present in pre-XP systems, as well as old-style dithering differences? Wine tests try to not depend on a

Re: website: mention bugzilla registration on sending_patches

2009-06-06 Thread Henri Verbeet
2009/6/6 Jeff Zaroyko jeffzaro...@gmail.com: On Sat, Jun 6, 2009 at 7:00 PM, Henri Verbeethverb...@gmail.com wrote: 2009/6/6 Jeff Zaroyko jeffzaro...@gmail.com: + liRegister an account on the Wine bugzilla with the email address you use to send patches. Why would I do that? Just so that

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Jerome Leclanche
Would it be a good/stupid idea to check for fglrx during wineboot, and set OSRM to a different value than fbo? 2009/6/6 Henri Verbeet hverb...@gmail.com: 2009/6/6 Kovács András and...@csevego.net: wine: Unhandled page fault on read access to 0x0018 at address 0x7c71fb02 (thread 0009),

Re: Socks support in ws2_32

2009-06-06 Thread Damjan Jovanovic
On Fri, Jun 5, 2009 at 9:29 PM, Steven Edwardswinehac...@gmail.com wrote: On Fri, Jun 5, 2009 at 9:40 AM, Gabriele Grecogabrielegr...@gmail.com wrote: Hello guys, I'm lurking this list since a pair of weeks but I've not yet posted here. I've added socks 4/5 support right inside of ws2_32

Re: Socks support in ws2_32

2009-06-06 Thread Francois Gouget
On Fri, 5 Jun 2009, Steven Edwards wrote: [...] Right off the bat I'd say the variables need to go. One possible exception is if the environment variables are the standard way to configure SOCKS support on Linux. Then Wine should respond to the same variables to activate its own SOCKS support

Re: user32/edit: Check for Null before strlen

2009-06-06 Thread Paul Vriens
André Hentschel wrote: related to Bug 4742 --- dlls/user32/edit.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Hi André, Your mixing tabs and spaces. -- Cheers, Paul.

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Roderick Colenbrander
Sure that is possible but it is something we should avoid. In the longterm having this enabled by default is better as it would get ATI and others to fix their drivers. If we would restore the old value (the old method is also not great for modern games and causes a lot of issues, FBOs are needed

Re: user32/edit: Check for Null before strlen(try2)

2009-06-06 Thread Nikolay Sivov
André Hentschel wrote: related to Bug 4742 try2: fixed indentation --- dlls/user32/edit.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) --- - countA = strlen(textA) + 1; +if(textA) +countA = strlen(textA) + 1; }

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Joel Holdsworth
GetVersion() is not a problem in itself but we make an effort to decide what to test based on behavior not version. If it absolutely can not be avoided (and you will see some examples in the code) GetVersion() is accepted. I think this is the case here. DrawIcon[Ex]'s behaviour has

Re: user32/edit: Check for Null before strlen(try2)

2009-06-06 Thread André Hentschel
Nikolay Sivov schrieb: André Hentschel wrote: related to Bug 4742 try2: fixed indentation --- dlls/user32/edit.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) --- -countA = strlen(textA) + 1; +if(textA) +countA = strlen(textA) + 1;

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Paul Vriens
Joel Holdsworth wrote: GetVersion() is not a problem in itself but we make an effort to decide what to test based on behavior not version. If it absolutely can not be avoided (and you will see some examples in the code) GetVersion() is accepted. I think this is the case here. DrawIcon[Ex]'s

Re: user32/edit: Check for Null before strlen(try2)

2009-06-06 Thread Nikolay Sivov
André Hentschel wrote: Nikolay Sivov schrieb: André Hentschel wrote: related to Bug 4742 try2: fixed indentation --- dlls/user32/edit.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) --- -countA = strlen(textA) + 1; +if(textA) +countA

Re: user32/edit: Check for Null before strlen(try2)

2009-06-06 Thread André Hentschel
Nikolay Sivov schrieb: Should i change the indentation of the code around? Just add your line same way. I did in try1: Paul Vriens schrieb: André Hentschel wrote: related to Bug 4742 --- dlls/user32/edit.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-)

Re: Socks support in ws2_32

2009-06-06 Thread David Laight
On Sat, Jun 06, 2009 at 12:45:58PM +0200, Damjan Jovanovic wrote: From what I see you can either write/patch a native socksification library to track dup()s and dup2()s, as well as possibly do something about the unix domain sockets that are used to transfer file descriptors between the app

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Henri Verbeet
2009/6/6 Jerome Leclanche adys...@gmail.com: Would it be a good/stupid idea to check for fglrx during wineboot, and set OSRM to a different value than fbo? That's essentially what blacklisting EXT_framebuffer_object would do, although during wined3d initialization, not wineboot. We want to

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input possibilities for

Re: user32/edit: Check for Null before strlen(try2)

2009-06-06 Thread Paul Vriens
André Hentschel wrote: Nikolay Sivov schrieb: Should i change the indentation of the code around? Just add your line same way. I did in try1: In try1 you added 1 line with tabs and 3 with spaces. -- Cheers, Paul.

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Paul Vriens
Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of

Одговор: Latest Git build 7aeffc442cc1 for Wi ne 1.1.23

2009-06-06 Thread Milan Kostić
Deafulting to fbo is good, but it should be more good to leave also prior working support for backbuffer on older cards who not have EXT_framebuffer_object. Reverting to OffscreenRenderingMode=backbuffer is not working as expected for me on r200 Mesa/DRI drivers, for example in Max Payne 2 which

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Stefan Dösinger
That's probably the same issue as http://bugs.winehq.org/show_bug.cgi?id=18794 I'm afraid the conclusion there is simply going to be that fglrx's FBO support sucks. We could probably justify not checking depth stencil formats, but it's perfecly reasonable to try GL_COMPRESSED_RED_GREEN_RGTC2_EXT.

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Henri Verbeet
2009/6/6 Stefan Dösinger stefandoesin...@gmx.at: Hmm. Does fglrx support this extension at all? http://bugs.winehq.org/attachment.cgi?id=21581 That's attached to bug 18794.

Re: Одговор: Latest Git build 7aeffc442cc1 fo r Wine 1.1.23

2009-06-06 Thread Roderick Colenbrander
We don't use GL extensions when they aren't around. Perhaps there is a small check which fails for FBOs. Backbuffer should work fine but a lot more changes have been made in .23 and those are which cause the zbuffer error. Roderick On Sat, Jun 6, 2009 at 4:58 PM, Milan Kostićsmoki00...@gmail.com

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right

Re: Одговор: Latest Git build 7aeffc442cc1 fo r Wine 1.1.23

2009-06-06 Thread Henri Verbeet
2009/6/6 Milan Kostić smoki00...@gmail.com: Deafulting to fbo is good, but it should be more good to leave also prior working support for backbuffer on older cards who not have EXT_framebuffer_object. Reverting to OffscreenRenderingMode=backbuffer is not working as expected for me on r200

Re: Одговор: Latest Git build 7aeffc442cc1 for Wine 1.1.23

2009-06-06 Thread Stefan Dösinger
Am 06.06.2009 um 08:18 schrieb Roderick Colenbrander: We don't use GL extensions when they aren't around. Perhaps there is a small check which fails for FBOs. Backbuffer should work fine but a lot more changes have been made in .23 and those are which cause the zbuffer error. A long time ago

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Andrew Eikum wrote: Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of

Re: Wine translation statistics sources

2009-06-06 Thread Jonathan Ernst
Hello, Le dimanche 07 décembre 2008 à 02:15 +0100, Mikołaj Zalewski a écrit : Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my Your server seems down. Wouldn't it be better to host your script on WineHQ ? Best regards

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Andrew Eikum
Nikolay Sivov wrote: Andrew Eikum wrote: Nikolay Sivov wrote: Paul Vriens wrote: Andrew Eikum wrote: This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]

2009-06-06 Thread Nikolay Sivov
Andrew Eikum wrote: Nikolay Sivov wrote: Exactly, you should patch code too, not only tests. In this particular case it's better to check count first and return InvalidParameter and check for GdipAlloc result and return OutOfMemory if it's NULL. Okay, excellent. I'll make the patch for

Test box tagged [dr-asus]

2009-06-06 Thread Nikolay Sivov
Hi. Does anyone no whose box is it (dr-asus)? It has some (actually always 10) test failures for ListView and I think it's possible to find a cause. Same failures on 2k and XP actually. I'd like to contact owner for testing some patches. Thanks.

Re: Test box tagged [dr-asus]

2009-06-06 Thread Paul Vriens
Nikolay Sivov wrote: Hi. Does anyone no whose box is it (dr-asus)? It has some (actually always 10) test failures for ListView and I think it's possible to find a cause. Same failures on 2k and XP actually. I'd like to contact owner for testing some patches. Thanks. Hi, I think it's

Одговор: Одговор: Latest Git build 7ae ffc442cc1 for Wine 1.1.23

2009-06-06 Thread Milan Kostić
2009/6/6, Henri Verbeet hverb...@gmail.com: 2009/6/6 Milan Kostić smoki00...@gmail.com: Deafulting to fbo is good, but it should be more good to leave also prior working support for backbuffer on older cards who not have EXT_framebuffer_object. Reverting to OffscreenRenderingMode=backbuffer

[setupapi/tests] pSetupGetField is A or W depending on OS

2009-06-06 Thread Paul Vriens
Hi, Sent to wine-devel for some feedback. I was checking for more lstrcmpW's (not supported on Win9x) and found one in setupapi/tests/parser.c. After some checking it turns out that it returns an ANSI string on Win9x and a Unicode one on NT4 and higher. There is no export of pSetupGetField[AW]

Re: Wine translation statistics sources

2009-06-06 Thread Mikołaj Zalewski
Jonathan Ernst napisał(a): Hello, Le dimanche 07 décembre 2008 à 02:15 +0100, Mikołaj Zalewski a écrit : Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my Your server seems down. Wouldn't it be better to host

Re: [1/5] WineD3D: Store the bumpmap ARB constants in ARB structures

2009-06-06 Thread Henri Verbeet
I think the actual patch is missing.

Re: [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported

2009-06-06 Thread Henri Verbeet
2009/6/7 Stefan Dösinger ste...@codeweavers.com: +/* Not reentrant! */ +static inline const int *get_int_const(const struct wined3d_shader_instruction *ins, IWineD3DBaseShaderImpl *This, DWORD idx) +{ +BOOL vshader =

Re: [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported

2009-06-06 Thread James Mckenzie
Stefan Dösinger ste...@codeweavers.com wrote about [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported Stefan: Could this not a be a function: +for(i = 0; i MAX_CONST_I; i++) +{ +if(int_skip (1 i)) +{ +args-loop_ctrl[i][0]

cd-roms that need unhide

2009-06-06 Thread Dan Kegel
Despite jwhite's kernel fix, http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9769f4eb3fad2dd53a5d24c81ee5f7f05450742b I find I have to use 'norock' on some discs, e.g. Macromedia Studio 8, http://bugs.winehq.org/show_bug.cgi?id=9467 Microsoft Dynamics GP demo,

Re: cd-roms that need unhide

2009-06-06 Thread Jeremy White
What say? Would this help users more than it would hurt? Dan, can you just quick check the file system type? If it's UDF, then it's a known issue. I basically need to do my patch again, but for the UDF file system. My original work was just for ISO9660; I failed to realize that DVDs had

Re: [2/5] WineD3D: Implement loops with the NV extensions

2009-06-06 Thread Allan Tong
This is using PUSHA and POPA without setting the NV_vertex_program3 option in the shader. - Allan