Re: dmusic: remove unused variable (try 2)

2010-07-27 Thread Andrew Nguyen
On Tue, Jul 27, 2010 at 12:59 AM, Austin English austinengl...@gmail.com wrote: -- -Austin The source file seems to use tabs for indentation, so your patch should do the same.

Re: kernel32: add a test for CreateFileA() (try 3)

2010-07-27 Thread Andrew Nguyen
On Tue, Jul 27, 2010 at 12:53 AM, Austin English austinengl...@gmail.com wrote: Addressing Nikolay and Dmitry's comments. Passed wtb: https://testbot.winehq.org/JobDetails.pl?Key=3947 -- -Austin You forgot to attach the patch.

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Paul Vriens
On 07/27/2010 03:48 AM, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... I do see output for July 26th or am I missing something? We could use a volunteer to implement compression for the

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: On 07/27/2010 03:48 AM, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... I do see output for July 26th or am I missing something? We could use

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Austin English
On Tue, Jul 27, 2010 at 2:01 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: On 07/27/2010 03:48 AM, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... I do see output for July 26th or am I

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Michael Stefaniuc
Hello Austin, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... wouldn't it make more sense to have a global variable 'max_filesize' instead of duplicating the magic constants all over the place?

[website] Update French translation of 'About Wine' page

2010-07-27 Thread Frédéric Delanoy
From d9eb3a4cf56f7fbaf972ed3418c82e91524117a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= frederic.dela...@gmail.com Date: Tue, 27 Jul 2010 11:22:49 +0200 Subject: Update French translation of 'About Wine' page --- templates/fr/about.template | 77

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3956 Your paranoid

Re: dmusic: use a previously unused variable (try 3)

2010-07-27 Thread Octavian Voicu
On Tue, Jul 27, 2010 at 9:36 AM, Austin English austinengl...@gmail.com wrote: Try 3: Use tabs, not spaces. Try 2: return hr, free memory There's still a memory leak in this function if IDirectMusicPortImpl_QueryInterface fails. Would be nice to fix that also :) Octavian

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread Jacek Caban
On 7/27/10 12:18 PM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: [2/2] ntdll: Fix the status code for ProcessDebugObjectHandle class in NtQueryInformationProcess when the debugger is ab

2010-07-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3961 Your paranoid

Re: mshtml: Improve status messages sent to IOleInPlaceFrame

2010-07-27 Thread Alexander Nicolaysen Sørnes
Mandag 26. juli 2010 15.59.55 skrev Jacek Caban : Hi Alexander, On 7/26/10 11:36 AM, Alexander Nicolaysen Sørnes wrote: In preparation for adding a status bar to Wine's IE -static const WCHAR wszDone[] = {'D','o','n','e',0}; +static WCHAR wszDone[40] = { 0 };

Re: [1/2] d3dx9: Implement missing D3DXCreateTextureFromFile functions

2010-07-27 Thread Henri Verbeet
On 26 July 2010 23:05, Owen Rudge o...@owenrudge.net wrote: +HRESULT WINAPI D3DXCreateTextureFromFileInMemory(LPDIRECT3DDEVICE9 device, + LPCVOID srcdata, + UINT srcdatasize, +

Re: [2/2] d3dx9: Implement D3DXCreateTextureFromFileInMemoryEx

2010-07-27 Thread Henri Verbeet
On 26 July 2010 23:05, Owen Rudge o...@owenrudge.net wrote: +if ((filter 0x) D3DX_FILTER_BOX filter != D3DX_DEFAULT) +return D3DERR_INVALIDCALL; + +if ((mipfilter 0x) D3DX_FILTER_BOX mipfilter != D3DX_DEFAULT) +return D3DERR_INVALIDCALL; + +if

Re: [3/4] shdocvw: Add and use AdviseSinkInerface for IE

2010-07-27 Thread Jacek Caban
On 7/27/10 1:25 PM, Alexander Nicolaysen Sørnes wrote: This will be used to change the address bar URL when navigating to new pages +*ppvoid = NULL; +if(IsEqualGUID(IID_IAdviseSink, riid)) You also need to handle IUnknown. +{ +*ppvoid = iface; +

Re: ddraw: Ensure fullscreen size of fullscreen windows

2010-07-27 Thread Johan Gill
On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 27.07.2010 um 00:19 schrieb Johan Gill: This patch fixes the long-standing regression bug 17215. Enjoy, and provide feedback if you don't ;) 17215.txt Usually wined3d does the window setup. I recommend to

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread Nicolas Le Cam
2010/7/27 Jacek Caban ja...@codeweavers.com:  On 7/27/10 12:18 PM,  (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full

Re: [2/6] richedit: EN_UPDATE notification is sent on WM_PAINT.

2010-07-27 Thread Dylan Smith
On Mon, Jul 26, 2010 at 3:48 PM, Dylan Smith dylan.ah.sm...@gmail.comwrote: On Mon, Jul 26, 2010 at 3:26 PM, James Mckenzie jjmckenzi...@earthlink.net wrote: Just a question, I don't see 1/6 in this sequence. Was it submitted earlier? I sent it, but somehow it must have gotten lost along

Ukrainian translation of Wine at 100%

2010-07-27 Thread Paul Vriens
Hi, And Ukrainian is also at a 100% !!! Thanks go to Igor for his efforts in getting us this far. -- Cheers, Paul.

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Matteo Bruni
2010/7/27 Henri Verbeet hverb...@gmail.com: On 26 July 2010 21:21, Matteo Bruni matteo.myst...@gmail.com wrote: // ID3D10Blob has been made version-neutral and moved to d3dcommon.h. Actually, since this comes up now, perhaps this is a good time to think about implementing d3dcompiler and

GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Joerg-Cyril.Hoehle
Hi, Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910 contains one binary downloadable via http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1 that I'd like people to test esp. on Win9X machines (virtual or real). Please invoke it as wintest.exe volume # or

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Henri Verbeet
On 27 July 2010 16:37, Matteo Bruni matteo.myst...@gmail.com wrote: Yes, this is the best time I believe. Some time ago there was agreement to implement the shader compiler in d3dcompiler, with the d3dx9/d3d10/d3dx10 compiler function calls forwarding to d3dcompiler. My plan for the immediate

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Austin English
On Tue, Jul 27, 2010 at 9:42 AM, joerg-cyril.hoe...@t-systems.com wrote: Hi, Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910 contains one binary downloadable via http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1 that I'd like people to test esp. on

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Matteo Bruni
2010/7/27 Henri Verbeet hverb...@gmail.com: On 27 July 2010 16:37, Matteo Bruni matteo.myst...@gmail.com wrote: Yes, this is the best time I believe. Some time ago there was agreement to implement the shader compiler in d3dcompiler, with the d3dx9/d3d10/d3dx10 compiler function calls

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-27 Thread Andrew Eikum
On 07/27/2010 09:42 AM, joerg-cyril.hoe...@t-systems.com wrote: Hi, Wine's testbot job #3910 at http://testbot.winehq.org/JobDetails.pl?Key=3910 contains one binary downloadable via http://testbot.winehq.org/GetFile.pl?JobKey=3910StepKey=1 that I'd like people to test esp. on Win9X machines

Re: [PATCH 01/11] d3d10: Add the ID3D10Blob interface.

2010-07-27 Thread Henri Verbeet
On 27 July 2010 17:04, Matteo Bruni matteo.myst...@gmail.com wrote: Will do. Not sure on the effect stuff: on http://msdn.microsoft.com/en-us/library/dd607324%28v=VS.85%29.aspx the D3DCompile input is described as a pointer to uncompiled shader data; either ASCII HLSL code or a compiled

Re: [1/2] shlwapi/tests: Skip on invalid security descriptor to avoid exception

2010-07-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3964 Your paranoid

Re: [2/2] shlwapi/ordinal: Partially implement SHGetShellKey

2010-07-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3965 Your paranoid

Re: [PATCH 02/11] d3d10: Implement D3D10CreateBlob().

2010-07-27 Thread Rico Schüller
Am 27.07.2010 00:55, schrieb Henri Verbeet: 2010/7/26 Rico Schüllerkgbric...@web.de: +IUnknown_Release((IUnknown *)object); Since you'll probably resend this anyway based on Matteo's comment, I think just HeapFree() should do just as well. Also, I don't have a recent enough

The Bugzilla Project is interested in hearing about your feedback

2010-07-27 Thread Frédéric Buclin
Hello dear Bugzilla maintainers and administrators, I am Frédéric LpSolit Buclin, the QA lead and one of the two assistant project leads for the Bugzilla project. You are receiving this email because you have already been contacted by Max Kanat-Alexander (mkanat) some time ago when he did a

Re: ddraw: Ensure fullscreen size of fullscreen windows

2010-07-27 Thread Johan Gill
On Tue, Jul 27, 2010 at 1:44 PM, Johan Gill johan.g...@gmail.com wrote: On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Usually wined3d does the window setup. I recommend to take a look at WineD3D's AcquireFocusWindow and SetDisplayMode The problem is

Re: ddraw: Added a todo_wine test for SetCooperativeLevel

2010-07-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3977 Your paranoid

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-27 Thread Scott Ritchie
On 07/26/2010 03:57 AM, Alexandre Julliard wrote: Damjan Jovanovic damjan@gmail.com writes: diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine.inf $(INSTALLDIRS)