Re: [PATCH 1/5] shell32: Implement loading of context menu shell extensions (try 3)

2011-08-22 Thread Nikolay Sivov
On 8/21/2011 19:20, Jay Yang wrote: The first two patches in the sequence relate to context menus and the last three to property sheets, but some of the changes in the last three depend on a function I created in the second patch so I've sent them as a sequence. Changes from last time (for

Re: [PATCH 2/5] shell32: Use SHCreateDefaultContextMenu to create context menus (try 2)

2011-08-22 Thread Nikolay Sivov
On 8/21/2011 19:20, Jay Yang wrote: Changes from last time: Factored out the code to find the registry keys for the extensions. --- dlls/shell32/classes.c| 47 + dlls/shell32/shell32_main.h |1 + dlls/shell32/shfldr.h |9

Re: [PATCH 3/5] shell32: Implement SHOpenPropSheet

2011-08-22 Thread Nikolay Sivov
On 8/21/2011 19:20, Jay Yang wrote: --- dlls/shell32/shell32.spec |3 ++ dlls/shell32/shellord.c | 88 + include/shlobj.h |4 ++ 3 files changed, 95 insertions(+), 0 deletions(-) It's not clear for me why you placed this in

Re: [PATCH 5/5] shell32: Implement a default property sheet for file system objects

2011-08-22 Thread Nikolay Sivov
On 8/21/2011 19:21, Jay Yang wrote: +LoadStringA(shell32_hInstance,IDS_PROPSHEET_VARIOUS, +various_str,sizeof(various_str)); +LoadStringW(shell32_hInstance,IDS_PROPSHEET_COUNT_FORMAT, +count_format,sizeof(count_format)/sizeof(WCHAR)); Why -A call here? +

Re: mshtml: Use the last colon in proxy url as port separator

2011-08-22 Thread Jacek Caban
On 08/19/11 22:10, André Hentschel wrote: Am 18.08.2011 22:50, schrieb Juan Lang: Is the ProxyServer specified as an URL? If yes then use the proper API to dissect the URL instead of cobbling something together. Just to follow up in this idea, you could use InternetCrackUrl. mshtml delay loads

Substained 10ms periods in Wine audio?

2011-08-22 Thread Joerg-Cyril . Hoehle
Hi, IMHO AudioClient_Stop must not map to snd_pcm_drop. It is more like snd_pcm_pause. Or perhaps simply lead ALSA into an underrun. afaict pause, with reset mapped to drop, Indeed. IMHO, the confusion around which of pause/reset/drop/drain applies arises because Wine does not behave like

Re: The sad state of audio GetPosition

2011-08-22 Thread Maarten Lankhorst
On 08/19/2011 05:10 PM, joerg-cyril.hoe...@t-systems.com wrote: Maarten Lankhorst wrote: [nice to hear from you] IMHO AudioClient_Stop must not map to snd_pcm_drop. It is more like snd_pcm_pause. Or perhaps simply lead ALSA into an underrun. afaict pause, with reset mapped to drop,

hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Francois Gouget
The native hhctrl.ocx does not have any resrouce strings. My understanding is that we have them in Wine because we use them as tooltips for the toolbar items. That's good I guess. However a number of them make no sense at all and are a pain to translate. For instance: IDTB_NOTES

Re: [PATCH 9/9] wscript: add textstream.c; implement Host_get_StdOut

2011-08-22 Thread Octavian Voicu
On Mon, Aug 22, 2011 at 1:54 PM, Michał Ziętek wrote: +static HRESULT WINAPI TextStream_QueryInterface(ITextStream *iface, REFIID riid, void **ppv) +{ +WINE_TRACE((%s %p)\n, wine_dbgstr_guid(riid), ppv); + +if(IsEqualGUID(IID_IUnknown, riid) + || IsEqualGUID(IID_IDispatch,

Re: server: correctly map mutex acces rights

2011-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13534 Your paranoid

The sad state of audio GetPosition

2011-08-22 Thread Joerg-Cyril . Hoehle
Hi, These exclusive mode test failures look like nothing: render.c:1086: Test failed: GetCurrentPadding returned 576, should be 0 render.c:1092: Test failed: Position 90720 at end vs. 91296 played frames but they made me completely rework my model of how mmdevapi works. 91296 = 90720 + 576

Re: Hebrew: update

2011-08-22 Thread Francois Gouget
#: crypt32.rc:182 msgid KeyID= -msgstr +msgstr KeyID= I think you should really translate 'KeyID' In French it was translated to 'ID de clé'. So assuming there is a Hebrew word for 'key' then this would not remain as is. -\t/i {package|productcode} [property]\n -\t/package

Re: The sad state of audio GetPosition

2011-08-22 Thread Maarten Lankhorst
On 08/22/2011 02:13 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, These exclusive mode test failures look like nothing: render.c:1086: Test failed: GetCurrentPadding returned 576, should be 0 render.c:1092: Test failed: Position 90720 at end vs. 91296 played frames but they made me

Re: [3/3]usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13546 Your paranoid

Re: [PATCH] mountmgr: Support the dbus service udisks for dynamic devices :-) [try 5]

2011-08-22 Thread Francois Gouget
On Tue, 16 Aug 2011, Detlef Riekenberg wrote: [...] Recent distributions depend on udisks, so the libhal development package should be uninstalled or disabled when building Wine (--without-hal). I don't understand this recommendation to build with '--without-hal'. It should be possible to

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
What's the difference between 'Jump1' and 'Jump2'? Both are, it appears, toolbar buttons that can be customised by the help file developer and used to link to individual topics or URLs. The captions are customisable. The strings Jump1 and Jump2 themselves, as far as I can tell, should never

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
However a number of them make no sense at all and are a pain to translate. For instance: IDTB_NOTES IDTB_NOTES IDTB_BROWSE_FWD IDTB_BROWSE_FWD IDTB_BROWSE_BACK IDT_BROWSE_BACK With regards to these buttons, attempting to use those constants on Windows results in buttons

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Francois Gouget
On Mon, 22 Aug 2011, Owen Rudge wrote: What's the difference between 'Jump1' and 'Jump2'? Both are, it appears, toolbar buttons that can be customised by the help file developer and used to link to individual topics or URLs. The captions are customisable. The strings Jump1 and Jump2

Re: hhctrl: IDTB_XXX resource strings

2011-08-22 Thread Owen Rudge
I see the strings being added to the toolbar with LPWSTR szBuf = HH_LoadString(buttons[dwIndex].idCommand); ... buttons[dwIndex].iString = (DWORD)SendMessageW(hToolbar, TB_ADDSTRINGW, 0, (LPARAM)szBuf); But from there it's not clear to me they whether they will be used or not. Did

Re: [1/3] wined3d: Constant load optimisations

2011-08-22 Thread Stefan Dösinger
On Sunday 21 August 2011 00:18:56 Henri Verbeet wrote: Yes, that's somewhat suspicious, although it's possible that the constants all being in a single array prevents that. I'd have to look up if the spec has anything to say about this. I think that was about the attributes, not the uniforms.

Re: mmdevapi: After GetBuffer, refuse Reset, but Start/Stop is ok.

2011-08-22 Thread Andrew Eikum
On Mon, Aug 22, 2011 at 10:56:29AM +0200, joerg-cyril.hoe...@t-systems.com wrote: My tests also show that a GetBuffer/ReleaseBuffer pair is left undisturbed by Stop/Start in between. Fortunately, this has no effect on the current code (but it shows that Stop must not change This-held_frames

Re: Hebrew: update

2011-08-22 Thread Andrew Nguyen
On 08/22/2011 07:25 AM, Francois Gouget wrote: msgid DirectX Diagnostic Tool -msgstr +msgstr DirectX Diagnostic Tool This is sort of a product name os it's always a bit dicey. Still, wouldn't it be better if 'Diagnostic Tool' was translated? At non-English speakers would understand

Re: tools/wine.inf: Add registry key HKLM, %CurrentVersionNT%, ProductName

2011-08-22 Thread Alexandre Julliard
Louis Lenders xerox_xerox2...@yahoo.co.uk writes: Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=28065 This would need to be updated when the version is changed in winecfg. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] GNU/kFreeBSD detection

2011-08-22 Thread Alexandre Julliard
Robert Millan r...@debian.org writes: diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h index 05adf31..cf389fb 100644 --- a/tools/winebuild/build.h +++ b/tools/winebuild/build.h @@ -148,6 +148,7 @@ enum target_platform PLATFORM_UNSPECIFIED, PLATFORM_APPLE,

Re: ntdll: While requesting TokenGroups calculate required user buffer size in server (try2)

2011-08-22 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: +SERVER_START_REQ( get_token_groups ) { -need_more_memory = FALSE; +TOKEN_GROUPS *groups = tokeninfo; +void *buffer; -SERVER_START_REQ( get_token_groups ) -{ -

The sad state of audio GetPosition

2011-08-22 Thread Joerg-Cyril . Hoehle
Hi, Maarten Lankhorst wrote: exclusive mode wants you to fill the entire buffer at the same time. You're confusing this with exclusive + EVENTCALLBACK mode, which I'm not using. There are 4 combinations of shared/exclusive and EVENTCALLBACK or not. Only one of the 4 needs no GetCurrentPadding

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-22 Thread Alexandre Julliard
Bernhard Loos bernhardl...@googlemail.com writes: diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 284223e..3a7e93a 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -1326,6 +1326,7 @@ int main(int argc, char **argv) { case

Re: The sad state of audio GetPosition

2011-08-22 Thread Maarten Lankhorst
On 08/22/2011 05:31 PM, joerg-cyril.hoe...@t-systems.com wrote: Hi, Maarten Lankhorst wrote: exclusive mode wants you to fill the entire buffer at the same time. You're confusing this with exclusive + EVENTCALLBACK mode, which I'm not using. There are 4 combinations of shared/exclusive and

mmdevapi: After GetBuffer, refuse Reset, but Start/Stop is ok.

2011-08-22 Thread Joerg-Cyril . Hoehle
Hi, My tests also show that a GetBuffer/ReleaseBuffer pair is left undisturbed by Stop/Start in between. Fortunately, this has no effect on the current code (but it shows that Stop must not change This-held_frames or the write_pos). Could you add tests to render.c showing this? Eventually

Re: wine-devel Digest, Vol 73, Issue 58

2011-08-22 Thread Michael Ost
Louis, I wonder if the patch referred to here is relevant for the device detection we need for the ilok...? I'm kinda shooting in the dark, without much background, but the message jumped out at me. - mo On 08/22/2011 08:06 AM, wine-devel-requ...@winehq.org wrote: Message: 3 Date: Mon, 22

Re: wine-devel Digest, Vol 73, Issue 58

2011-08-22 Thread Michael Ost
Dear list, sorry for the accidental posting! Gah! I hit a premature ctrl+enter! ... Michael Ost On 08/22/2011 09:16 AM, Michael Ost wrote: Louis, I wonder if the patch referred to here is relevant for the device snip

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-22 Thread Bernhard Loos
On Mon, Aug 22, 2011 at 5:35 PM, Alexandre Julliard julli...@winehq.org wrote: Bernhard Loos bernhardl...@googlemail.com writes: diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 284223e..3a7e93a 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@

The sad state of audio GetPosition

2011-08-22 Thread Joerg-Cyril . Hoehle
Hi, Maarten Lankhorst wrote: But it's not the same, wine doesn't officially handle exclusive mode. Eh? This is new to me! Back in June Andrew Eikum wrote: These limitations might be true for exclusive mode, which isn't really implemented in Wine. ... which is not the same in my ears. Andrew

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-22 Thread Jerome Leclanche
That's to be fixed in bash-completion, not winegcc... On Mon, Aug 22, 2011 at 5:31 PM, Bernhard Loos bernhardl...@googlemail.com wrote: On Mon, Aug 22, 2011 at 5:35 PM, Alexandre Julliard julli...@winehq.org wrote: Bernhard Loos bernhardl...@googlemail.com writes: diff --git

Re: [1/2] dinput8/tests: Moved EnumDevicesBySemantics specific tests to dinput.c and added a couple more

2011-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13552 Your paranoid

Re: [2/2] dinput8/tests: Tests for DIPROP_USERNAME property

2011-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13553 Your paranoid

Re: mshtml: Use the last colon in proxy url as port separator

2011-08-22 Thread André Hentschel
Am 22.08.2011 11:01, schrieb Jacek Caban: On 08/19/11 22:10, André Hentschel wrote: Am 18.08.2011 22:50, schrieb Juan Lang: Is the ProxyServer specified as an URL? If yes then use the proper API to dissect the URL instead of cobbling something together. Just to follow up in this idea, you

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13562 Your paranoid

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-22 Thread Henri Verbeet
On 22 August 2011 21:16, Stefan Dösinger stefandoesin...@gmx.at wrote: +{WINED3DFMT_D24_UNORM, 0x0,0x0,0x0, 0x0,4, 24, 0}, {WINED3DFMT_X8D24_UNORM,0x0,0x0,0x0, 0x0,4, 24,

Re: [PATCH] GNU/kFreeBSD detection

2011-08-22 Thread Robert Millan
2011/8/22 Alexandre Julliard julli...@winehq.org: If it doesn't need a different behavior there's no need for a new platform, just use PLATFORM_FREEBSD. It may need different behaviour in the future. Anyhow, if you still prefer to share the same macro here's the new patch. Thanks -- Robert

Re: tools/winegcc: support a trailing / in paths to winebuild

2011-08-22 Thread Bernhard Loos
On Mon, Aug 22, 2011 at 7:02 PM, Jerome Leclanche adys...@gmail.com wrote: That's to be fixed in bash-completion, not winegcc... Uhm, what's wrong with bash-completation? -B takes a directory as an argument so bash adds a slash during autocomplete, that's ok. gcc itself can also deal with a

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 22.08.2011 um 23:50 schrieb Henri Verbeet: On 22 August 2011 21:16, Stefan Dösinger stefandoesin...@gmx.at wrote: +{WINED3DFMT_D24_UNORM, 0x0,0x0,0x0, 0x0,4, 24, 0},

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding

2011-08-22 Thread Henri Verbeet
On 23 August 2011 00:38, Stefan Dösinger stefandoesin...@gmx.at wrote: How is WINED3DFMT_D24_UNORM different from WINED3DFMT_X8D24_UNORM? It has a different application-visible ddraw format. I'm not sure that really justifies adding duplicate formats in wined3d. Also, calling this D24_UNORM

Re: mshtml: Use wininet to get and parse the proxy (try 2)

2011-08-22 Thread Dmitry Timoshkov
André Hentschel n...@dawncrow.de wrote: please ignore also that one. APPINFO_QueryOption needs to be fixed first And there's still a leak there. -- Dmitry.

Re: [PATCH] GNU/kFreeBSD detection

2011-08-22 Thread GOUJON Alexandre
On 08/22/2011 07:11 PM, Robert Millan wrote: 2011/8/22 Alexandre Julliardjulli...@winehq.org: If it doesn't need a different behavior there's no need for a new platform, just use PLATFORM_FREEBSD. It may need different behaviour in the future. Anyhow, if you still prefer to share the same