Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified

2009-07-01 Thread Paul Vriens
Brent Roman wrote: Originally submitted on 6/14/09. Resubmitted after comments on this bug: http://bugs.winehq.org/show_bug.cgi?id=19134 The attached patch against the master branch (as of today) fixes what appears to be a long standing bug in Wine's GetSystemMenu function in User32.dll.so.

Re: regedit: Open last key at startup

2009-07-01 Thread Alexandre Julliard
Vladimir Pankratov script...@mail.ru writes: Hi all. Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Paul Vriens
Hans Leidekker wrote: Passes on win2k3, vista and the win7 release candidate. Hi Hans, These are the results on Win95: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK,

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Paul Vriens
Paul Vriens wrote: Hans Leidekker wrote: Passes on win2k3, vista and the win7 release candidate. Would using IsValidCodePage() be helpful here? Yep, something like: hr = IMultiLanguage2_IsCodePageInstallable(ml2, i); if (i == 29001 || /* win2k3 */ i == 50930 ||

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Hans Leidekker
On Wednesday 01 July 2009 12:12:47 pm Paul Vriens wrote: Would using IsValidCodePage() be helpful here? Yep, something like: hr = IMultiLanguage2_IsCodePageInstallable(ml2, i); if (i == 29001 || /* win2k3 */ i == 50930 || i == 50931 || i == 50933 || i ==

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Paul Vriens
Hans Leidekker wrote: On Wednesday 01 July 2009 12:12:47 pm Paul Vriens wrote: Would using IsValidCodePage() be helpful here? Yep, something like: hr = IMultiLanguage2_IsCodePageInstallable(ml2, i); if (i == 29001 || /* win2k3 */ i == 50930 || i == 50931 || i

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: Hans Leidekker wrote: On Wednesday 01 July 2009 12:12:47 pm Paul Vriens wrote: Would using IsValidCodePage() be helpful here? Yep, something like: hr = IMultiLanguage2_IsCodePageInstallable(ml2, i); if (i == 29001 || /*

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Paul Vriens
Alexandre Julliard wrote: Paul Vriens paul.vriens.w...@gmail.com writes: Hans Leidekker wrote: On Wednesday 01 July 2009 12:12:47 pm Paul Vriens wrote: Would using IsValidCodePage() be helpful here? Yep, something like: hr = IMultiLanguage2_IsCodePageInstallable(ml2, i);

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Hans Leidekker
On Wednesday 01 July 2009 01:09:52 pm Alexandre Julliard wrote: IsValidCodePage might be helpful yes, although marking it broken is a bit too strong I think, it's just a difference in codepage databases. -Hans Yes, broken() seems strong but it's actually meant as

Standard dialogs size translation

2009-07-01 Thread Frédéric Delanoy
Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES However, e.g. in the standard File Open dialog, the standard size of some labels (e.g. File name) is too

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.

2009-07-01 Thread Alexandre Julliard
Hans Leidekker h...@codeweavers.com writes: Some more testing suggests that the installable set is a superset of the valid codepages set. So we could just return the set of valid codepages for now and not hardcode anything. Yes, it should probably use something like

Re: Standard dialogs size translation

2009-07-01 Thread Alexander Nicolaysen Sørnes
Onsdag 01 juli 2009 14:23:47 skrev Frédéric Delanoy: Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES However, e.g. in the standard File Open dialog,

regression: loader: Reserve some more memory to cover the native ole32 addresses.

2009-07-01 Thread Markus Amsler
commit 8d833ee2e7a1d8b82e2dccf51e0cbc20742a0833 Author: Alexandre Julliard julli...@winehq.org Date: Thu Jun 25 14:19:09 2009 +0200 loader: Reserve some more memory to cover the native ole32 addresses. After this commit WoW with mesa/r500 falls back to indirect rendering. libGL tries to

Re: winex11.drv: Move clipboard handling to a separate thread

2009-07-01 Thread Alexandre Julliard
Yuri Khan yurivk...@gmail.com writes: This patch achieves this by creating an auxiliary thread that will run in the same process that puts data on the clipboard and handle X selection messages. That looks quite inefficient, especially since you create a new thread every time. You should limit

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified

2009-07-01 Thread Alexandre Julliard
Brent Roman br...@mbari.org writes: Originally submitted on 6/14/09. Resubmitted after comments on this bug: http://bugs.winehq.org/show_bug.cgi?id=19134 The attached patch against the master branch (as of today) fixes what appears to be a long standing bug in Wine's GetSystemMenu

Re: regedit: Open last key at startup

2009-07-01 Thread André Hentschel
Alexandre Julliard schrieb: Vladimir Pankratov script...@mail.ru writes: Hi all. Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to

Re: msctf: fully clear the Variant before setting it.

2009-07-01 Thread Huw Davies
On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c index 3afcfda..e1c7187 100644 --- a/dlls/msctf/compartmentmgr.c +++ b/dlls/msctf/compartmentmgr.c @@ -537,6 +537,7 @@ static HRESULT WINAPI

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?

2009-07-01 Thread Lei Zhang
On Tue, Jun 23, 2009 at 8:17 AM, joerg-cyril.hoe...@t-systems.com wrote: Hi, http://bugs.winehq.org/show_bug.cgi?id=19028 winecfg on Mac OSX (10.5.6 and .7) does not link My Videos etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead.

Re: [PATCH 5/6] urlmon: Added user agent tests.

2009-07-01 Thread Jacek Caban
Hi Paul, Paul Vriens wrote: Jacek Caban wrote: --- dlls/urlmon/tests/misc.c | 84 - 1 files changed, 82 insertions(+), 2 deletions(-) Hi Jacek, The addition of these

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?

2009-07-01 Thread James Mckenzie
You probably want a separate code path in shellpath.c for the Mac. I don't think XDG works there. Can check, but make sure you do not use ObjC code. AJ will reject. Also pass to me, and I will add/test it. James McKenzie