italic transformation was just ignored, so roman characters were
displayed, now WineEngGetGlyphOutline runs into this error case,
breaking applications trying to use MS Sans Serif in italic.
Regards,
Michael Karcher
as that can translate 16 bit assembler code.
Regards,
Michael Karcher
byte boundary to get the correct data. #4/10 corrects
that problem for both reading and writing.
That's really ugly.
That's only the case if the device has been opened with O_DIRECT. For
buffered read/write, no alignment is needed.
Regards,
Michael Karcher
variable to
the current location, and then calls a printing function passing and
evaluating the parameters. If one of them changes the global variable
already set, the location printed is wrong, as you see here.
Regards,
Michael Karcher
decide this behaviour to be a bug, we want it to
be in Wine as Wine should be bug-to-bug compatible.
Regards,
Michael Karcher
just fixed that bug and your statement:
Color on monochrome bitmap is seldomly used anyway sounded an alarming
bell in my head. This mail was just a warning to not disregard the issue
and no specific problem report.
Regards,
Michael Karcher
\Windows
\CurrentVersion\Applets\Regedit.
Regards,
Michael Karcher
Am Donnerstag, den 02.07.2009, 09:02 +0200 schrieb Paul Vriens:
There is no need for the RegCloseKey as you are opening a predefined one.
Are you sure? He opens HKCU\Software\Microsoft\Windows\CurrentVersion
\Applets\Regedit
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein
Am Montag, den 27.07.2009, 13:24 +0900 schrieb Dmitry Timoshkov:
Michael Karcher w...@mkarcher.dialup.fu-berlin.de wrote:
The meaning of enable is the same in Windows and Wine: it enables the
execute permission, not the data execution prevention.
JFYI, I based my original patch
dlls/ntdll/tests/exception.c
framework.
You are right, I will resubmit the series. I was just grepping for
__TRY in the tests to find a source file to add to, so I didn't find
that stuff because it sets up the handler manually.
Regards,
Michael Karcher
does a forbidden access out of array bounds, you just don't
notice without optimization, or put in other words: Without optimization
the program is as wrong as with optimization, it just happens to do the
right thing anyways.
Regards,
Michael Karcher
be changed, but I suspect the latter. If you test for
reversed control characters only I a reversed BOM was found, you should
not test for non-reversed control characters if a reversed BOM was
found, according to my intuition.
Regards,
Michael Karcher
; on the other hand, relay seems
like a mostly safe channel, as it does not print user data except for
strings, and that codepath is very well exercised.)
Regards,
Michael Karcher
the DX7 code, and does not use the relaxed thunk from
IDirectDrawSurface3 (which is also used for IDirectDrawSurface and
IDirectDrawSurface2).
If I get it right, the correct fix is to add a thunk vtable for
IDirectDraw4 that uses relaxed parameter checks on AddAttachedSurface.
Regards,
Michael
Am Freitag, den 27.06.2008, 07:46 -0400 schrieb Christopher J. Ahrendt:
If I get it right, the correct fix is to add a thunk vtable for
IDirectDraw4 that uses relaxed parameter checks on AddAttachedSurface.
Regards,
Michael Karcher
Are we sure its 6.0 and not 6.1? from what I
by a C compiler, you get
points_per_pixel=0, as 1 and 72 are integers, so 1/72 is an integer
division that yields zero. This zero *then* gets converted to REAL. You
probably mean points_per_inch = 72 or inches_per_point = 1./72 (note the
decimal dot!)
Regards,
Michael Karcher
to the
strict *or* to the relaxed version of AddAttachedSurface. I might get
around to send a patch on sunday.
Regards,
Michael Karcher
does, too.
Regards,
Michael Karcher
as is, and the second F upside down above the line, with the
lowest part of the white box touching the black line. No Wine version
does handle this case correctly.
Regards,
Michael Karcher
#include windows.h
LRESULT CALLBACK wndproc(HWND wnd, UINT msg, WPARAM wp, LPARAM lp)
{
if(msg == WM_PAINT
.
Regards,
Michael Karcher
function, as Windows
usually uses the stdcall calling convention, whereas linux uses cdecl by
default. There might be some way to automate writing the wrapper
functions.
Regards,
Michael Karcher
not respond to reading 0x3ba at all. And ISA is TTL
compatible, i.e. open inputs read as one, so reads without responder
return 0xFF.
Regards,
Michael Karcher
Am Montag, den 07.07.2008, 17:17 +0200 schrieb Michael Karcher:
Sorry for commentless resending. I am too stupid to notice that July had
begun and considered the mail lost as it didn't appear in June's
archive. Still I wonder why the patch (series) didn't make it in. Any
feedback?
Regards
== State_Stopped)
+{
+LeaveCriticalSection(pTransformFilter-csFilter);
+return VFW_E_WRONG_STATE;
+}
I have to admit that I don't know anything about quartz. Are you sure
you may access pTransformFilter-ppPins[0] before taking the lock?
Regards,
Michael Karcher
).
Regards,
Michael Karcher
Am Mittwoch, den 09.07.2008, 20:15 +0300 schrieb Ismael Barros:
Thanks for the review :)
No problem.
On 7/9/08, Michael Karcher [EMAIL PROTECTED] wrote:
I dislike the order of the parameters and the name. You would write
Because _okHR compares HRESULT codes, but there's also _ok to compare
uniqueness of the IUnknown interface.
This seems to be done a lot in other dlls)
For ddraw for example, it is correct. The IDirectDrawImpl object is live
until all references to it (including the IUnknown one) are gone.
Regards,
Michael Karcher
Am Freitag, den 11.07.2008, 18:11 +0300 schrieb Ismael Barros:
On 7/11/08, Michael Karcher [EMAIL PROTECTED] wrote:
If it's not that bad, would it be okay to leave it with the deadbeef
solution, with a TODO comment to do it the right way later? Right now
I would like to focus on other
,
Michael Karcher
, please
bottom-post on this mailing list.
OK, you got a point. So, what about an uninstalled file in include/wine?
Not all files from there get installed.
Regards,
Michael Karcher
on Windows?
Regards,
Michael Karcher
[1] Which I found (as expected) when looking at dlls/gdiplus/matrix.c
variables or calc via SSE or 3Dnow! (overkill for a matrix inversion, I
know), matrix inversion probably fails, if no tricks are used.
Regards,
Michael Karcher
Am Sonntag, den 13.07.2008, 01:14 +0200 schrieb Michael Karcher:
Am Samstag, den 12.07.2008, 23:56 +0100 schrieb Reece Dunn:
If you are brave enough to really find out what happens (might be
different depending on Windows version, instruction sets available and
things like that), also try
catch right before the program dies. See
http://www.winehq.org/site/docs/winedev-guide/dbg-config for more info
about configuring the debugger.
Have you tried a relay trace yet?
Regards,
Michael Karcher
are not allowed to commit code to Wine anymore. IIRC there
is no consensus yet to what extent this rule applies, but (IIRC again)
the usual interpretation is you may not contribute to the dll you
disassembled.
Regards,
Michael Karcher
implement that test (if it turns out that a strict comparison to 0 is
not the right result): Do not calculate the sum of a*d and -b*c, but
compare these numbers in a sensible way.
Regards,
Michael Karcher
Am Sonntag, den 13.07.2008, 14:09 +0400 schrieb Nikolay Sivov:
Michael Karcher wrote:
Am Sonntag, den 13.07.2008, 12:42 +0400 schrieb Nikolay Sivov:
I think first of all we should choose an appropriate method to do so and
only after that try to compare results with native. What do you
, it can't go into include.
OK, you got a point. So, what about an uninstalled file in include/wine?
Not all files from there get installed.
Maybe. You'd have to ask Julliard.
Regards,
Michael Karcher
was intended to be
singular (and were singular if there were no rounding errors on the
thirds). You should understand the cause of this before you try to write
a robust float comparison function.
Regards,
Michael Karcher
that do this printing (but not
only for cuda, of course, except if configured appropriately). In the
short term, this should yield a hint where to start searching more
quickly.
Regards,
Michael Karcher
for all-bits-set, a grep on the wine
source code showed that wine always uses ~0U, and never -1U, so in wine
it is ~0U (or ~0UL if dealing with platform longs).
Regards,
Michael Karcher
Am Donnerstag, den 17.07.2008, 20:24 +0300 schrieb Alexander Dorofeyev:
+do
+{
+hr = IUnknown_Release(pUnkInner);
+} while (hr);
Release returns a ULONG, not a HRESULT. Do we ignore the difference in
Wine?
Regards,
Michael Karcher
/sending_patches , it tells to use the
--attach option in the imap case.
Regards,
Michael Karcher
')
{
+++gl_string_cursor;
+}
What is the advantage of that compared to
major = strtol(gl_string, gl_string_cursor,10);
?
Or even replace the whole scanning code by
if(sscanf(gl_string, %d.%d, major, minor) != 2)
ERR_(d3d_caps)(...)
Regards,
Michael Karcher
by 255. If you use
bits8 = bits5 3 | bits5 2;
you get bits8 = bits5 * 8.25, which is always less than one off the
correct result. What you do is to repeat the bit pattern infinitely
instead of filling with zeroes on the right hand.
Regards,
Michael Karcher
initialization you should create a map from vkey
do DIK. SDL uses something like the DIK codes seem to be with their SDLK
constants. As SDL is also LGPL one might take a look into SDL how it is
implemented there.
Regards,
Michael Karcher
Am Donnerstag, den 31.07.2008, 08:53 +0200 schrieb Michael Karcher:
SDL uses something like the DIK codes seem to be with their SDLK
constants.
Argl! That sentence sense no make does. I meant to say: SDL's SDLK_*
constants seem to be conceptually what Window's DIK_* are.
Regards,
Michael
by pGetCORVersion !=
NULL.
Regards,
Michael Karcher
Am Montag, den 11.08.2008, 09:45 -0700 schrieb Dan Kegel:
The scripts now run conformance tests and report regressions.
Does Ditto, but just the new error:end of output mean that there are
no new errors?
Regards,
Michael Karcher
{ background color: #ff5050; }
At least on my laptop display, #ff5050 on #ff is quite hard to read.
Regards,
Michael Karcher
after 40
characters.
Still, besides all the critique: Great work!
Regards,
Michael Karcher
PS: Yet patchwatcher would be even greater if my patches would get
green. They seem to fail afoul flaky tests, but you are already aware of
that problem.
do, see above.
Regards,
Michael Karcher
, as it only recognizes the 64 bit request, if I understood
Vitaliy correct. I consider that a kernel bug.
Regards,
Michael Karcher
is to implement the corner
cases (at least the empty string) explained on MSDN, also backed up by
an API test. Please also note the documented behaviour for the case of
the output buffer being short by one byte.
Regards,
Michael Karcher
, an ok(ret,Error...) should
precede the if(ret) block, the else part killed. If you expect
something, always test it with an ok statement; do not sprinkle
ok(FALSE) later in the code.
Regards,
Michael Karcher
,
Michael Karcher
Am Montag, den 18.08.2008, 09:30 +0200 schrieb Detlef Riekenberg:
On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
---
configure | 303
+++
You should never include autogenerated code in a Patch.
This will reduce
this flag.
What I do care about is whether the program requested some functionality
from wine it can't handle. So I would just show a message that says
DI_NOMIRROR flag unimplemented, and skip the version information.
Regards,
Michael Karcher
is to leave style of
code parts one does not touch alone. If you really feel like that line
should be changed, submit it as seperate patch.
Regards,
Michael Karcher
the appropriate
testcase directly at hand. Patches including testcases also have a
higher chance of getting committed.
Regards,
Michael Karcher
Am Montag, den 18.08.2008, 20:31 +0200 schrieb Michael Karcher:
Am Montag, den 18.08.2008, 08:46 + schrieb Louis. Lenders:
hi, tests show that UrlUnEscape still converts the url-string if the
bufferpointer is set to NULL, and the
URL_UNESCAPE_INPLACE is set. Test passes fine
.
Regards,
Michael Karcher
page, stating that
lstrcpyn(dest,abcdefghi,4)
puts abc into dest.
Regards,
Michael Karcher
Am Donnerstag, den 21.08.2008, 17:35 -0500 schrieb John Klehm:
On Thu, Aug 21, 2008 at 4:35 PM, Michael Karcher
[EMAIL PROTECTED] wrote:
page, stating that
lstrcpyn(dest,abcdefghi,4)
puts abc into dest.
Seems like Wine's version at least always null terminates it, so
abc\0.
Sorry if my
, but the details about exact error codes have been removed
from the patch.
Regards,
Michael Karcher
suggenst to remove the result traces from
there?
Regards,
Michael Karcher
to the NtCreateCall, i.e.
understand the flow. I don't understand that.
| If you want details like the exact error codes you can use +relay or
| +server.
I agree too, but the details about exact error codes have been removed
from the patch.
Regards,
Michael Karcher
signature.asc
Description: Dies
%d:
%d,%d-%d,%d\n,
+width, height, rect.left, rect.top, rect.right, rect.bottom);
These messages contain a copy paste mistake. Please fix the 6x6.
Regards,
Michael Karcher
desktop case.
Regards,
Michael Karcher
easier. Having MultiByteToWideChar calls
fail in that case seems to make recompilation of most DLLs (that export
A and W functions) with -O0 impossible.
Regards,
Michael Karcher
different places.
Regards,
Michael Karcher
Am Donnerstag, den 11.09.2008, 18:21 +0200 schrieb Martin Profittlich:
In this particular case, I think the crash log does not really indicate
an alignment problem, but a x/i $eip in winedbg on the crash might
help to check further. I suspect a [edx-1] address while edx contains a
NULL
.
In this particular case, I think the crash log does not really indicate
an alignment problem, but a x/i $eip in winedbg on the crash might
help to check further. I suspect a [edx-1] address while edx contains a
NULL pointer.
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein digital
are a kind of of Win32 API reference by example. IMHO you
shouldn't include such misleading parameters as the size in the wrong
unit into API usage examples.
Regards,
Michael Karcher
(DependOnGroup) with FALSE, so definitely not a retry.
Peter, are you sure that windows will handle REG_SZ *only* in the
DependOnService case and fail if you have a REG_SZ in DependOnGroup?
Regards,
Michael Karcher
loading behaviour for DependOnService and
DependOnGroup is verified. Just for reference: WinXP SP3 in KVM here.
Regards,
Michael Karcher
the implementation of glibc's sscanf, and you explicitly have to
forbid it to use this knowledge which does not apply perfectly to
Microsofts sscanf. This (of course) is only applicable to those parts of
wine that link to msvcrt and thus use msvcrt's scanf implementation.
Regards,
Michael Karcher
Am Samstag, den 20.09.2008, 10:50 +0200 schrieb Michael Karcher:
Looks like we need to compile with -fno-builtin-sscanf, because gcc
knows the implementation of glibc's sscanf,
OK, I looked further into it. On Linux, we don't get the warning,
because gcc is called with the sledgehammer option
ready that checks
whether the global -fno-builtin is really needed., and uses separate
flags otherwise. I am planning to submit it in series with a second
patch that checks for whether -fno-builtin-scanf is needed (check for
warning on %P).
Regards,
Michael Karcher
to everyone: I suppose if the trace above indicates the run
number, these modifications are unneded. Do you agree?
Regards,
Michael Karcher
Am Sonntag, den 21.09.2008, 11:25 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
OK. Thanks for the pointer. I have a configure test ready that checks
whether the global -fno-builtin is really needed., and uses separate
flags otherwise. I am planning to submit
Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
Sure I can, this was approach b I suggested. But that may be harmful to
performance, as it forbids gcc to use any knowledge about the standard
library (includes inlining of memcpy
Am Sonntag, den 21.09.2008, 13:46 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard:
If performance is an issue you most likely don't want to use msvcrt at
all, native Unix libc will always
debug channels (that's
where TRACE messages go to).
Without modifying the test messages, we'll only get
a line number, and no mention of which data caused the test to fail.
You just look some lines upwards to the trace output. It's right next to
the failure message.
Regards,
Michael Karcher
:
http://www.winehq.org/pipermail/wine-patches/2008-September/061760.html
In that patch, you are definitely missing the prototype for
MsiSetExternalUIRecord in msi.h. I didn't notice any further problems.
Regards,
Michael Karcher
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo. The test passes both ways, but from the code flow I
suspect that node_list2 was obtained for a reason, namely using it.
Regards,
Michael Karcher
This patch fixes the type, if it turn out
[resend, as I used a non-subscribed From: in the first try]
Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after
Am Samstag, den 04.10.2008, 21:00 +0200 schrieb Michael Karcher:
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after fixing the
typo does *not* succeed in WinXP, only in wine.
Last followup
Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after fixing the
typo does *not* succeed in WinXP, only in wine
. He did never submit
in that form. I would be happy about any advice.
The indentation-fixed patch is included, although the first two lines
are munged to prevent the patch to get away with the forged
attribution.
Regards,
Michael Karcher
Based-on-From 37a6d97098fa8d4de70b125f6303de5b5fa92357
Am Freitag, den 10.10.2008, 14:26 +0100 schrieb Rob Shearman:
2008/10/8 Michael Karcher [EMAIL PROTECTED]:
In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html
Peter Urbanec sent a patch I like, that adds timing information to the
log. It has been critized for having
/412577.aspx
Regards,
Michael Karcher
notably, packed 24 bpp true color (D3DFMT_R8G8B8) support
is missing, as most modern cards use 32 bpp true color
(D3DFMT_X8R8G8B8). I would expect NULLREF to fail on a system with
d3dref9.dll available but a 24 bpp framebuffer.
Regards,
Michael Karcher
test (as I suggested),
*please* also post the code you used to generate that output.
Regards,
Michael Karcher
should point to the DirectDrawSurface interface, is a NULL value
pointing nowhere instead, which is exactly what we need here.
Regards,
Michael Karcher
Am Dienstag, den 14.10.2008, 13:34 -0700 schrieb chris ahrendt:
Yes if we need to move this off list please let me know
Michael Karcher wrote:
That's why I suggested you to introduce the err2 label. The end of the
function should look like this:
Ya, Ich versteh
Sehr gut.
here
;
| IDirectDrawPalette *palette = NULL;
As they are initialized to NULL, the condition of the if statement is
false if these variables were not yet initialized. So no crash possible
here. Your return statement leaks palette.
Regards,
Michael Karcher
that the testcase should handle that.
Regards,
Michael Karcher
?
Not necessarily. The problem is that the ATI driver behaves differently
with different stack limits, and the Wine developers have to decide
whether they accept both behaviours as OK.
Regards,
Michael Karcher
statement
might be written as
return (hr == S_OK ? E_FAIL : hr);
Regards,
Michael Karcher
1 - 100 of 176 matches
Mail list logo
