Re: wireguard dkms systemd

2018-11-06 Thread Daniel Kahn Gillmor
On Tue 2018-11-06 14:04:43 +0100, Fabian Grünbichler wrote: > if nobody beats me to it, I will - but no time until the weekend. do you > prefer patch here or via BTS or MR on salsa or BTS referencing MR? ;) either way you like is ok with me -- patches or MR on salsa. but please do make sure it

Re: wireguard dkms systemd

2018-11-06 Thread Fabian Grünbichler
On Tue, Nov 06, 2018 at 02:16:56PM +0700, Daniel Kahn Gillmor wrote: > On Mon 2018-11-05 12:27:44 +0100, Fabian Grünbichler wrote: > > FWIW, I'd like to see some variant of transparent reloading integrated > > into the Debian packages (even if disabled by default). > > if you want to propose a

Re: wireguard dkms systemd

2018-11-06 Thread Daniel Kahn Gillmor
On Mon 2018-11-05 12:27:44 +0100, Fabian Grünbichler wrote: >> * i'm leery of the "systemctl daemon-reload" approach in particular, as >>mentioned above. if lots of packages did that in their postinst >>they'd be interacting weirdly with each other during a multi-package >>upgrade. >

Re: wireguard dkms systemd

2018-11-05 Thread Jason A. Donenfeld
On Mon, Nov 5, 2018 at 7:47 AM Daniel Kahn Gillmor wrote: > * echoing suggestions to stdout to rmmod/modprobe just before actually >doing the thing seems like a recipe for it happening twice. I think >i wouldn't make that prompt if the administrator has already asked >the system to

Re: wireguard dkms systemd

2018-11-05 Thread Fabian Grünbichler
On Mon, Nov 05, 2018 at 01:28:37PM +0700, Daniel Kahn Gillmor wrote: > On Sun 2018-11-04 16:35:07 +0100, Jason A. Donenfeld wrote: > > FWIW, Ubuntu users got confused with reloading the kernel module (let > > alone systemd's view of units), so we wound up adding something a bit > > strange to the

Re: wireguard dkms systemd

2018-11-04 Thread Daniel Kahn Gillmor
On Sun 2018-11-04 16:35:07 +0100, Jason A. Donenfeld wrote: > FWIW, Ubuntu users got confused with reloading the kernel module (let > alone systemd's view of units), so we wound up adding something a bit > strange to the postinst: > >

Re: wireguard dkms systemd

2018-11-04 Thread Jason A. Donenfeld
FWIW, Ubuntu users got confused with reloading the kernel module (let alone systemd's view of units), so we wound up adding something a bit strange to the postinst: https://github.com/EggieCode/wireguard-ppa/blob/master/debian/wireguard-dkms.postinst#L36-L72 Not sure that Debian would want to

Re: wireguard dkms systemd

2018-11-03 Thread Daniel Kahn Gillmor
On Sat 2018-11-03 12:54:24 +0100, Matthias Urlichs wrote: > On 02.11.18 14:52, Daniel Kahn Gillmor wrote: >> "systemctl daemon-reload" in postinst > > Looks like the perfect usecase for a dpkg trigger. it might be a reasonable use case -- it'd be worth talking with the systemd maintainers in your

Re: wireguard dkms systemd

2018-11-03 Thread Daniel Kahn Gillmor
On Fri 2018-11-02 18:27:55 -0500, Reuben Martin wrote: > All this discussion about service management kinda misses the > point. You're swapping out a kernel module. There will always be > risk. Changing service management procedures won't mitigate that. If > you do not have a means to connect

Re: wireguard dkms systemd

2018-11-03 Thread Matthias Urlichs
On 02.11.18 14:52, Daniel Kahn Gillmor wrote: > "systemctl daemon-reload" in postinst Looks like the perfect usecase for a dpkg trigger. -- -- Matthias Urlichs ___ WireGuard mailing list WireGuard@lists.zx2c4.com

Re: wireguard dkms systemd

2018-11-02 Thread Reuben Martin
On Fri, Nov 2, 2018, 6:06 PM Daniel Kahn Gillmor On Sun 2018-10-21 18:49:19 +0300, Lucian Cristian wrote: > > is an annoyance to restart it manually, if you are inside the vpn, you > > can't do it, I thought that there is a restart script at package update.. > > > > If anyone has a

Re: wireguard dkms systemd

2018-11-02 Thread Daniel Kahn Gillmor
On Sun 2018-10-21 18:49:19 +0300, Lucian Cristian wrote: > is an annoyance to restart it manually, if you are inside the vpn, you > can't do it, I thought that there is a restart script at package update.. as a packager (debian, not ubuntu, but priniciples might be similar across operating

Re: wireguard dkms systemd

2018-10-21 Thread Lucian Cristian
On 21.10.2018 15:12, Jordan Glover wrote: ‐‐‐ Original Message ‐‐‐ On Saturday, October 20, 2018 10:59 PM, Lucian Cristian wrote: updating the wireguard module on systemd based linux gives Warning: The unit file, source configuration file or drop-ins of wg-quick@wg0.service changed

Re: wireguard dkms systemd

2018-10-21 Thread Jonathon Fernyhough
On 20/10/2018 21:59, Lucian Cristian wrote: > updating the wireguard module on systemd based linux How are you updating Wireguard, and on which Linux distro? > gives > > Warning: The unit file, source configuration file or drop-ins of > wg-quick@wg0.service changed on disk. Run 'systemctl

Re: wireguard dkms systemd

2018-10-21 Thread Jordan Glover
‐‐‐ Original Message ‐‐‐ On Saturday, October 20, 2018 10:59 PM, Lucian Cristian wrote: > updating the wireguard module on systemd based linux gives > > Warning: The unit file, source configuration file or drop-ins of > wg-quick@wg0.service changed on disk. Run 'systemctl daemon-reload'