https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #21 from Holger Freyther ze...@selfish.org 2011-02-02 05:06:50
PST ---
(In reply to comment #19)
Base code + patches Committed revision 35753, 35754 and 35755.
Comments on code changes
- All C++ style comments (//) must
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #23 from Holger Freyther ze...@selfish.org 2011-02-02 06:01:39
PST ---
Created an attachment (id=5856)
-- (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5856)
Furhter cleanups to the packet-tetra-template.c
Everything
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #24 from Anders Broman anders.bro...@ericsson.com 2011-02-02
06:30:26 PST ---
Hi,
I have not studied the code in great detail so it might not be relevant in this
case, but it is prefered to do:
proto_tree_add_item(ver_tree,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5856|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5840|review_for_checkin-
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #19 from Anders Broman anders.bro...@ericsson.com 2011-02-01
22:58:04 PST ---
Base code + patches Committed revision 35753, 35754 and 35755.
Comments on code changes
- Please move proto_register_tetra() to the end of the fie
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5837|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5838|review_for_checkin?
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5839|review_for_checkin?
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Anders Broman anders.bro...@ericsson.com changed:
What|Removed |Added
Attachment #5840|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #14 from Harald Welte lafo...@gnumonks.org 2011-01-31 07:30:50
PST ---
Unfortunately the TETRA spec has no ASN.1 in it. It simply describes its
encoding rules and then gives textual tables of the information elements and
their
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5820|review_for_checkin? |
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #18 from Holger Freyther ze...@selfish.org 2011-01-31 07:59:41
PST ---
Created an attachment (id=5840)
-- (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5840)
0004 Buildsystem integration...
--
Configure bugmail:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
CC|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5820|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5821|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5822|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5823|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5824|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5825|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5826|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5827|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5829|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
Holger Freyther ze...@selfish.org changed:
What|Removed |Added
Attachment #5828|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
LI Hai zeals...@gmail.com changed:
What|Removed |Added
CC||zeals...@gmail.com
--
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #11 from Holger Freyther ze...@selfish.org 2011-01-30 05:45:33
PST ---
I got the name of the univerity wrong. It is the Beijing Institute of
Technology (BIT) and associate professor LI Hai that is kind enough to share
their
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #12 from Jaap Keuter jaap.keu...@xs4all.nl 2011-01-30 19:56:53
CET ---
Could you have a look at the Code style, portability section of
doc/README.developer.
I see (and that's mainly the template file) some show stoppers, like:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #13 from Anders Broman anders.bro...@ericsson.com 2011-01-30
23:03:00 PST ---
Hi,
I assume the TETRA ASN.1 code comes from a ETSI standard, it would be nice
if it indicated which standard and didn't have a copyright clause
as
29 matches
Mail list logo
