[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #23 from Gerrit Code Review--- Change 26169 had a related patch set uploaded by Uli Heilmeier: BGP: Heuristic for IPv6 NLRI path identifier https://code.wireshark.org/review/26169 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #22 from Gerrit Code Review--- Change 26157 merged by Alexis La Goutte: BGP: Heuristic for IPv6 NLRI path identifier https://code.wireshark.org/review/26157 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #21 from Gerrit Code Review--- Change 26157 had a related patch set uploaded by Uli Heilmeier: BGP: Heuristic for IPv6 NLRI path identifier https://code.wireshark.org/review/26157 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Vincent Bernatchanged: What|Removed |Added CC||ber...@luffy.cx -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #20 from Garri--- (In reply to Dipankar Shaw from comment #19) > Any update on this bug, added some test results using the daily build i > downloaded. Please, don't push on Wireshark developers. It is open source project maintained by volunteers. I believe, the bug fix is not simple as you may think and may require wide free time window of core developers. You'll immediately receive any updates related to the report, because you are in CC list. Thank you. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Dipankar Shawchanged: What|Removed |Added Priority|Low |High --- Comment #19 from Dipankar Shaw --- Hi, Any update on this bug, added some test results using the daily build i downloaded. Dipankar -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #18 from Dipankar Shaw--- hi garri, I see in this build Version 2.4.3rc0-70-gf40faca928 (v2.4.3rc0-70-gf40faca928) When there is no path ID in the Update packet, then Wire-shark is not able to decode now. Which is a breakage from earlier build. Earlier Build(2.4.2) could decode the packet correctly when there was no path ID with the IPv6 prefix. BR// Dipankar. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #17 from Dipankar Shaw--- (In reply to Garri from comment #11) > (In reply to Dipankar Shaw from comment #10) > > How to use the patch to load in my current wireshark version > > Version 2.4.2 (v2.4.2-0-gb6c63ae086) > > or, Can you give me a download link for Wire shark containing this Patch !! > > AFAIK, you can use daily generated binaries for Windows: > > https://www.wireshark.org/download/automated/ Hi Garri, i have taken a daily version from your Link. Version 2.4.3rc0-70-gf40faca928 (v2.4.3rc0-70-gf40faca928) i checked the file with respect to the bug i reported. i can see Wire-shark is able to decode the update messsage correctly. is there any issue still pending with respect to this BUG. BR// Dipankar. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Dipankar Shawchanged: What|Removed |Added CC||dipcom02...@gmail.com -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #16 from Dipankar Shaw--- (In reply to Garri from comment #12) > > If I understand It correctly, Wireshark should decode NLRI as Add-path > capable only if it seen Open messages exchange with Add-path capabilities. > > > [1] https://tools.ietf.org/html/rfc7911#section-6 Hi Garri, If you see my capture , there is open message with Add-path capability ( look for capability code 69) and Wireshark version 2.4.2 is able to decode it correctly. Only Problem is when decoding the Update packet containing IPv6 prefix along with path ID. Br//Dipankar. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #15 from Garri--- (In reply to Garri from comment #14) > P.S.: I could provide any BGP conversations related to AddPath capability, > if needed. I mean dumps of BGP messages. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #14 from Garri--- (In reply to Alexis La Goutte from comment #13) > or need to add preference to force a capability... Maybe Wireshark could use some heuristics. For example, it could try to dissect an NLRI as ordinary NLRI and check if it see a next path attribute (known to Wireshark) or an end of Update message _correctly_. If it would fail - try to dissect as PathID prefixed NLRI. Just an idea. Thanks. (In reply to Michael Mann from comment #2) > The issue is with packet 6 in the supplied capture. Just playing around, I > modified tvb_get_ipv6_addr_with_prefix_len() and removed the handling of > prefix values not divisible by 8 (non full bytes), and the packet dissected > correctly. A prefix length could be 68 bits, for example. It would use 9 bytes for an address length in NLRI field. P.S.: I could provide any BGP conversations related to AddPath capability, if needed. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Alexis La Gouttechanged: What|Removed |Added Status|RESOLVED|CONFIRMED Resolution|FIXED |--- --- Comment #13 from Alexis La Goutte --- or need to add preference to force a capability... -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #12 from Garri--- Below is important note from the RFC 7911 [1], related to the issue: - The only explicit indication that the encoding described in Section 3 is in use in a particular BGP session is the exchange of Capabilities described in Section 4. If the exchange is successful [RFC5492], then the BGP speakers will be able to process all BGP UPDATES properly, as described in Section 5. However, if, for example, a packet analyzer is used on the wire to examine an active BGP session, it may not be able to properly decode the BGP UPDATES because it lacks prior knowledge of the exchanged Capabilities. - If I understand It correctly, Wireshark should decode NLRI as Add-path capable only if it seen Open messages exchange with Add-path capabilities. [1] https://tools.ietf.org/html/rfc7911#section-6 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #11 from Garri--- (In reply to Dipankar Shaw from comment #10) > How to use the patch to load in my current wireshark version > Version 2.4.2 (v2.4.2-0-gb6c63ae086) > or, Can you give me a download link for Wire shark containing this Patch !! AFAIK, you can use daily generated binaries for Windows: https://www.wireshark.org/download/automated/ -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #10 from Dipankar Shaw--- How to use the patch to load in my current wireshark version Version 2.4.2 (v2.4.2-0-gb6c63ae086) or, Can you give me a download link for Wire shark containing this Patch !! BR/// Dipankar. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #9 from Garri--- Created attachment 15984 --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=15984=edit MP-BGP IPv6 NLRI w/o Add-Path -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Garrichanged: What|Removed |Added CC||g.djavad...@gmail.com --- Comment #8 from Garri --- I believe I see a regression related to MP-BGP IPv6 NLRI. For example, Wireshark incorrectly dissects IPv6 NLRI w/o Add-Path ID: Network layer reachability information (9 bytes) ::/0 PathId 1090322432 NLRI path id: 1090322432 MP Reach NLRI prefix length: 0 MP Reach NLRI IPv6 prefix: :: 101:40:206:201::/64 PathId 1 NLRI path id: 1 MP Reach NLRI prefix length: 64 MP Reach NLRI IPv6 prefix: 101:40:206:201:: Actual NLRI is FD00:0:0:1::/64 Wireshark git version is: Version 2.5.0 (v2.5.0rc0-1839-g7eb2c7db). The dump is attached. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #7 from Gerrit Code Review--- Change 24557 merged by Alexis La Goutte: BGP: Add Path Identifier to IPv6 NLRI https://code.wireshark.org/review/24557 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #6 from Gerrit Code Review--- Change 24557 had a related patch set uploaded by Michael Mann: BGP: Add Path Identifier to IPv6 NLRI https://code.wireshark.org/review/24557 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Michael Mannchanged: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #5 from Gerrit Code Review--- Change 24553 merged by Roland Knall: BGP: Add Path Identifier to IPv6 NLRI https://code.wireshark.org/review/24553 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #4 from Gerrit Code Review--- Change 24553 had a related patch set uploaded by Michael Mann: BGP: Add Path Identifier to IPv6 NLRI https://code.wireshark.org/review/24553 -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 --- Comment #3 from Dipankar Shaw--- please refer RFC 7911, section 3 Extended NLRI Encodings. in the packet I attached, i expect to see, First 4 Bytes as path Identifier -- 00 00 00 01 - mean decimal 1 1 Byte : prefix length 80 - mean decimal 128 last 16 Bytes as IPv6 address. -- 20A0:::::2111::: -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Michael Mannchanged: What|Removed |Added Status|INCOMPLETE |CONFIRMED CC||mman...@netscape.net --- Comment #2 from Michael Mann --- The issue is with packet 6 in the supplied capture. Just playing around, I modified tvb_get_ipv6_addr_with_prefix_len() and removed the handling of prefix values not divisible by 8 (non full bytes), and the packet dissected correctly. My function now looks like this: int tvb_get_ipv6_addr_with_prefix_len(tvbuff_t *tvb, int offset, ws_in6_addr *addr, guint32 prefix_len) { guint32 addr_len; if (prefix_len > 128) return -1; addr_len = (prefix_len) / 8; memset(addr->bytes, 0, 16); tvb_memcpy(tvb, addr->bytes, offset, addr_len); return addr_len; } I'm not sure if "bit handling" is just an IPv4 thing and it was erroneously copy/pasted for IPv6, but this would affect a handful of dissectors if this was changed. No idea which RFCs this would refer to. -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Alexis La Gouttechanged: What|Removed |Added Status|UNCONFIRMED |INCOMPLETE Ever confirmed|0 |1 --- Comment #1 from Alexis La Goutte --- Hi, it is define in rfc number ? What the IPv6 address need to be display ? -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
[Wireshark-bugs] [Bug 14241] BGP: IPv6 NLRI is received with Add-path ID, then Wire shark is not able to decode the packet correctly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14241 Alexis La Gouttechanged: What|Removed |Added Summary|IPv6 NLRI is received with |BGP: IPv6 NLRI is received |Add-path ID, then Wire |with Add-path ID, then Wire |shark is not able to decode |shark is not able to decode |the packet correctly|the packet correctly CC||alexis.lagou...@gmail.com -- You are receiving this mail because: You are watching all bug changes.___ Sent via:Wireshark-bugs mailing list Archives:https://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe