[Wireshark-commits] master 228fc00: couchbase: Add new DCP commands

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=228fc003b7e66c4e73c642dd514d389d10df70a5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 228fc00 by Jim Walker (j...@couchbase.com): couchbase: Add new DCP commands Add suppo

[Wireshark-commits] master f4cd24a: NAS 5GS: improve dissection of SUCI

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4cd24a3fc491edd44f0b763228afdbfb9605050 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f4cd24a by Pascal Quantin (pas...@wireshark.org): NAS 5GS: improve dissection of SUCI

[Wireshark-commits] master-3.0 60ac353: Handle nanosecond-resolution pcap files.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60ac353b27f665b5ca03e602723fc6b72462c025 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 60ac353 by Guy Harris (g...@alum.mit.edu): Handle nanosecond-resolution pcap files.

[Wireshark-commits] master-3.2 383bbcf: Handle nanosecond-resolution pcap files.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=383bbcf581b68e8f6ee0775944dbd2f57e320259 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 383bbcf by Guy Harris (g...@alum.mit.edu): Handle nanosecond-resolution pcap files.

[Wireshark-commits] master c4d32e8: Handle nanosecond-resolution pcap files.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4d32e8ddf6608891145b1605a9eaa40f2467a8d Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: c4d32e8 by Guy Harris (g...@alum.mit.edu): Handle nanosecond-resolution pcap files. Chan

[Wireshark-commits] master-2.6 919d4e5: Handle nanosecond-resolution pcap files.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=919d4e500bc21b38c801e0f873fe708eaa874ebb Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 919d4e5 by Guy Harris (g...@alum.mit.edu): Handle nanosecond-resolution pcap files.

[Wireshark-commits] master-3.2 0e588b5: Fix the nanosecond-resolution pcap magic numbers.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e588b5ef0af4afd7699c9a975a029ae6814144c Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 0e588b5 by Guy Harris (g...@alum.mit.edu): Fix the nanosecond-resolution pcap magic numbers.

[Wireshark-commits] master a955d38: Fix the nanosecond-resolution pcap magic numbers.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a955d38f3a9f8c9952897a5319abc8f8924d15b7 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: a955d38 by Guy Harris (g...@alum.mit.edu): Fix the nanosecond-resolution pcap magic numbers.

[Wireshark-commits] master-2.6 bcd118a: Fix the nanosecond-resolution pcap magic numbers.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bcd118a74a5c448aad1dd0a2dc9ee0ead75ec345 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: bcd118a by Guy Harris (g...@alum.mit.edu): Fix the nanosecond-resolution pcap magic numbers.

[Wireshark-commits] master-3.0 549687f: Fix the nanosecond-resolution pcap magic numbers.

2020-03-20 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=549687f161dff36a30a7cbb8d8e5660dac211157 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 549687f by Guy Harris (g...@alum.mit.edu): Fix the nanosecond-resolution pcap magic numbers.

[Wireshark-commits] master 1796abb: cirrus-ci: update freebsd 12.0 to 12.1.

2020-03-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1796abbed660cb1ec370e52d0012d98ceb90c459 Submitter: "Dario Lombardo " Changed: branch: master Repository: wireshark Commits: 1796abb by Dario Lombardo (lom...@gmail.com): cirrus-ci: update freebsd 12.0 to 12.1.

[Wireshark-commits] master 0af8d7c: Some cppcheck fixes.

2020-03-21 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0af8d7c091d5eca352474a71fd0423b3cebbc5d3 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 0af8d7c by Martin Mathieson (martin.mathie...@keysight.com): Some cppcheck fixes.

[Wireshark-commits] master 428735c: [Automatic update for 2020-03-22]

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=428735ce9ea17e80b5afce108163a87bc9651e41 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 428735c by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-22] Upda

[Wireshark-commits] master-3.2 acb73c7: [Automatic update for 2020-03-22]

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acb73c7449868b03be8632a4a89b07146361680f Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: acb73c7 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-22]

[Wireshark-commits] master-3.0 7a8111e: [Automatic update for 2020-03-22]

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a8111ef382c553f86056cec5b1ae577ae3e2220 Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: 7a8111e by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-22]

[Wireshark-commits] master-2.6 e43828a: [Automatic update for 2020-03-22]

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e43828a87484014b484139882b7fd0723b5fa445 Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: e43828a by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-22]

[Wireshark-commits] master f998e78: RTCP: contain BYE packet dissection to its stated length

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f998e785d5ead49c57ef282765519d4ae75e056e Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f998e78 by Jaap Keuter (jaap.keu...@xs4all.nl): RTCP: contain BYE packet dissection to its sta

[Wireshark-commits] master-3.0 b8f2f81: RTCP: contain BYE packet dissection to its stated length

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8f2f8133f3d5b322103b2aaca12d1dfe97aa792 Submitter: "Peter Wu " Changed: branch: master-3.0 Repository: wireshark Commits: b8f2f81 by Jaap Keuter (jaap.keu...@xs4all.nl): RTCP: contain BYE packet dissection to its stat

[Wireshark-commits] master-3.2 67c7761: RTCP: contain BYE packet dissection to its stated length

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67c7761c1fe2fa67d39a5727b698707c05e021b9 Submitter: "Peter Wu " Changed: branch: master-3.2 Repository: wireshark Commits: 67c7761 by Jaap Keuter (jaap.keu...@xs4all.nl): RTCP: contain BYE packet dissection to its stat

[Wireshark-commits] master-2.6 f5ff525: RTCP: contain BYE packet dissection to its stated length

2020-03-22 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5ff525868c0331b270a4ae7441f2ac64c4ff8aa Submitter: "Peter Wu " Changed: branch: master-2.6 Repository: wireshark Commits: f5ff525 by Jaap Keuter (jaap.keu...@xs4all.nl): RTCP: contain BYE packet dissection to its stat

[Wireshark-commits] master 3e9ce48: dot11decrypt: Fix decryption of MFP enabled connections

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e9ce48d24242c891968f65ae5160e967e73cfa5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3e9ce48 by Mikael Kanstrup (mikael.kanst...@sony.com): dot11decrypt: Fix decryption of MFP ena

[Wireshark-commits] master 3b3a978: WSUG: Add dfilter_buttons configuration file

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b3a978d2632acb20bc4aee238a3708bee1ee3a9 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3b3a978 by Markku Leiniö (mar...@iki.fi): WSUG: Add dfilter_buttons configuration file

[Wireshark-commits] master a3195b5: tempfile(.h): fix -Wdocumentation

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a3195b5539256563ac84d300bae594d682b021e3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a3195b5 by Alexis La Goutte (alexis.lagou...@gmail.com): tempfile(.h): fix -Wdocumentation

[Wireshark-commits] master 52a782d: dot11crypt_system(.h): fix Wdocumentation

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52a782d653521b19da697c1e55fda8da29f1d5a9 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 52a782d by Alexis La Goutte (alexis.lagou...@gmail.com): dot11crypt_system(.h): fix Wdocumenta

[Wireshark-commits] master 25f159e: fix typo found by lintian (Unkown => Unknown)

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=25f159e6360f415fbdeff251492efebd62c99154 Submitter: "Tomasz Moń " Changed: branch: master Repository: wireshark Commits: 25f159e by Alexis La Goutte (alexis.lagou...@gmail.com): fix typo found by lintian (Unkown => Unk

[Wireshark-commits] master dc6fc9b: btmesh: fix typo (Accesss => Access)

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc6fc9bfc3ef7bed0d1aad7b149cd4886fd76526 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: dc6fc9b by Alexis La Goutte (alexis.lagou...@gmail.com): btmesh: fix typo (Accesss => Access)

[Wireshark-commits] master 16d4dec: systemd-journal: fix lintian (Unkown => Unknown)

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16d4decb4d99124e28dc6370455b8862e28e4d01 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 16d4dec by Alexis La Goutte (alexis.lagou...@gmail.com): systemd-journal: fix lintian (Unkown

[Wireshark-commits] master d0e279a: wassp: fix typo found by lintian (Unknown => Unknow)

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0e279aaed0a606de25f0cf9a7bde531dd110270 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d0e279a by Alexis La Goutte (alexis.lagou...@gmail.com): wassp: fix typo found by lintian (Unk

[Wireshark-commits] master c6ea36d: kerberos: fix compilation when kerberos is unavailable.

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6ea36d9811f21be2979bed133d4283d8fa25f82 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c6ea36d by Dario Lombardo (lom...@gmail.com): kerberos: fix compilation when kerberos is unava

[Wireshark-commits] master 19240a6: kerberos: change indentation from tabs to spaces.

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=19240a6182bfd9ed6cbf2e41e5ba4110dc7a9dda Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 19240a6 by Dario Lombardo (lom...@gmail.com): kerberos: change indentation from tabs to spaces

[Wireshark-commits] master 3f92e41: kerberos: remove redundant returns.

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f92e4173b082c4ff8133e0c762f1464bf77e679 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3f92e41 by Dario Lombardo (lom...@gmail.com): kerberos: remove redundant returns. It'

[Wireshark-commits] master 2f21e7c: ACDR: Support LawfulIntercept bit

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f21e7c981b1cf19843f29406f16dd09b46ed6ce Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2f21e7c by Orgad Shaneh (orgad.sha...@audiocodes.com): ACDR: Support LawfulIntercept bit

[Wireshark-commits] master-3.2 706db7f: coap: use correct OSCORE option type

2020-03-23 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=706db7f0d1d7a171743522a99c5baeabb976b761 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 706db7f by Cenk Gündoğan (mail+...@gundogan.net): coap: use correct OSCORE option type

[Wireshark-commits] master 9c28c92: USBLL: Handle addresses for all packets

2020-03-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c28c92d78c9e936dd555b0b6fe277d890ebd7a4 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9c28c92 by Ameya Deshpande (ameya.181co...@nitk.edu.in): USBLL: Handle addresses for all packe

[Wireshark-commits] master d854143: NAS-5GS: shift supi_fmt field before testing

2020-03-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d854143e8fa49aea130a0dfa995fe7466076b7c8 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: d854143 by Martin Mathieson (martin.mathie...@keysight.com): NAS-5GS: shift supi_fmt field be

[Wireshark-commits] master-3.2 8885cd2: NAS-5GS: shift supi_fmt field before testing

2020-03-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8885cd29fdf8136d50dd9454eb34baf0745be447 Submitter: "Pascal Quantin " Changed: branch: master-3.2 Repository: wireshark Commits: 8885cd2 by Martin Mathieson (martin.mathie...@keysight.com): NAS-5GS: shift supi_fmt fiel

[Wireshark-commits] master eb439e8: wslua: WSLUA_BIT_OP_FUNC macro already does return .

2020-03-24 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb439e89f13913ce98d706ac6741eea6d00b8d73 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: eb439e8 by Martin Mathieson (martin.mathie...@keysight.com): wslua: WSLUA_BIT_OP_FUNC macro

[Wireshark-commits] master 21ed54a: RDMnet

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21ed54aba132ff598a68b8b7474d60268f369456 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 21ed54a by Jim Schaettle (jimschaet...@gmail.com): RDMnet Fixing infinite loop bugs i

[Wireshark-commits] master 12d5041: Qt: Fix Lua GUI issues and get rid of casts.

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12d5041eb7cbd5b28567ac58b140864561fadccd Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 12d5041 by Gerald Combs (ger...@wireshark.org): Qt: Fix Lua GUI issues and get rid of casts.

[Wireshark-commits] master 5fbe2e4: GTPv2: Dissect IE 8.106 Node Number

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5fbe2e4df8aa4f7b0268b83de8832d1a94afcbf5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5fbe2e4 by Anders Broman (anders.bro...@ericsson.com): GTPv2: Dissect IE 8.106 Node Number

[Wireshark-commits] master 3d730f8: nstime: make declaration arg order match definition

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d730f84fe42d7dc78af3f8313917cacb028c3b0 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 3d730f8 by Martin Mathieson (martin.mathie...@keysight.com): nstime: make declaration arg o

[Wireshark-commits] master 8baf0fd: fix typo found by lintian (mesage => message)

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8baf0fd295a58a26564ad0db541dc9c32d8b Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 8baf0fd by Alexis La Goutte (alexis.lagou...@gmail.com): fix typo found by lintian (mesage =>

[Wireshark-commits] master a71765a: TPNCP: Simplify names for data field info

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a71765a619f8da8597f5f8e140bbf0dbb2e68829 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a71765a by Orgad Shaneh (orgad.sha...@audiocodes.com): TPNCP: Simplify names for data field in

[Wireshark-commits] master 31f9331: TPNCP: Use security_cmd_offset value

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31f933121b192119662a48b7eb4c8991f2432278 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 31f9331 by Orgad Shaneh (orgad.sha...@audiocodes.com): TPNCP: Use security_cmd_offset value

[Wireshark-commits] master 7579d98: gitlab-ci: upgrade to Clang 10, drop special -Wframe-larger-than case

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7579d9844839d34ac5fcfcc6e3037a6ddc381583 Submitter: "Peter Wu " Changed: branch: master Repository: wireshark Commits: 7579d98 by Peter Wu (pe...@lekensteyn.nl): gitlab-ci: upgrade to Clang 10, drop special -Wframe-lar

[Wireshark-commits] master-3.2 226939b: gitlab-ci: upgrade to Clang 10, drop special -Wframe-larger-than case

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=226939b6cc64bc22e45554e61a7a05447db63457 Submitter: "Peter Wu " Changed: branch: master-3.2 Repository: wireshark Commits: 226939b by Peter Wu (pe...@lekensteyn.nl): gitlab-ci: upgrade to Clang 10, drop special -Wframe

[Wireshark-commits] master-3.0 054553e: gitlab-ci: upgrade to Clang 10, drop special -Wframe-larger-than case

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=054553eb3a0bb8256bff05f1dc2a3e017012b3dc Submitter: "Peter Wu " Changed: branch: master-3.0 Repository: wireshark Commits: 054553e by Peter Wu (pe...@lekensteyn.nl): gitlab-ci: upgrade to Clang 10, drop special -Wframe

[Wireshark-commits] master a7a4475: ASTERIX: Add support to dissect CAT010

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7a44755f11acc0ee6398c10344a35541d476011 Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: a7a4475 by Prince Paul (prince.pau...@gmail.com): ASTERIX: Add support to dissect CAT010

[Wireshark-commits] master 9f5be6f: fix typo found by lintian (Uknown => Unknown)

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f5be6f7eba95c9c39b00a12f2dfe938436b7b0f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9f5be6f by Alexis La Goutte (alexis.lagou...@gmail.com): fix typo found by lintian (Uknown =>

[Wireshark-commits] master 7b8ea03: lltd: fix typo found by lintian (Phyiscal => Physical)

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b8ea03c6472c0f52b17e13324826839eb871dd3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7b8ea03 by Alexis La Goutte (alexis.lagou...@gmail.com): lltd: fix typo found by lintian (Phyi

[Wireshark-commits] master f6ef53e: csn1: Validate recursive array max size during decoding

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6ef53e3ed87cb83144e2e7270f38a459d459711 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: f6ef53e by Pau Espin Pedrol (pes...@sysmocom.de): csn1: Validate recursive array max size dur

[Wireshark-commits] master badbc3c: rlcmac: Don't pass array element to CSN1 descriptors

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=badbc3c6097e3365151eb97e94ee7f2d945ec094 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: badbc3c by Pau Espin Pedrol (pes...@sysmocom.de): rlcmac: Don't pass array element to CSN1 de

[Wireshark-commits] master 69a4769: rlcmac: Fix bug receiving RA cap

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69a47691cdf6a9304ef8689d3a39d510e81e001c Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 69a4769 by Pau Espin Pedrol (pes...@sysmocom.de): rlcmac: Fix bug receiving RA cap I

[Wireshark-commits] master-3.2 e854276: rlcmac: Fix bug receiving RA cap

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8542760aa94a4d3becc9e0d7137214cc2be16f3 Submitter: "Pascal Quantin " Changed: branch: master-3.2 Repository: wireshark Commits: e854276 by Pau Espin Pedrol (pes...@sysmocom.de): rlcmac: Fix bug receiving RA cap

[Wireshark-commits] master 439005c: rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare bits

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=439005cc2c78258d47a85e4b161df9c37041e60a Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 439005c by Pau Espin Pedrol (pes...@sysmocom.de): rlcmac: Introduce MS Radio Access Capabilit

[Wireshark-commits] master 3662a69: Maintain cf->state, because file cleanup depends on it.

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3662a69036f33a169301cfc76bd3a3c09023a68d Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 3662a69 by Guy Harris (g...@alum.mit.edu): Maintain cf->state, because file cleanup depends on it

[Wireshark-commits] master-3.2 84cf682: Maintain cf->state, because file cleanup depends on it.

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84cf682883e56a0d69efdea73c312a835a8fbcc6 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 84cf682 by Guy Harris (g...@alum.mit.edu): Maintain cf->state, because file cleanup depends o

[Wireshark-commits] master-3.0 c753d6c: Maintain cf->state, because file cleanup depends on it.

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c753d6c790b81dd983169d1fd769973811243d1b Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: c753d6c by Guy Harris (g...@alum.mit.edu): Maintain cf->state, because file cleanup depends o

[Wireshark-commits] master 30bad8e: Have callback function pointers in a capture_session structure.

2020-03-25 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30bad8e627ad087bd905ea29ba832d79f2fc5f63 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 30bad8e by Guy Harris (g...@alum.mit.edu): Have callback function pointers in a capture_session s

[Wireshark-commits] master 464d568: Don't build code to handle capturing if we don't have pcap.

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=464d5688cc241556b2042ea99ef4f6d74d0bd996 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 464d568 by Guy Harris (g...@alum.mit.edu): Don't build code to handle capturing if we don't have

[Wireshark-commits] master 7785557: Add a dissector for the USB printer class.

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=778555795ec005e1893065e9a5900f00b388ea41 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7785557 by Martin Kaiser (wiresh...@kaiser.cx): Add a dissector for the USB printer class.

[Wireshark-commits] master 2f6a692: TPNCP: Fix dissection of acTOpenOrUpdateSBCSession

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f6a692fcdc17a6eb332cbc3e2d546ac5c14d951 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2f6a692 by Orgad Shaneh (orgad.sha...@audiocodes.com): TPNCP: Fix dissection of acTOpenOrUpdat

[Wireshark-commits] master 49a2de6: ASTERIX: Bugfix in CAT010

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49a2de66da5fd7968f836bdf6319fddc0a28aeb2 Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: 49a2de6 by Prince Paul (prince.pau...@gmail.com): ASTERIX: Bugfix in CAT010 1. Add miss

[Wireshark-commits] master ac78d86: HiSLIP misc changes

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac78d8658d1239f70078ec5a4002ded828cbe34f Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: ac78d86 by Martin Mathieson (martin.mathie...@keysight.com): HiSLIP misc changes -

[Wireshark-commits] master 9f1b91a: csn1: fix: do not return 0 if no more bits left in the buffer

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f1b91a4a0a53796d868a218b853dbf2ca5f33b8 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 9f1b91a by Vadim Yanitskiy (axilira...@gmail.com): csn1: fix: do not return 0 if no more bits l

[Wireshark-commits] master 9d14dfb: GSM RLC/MAC: Drop extra empty line

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d14dfb82f7cb1bc5e78f57fb4a8b10df646b1fe Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 9d14dfb by Pau Espin Pedrol (pes...@sysmocom.de): GSM RLC/MAC: Drop extra empty line C

[Wireshark-commits] master 560836f: GSM RLC/MAC: fix typo in comment

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=560836f0e57d488360febd70ce40bd369038145f Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 560836f by Pau Espin Pedrol (pes...@sysmocom.de): GSM RLC/MAC: fix typo in comment Cha

[Wireshark-commits] master 39ee56e: github: fix job names.

2020-03-26 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39ee56ec33f63f0d6d7e0df73729c859e5629a3a Submitter: "Jaap Keuter " Changed: branch: master Repository: wireshark Commits: 39ee56e by Dario Lombardo (lom...@gmail.com): github: fix job names. Change-Id: I26e77b

[Wireshark-commits] master db1d040: bluetooth: Update Assigned Numbers

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db1d0402f2f75fc0cfcf1c014e0cce68b4901b6b Submitter: "Stig Bjørlykke " Changed: branch: master Repository: wireshark Commits: db1d040 by Stig Bjørlykke (s...@bjorlykke.org): bluetooth: Update Assigned Numbers C

[Wireshark-commits] master c67b607: QUIC: For gboolean fields, use FALSE/TRUE rather than 0/1.

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c67b607274efb717f876e183b5cfa2cb905dee86 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: c67b607 by Martin Mathieson (martin.mathie...@keysight.com): QUIC: For gboolean fields, use

[Wireshark-commits] master 64ffd45: CSN.1: Properly verify CSN_BITMAP length

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=64ffd4512bd112fbe67f391a2882c9166eb5c29c Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 64ffd45 by Pau Espin Pedrol (pes...@sysmocom.de): CSN.1: Properly verify CSN_BITMAP length

[Wireshark-commits] master 543c55b: CSN.1: verify enough bits present to decode whole CSN_UINT_ARRAY

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=543c55b2c0ebdfed8a29391034841b38a3fae69f Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 543c55b by Pau Espin Pedrol (pes...@sysmocom.de): CSN.1: verify enough bits present to decode

[Wireshark-commits] master f9fdf32: CSN.1: Optimize update of remaining_bits_len dissecting CSN_UINT_ARRAY

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9fdf327ce8976cbce10a0c547161280616ff7f6 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: f9fdf32 by Pau Espin Pedrol (pes...@sysmocom.de): CSN.1: Optimize update of remaining_bits_le

[Wireshark-commits] master f9cf25f: Add support for IDB option 15 - if_hardware, for hardware description.

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9cf25f7df071fe4db4c648e84476d9eef48796c Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: f9cf25f by Guy Harris (g...@alum.mit.edu): Add support for IDB option 15 - if_hardware, for hardw

[Wireshark-commits] master 5e77ab8: Remove space that snuck in during editing.

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e77ab8b9512519c7e975bbbac264a2241904bc6 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 5e77ab8 by Guy Harris (g...@alum.mit.edu): Remove space that snuck in during editing. Ch

[Wireshark-commits] master fd88bfa: Write the if_hardware option, if available, to pcapng files when capturing.

2020-03-27 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd88bfa348677ec7bdd95d6a7130a08212ee98f7 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: fd88bfa by Guy Harris (g...@alum.mit.edu): Write the if_hardware option, if available, to pcapng

[Wireshark-commits] master-3.2 56b8dd3: bluetooth: Update Assigned Numbers

2020-03-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56b8dd3516826d2407f7ef9e446daee1c4669de9 Submitter: "Anders Broman " Changed: branch: master-3.2 Repository: wireshark Commits: 56b8dd3 by Stig Bjørlykke (s...@bjorlykke.org): bluetooth: Update Assigned Numbers

[Wireshark-commits] master ca41f28: NAS 5GS: S-NSSAI dissection fixed

2020-03-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca41f28cb596dcb66a35de0c651db2fd9bb880bf Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: ca41f28 by Swapnil Roy (swapnil.adv...@gmail.com): NAS 5GS: S-NSSAI dissection fixed

[Wireshark-commits] master-3.2 a8b0fb1: NAS 5GS: S-NSSAI dissection fixed

2020-03-28 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8b0fb1e575fb413c55c57c26e3edf75ce128797 Submitter: "Pascal Quantin " Changed: branch: master-3.2 Repository: wireshark Commits: a8b0fb1 by Swapnil Roy (swapnil.adv...@gmail.com): NAS 5GS: S-NSSAI dissection fixed

[Wireshark-commits] master 1af213e: [Automatic update for 2020-03-29]

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1af213e4c46fb4d16c0bf2a3f11cb0469499c222 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 1af213e by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-29] Upda

[Wireshark-commits] master-3.2 b95762a: [Automatic update for 2020-03-29]

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b95762a320d5405d449fc7e08bb0489e05ecc6c6 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: b95762a by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-29]

[Wireshark-commits] master-3.0 22b15e8: [Automatic update for 2020-03-29]

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22b15e80c6d35bb10eddc7117c1b077c537429bd Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: 22b15e8 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-29]

[Wireshark-commits] master-2.6 67a8c2f: [Automatic update for 2020-03-29]

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67a8c2fb72cb58b307ba4a42e1a29fe493138ef2 Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: 67a8c2f by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-03-29]

[Wireshark-commits] master ea2ca38: When using preference for window scaling, show same way as signalled.

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea2ca383a95e3dbc8bcf8d87221fca400699b901 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: ea2ca38 by Martin Mathieson (martin.mathie...@keysight.com): When using preference for wind

[Wireshark-commits] master-3.2 1b126e5: gitlab/travis: remove nopcap tests.

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b126e5b51bc054d80e735b6b0751b873e58e273 Submitter: "Peter Wu " Changed: branch: master-3.2 Repository: wireshark Commits: 1b126e5 by Dario Lombardo (lom...@gmail.com): gitlab/travis: remove nopcap tests. Lack

[Wireshark-commits] master 77b0dc6: gitlab/travis: remove nopcap tests.

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77b0dc69310234bbbf2df3e920c0afccd79c731d Submitter: "Peter Wu " Changed: branch: master Repository: wireshark Commits: 77b0dc6 by Dario Lombardo (lom...@gmail.com): gitlab/travis: remove nopcap tests. Lack of

[Wireshark-commits] master 1a3e64d: wslua: Update the GUI docs.

2020-03-29 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a3e64db390deb23981d177bdbcc4c1a476865d3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 1a3e64d by Gerald Combs (ger...@wireshark.org): wslua: Update the GUI docs. Add conte

[Wireshark-commits] master 23a9470: wslua: Update the Listener docs.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23a947073b0cfc103d653958aee98b1d49e21c0a Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 23a9470 by Gerald Combs (ger...@wireshark.org): wslua: Update the Listener docs. Add

[Wireshark-commits] master-3.0 6b586f9: modbustcp: fix a shadowed variable warning

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b586f994a270b1126eb39721eeec9832b40db6c Submitter: "Anders Broman " Changed: branch: master-3.0 Repository: wireshark Commits: 6b586f9 by Graham Bloice (graham.blo...@trihedral.com): modbustcp: fix a shadowed variable

[Wireshark-commits] master 0bbc8f7: ACDR: Fix T38 over UDP dissection

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bbc8f7293300fdd28c3d498fd5b34e6fd896d37 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 0bbc8f7 by Orgad Shaneh (orgad.sha...@audiocodes.com): ACDR: Fix T38 over UDP dissection

[Wireshark-commits] master b2e13cd: ACDR: Remove unused udp dissector table

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2e13cd7825b5b8e08aac0fcf3aa8f32ad41dc4f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b2e13cd by Orgad Shaneh (orgad.sha...@audiocodes.com): ACDR: Remove unused udp dissector table

[Wireshark-commits] master fa1599a: ACDR: Dissect LIX2X3 packets when the corresponding bit is enabled

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa1599a22a5a641b8d99beddf134c8eb69274bad Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: fa1599a by Orgad Shaneh (orgad.sha...@audiocodes.com): ACDR: Dissect LIX2X3 packets when the c

[Wireshark-commits] master c4f7a97: ASTERIX: Add support to dissect CAT011

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4f7a9798b93dc5c85f8755f480cfee8d86fcd24 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c4f7a97 by Prince Paul (prince.pau...@gmail.com): ASTERIX: Add support to dissect CAT011

[Wireshark-commits] master 48407df: wslua: Update the TreeItem docs.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48407df4484c94812c0399c3a2db78279077e420 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 48407df by Gerald Combs (ger...@wireshark.org): wslua: Update the TreeItem docs. Add

[Wireshark-commits] master 87be7fa: wslua: Update the dissector docs.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87be7fa23ce222ae7e2f8c2f72a08c563fe64e03 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 87be7fa by Gerald Combs (ger...@wireshark.org): wslua: Update the dissector docs. Add

[Wireshark-commits] master 404bedb: USB: GitHub link update

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=404bedbf392bc0f05c8e2359c285a1bb5fd16933 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 404bedb by Ameya Deshpande (ameya.181co...@nitk.edu.in): USB: GitHub link update Cha

[Wireshark-commits] master e53cb23: wslua: Update the packet information docs.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e53cb23b1f9633ed2764bee456b70348dba16764 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: e53cb23 by Gerald Combs (ger...@wireshark.org): wslua: Update the packet information docs.

[Wireshark-commits] master 6f59b8e: wslua: Cross-reference and title case fixes.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f59b8e84d09a9d71ac5efcd7b1707530ce53c08 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 6f59b8e by Gerald Combs (ger...@wireshark.org): wslua: Cross-reference and title case fixes.

[Wireshark-commits] master-3.0 9f5ee1b: bluetooth: Update Assigned Numbers

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f5ee1bd67097218c99ef757906e16de392d1b00 Submitter: "Anders Broman " Changed: branch: master-3.0 Repository: wireshark Commits: 9f5ee1b by Stig Bjørlykke (s...@bjorlykke.org): bluetooth: Update Assigned Numbers

[Wireshark-commits] master 3069129: Qt+wslua: Add back progress bar titles.

2020-03-30 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3069129fe5e6593be4f3bcdc48f96e71d46cbdd5 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3069129 by Gerald Combs (ger...@wireshark.org): Qt+wslua: Add back progress bar titles.

<    2   3   4   5   6   7   8   9   10   11   >