Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Guy Harris
On Aug 14, 2012, at 5:32 PM, Evan Huus wrote: The case in the filed bug is fairly trivial to fix, but I'm wondering if this is something that should be added to the Code Style / Portability section of README.developer? No - it should be added to the Robustness section; I'd say Portability is

[Wireshark-dev] Loading packets from database

2012-08-15 Thread Larik Ishkulov
Hi everybody, I need to open in wireshark packets stored in database. I have an idea how to do it and it would be great if you comment or may be suggest better solution. I have a number of hosts which stores packets in local databases. And I have API to request packets. I need to show packets

[Wireshark-dev] ep_ memory is not garbage collected

2012-08-15 Thread Jakub Zawadzki
From commit r42254 (reference counting of edt) we have problem with ep_ memory not being returned to pool after dissecting packet. Wireshark after initial opening file, always keep edt for currently selected packet, so edt_refs is always 0. You can reproduce it by loading some bigger files,

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Jeff Morriss
Evan Huus wrote: On Linux and most other operating systems I know of, passing a NULL to a %s format specifier is safe. On Solaris, as it turns out, it isn't [1]. The case in the filed bug is fairly trivial to fix, but I'm wondering if this is something that should be added to the Code Style /

Re: [Wireshark-dev] ep_ memory is not garbage collected

2012-08-15 Thread Evan Huus
On Wed, Aug 15, 2012 at 9:53 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: From commit r42254 (reference counting of edt) we have problem with ep_ memory not being returned to pool after dissecting packet. Wireshark after initial opening file, always keep edt for currently selected

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread mmann78
It's a bit clunky, but would ws_strlen() be a solution? Wrapping strlen() but ensuring the NULL check is done? -Original Message- From: Jeff Morriss jeff.morriss...@gmail.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Wed, Aug 15, 2012 10:17 am Subject:

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Jeff Morriss
The problem with that is, at least in the backtrace I started that other thread with, that we're not calling strlen() ourselves but rather (in that case) vsnprintf() is. Technically we could LD_PRELOAD our wonderful strlen() in [on systems that support that], but as I mentioned, that would be

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Evan Huus
On Wed, Aug 15, 2012 at 10:15 AM, Jeff Morriss jeff.morriss...@gmail.com wrote: Evan Huus wrote: On Linux and most other operating systems I know of, passing a NULL to a %s format specifier is safe. On Solaris, as it turns out, it isn't [1]. The case in the filed bug is fairly trivial to

Re: [Wireshark-dev] ep_ memory is not garbage collected

2012-08-15 Thread Jakub Zawadzki
On Wed, Aug 15, 2012 at 10:22:13AM -0400, Evan Huus wrote: On Wed, Aug 15, 2012 at 9:53 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: From commit r42254 (reference counting of edt) we have problem with ep_ memory not being returned to pool after dissecting packet. Wireshark after

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Jakub Zawadzki
On Wed, Aug 15, 2012 at 11:12:10AM -0400, Evan Huus wrote: On Wed, Aug 15, 2012 at 10:15 AM, Jeff Morriss jeff.morriss...@gmail.com wrote: For the record we last discussed this a little over a year ago: http://www.wireshark.org/lists/wireshark-dev/201105/msg00202.html As for adding

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Jeff Morriss
Evan Huus wrote: On Wed, Aug 15, 2012 at 10:15 AM, Jeff Morriss jeff.morriss...@gmail.com wrote: Evan Huus wrote: On Linux and most other operating systems I know of, passing a NULL to a %s format specifier is safe. On Solaris, as it turns out, it isn't [1]. The case in the filed bug is

[Wireshark-dev] Wireshark 1.4.15 is now available

2012-08-15 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.4.15. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New Bug Fixes The

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Guy Harris
On Aug 15, 2012, at 8:59 AM, Jakub Zawadzki wrote: Myself I'm still fan of forking gnulib snprintf() and naming it ws_snprintf() ;) Later we could add new conversion specifier for addresses (IPv4, IPv6, ...), thousands grouping, or other ideas from:

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Guy Harris
On Aug 15, 2012, at 8:12 AM, Evan Huus wrote: I'm a fan of a macro like Jakub mentioned as part of the old conversation: http://www.wireshark.org/lists/wireshark-dev/201105/msg00205.html ...but let's have the macro report a dissector bug if it sees a null pointer. The dissector in

Re: [Wireshark-dev] Passing NULL to %s format specifiers

2012-08-15 Thread Guy Harris
On Aug 15, 2012, at 12:10 PM, Guy Harris wrote: On Aug 15, 2012, at 8:12 AM, Evan Huus wrote: I'm a fan of a macro like Jakub mentioned as part of the old conversation: http://www.wireshark.org/lists/wireshark-dev/201105/msg00205.html ...but let's have the macro report a dissector bug

[Wireshark-dev] Wireshark 1.6.10 is now available

2012-08-15 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.6.10. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New Bug Fixes The

[Wireshark-dev] Wireshark 1.8.2 is now available

2012-08-15 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.8.2. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New Bug Fixes The