Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-13 Thread Jakub Zawadzki
On Sun, Oct 13, 2013 at 04:43:28PM -0400, Evan Huus wrote: > On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki > wrote: > > About tvb_offset_exists() comment, compute_offset() is not returning > > exception when offset == tvb->length. > > Ah, OK. Should it? When offset == tvb->length I would think

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-13 Thread didier
Hi, Le dimanche 13 octobre 2013 à 16:43 -0400, Evan Huus a écrit : > On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki > wrote: > > About tvb_offset_exists() comment, compute_offset() is not returning > > exception when offset == tvb->length. > > Ah, OK. Should it? When offset == tvb->length I woul

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-13 Thread Evan Huus
On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki wrote: > About tvb_offset_exists() comment, compute_offset() is not returning > exception when offset == tvb->length. Ah, OK. Should it? When offset == tvb->length I would think that should be an exception, since no bytes exist at that location. The

Re: [Wireshark-dev] Help needed building portaudio for windows

2013-10-13 Thread Gerald Combs
On 10/13/13 1:18 AM, Graham Bloice wrote: > On 12 October 2013 23:10, Joerg Mayer > wrote: > > On Sat, Oct 12, 2013 at 07:45:10PM +0100, Graham Bloice wrote: > > On 12 October 2013 18:20, Joerg Mayer > wrote: > > > > > I still

Re: [Wireshark-dev] Idea for faster dissection on second pas

2013-10-13 Thread Turney, Cal
On Fri, Oct 11, 2013 at 12:37 PM, Evan Huus wrote: On Sat, Oct 12, 2013 at 11:46 AM, Anders Broman wrote: >> Just looking at performance in general as I got reports that top of trunk >> was slower than 1.8. >> Thinking about it fast filtering is more attractive as long as loading isn't >> to slo

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-13 Thread Graham Bloice
wsutil has stopped linking for me. It's looking for gmodule-2.0.lib. Looking at the linker input the library is specified but without the full path to ...\wireshark-win-32-libs\gtk2\lib. In fact the linker input for this target isn't very good at all, it has gmodule-2.0.lib, glib-2.0.lib and intl

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-13 Thread Graham Bloice
On 13 October 2013 09:45, Graham Bloice wrote: > On 12 October 2013 23:22, Joerg Mayer wrote: > >> On Sat, Oct 12, 2013 at 07:58:45PM +0100, Graham Bloice wrote: >> > > >> > > - Are there other platforms that would benefit from something similar >> to >> > > what I did with the setenv.bat scri

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-13 Thread Joerg Mayer
On Sun, Oct 13, 2013 at 09:46:52AM +0100, Graham Bloice wrote: > > Sounds good to me. UseMakeDissectorReg.cmake only implements the python > > version, > > no idea why I implemented the shell version in UseMakeTapReg.cmake. > > > > I'll try these changes out on a Linux CMake build to make sure the

Re: [Wireshark-dev] Help needed building portaudio for windows

2013-10-13 Thread Joerg Mayer
On Sun, Oct 13, 2013 at 09:18:20AM +0100, Graham Bloice wrote: > > Is there any reason why zlib and portaudio aren't built by the setup > > target/script instead of the build process? > > > > Setup doesn't really know what toolchain you'll be building with. > > The reason for compiling zlib is be

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-13 Thread Graham Bloice
On 12 October 2013 23:38, Joerg Mayer wrote: > On Sat, Oct 12, 2013 at 07:31:27PM +0100, Graham Bloice wrote: > > On 11 October 2013 16:09, Joerg Mayer wrote: > > > > > > > Another milestone hit: > > > > > > - Win 32bit: The following executables build and run from the build > > > directory > >

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-13 Thread Graham Bloice
On 12 October 2013 23:22, Joerg Mayer wrote: > On Sat, Oct 12, 2013 at 07:58:45PM +0100, Graham Bloice wrote: > > > > > > - Are there other platforms that would benefit from something similar > to > > > what I did with the setenv.bat script? > > > > > > The setenv.bat (I hope that is the file y

Re: [Wireshark-dev] Help needed building portaudio for windows

2013-10-13 Thread Graham Bloice
On 12 October 2013 23:10, Joerg Mayer wrote: > On Sat, Oct 12, 2013 at 07:45:10PM +0100, Graham Bloice wrote: > > On 12 October 2013 18:20, Joerg Mayer wrote: > > > > > I still haven't found out how to build portaudio in the > > > Wireshark-win32-libs > > > directory. Can someone please provide

[Wireshark-dev] Idea for process image dissection

2013-10-13 Thread Roland Knall
Hello I just wanted to bring something by you guys, if it would be worth implementing. I work on the openSAFETY and EPL dissectors. Both are fieldbus specific implementations. As such the communicate process images as payloads. This is the same with nearly all other fieldbus implementations i kno

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-13 Thread Jakub Zawadzki
> On Sun, Oct 13, 2013 at 12:54 AM, wrote: > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52578 > > > > User: eapache > > Date: 2013/10/13 04:54 AM > > > > Log: [...] > > All of this is (theoretically) unnecessary - simply checking the offset > > without > > worrying abou