Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Constantine Gavrilov
Dario: Thank you for taking your time to reply. I am surprised that NVMEoF has such little interest. I think it shall be hot. It is not a problem to wait, if you know that someone is looking at the MR. May I suggest that the project implements better tracking of merge requests and areas of

Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Constantine Gavrilov
Pascal: Thank you for taking your time to reply and also to review my merge request. I appreciate it. I also appreciate that you have expressed the view that it is a shame, if MR is closed. Several clarifications: I have not assumed I am busier than core developers, I have just said I am

Re: [Wireshark-dev] Proposal: New set of help pages for VoIP dialogs

2021-03-29 Thread Jaap Keuter
Hi, You could instead think about adding to the user guide, where this stuff should be in the first place. Thanks, Jaap > On 29 Mar 2021, at 08:36, Jirka Novak wrote: > > Hi, > > I'm working on VoIP dialogs for several weeks. RTP Player was > significantly changed, there are more available

Re: [Wireshark-dev] Dissector lifecycle and per-file data

2021-03-29 Thread Vincent Mallet
On Mon, Mar 29, 2021 at 9:32 AM Pascal Quantin wrote: > Did you look at the register_cleanup_routine() found in epan/packet.h? It > seems to be what you are looking for. To quote the comments: > > register_init_routine() and register_cleanup_routine() are exactly what I was after. Beautiful,

Re: [Wireshark-dev] Dissector lifecycle and per-file data

2021-03-29 Thread Pascal Quantin
Hi Vincent, Le lun. 29 mars 2021 à 18:24, Vincent Mallet a écrit : > I am hoping this is the right place to ask this question but if not please > redirect me. > That's the right place :) > I am working on a custom C dissector and need to keep some data around for > the lifetime of the

[Wireshark-dev] Dissector lifecycle and per-file data

2021-03-29 Thread Vincent Mallet
I am hoping this is the right place to ask this question but if not please redirect me. I am working on a custom C dissector and need to keep some data around for the lifetime of the current file. At the moment I allocate my structures using various wmem_ functions with a wmem_file_scope() scope

Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Dario Lombardo
Hi Constantine I know that sometimes working on a change without getting it merged soon can be frustrating. Unfortunately it is as you just described: this is a voluntary-based project where people donate their own time just for the love of the project itself. And it is not "don't bother me, I

Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Pascal Quantin
Hi Constantine, Le lun. 29 mars 2021 à 17:36, Constantine Gavrilov a écrit : > I have waited for another week and nothing happens. Unfortunately those kinds of things happen sometimes. As said previously we are all doing this in our spare time, and maybe the previous exchanges did not

Re: [Wireshark-dev] Improvments for NVMeOF dissector

2021-03-29 Thread Constantine Gavrilov
I have waited for another week and nothing happens. This merge request (!2405) was created more than two weeks ago, and the people who have looked into it either lost interest or do not have time. I appreciate that everyone is so busy, but the same claim goes for contributors as well as

Re: [Wireshark-dev] tvb_get_nstringz0

2021-03-29 Thread Dario Lombardo
Hi, John, thanks for the follow-up. I have used gdb but I didn't hit any failed assertion. I will file a bug with the test sample and reference you in it so you can have a clearer view of what's going on. On Sun, Mar 28, 2021 at 1:33 AM John Thacker wrote: > > On Sat, Mar 27, 2021 at 2:57 PM

[Wireshark-dev] Proposal: New set of help pages for VoIP dialogs

2021-03-29 Thread Jirka Novak
Hi, I'm working on VoIP dialogs for several weeks. RTP Player was significantly changed, there are more available actions in other VoIP dialogs too and I plan to update wiki pages for it. What I found is that e.g. RTP Player changes are so big that it is difficult to describe current behaving