Re: [Wireshark-dev] Is there some reasonable way to split up epan/dissectors/packet-ieee80211.c into smaller files?

2021-12-03 Thread Richard Sharpe
On Thu, Dec 2, 2021 at 11:12 PM Alexis La Goutte wrote: > > Hi Richard, > > yes, ieee802.11 dissector is big... > do you have some idea how to split ? Here is a thought, but it does not handle everything. Each new version of the Wi-Fi spec (which is now around 4000+ pages in size) introduces

Re: [Wireshark-dev] MPLS Echo Packet containing FEC stack change Sub-TLV in DDMAP TLV is not decoded by wireshark or https://hpd.gasmi.net/

2021-12-03 Thread Alexis La Goutte
Hi, Can you open an issue on wireshark gitlab ? With pcap file and link to spec. Cheers Le ven. 3 déc. 2021 à 17:26, max payne.. a écrit : > Hi, > > This is to inform you that we are supporting FEC Stack Change Sub-TLV in > DDMAP TLV. I have Hex Dump, which is correct as per my understanding

[Wireshark-dev] MPLS Echo Packet containing FEC stack change Sub-TLV in DDMAP TLV is not decoded by wireshark or https://hpd.gasmi.net/

2021-12-03 Thread max payne..
Hi, This is to inform you that we are supporting FEC Stack Change Sub-TLV in DDMAP TLV. I have Hex Dump, which is correct as per my understanding but it is not getting decoded on Wireshark or Online Decoder. Please let me know if the latest Wireshark "Version 3.6.0 (v3.6.0-0-g3a34e44d02c9)"

[Wireshark-dev] ISO-8601 date support

2021-12-03 Thread Jaap Keuter
Hi Jörg, With commit a0173cd7 you’ve added ISO-8601 date support to text2pcap. The “Import from Hex dump...” feature of Wireshark is supposed to be equally capable. Would you be able to add this capability there as well? Thanks, Jaap

Re: [Wireshark-dev] Is there some reasonable way to split up epan/dissectors/packet-ieee80211.c into smaller files?

2021-12-03 Thread Jaap Keuter
Hi Richard, Indeed it’s a rather monolithic block. Quick look at the code, here are some suggestions . - Extract the dissection of the fixed management fields. All these add_ff_... functions count up to a lot. Not sure how they are dependant on other parts of the dissector, but these at least