Re: [Wireshark-dev] Editor config and code formatting

2022-03-02 Thread Jaap Keuter
Hi, As consistent formatting not always translates into readable formatting (although in many/most cases it does) I’m not in favour of forced automatic formatting. And that is where great freedom comes with great responsibility. I’m already pleased if we can have a consistent style _per file_

Re: [Wireshark-dev] Editor config and code formatting

2022-03-02 Thread João Valverde
EditorConfig has been in use with Wireshark for seven years at this point and it's still hit or miss to configure the indentation correctly for C. It's not a good tool to manage inconsistent styles. That's not what it was designed for. The only advantage EditorConfig has over modelines in

Re: [Wireshark-dev] Editor config and code formatting

2022-03-02 Thread Graham Bloice
Always difficult to comment on such things as I'm a hard-line centrist, but I would be in favour of enforcing both indents and style\formatting. If we had enforced style, we wouldn't be having this discussion, nor would we need to even think about it when writing code, it would just happen

Re: [Wireshark-dev] Editor config and code formatting

2022-03-02 Thread João Valverde
The policy that exists for new files is a mere recommendation to use 4 space indentation, and no one is enforcing it, nor really paying much attention to it. On 01/03/22 19:00, Roland Knall wrote: Policy always was and has been, that we try to achieve consistent guidelines for new files and