[Wireshark-dev] Crash in ws_mempbrk_sse42_compile()

2015-02-11 Thread Martin Mathieson
I am building on MSVC2010EE and getting a crash upon startup. This is after doing a clean and rebuild. [image: Inline image 1] 'needles' is set to {0x1, 0x0}. 'length'. 'length' (set by call to strlen()) appears to be 0x68034a68, which would surely crash the memcpy(). Sorry, don't have time

Re: [Wireshark-dev] Script used to automatically delete unused #includes

2015-02-09 Thread Martin Mathieson
I will try to get it into a state where it will at least run under Windows or an Ubuntu VM and check it in with a licence header and warnings... Martin On Sun, Feb 8, 2015 at 6:01 PM, Alexis La Goutte alexis.lagou...@gmail.com wrote: On Mon, Jan 5, 2015 at 12:56 AM, Martin Mathieson

[Wireshark-dev] Script used to automatically delete unused #includes

2015-01-04 Thread Martin Mathieson
Hi, I have attached the script that I used over the past week or 2 to detect and delete unneeded #includes. I am not sure whether it is fit for submitting to the tools folder in its current state. By my count it deleted 1400 #includes, although: - not all source files were scanned (e.g.

Re: [Wireshark-dev] [Wireshark-commits] master d541774: Include math.h or stdlib.h as necessary to declare functions.

2014-12-22 Thread Martin Mathieson
Thanks Guy. Unfortunately I'm running my script to generate these changes on Windows, which is too forgiving. Will put stdlib.h and math.h on the do-not-remove list for now. Martin On Mon, Dec 22, 2014 at 9:24 PM, Wireshark code review code-review-do-not-re...@wireshark.org wrote: URL:

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Martin Mathieson
Meier wme...@newsguy.com wrote: On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Martin Mathieson
On Thu, Sep 11, 2014 at 11:54 AM, Graham Bloice graham.blo...@trihedral.com wrote: On 7 September 2014 23:51, Martin Mathieson martin.r.mathie...@googlemail.com wrote: I hadn't updated git-review since I first installed it, but running $ pip install -U git-review Requirement already up

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-11 Thread Martin Mathieson
On Thu, Sep 11, 2014 at 6:31 PM, Graham Bloice graham.blo...@trihedral.com wrote: On 11 September 2014 18:11, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi Graham, I am running git inside a Cygwin shell. I didn't notice any issues wth line-endings. So are you using

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-07 Thread Martin Mathieson
to push some refs to 'ssh:// mart...@code.wireshark.org:29418/wireshark' mmathie2@mmathie2-WS /cygdrive/c/wireshark-git $ git log -1 commit f4665be2e5fa30d7500f4b15109053979180efc0 Author: Martin Mathieson martin.r.mathie...@googlemail.com Date: Sun Sep 7 23:45:08 2014 +0100 Trying to get footer

[Wireshark-dev] Failing to push to gerrit

2014-09-05 Thread Martin Mathieson
message footer. But, my hook for adding this still works, and the commit message reads: $ git log -1 commit d0bb3fe405e7a3b7d10f69109b968af6a296bb02 Author: Martin Mathieson martin.r.mathie...@googlemail.com Date: Fri Sep 5 18:57:46 2014 +0100 When showing whether interfreq measurements

Re: [Wireshark-dev] Failing to push to gerrit

2014-09-05 Thread Martin Mathieson
I tried with and without the trailing new line (by amending the last commit). On Fri, Sep 5, 2014 at 7:18 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Le 5 sept. 2014 20:15, Martin Mathieson martin.r.mathie...@googlemail.com a écrit : Hi, Its been a while since I last pushed

Re: [Wireshark-dev] Errors using nmake/VC++2010 EE

2014-08-21 Thread Martin Mathieson
I ended up deleting ./ui/gtk/wireshark-tap-register.c On Thu, Aug 21, 2014 at 4:11 PM, Graham Bloice graham.blo...@trihedral.com wrote: On 21 August 2014 16:00, Robert Cragie robert.cra...@gridmerge.com wrote: Hopefully this is the right mailing list - if not, please tell me where to

Re: [Wireshark-dev] [Wireshark-commits] master 5607620: Fix buildbot issues with commit f8f3239bb03487de1844ab0f6df0ba693322ce4b from change 3016.

2014-07-14 Thread Martin Mathieson
Thanks Graham, I was forgetting that I can't access the remote git repo from inside my office... Martin On Mon, Jul 14, 2014 at 3:02 PM, Wireshark code review code-review-do-not-re...@wireshark.org wrote: URL:

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64

2014-06-05 Thread Martin Mathieson
: [branch master] 29222aba7c110c766f752800c2f2a4a4b5b51271 Blamelist: Martin Mathieson martin.r.mathie...@googlemail.com BUILD FAILED: failed make distcheck sincerely, -The Buildbot ___ Sent via:Wireshark-commits

[Wireshark-dev] Review/testing of ESP decryption changes ?

2014-04-28 Thread Martin Mathieson
I had a look through the history of packet-ipsec.c, looking for specific people to invite to review my patch ( https://code.wireshark.org/review/#/c/1421/), but so many people have been involved I thought I'd just post to wireshark-dev. The description for the change was as follows: Add an API

Re: [Wireshark-dev] pre-commit hook issue

2014-04-27 Thread Martin Mathieson
Ha, I'm having my own problems with commit_msg, but am replying because I have some almost-ready changes that will need to reinstate packet-ipsec.h. My changes are to add a function to add an SA from another (private) dissector, and also to speed up ESP:decryption in several ways. Martin On

Re: [Wireshark-dev] Fix bug in GSM MAP, have problems with GIT

2014-03-11 Thread Martin Mathieson
I too am looking forward to seeing this. On Tue, Mar 11, 2014 at 1:08 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: On 03/08/14 04:46, Anders Broman wrote: Pascal Quantin skrev 2014-03-08 09:56: Le 08/03/2014 09:45, Anders Broman a écrit : Thanks a million Pascal, I have to try to

Re: [Wireshark-dev] snow3g dissector in violation of GPLv2+

2014-01-16 Thread Martin Mathieson
Re-reading the terms quoted by Guy, my impression is that its the algorithm rather than the reference implementation that the administrative charge gives an organisation access to, so re-implementing would not help. There are multiple algorithms for ciphering and integrity (currently 3), which

Re: [Wireshark-dev] snow3g dissector in violation of GPLv2+

2014-01-16 Thread Martin Mathieson
, but will respect the consensus this doesn't go far enough. Martin On Thu, Jan 16, 2014 at 10:30 AM, Joerg Mayer jma...@loplof.de wrote: On Thu, Jan 16, 2014 at 09:54:48AM +, Martin Mathieson wrote: Re-reading the terms quoted by Guy, my impression is that its the algorithm rather than the reference

Re: [Wireshark-dev] [Wireshark-commits] rev 54579: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2014-01-03 Thread Martin Mathieson
Thanks Pascal! Martin On Fri, Jan 3, 2014 at 12:21 PM, pas...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=54579 User: pascal Date: 2014/01/03 12:21 PM Log: EIA2 is now functional Directory: /trunk/epan/dissectors/ ChangesPath

Re: [Wireshark-dev] [Wireshark-commits] rev 54438: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2013-12-24 Thread Martin Mathieson
It might do, but the variable itself (as you changed it) should be outside of the #if HAVE_LIBGCRYPT, as we may still want to check that the expected value of 0x is found when NULL integrity is configured.Work on integrity isn't quite finished yet - hope to get it done during the holidays.

[Wireshark-dev] Is it possible to update the version of gcrypt?

2013-12-23 Thread Martin Mathieson
Hi, I would like to make use of an AES mode only available in the most recent version of gcrypt (1.6). Is it possible to upgrade the version that comes as a result of running the Windows 'setup' target? My guess is that its not easy, and that we take the version that came with an old version of

[Wireshark-dev] Is this patch to semcheck.c valid (handling FT_SYSTEM_ID) ?

2013-12-23 Thread Martin Mathieson
My gcc build is complaining that FT_SYSTEM_ID is missing from 3 switch statements. I'm not sure I properly understand how it is used, so would appreciate if someone could take a quick look at this patch? If there are no objections I will commit it later... Thanks, Martin Index: semcheck.c

[Wireshark-dev] Windows build crashing today for me

2013-12-19 Thread Martin Mathieson
Hi, My windows build (from current trunk) is crashing upon startup today, with the error This application has requested the Runtime to terminate in an unusual way. The usual steps to get rid of this, i.e. doing a 'clean', or a 'setup' and 'clean' don't make any difference. And running within

Re: [Wireshark-dev] Windows build crashing today for me

2013-12-19 Thread Martin Mathieson
: On 19 December 2013 16:00, Christopher Maynard christopher.mayn...@gtech.com wrote: Martin Mathieson martin.r.mathieson@... writes: My windows build (from current trunk) is crashing upon startup today, with the error This application has requested the Runtime to terminate in an unusual way

Re: [Wireshark-dev] [Wireshark-commits] rev 54161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2013-12-17 Thread Martin Mathieson
warnings being treated as errors On Tue, Dec 17, 2013 at 1:16 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Thanks for fixing this up, Guy, you just beat me to it. That was one commit too far before I left work. Martin On Mon, Dec 16, 2013 at 11:08 PM, g...@wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 54161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2013-12-16 Thread Martin Mathieson
Thanks for fixing this up, Guy, you just beat me to it. That was one commit too far before I left work. Martin On Mon, Dec 16, 2013 at 11:08 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=54161 User: guy Date: 2013/12/16 11:08 PM Log: Fix

Re: [Wireshark-dev] [Wireshark-commits] rev 53588: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-icmp.c

2013-11-27 Thread Martin Mathieson
Yes, I'll get to it over the next week, hopefully. Martin On Wed, Nov 27, 2013 at 9:30 AM, Alexis La Goutte alexis.lagou...@gmail.com wrote: Hi Chris, I already ask the question to Martin. And send a sample of ICMPv6 traffic to try :-) Regards, On Wed, Nov 27, 2013 at 6:05 AM,

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Martin Mathieson
PS I suspect some new heuristic dissector has been introduced, since none of the other changes from 1.8 to trunk are likely to have such a significant performance impact. I haven't checked to see when it was last changed, but I noticed a while back that SIP and HTTP were both pretty

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Martin Mathieson
You load it into kcachegrind. I found a compiled windows version on sourceforge (I think http://sourceforge.net/projects/precompiledbin/). Martin On Thu, Sep 12, 2013 at 1:54 PM, Anders Broman anders.bro...@ericsson.comwrote: -Original Message- From:

Re: [Wireshark-dev] Commit r51222 triggered a coverity message:wq

2013-08-13 Thread Martin Mathieson
Thanks, this was wrong - I submitted r51336. Martin On Tue, Aug 13, 2013 at 11:26 AM, Joerg Mayer jma...@loplof.de wrote: Hello, commit r51222 | martinm | 2013-08-08 18:56:41 +0200 (Do, 08 Aug 2013) | 1 line Apply

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX-10.5-x86

2013-08-10 Thread Martin Mathieson
Sorry, I don't understand these warning messages... On Sat, Aug 10, 2013 at 10:06 PM, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure on builder OSX-10.5-x86 while building Wireshark (development). Full details are available at:

Re: [Wireshark-dev] [Wireshark-commits] rev 51289: /trunk/wiretap/ /trunk/wiretap/: vwr.c

2013-08-10 Thread Martin Mathieson
Thanks Guy. On Sat, Aug 10, 2013 at 10:34 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=51289 User: guy Date: 2013/08/10 02:34 PM Log: Initialize float variables with float constants, not double constants, and assign float constants, not

[Wireshark-dev] Adding an optional expert field to colouring rules?

2013-08-06 Thread Martin Mathieson
Hi, I sometimes add colouring rules for some condition I am only interested in for a short time (i.e. its not worth adding expert info for to the relevant dissector). Then, I want to quickly find the frames that match that condition. I realise that I can use filtering rules such as:

[Wireshark-dev] RFC: Any reason not to do this?

2013-04-23 Thread Martin Mathieson
In a profile, I was surprised to see that 2.5% of time was spent calling dissect_sip_tcp_heur(). There are no SIP PDUs in the log. HTTP was very similar. Does the attached change look reasonable? It does a quick check for the first character being printable before trying to extract the first

Re: [Wireshark-dev] changing the time

2013-01-31 Thread Martin Mathieson
I don't know if overriding the time is a good idea - but I'm not sure what would go wrong. You can add any field as a column by right-clicking on the field and choosing 'Apply as Column'. I do this with the log files my company uses - we have a timestamp field in our file format that ends up

Re: [Wireshark-dev] [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c

2013-01-14 Thread Martin Mathieson
On Mon, Jan 14, 2013 at 4:28 AM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=47059 User: wmeier Date: 2013/01/13 08:28 PM Log: Cleanup: Whitespace, formatting-style, long-lines etc. Use 4 space indentation. Add an XXX comment about

Re: [Wireshark-dev] FW: [Wireshark-commits] rev 46479: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-per.c

2012-12-09 Thread Martin Mathieson
Maybe. I'm guessing we'd probably want to improve decode_bits_in_field() to avoid those g_strlcat() calls by keeping track of the offset. Martin On Sun, Dec 9, 2012 at 11:07 AM, Anders Broman anders.bro...@ericsson.comwrote: Hi, Would using proto_tree_add_bits_item() be less efficient?

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-26 Thread Martin Mathieson
Alex, do you still see crashes when switching graph type? Martin Hi Martin, sorry, my HD died and I had to resetup my whole computer. Now the crashes disappeared. What was the issue? Cheers Alex For that graph type, we add an element to display for every single segment or ACK,

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-24 Thread Martin Mathieson
On Tue, Nov 20, 2012 at 12:17 PM, Jim Young jyo...@gsu.edu wrote: Hello Martin, On 11/20/12 9:12 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Alex, do you still see crashes when switching graph type? Martin I'm not trying to answer for Alex, but I also saw the crashes

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-20 Thread Martin Mathieson
On Sun, Nov 18, 2012 at 2:54 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: On Sun, Nov 18, 2012 at 2:09 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: On Sun, Nov 18, 2012 at 1:50 PM, Alexander Koeppe forma...@online.dewrote: Am 14.11.2012 15:53, schrieb

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-18 Thread Martin Mathieson
On Sun, Nov 18, 2012 at 1:50 PM, Alexander Koeppe forma...@online.dewrote: Am 14.11.2012 15:53, schrieb Martin Mathieson: On Wed, Nov 14, 2012 at 3:54 AM, Cristian Constantin const.cr...@googlemail.com mailto:const.cr...@googlemail.com wrote: On Tue, Nov 13, 2012 at 9:15 PM

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-18 Thread Martin Mathieson
On Sun, Nov 18, 2012 at 2:09 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: On Sun, Nov 18, 2012 at 1:50 PM, Alexander Koeppe forma...@online.dewrote: Am 14.11.2012 15:53, schrieb Martin Mathieson: On Wed, Nov 14, 2012 at 3:54 AM, Cristian Constantin const.cr

Re: [Wireshark-dev] tcp graphs vs. sctp graphs

2012-11-12 Thread Martin Mathieson
On Mon, Nov 12, 2012 at 9:11 AM, Cristian Constantin const.cr...@googlemail.com wrote: On Mon, Nov 12, 2012 at 2:35 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi Cristian, a couple of comments in-line below. Martin On Mon, Nov 12, 2012 at 5:41 AM, Cristian

Re: [Wireshark-dev] [Wireshark-commits] rev 46002: /trunk/ /trunk/ui/gtk/: conversations_table.c

2012-11-11 Thread Martin Mathieson
Thanks, you beat me by a few seconds! Mine was very similar... I will let your version stand. Martin On Sun, Nov 11, 2012 at 2:16 PM, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=46002 User: eapache Date: 2012/11/11 11:16 AM Log: Fix

Re: [Wireshark-dev] GTK - draw a box

2012-10-29 Thread Martin Mathieson
On Mon, Oct 29, 2012 at 10:07 PM, Edwin Groothuis edwin.grooth...@riverbed.com wrote: Hello, In bug 7931 I have a patch to be able to zoom in into a TCP Graph (tcptrace or stevens) by just marking a rectangle in the graph. It all works fine but there is one thing which I can't make: The

Re: [Wireshark-dev] RFD: Limiting scope of ep_ memory

2012-10-14 Thread Martin Mathieson
On Sun, Oct 14, 2012 at 10:20 PM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Fri, Oct 12, 2012 at 02:02:53PM +, Anders Broman wrote: Why not make a patch that developers can try out and start debugging? Attached. PS. I'd rather want to hear comments, rather than debugging... I

Re: [Wireshark-dev] Building for Windows without zlib?

2012-10-13 Thread Martin Mathieson
On Fri, Sep 28, 2012 at 3:47 PM, robert.bul...@usbank.com wrote: I build Wireshark for Windows without zlib. It works faster, but I think that is more the result of consuming less memory than an actual speed increase. In addition, it allows files larger than 2 GB to be read (at least that

[Wireshark-dev] Crash in trunk today whenever I open a subtree

2012-10-11 Thread Martin Mathieson
Things were running well yesterday after the emem.c changes, but today I can't open up any protocol trees. When I do, I always get the stack trace below. Martin wireshark:13250): GLib-GObject-CRITICAL **: g_object_get_data: assertion `G_IS_OBJECT (object)' failed **

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7814] Buildbot crash output: fuzz-2012-10-08-21623.pcap

2012-10-10 Thread Martin Mathieson
On Wed, Oct 10, 2012 at 5:19 AM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Tue, Oct 09, 2012 at 10:53:41PM -0400, Martin Mathieson wrote: I am getting the same assertion, for every file that I try reload/refilter. Can you get errno number for me? 12 (Cannot Allocate Memory

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7814] Buildbot crash output: fuzz-2012-10-08-21623.pcap

2012-10-10 Thread Martin Mathieson
I have discovered one problem since the change, but it may have been a bug all along. In tcp_graph.c, it was referencing the tap (struct tcpheader) after the tap had run. The struct is allocated in packet-tcp.c using ep_alloc(), but now it wasn't valid to access that memory (immediately after

Re: [Wireshark-dev] WARNING **: Too many taps queued

2012-10-10 Thread Martin Mathieson
On Wed, Oct 10, 2012 at 9:41 PM, Jaap Keuter jaap.keu...@xs4all.nl wrote: On 10/10/2012 03:48 PM, mman...@netscape.net wrote: I ran some fuzztesting overnight (on a 32-bit WinXP VM, off of trunk), and when I checked on it this morning, I had WARNING **: Too many taps queued so many times,

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 7814] Buildbot crash output: fuzz-2012-10-08-21623.pcap

2012-10-09 Thread Martin Mathieson
I am getting the same assertion, for every file that I try reload/refilter. Is there a fix in the works? In the meantime, could someone advise which files to rollback to which versions so that trunk is again usable? Thanks, Martin On Tue, Oct 9, 2012 at 10:14 PM, bugzilla-dae...@wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 45313: /trunk/ /trunk/doc/: reordercap.pod /trunk/: reordercap.c

2012-10-05 Thread Martin Mathieson
On Fri, Oct 5, 2012 at 1:25 PM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Fri, Oct 05, 2012 at 06:11:02PM +0200, Joerg Mayer wrote: On Thu, Oct 04, 2012 at 06:24:22PM +, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=45313

Re: [Wireshark-dev] [Wireshark-commits] rev 45313: /trunk/ /trunk/doc/: reordercap.pod /trunk/: reordercap.c

2012-10-05 Thread Martin Mathieson
On Fri, Oct 5, 2012 at 6:43 PM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Fri, Oct 05, 2012 at 01:36:58PM -0400, Martin Mathieson wrote: I think Joerg might have meant that adding a man page makes it look more final that it will not be integrated? If it's true, than r45282 should

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu-12.04-x64

2012-10-03 Thread Martin Mathieson
On Wed, Oct 3, 2012 at 8:45 AM, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure on builder Ubuntu-12.04-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Ubuntu-12.04-x64/builds/2045

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu-12.04-x64

2012-10-03 Thread Martin Mathieson
On Wed, Oct 3, 2012 at 9:39 AM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Wed, Oct 03, 2012 at 09:00:49AM -0400, Martin Mathieson wrote: I can't see what's wrong here... Might be fixed in r45284 ___ Hopefully

[Wireshark-dev] Building for Windows without zlib?

2012-09-27 Thread Martin Mathieson
Hi, At one stage, building without zlib support meant that opening/reading files was much faster than with. On this machine, the performance under Windows is much worse than under linux, so I wanted to try doing a windows build in this way. There are 2 places in config.nmake that let you

Re: [Wireshark-dev] Reordering capture files

2012-09-19 Thread Martin Mathieson
, 2012 at 11:02 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: I think I will write a separate wiretap console app (tonight, if I get carried away). My log files tend to be long (100s MB), so I don't think a script such as yours would work well for me. Ultimately it would

Re: [Wireshark-dev] r45005: changes in proto_item_append_string()

2012-09-19 Thread Martin Mathieson
Hi, Sorry about that. I had no idea that the old function could change the value behind a filter - should have been more careful (especially when I noticed that packet-frame.c was also using it...). Maybe I could create and use a new function such as proto_item_append_literal_text() I will be

Re: [Wireshark-dev] r45005: changes in proto_item_append_string()

2012-09-19 Thread Martin Mathieson
Reverted now. On Wed, Sep 19, 2012 at 9:34 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi, Sorry about that. I had no idea that the old function could change the value behind a filter - should have been more careful (especially when I noticed that packet-frame.c was also

[Wireshark-dev] Reordering capture files

2012-09-17 Thread Martin Mathieson
Hi, I work with log files that are created from multiple sources, and although the timestamps are in good synchronisation, they are often written to the log file slightly out of order (up to a few milliseconds). editcap -S supports rewriting the timestamps to be in strict chronological order

Re: [Wireshark-dev] Reordering capture files

2012-09-17 Thread Martin Mathieson
, Jim Y. On 9/17/12 9:21 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi, I work with log files that are created from multiple sources, and although the timestamps are in good synchronisation, they are often written to the log file slightly out of order (up to a few

Re: [Wireshark-dev] [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c

2012-08-07 Thread Martin Mathieson
On Tue, Aug 7, 2012 at 7:16 PM, Joerg Mayer jma...@loplof.de wrote: On Tue, Aug 07, 2012 at 11:04:48PM +, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=44316 User: martinm Date: 2012/08/07 04:04 PM Log: Do the cross like it is in

Re: [Wireshark-dev] packet-rlc.c changes

2012-08-03 Thread Martin Mathieson
this part. Martin Mathieson might have some dct2000 captures so as to check that everything is still working as expected. I do not have any myself, so we will have to rely on someone else to confirm that it is still working as expected ;) Yes I'm not sure anyone is using that support

Re: [Wireshark-dev] Fuzz testing with valgrind

2012-07-25 Thread Martin Mathieson
On Wed, Jul 25, 2012 at 6:12 PM, Evan Huus eapa...@gmail.com wrote: I've been playing around in my head for a while now with the idea of running fuzz tests under valgrind. I notice the fuzz-test script already sets a bunch of environment variables for memory checking, so I'm not sure if

Re: [Wireshark-dev] [Wireshark-commits] rev 43908: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ftp.c

2012-07-23 Thread Martin Mathieson
to remove ftp_data_tree = proto_item_add_subtree(ti, ett_ftp_data);, it is no longer use ! Also why use ftp and ftp-data, it is not better to use a ftp.data (filter) ? (and known ftp and ftp-data is not the same protocol...) Alexis On Mon, Jul 23, 2012 at 3:42 AM, Martin Mathieson

Re: [Wireshark-dev] [Wireshark-commits] rev 43908: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ftp.c

2012-07-22 Thread Martin Mathieson
I think I'd like to change it to what the attached patch does. i.e. have a quick look to see if the first few characters are printable. - if yes, show the string (but as before not formatting more text than will be used) - if no, just add the details of how many bytes are in the segment In both

Re: [Wireshark-dev] [Wireshark-commits] rev 43654: /trunk/ui/gtk/ /trunk/ui/gtk/: rlc_lte_graph.c

2012-07-15 Thread Martin Mathieson
On Thu, Jul 12, 2012 at 9:46 PM, Guy Harris g...@alum.mit.edu wrote: On Jul 10, 2012, at 7:43 PM, mart...@wireshark.org wrote: Note that both of these improvements would also apply to tcp_graph.c - will wait a couple of days to be sure the changes are good. To what extent could code be

[Wireshark-dev] [RFC] A patch to set TCP window scaling when options weren't captured

2012-07-04 Thread Martin Mathieson
This was discussed a little bit at Sharkfest. I often need to analyse TCP streams where I only see part of a very long TCP session, not including the initial options where window scaling was set (but where I know the scaling because of other, very similar runs). Without knowing the proper

Re: [Wireshark-dev] [Wireshark-commits] rev 42468: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rlc-lte.c

2012-05-07 Thread Martin Mathieson
Sorry Guy, I just added it to the header file. Shall I revert? Martin On Mon, May 7, 2012 at 6:04 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=42468 User: guy Date: 2012/05/07 10:04 AM Log: packet-umts_fp.h now requires

Re: [Wireshark-dev] [Wireshark-commits] rev 42468: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rlc-lte.c

2012-05-07 Thread Martin Mathieson
On Mon, May 7, 2012 at 6:25 PM, Guy Harris g...@alum.mit.edu wrote: On May 7, 2012, at 10:13 AM, Martin Mathieson wrote: Sorry Guy, I just added it to the header file. Shall I revert? Actually, according to SVN, you didn't, you removed it from the .c file: Oh dear. I must have done

Re: [Wireshark-dev] [Wireshark-commits] rev 42468: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rlc-lte.c

2012-05-07 Thread Martin Mathieson
On Mon, May 7, 2012 at 6:36 PM, Guy Harris g...@alum.mit.edu wrote: On May 7, 2012, at 10:33 AM, Martin Mathieson wrote: I will do it in the .c files. One reason might be that someone might include that header file in their own project and doesn't want to have to have the wireshark folder

Re: [Wireshark-dev] dynamic generation of dissector

2012-05-02 Thread Martin Mathieson
There are dissectors such as Diameter that get some of their information from configuration files. It parses XML files to build up entries it knows about and dynamically registers items based up the names and types of items it finds there. It then looks up and uses those items while dissecting.

Re: [Wireshark-dev] [Wireshark-commits] rev 42038: /trunk/ui/gtk/ /trunk/ui/gtk/: main_proto_draw.c

2012-04-12 Thread Martin Mathieson
That does look better. I knew there must be a better way :) On Thu, Apr 12, 2012 at 5:56 PM, darkja...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=42038 User: darkjames Date: 2012/04/12 02:56 PM Log: Simplify r42030 expression. Thanks!

Re: [Wireshark-dev] [Patch, RFC] to TCP Sequence Analysis

2012-03-24 Thread Martin Mathieson
On Sat, Mar 24, 2012 at 3:39 AM, Guy Harris g...@alum.mit.edu wrote: On Mar 23, 2012, at 6:11 PM, Martin Mathieson wrote: I'm now needing to analyse TCP conversations carried over LTE MAC/RLC/PDCP/IP. So one frame in a log or capture can hold many segments of the same TCP conversation

[Wireshark-dev] [Patch, RFC] to TCP Sequence Analysis

2012-03-23 Thread Martin Mathieson
Hi, I'm now needing to analyse TCP conversations carried over LTE MAC/RLC/PDCP/IP. So one frame in a log or capture can hold many segments of the same TCP conversation. The current implementation for TCP analysis is that there is a tcp_analysis struct for each conversation. Within that struct

Re: [Wireshark-dev] Defining a DLT which could be used to dissect any protocol.

2012-02-07 Thread Martin Mathieson
Isn't this similar (but more general) to what packet-meta.c does - although probably that one is tailored to what Tobias has needed? Martin On Tue, Feb 7, 2012 at 2:33 PM, Anders Broman anders.bro...@ericsson.comwrote: Hi, How about defining a DLT with a TLV based header which could be used

Re: [Wireshark-dev] [Wireshark-commits] rev 40275: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rlc.c

2011-12-22 Thread Martin Mathieson
On Thu, Dec 22, 2011 at 2:49 PM, cmayn...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=40275 aspell and my own spelling preferences do not always agree with the spelling variations used by folks across the pond. Revert a couple of spelling changes.

Re: [Wireshark-dev] Recent buildbot failure capture_dlg.c:802: warning: 'insert_new_rows' defined but not used

2011-11-30 Thread Martin Mathieson
Hi Anders, I hadn't seen your email, the fix I submitted was different. It seems that (despite its general-sounding name) the insert_new_rows() is only used now with remote capturing. On Wed, Nov 30, 2011 at 9:33 AM, Anders Broman anders.bro...@ericsson.comwrote: Possible fix

Re: [Wireshark-dev] Some questions about licensing/core

2011-11-25 Thread Martin Mathieson
Hi, You could consider adding a dissector preference that controlled how much detail should be displayed, with a sensible default setting. Regards, Martin On Fri, Nov 25, 2011 at 2:30 PM, Teto matta...@gmail.com wrote: Thanks for that answer. I will propose a patch to add energywise

Re: [Wireshark-dev] [Wireshark-commits] rev 39731: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-catapult-dct2000.c

2011-11-04 Thread Martin Mathieson
Oops, thanks! On Fri, Nov 4, 2011 at 1:41 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=39731 User: morriss Date: 2011/11/04 06:41 AM Log: Terminate a value_string. Directory: /trunk/epan/dissectors/ ChangesPath

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Martin Mathieson
On Fri, Oct 14, 2011 at 12:11 PM, Guy Harris g...@alum.mit.edu wrote: On Oct 14, 2011, at 4:03 AM, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=39422 User: martinm Date: 2011/10/14 04:03 AM Log: make_menu_items() isn't called

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Martin Mathieson
On Fri, Oct 14, 2011 at 4:37 PM, Tony Trinh ton...@gmail.com wrote: Hi Martin/Anders, Actually, the valid #define for Lua code throughout Wireshark is HAVE_LUA_5_1 (not HAVE_LUA). HAVE_LUA works in Windows but not other OS's (such as OSX). But I do like HAVE_LUA better than a

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

2011-10-12 Thread Martin Mathieson
On Wed, Oct 12, 2011 at 6:42 PM, Guy Harris g...@alum.mit.edu wrote: (Paging LTE experts here) On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=39384 User: wmeier Date: 2011/10/12 08:02 AM Log: Fix a

Re: [Wireshark-dev] [Wireshark-commits] rev 39305: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sdp.c

2011-10-11 Thread Martin Mathieson
On Tue, Oct 11, 2011 at 6:30 PM, Stephen Fisher st...@stephen-fisher.comwrote: On Mon, Oct 10, 2011 at 11:13:41AM +0100, Martin Mathieson wrote: packet-sdp.c:1302 'data_tvb' might get clobbered by 'longjmp' or 'vfork' Making 'data_tvb' volatile doesn't work as I then get warnings about

Re: [Wireshark-dev] [Wireshark-commits] rev 39305: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sdp.c

2011-10-10 Thread Martin Mathieson
This is giving me a warning packet-sdp.c:1302 'data_tvb' might get clobbered by 'longjmp' or 'vfork' Making 'data_tvb' volatile doesn't work as I then get warnings about discarding the volatile qualifier by passing data_tvb to the various sub-dissectors. I've never been sure of the best way to

Re: [Wireshark-dev] catching [Malformed Packet]

2011-09-24 Thread Martin Mathieson
On Sat, Sep 24, 2011 at 8:55 PM, Roland Knall rkn...@gmail.com wrote: On Sat, Sep 24, 2011 at 9:09 PM, Guy Harris g...@alum.mit.edu wrote: On Sep 24, 2011, at 9:58 AM, Chris Maynard wrote: Roland Knall rknall@... writes: On a similar topic, how can you mark a package as malformed?

Re: [Wireshark-dev] [Wireshark-commits] rev 39045: /trunk/ /trunk/: tap-expert.c

2011-09-19 Thread Martin Mathieson
On Mon, Sep 19, 2011 at 7:03 PM, Bill Meier wme...@newsguy.com wrote: On 9/19/2011 1:41 PM, Bill Meier wrote: On 9/19/2011 9:53 AM, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/**viewvc/viewvc.cgi?view=rev**

[Wireshark-dev] Extracting expert info using tshark

2011-09-14 Thread Martin Mathieson
Hi, I'd like to be able to extract the information that Wireshark shows in the 'Expert Info Composite' window using tshark, i.e. list each category (error, warning, note, chat) as a separate section - not sure if I'd want to sort them within the section or just leave it chronological... It

Re: [Wireshark-dev] Extracting expert info using tshark

2011-09-14 Thread Martin Mathieson
On Wed, Sep 14, 2011 at 11:17 AM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi, I'd like to be able to extract the information that Wireshark shows in the 'Expert Info Composite' window using tshark, i.e. list each category (error, warning, note, chat) as a separate section

Re: [Wireshark-dev] Fwd: [FOSDEM] Dates for FOSDEM 2012: 4 5 February

2011-09-13 Thread Martin Mathieson
On Mon, Sep 12, 2011 at 6:53 PM, Gerald Combs ger...@wireshark.org wrote: Would anyone be interested in meeting at FOSDEM in February for a Wireshark Bug Day? As I recall, someone suggested this at Sharkfest. I am interested. How would a Wireshark Bug Day work? Martin

Re: [Wireshark-dev] [Wireshark-commits] rev 38734: /trunk/gtk/ /trunk/gtk/: mac_lte_stat_dlg.c rlc_lte_stat_dlg.c

2011-08-25 Thread Martin Mathieson
I was trying to work out why RLC appears under Telephony | LTE but MAC doesn't. I can see that register_tap_listener_mac_lte_stat() is being called... I've seen this in my Windows and Linux builds. Under Linux MAIN_MENU_USE_UIMANAGER is defined. Any ideas? Martin On Thu, Aug 25, 2011 at 3:15

Re: [Wireshark-dev] [Wireshark-commits] rev 38734: /trunk/gtk/ /trunk/gtk/: mac_lte_stat_dlg.c rlc_lte_stat_dlg.c

2011-08-25 Thread Martin Mathieson
-- *From:* wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] *On Behalf Of *Martin Mathieson *Sent:* den 25 augusti 2011 16:20 *To:* wireshark-dev@wireshark.org *Subject:* Re: [Wireshark-dev] [Wireshark-commits] rev 38734: /trunk/gtk

Re: [Wireshark-dev] [Wireshark-commits] rev 38665: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-08-22 Thread Martin Mathieson
Hi, Compilation of this file still fails for me. main_menubar.c: In function `menu_open_recent_file_cmd': main_menubar.c:3752: warning: implicit declaration of function `gtk_action_get_label' main_menubar.c:3752: warning: assignment makes pointer from integer without a cast main_menubar.c: At

Re: [Wireshark-dev] [Wireshark-commits] rev 38155: /trunk/ /trunk/: editcap.c

2011-07-22 Thread Martin Mathieson
Thanks Jeff. On Thu, Jul 21, 2011 at 10:19 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=38155 User: morriss Date: 2011/07/21 02:19 PM Log: Remove the snaplen check added in r37633: the change in r37634 makes it unnecessary.

[Wireshark-dev] Is snaplen check in editcap.c correct?

2011-07-19 Thread Martin Mathieson
Hi, I'm using editcap with Catapult DCT2000 log files. The wiretap module doesn't set wth-snapshot_len, so its coming out as 0. It was intentionally left as 0, as I thought this corresponded to we have the whole frame, its not truncated. Most other wiretap modules seem to do the same.

Re: [Wireshark-dev] [Wireshark-commits] rev 38112: /trunk/gtk/ /trunk/gtk/: menus.c new_packet_list.c profile_dlg.c sip_stat.c uat_gui.c

2011-07-19 Thread Martin Mathieson
Also, gtk_table_get_size() was only introduced in gtk 2.22 Martin 2011/7/19 Stig Bjørlykke s...@bjorlykke.org On Tue, Jul 19, 2011 at 5:13 PM, jma...@wireshark.org wrote: Log: Fix access to the following stuctures: GtkCheckMenuItem GtkTable GtkTreeViewColumn Did you test all

Re: [Wireshark-dev] [Wireshark-commits] rev 38118: /trunk/gtk/ /trunk/gtk/: rlc_lte_stat_dlg.c

2011-07-19 Thread Martin Mathieson
[I thought I'd sent this, seems that it was still draft...] Hi Joerg, I don't see why you would get an error, I presume with the new BCH channel tags? They are updated in epan/dissectors/packet-rlc-lte.h, which is included by this file. It built for me under Linux anyway... Martin On Tue, Jul

[Wireshark-dev] gtk/main_welcome.c using gtk_cell_renderer_set_visible() (gtk 2.18)

2011-07-07 Thread Martin Mathieson
Hi, My build is broken because of this, for now we seem to still support gtk 2.4 in configure.in Best regards, Martin ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:

Re: [Wireshark-dev] lte rrc wiki screenshot

2011-06-18 Thread Martin Mathieson
On Wed, Jun 15, 2011 at 5:35 PM, Jin He jinn...@gmail.com wrote: Hi there Does the screenshot on lte rrc wireshark wiki http://wiki.wireshark .org/LTE%20RRC come from standard build of wireshark? If so, what's the format we need to use? Cheers, - Jin Hi Jin, I just updated that page

<    1   2   3   4   >