Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? On Mon, Aug 18, 2014 at 3:44 PM, Wireshark code review code-review-do-not-re...@wireshark.org wrote: URL:

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Guy Harris
On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? No, and not exactly. I have my regression script, which I was using to

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? No,

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Jeff Morriss
On 08/18/14 16:45, Evan Huus wrote: On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just

Re: [Wireshark-dev] [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.

2014-08-18 Thread Evan Huus
On Mon, Aug 18, 2014 at 5:06 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 08/18/14 16:45, Evan Huus wrote: On Mon, Aug 18, 2014 at 4:31 PM, Guy Harris g...@alum.mit.edu wrote: On Aug 18, 2014, at 12:46 PM, Evan Huus eapa...@gmail.com wrote: Guy, how are you finding these last four