Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Ulf Lamping
Guy Harris schrieb: On Jun 21, 2009, at 1:03 PM, Ulf Lamping wrote: g...@wireshark.org schrieb: http://anonsvn.wireshark.org/viewvc/viewvc.cgi? view=revrevision=28794 User: guy Date: 2009/06/21 12:16 PM Log: main_menu.[ch] - menus.[ch]; it handles not only the main menu, but

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Guy Harris
On Jun 21, 2009, at 11:53 PM, Ulf Lamping wrote: I don't know if main_window_menus.[ch] or simply main_menus.[ch] might be better (although I would prefer main_menus). But giving up the main_ prefix just as you didn't notice it is, well, a step in the wrong direction IMHO. A main_ prefix

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Ulf Lamping
Guy Harris schrieb: On Jun 21, 2009, at 11:53 PM, Ulf Lamping wrote: But what are you trying to achieve? Being able to find files that implement more than main things, whether it's the main menu or the main window. What I've tried to point out is that having less prefixes makes it

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Guy Harris
On Jun 22, 2009, at 1:41 AM, Ulf Lamping wrote: Now you're telling me that file name in question is not 100% correct so you're changing it back into the chaos we once had - ignoring the benefits we could get from the name prefixes.f I'm unconvinced that, for that *particular* file,

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Ulf Lamping
Guy Harris schrieb: On Jun 22, 2009, at 1:41 AM, Ulf Lamping wrote: Now you're telling me that file name in question is not 100% correct so you're changing it back into the chaos we once had - ignoring the benefits we could get from the name prefixes.f I'm unconvinced that, for that

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Guy Harris
On Jun 22, 2009, at 12:03 PM, Ulf Lamping wrote: Reading this, I'm unconvinced that you even understand the problem I tried to solve. If the problem was that the names of source files made it harder to find the source code for particular parts of the UI, then your attempt at a solution

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Sake Blok
On Mon, Jun 22, 2009 at 09:03:14PM +0200, Ulf Lamping wrote: Guy Harris schrieb: On Jun 22, 2009, at 1:41 AM, Ulf Lamping wrote: Now you're telling me that file name in question is not 100% correct so you're changing it back into the chaos we once had - ignoring the benefits we

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-22 Thread Guy Harris
On Jun 22, 2009, at 2:31 PM, Sake Blok wrote: Lets define categories of code first and then make a team effort to split up the source files and consolidate the code belonging to one category into new files, either in subdirectories or files with a category prefix. Does that sound like a

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-21 Thread Ulf Lamping
g...@wireshark.org schrieb: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=28794 User: guy Date: 2009/06/21 12:16 PM Log: main_menu.[ch] - menus.[ch]; it handles not only the main menu, but context menus. Which menus that are not part of the main window does it

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-21 Thread Guy Harris
On Jun 21, 2009, at 1:03 PM, Ulf Lamping wrote: g...@wireshark.org schrieb: http://anonsvn.wireshark.org/viewvc/viewvc.cgi? view=revrevision=28794 User: guy Date: 2009/06/21 12:16 PM Log: main_menu.[ch] - menus.[ch]; it handles not only the main menu, but context menus. Which

Re: [Wireshark-dev] [Wireshark-commits] rev 28794: /trunk/gtk/ /trunk/gtk/: Makefile.common capture_dlg.c capture_file_dlg.c drag_and_drop.c file_dlg_win32.c fileset_dlg.c main.c main.h main_filter_to

2009-06-21 Thread Guy Harris
On Jun 21, 2009, at 1:57 PM, Guy Harris wrote: The menus in question might be part of the main *window*, but they're not the main (menu bar) menu. As such, if we want to emphasize that they're menus for the main window, perhaps main_window_menu.[ch] or main_window_menus.[ch] would be