Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread João Valverde
On 15/05/20 23:46, Richard Sharpe wrote: On Fri, May 15, 2020 at 3:33 PM Peter Wu wrote: The "asn1" target rebuilds all asn1 dissectors. Alternatively to rebuild a specific one, use a target such as "generate_dissector-pkcs1". Sure, but there seems to be multiple issues. 1. The

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread Pascal Quantin
Le sam. 16 mai 2020 à 23:01, Richard Sharpe a écrit : > On Sat, May 16, 2020 at 8:51 AM Pascal Quantin > wrote: > > > > Hi Richard, > > > > Le sam. 16 mai 2020 à 17:34, Richard Sharpe > a écrit : > >> > >> On Sat, May 16, 2020 at 6:00 AM João Valverde > >> wrote: > >> > > >> > Hi Richard, >

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread Richard Sharpe
On Sat, May 16, 2020 at 8:51 AM Pascal Quantin wrote: > > Hi Richard, > > Le sam. 16 mai 2020 à 17:34, Richard Sharpe a > écrit : >> >> On Sat, May 16, 2020 at 6:00 AM João Valverde >> wrote: >> > >> > Hi Richard, >> > >> > On 15/05/20 23:46, Richard Sharpe wrote: >> > > On Fri, May 15, 2020

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread Pascal Quantin
Hi Richard, Le sam. 16 mai 2020 à 17:34, Richard Sharpe a écrit : > On Sat, May 16, 2020 at 6:00 AM João Valverde > wrote: > > > > Hi Richard, > > > > On 15/05/20 23:46, Richard Sharpe wrote: > > > On Fri, May 15, 2020 at 3:33 PM Peter Wu wrote: > > >> The "asn1" target rebuilds all asn1

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread Richard Sharpe
On Sat, May 16, 2020 at 6:00 AM João Valverde wrote: > > Hi Richard, > > On 15/05/20 23:46, Richard Sharpe wrote: > > On Fri, May 15, 2020 at 3:33 PM Peter Wu wrote: > >> The "asn1" target rebuilds all asn1 dissectors. > >> Alternatively to rebuild a specific one, use a target such as > >>

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-16 Thread João Valverde
Hi Richard, On 15/05/20 23:46, Richard Sharpe wrote: On Fri, May 15, 2020 at 3:33 PM Peter Wu wrote: The "asn1" target rebuilds all asn1 dissectors. Alternatively to rebuild a specific one, use a target such as "generate_dissector-pkcs1". Sure, but there seems to be multiple issues. 1. The

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Richard Sharpe
On Fri, May 15, 2020 at 3:33 PM Peter Wu wrote: > > The "asn1" target rebuilds all asn1 dissectors. > Alternatively to rebuild a specific one, use a target such as > "generate_dissector-pkcs1". Sure, but there seems to be multiple issues. 1. The 'documented' command placed in the generated

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Peter Wu
The "asn1" target rebuilds all asn1 dissectors. Alternatively to rebuild a specific one, use a target such as "generate_dissector-pkcs1". Example: mkdir build cd build cmake .. cmake --build . --target generate_dissector-pkcs1 Or if you use ninja: mkdir build cd build

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Richard Sharpe
On Fri, May 15, 2020 at 2:29 PM Richard Sharpe wrote: > > On Fri, May 15, 2020 at 2:30 PM Peter Wu wrote: > > > > Hi Richard, > > > > On Fri, May 08, 2020 at 08:54:58AM -0700, Richard Sharpe wrote: > > [..] > > > It doesn't look like it was manually modified. The last person who > > > touched

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Richard Sharpe
On Fri, May 15, 2020 at 2:30 PM Peter Wu wrote: > > Hi Richard, > > On Fri, May 08, 2020 at 08:54:58AM -0700, Richard Sharpe wrote: > [..] > > It doesn't look like it was manually modified. The last person who > > touched that file was Peter Wu, it seems, so maybe he can shed some > > light on

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-15 Thread Peter Wu
Hi Richard, On Fri, May 08, 2020 at 08:54:58AM -0700, Richard Sharpe wrote: [..] > It doesn't look like it was manually modified. The last person who > touched that file was Peter Wu, it seems, so maybe he can shed some > light on it. How did you invoke asn2wrs.py? If I run the asn1 ninja/make

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-08 Thread Richard Sharpe
On Fri, May 8, 2020 at 8:43 AM Pascal Quantin wrote: > > Hi Richard, It doesn't look like it was manually modified. The last person who touched that file was Peter Wu, it seems, so maybe he can shed some light on it. > Le ven. 8 mai 2020 à 17:08, Richard Sharpe a > écrit : >> >> Hi folks, >>

Re: [Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-08 Thread Pascal Quantin
Hi Richard, Le ven. 8 mai 2020 à 17:08, Richard Sharpe a écrit : > Hi folks, > > While figuring out how to get a dissection function for > ECDSA_Sig_Value, I noticed that asn2wrs.py no longer generates the > same code it once did. > > I re-ran asn2wrs.py against

[Wireshark-dev] asn2wrs.py no longer seems to generate the same code ...

2020-05-08 Thread Richard Sharpe
Hi folks, While figuring out how to get a dissection function for ECDSA_Sig_Value, I noticed that asn2wrs.py no longer generates the same code it once did. I re-ran asn2wrs.py against epan/dissectors/asn1/pkcs1/pkcs1.cnf (unmodified) and then compared the current output to what is checked in.