Re: [Wireshark-dev] how to include a head file

2014-03-28 Thread Peter Wu
On Friday 28 March 2014 13:10:09 我想不无聊 wrote: then I add the file to /gtk/main.c file , #include peformance.h //somebody told me not to use ../peformance.h because there is subdir to search Well, I was that somebody and refused to reply on the last private mail because you provided *no*

[Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Hadriel Kaplan
Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with 5.1. There's very little difference to end users (i.e., older scripts should continue to work)... but for the C-code it's a lot more painful to have to

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Evan Huus
If 5.2 has been out for three years at this point it sounds fine to me. On Fri, Mar 28, 2014 at 10:29 AM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Graham Bloice
Hi Pavel, Can you use the revised workflow and submit the change to Gerrit. Any discussion on the proposed change will take place in the Gerrit Review process. Workflow info can be found here: http://wiki.wireshark.org/Development/Workflow On 28 March 2014 15:06, Pavel Karneliuk

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Pascal Quantin
2014-03-28 16:02 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: +1 The Debian packages use Lua since 1.10.2-2 without any problem. Cheers, Balint 2014-03-28 15:45 GMT+01:00 Nakayama Kenjiro nakayamakenj...@gmail.com: +1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan

[Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
Hello, At first, thank you all for Wireshark. It is amazing tool! I found a defect and register Bug 9936https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9936 - epan/follow.c - Incorrect comparing a sequence number of TCP fragment when its value wraps over uint32_t limit A capture file and

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
Hi Pascal, thank you for answer. I saw your commits to follow.c and I hoped for your reply. 450:if( newseq seq[idx] ) { I think - Yes. It compares sequence numbers. 459: if ( current-data_len new_pos ) { I am sure, that - No. Because it compares length of data from fragment instead of

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Pascal Quantin
2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What do you mean by we have a 5.2.1 library for Windows but not a 5.2.3 one? Do you

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pascal Quantin
2014-03-28 16:06 GMT+01:00 Pavel Karneliuk pavel_karnel...@epam.com: Hello, At first, thank you all for Wireshark. It is amazing tool! I found a defect and register Bug 9936https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9936- epan/follow.c - Incorrect comparing a sequence number

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Hadriel Kaplan
The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What do you mean by we have a 5.2.1 library for Windows but not a 5.2.3 one? Do you mean from some pre-built binary repository somewhere? -hadriel On Mar 28,

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
Yes, I am going to gerrit. From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Pascal Quantin Sent: Friday, March 28, 2014 6:57 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Hadriel Kaplan
BTW, to answer your question directly, no I don't think it's a big deal if you only run 5.2.1. The bugs fixed in 5.2.2 were pretty esoteric, and even more so those fixed in 5.2.3. FWIW, I use Lua 5.2.1 on my Mac all the time (because MacPorts hasn't updated their Lua installer to 5.2.3 yet,

[Wireshark-dev] Gerrit Diff format

2014-03-28 Thread Bill Meier
(To: Gerald) Currently the Gerrit diff shows whitespace changes. Previously, when viewing diffs of SVN commits via the web, whitespace changes were not shown. If others agree, is it possible to configure the Gerrit diff to not show whitespace changes ? (Or to provide an option ?) Bill

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Nakayama Kenjiro
+1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan hadriel.kap...@oracle.comwrote: Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with 5.1. There's very little difference to end users (i.e., older

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Bálint Réczey
+1 The Debian packages use Lua since 1.10.2-2 without any problem. Cheers, Balint 2014-03-28 15:45 GMT+01:00 Nakayama Kenjiro nakayamakenj...@gmail.com: +1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Howdy, Is there any reason not to make wireshark

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pascal Quantin
Le 28 mars 2014 16:52, Pavel Karneliuk pavel_karnel...@epam.com a écrit : Hi Pascal, thank you for answer. I saw your commits to follow.c and I hoped for your reply. 450:if( newseq seq[idx] ) { I think - Yes. It compares sequence numbers. 459: if ( current-data_len new_pos ) { I am

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Hadriel Kaplan
On Mar 28, 2014, at 11:42 AM, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What

[Wireshark-dev] (no subject)

2014-03-28 Thread khemis haythem
  Khemis Haythem Adresse: BoitePostale 101  4118, Mednine GSM : +216 55 69 19 90 E-mail : khemis.hayt...@yahoo.fr Statut : Élèveingénieur  Spatialité : Géniedes Communications etdesRéseaux  Ecole : Ecole National d'IngénieursdeGabes      hello,  I was just hoping if anyone could provide me with

Re: [Wireshark-dev] (no subject)

2014-03-28 Thread Hadriel Kaplan
Start here: http://wiki.wireshark.org/Development https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=doc/README.dissector https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=doc/README.developer -hadriel On Mar 28, 2014, at 8:49 PM, khemis haythem