[Wireshark-dev] Difference between Autofoo and CMake build ?

2014-07-24 Thread Bill Meier
(For Jörg Mayer) While reviewing the new ceph dissector [1], two issues cropped up where my build on Linux (using Autofoo) apparently gave different results then a build by Kevin Cox (the submitter of the new dissector) using CMake on Linux. He used GCC 4.9.1 and CMake while I used GCC

Re: [Wireshark-dev] Difference between Autofoo and CMake build ?

2014-07-24 Thread Joerg Mayer
On Thu, Jul 24, 2014 at 11:58:51AM -0400, Bill Meier wrote: While reviewing the new ceph dissector [1], two issues cropped up where my build on Linux (using Autofoo) apparently gave different results then a build by Kevin Cox (the submitter of the new dissector) using CMake on Linux. He

Re: [Wireshark-dev] Difference between Autofoo and CMake build ?

2014-07-24 Thread Kevin Cox
On 24/07/14 12:36, Joerg Mayer wrote: On Thu, Jul 24, 2014 at 11:58:51AM -0400, Bill Meier wrote: While reviewing the new ceph dissector [1], two issues cropped up where my build on Linux (using Autofoo) apparently gave different results then a build by Kevin Cox (the submitter of the new

[Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Joerg Mayer
IIRC there was some discussion which versions of VS should still be supported, but I failed to find it in the archives. So, was there some consensus which is the oldest version we are going to support with master? Thanks Jörg -- Joerg Mayer

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 18:08, Joerg Mayer jma...@loplof.de wrote: IIRC there was some discussion which versions of VS should still be supported, but I failed to find it in the archives. So, was there some consensus which is the oldest version we are going to support with master? I brought up the

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Joerg Mayer
On Thu, Jul 24, 2014 at 06:20:48PM +0100, Graham Bloice wrote: On 24 July 2014 18:08, Joerg Mayer jma...@loplof.de wrote: IIRC there was some discussion which versions of VS should still be supported, but I failed to find it in the archives. So, was there some consensus which is the

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Pascal Quantin
Le 24/07/2014 19:39, Joerg Mayer a écrit : On Thu, Jul 24, 2014 at 06:20:48PM +0100, Graham Bloice wrote: On 24 July 2014 18:08, Joerg Mayer jma...@loplof.de wrote: IIRC there was some discussion which versions of VS should still be supported, but I failed to find it in the archives. So, was

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Joerg Mayer
On Thu, Jul 24, 2014 at 07:51:37PM +0200, Pascal Quantin wrote: Le 24/07/2014 19:39, Joerg Mayer a écrit : [...] Hmm, OK. So we need an updated developer's guide setup section. I will try to update my Windows vom 2010 to 2013 and see how it goes - just have to find out how to snapshot the

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 18:51, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24/07/2014 19:39, Joerg Mayer a écrit : On Thu, Jul 24, 2014 at 06:20:48PM +0100, Graham Bloice wrote: On 24 July 2014 18:08, Joerg Mayer jma...@loplof.de wrote: IIRC there was some discussion which versions of VS

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 18:59, Joerg Mayer jma...@loplof.de wrote: On Thu, Jul 24, 2014 at 07:51:37PM +0200, Pascal Quantin wrote: Le 24/07/2014 19:39, Joerg Mayer a écrit : [...] Hmm, OK. So we need an updated developer's guide setup section. I will try to update my Windows vom 2010 to 2013

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Pascal Quantin
Le 24 juil. 2014 20:00, Graham Bloice graham.blo...@trihedral.com a écrit : On 24 July 2014 18:51, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24/07/2014 19:39, Joerg Mayer a écrit : On Thu, Jul 24, 2014 at 06:20:48PM +0100, Graham Bloice wrote: On 24 July 2014 18:08, Joerg Mayer

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 19:03, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24 juil. 2014 20:00, Graham Bloice graham.blo...@trihedral.com a écrit : On 24 July 2014 18:51, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24/07/2014 19:39, Joerg Mayer a écrit : On Thu, Jul 24, 2014 at

Re: [Wireshark-dev] Difference between Autofoo and CMake build ?

2014-07-24 Thread Kevin Cox
On 24/07/14 12:54, Kevin Cox wrote: On 24/07/14 12:36, Joerg Mayer wrote: On Thu, Jul 24, 2014 at 11:58:51AM -0400, Bill Meier wrote: While reviewing the new ceph dissector [1], two issues cropped up where my build on Linux (using Autofoo) apparently gave different results then a build by

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-24 Thread Bálint Réczey
Hi Jakub, 2014-07-22 0:52 GMT+02:00 darkjames...@darkjames.pl: Hi, On Sat, Jul 12, 2014 at 02:27:06AM +0200, B??lint R??czey wrote: I plan using ASAN for all programs which would catch (among others) use-after-free and reading below or over the malloc()-ed memory area. Those can't be

Re: [Wireshark-dev] tvb allocator (was: Re: [Wireshark-commits] master b6d20a2: Optimize reseting epan_dissect_t when filtering.)

2014-07-24 Thread Evan Huus
On Thu, Jul 24, 2014 at 2:42 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Jakub, 2014-07-22 0:52 GMT+02:00 darkjames...@darkjames.pl: Hi, On Sat, Jul 12, 2014 at 02:27:06AM +0200, B??lint R??czey wrote: I plan using ASAN for all programs which would catch (among others)

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 19:06, Graham Bloice graham.blo...@trihedral.com wrote: On 24 July 2014 19:03, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24 juil. 2014 20:00, Graham Bloice graham.blo...@trihedral.com a écrit : On 24 July 2014 18:51, Pascal Quantin pascal.quan...@gmail.com wrote:

Re: [Wireshark-dev] Difference between Autofoo and CMake build ?

2014-07-24 Thread Bill Meier
On 7/24/2014 2:09 PM, Kevin Cox wrote: I usually get these too. Maybe it was a compiler bug or something. I will try checking out the old version and doing a clean build to see if the warning/error shows up now. I just did a complete rebuild and I am now getting this error under CMake as

[Wireshark-dev] const'ness of value_string_ext

2014-07-24 Thread Kevin Cox
Hello All, While working on the new Ceph dissector I made a mistake using value_string_ext (herein evs) where I declared them 'const' which was causing an error when they were put in a read-only segment of the executable. Thankfully Bill Meier was able to figure out why it was crashing on his

Re: [Wireshark-dev] const'ness of value_string_ext

2014-07-24 Thread Evan Huus
On Thu, Jul 24, 2014 at 4:35 PM, Kevin Cox kevin...@kevincox.ca wrote: Hello All, While working on the new Ceph dissector I made a mistake using value_string_ext (herein evs) where I declared them 'const' which was causing an error when they were put in a read-only segment of the

Re: [Wireshark-dev] const'ness of value_string_ext

2014-07-24 Thread Kevin Cox
On 24/07/14 16:38, Evan Huus wrote: We are usually not afraid of breaking API changes (whether that's a good thing or not is debatable, but it's true) so probably solution 2 if somebody wants to tackle it :) I others agree I will start by just changing the extended value string functions

Re: [Wireshark-dev] Buildbot updates

2014-07-24 Thread Gerald Combs
I upgraded the fuzz testing buildslave to Ubuntu 14.04. The new version of scan-build (clang+LLVM 3.4) crashes on packet-parlay.c. We also jumped from 39 to 47 scan-build issues. I also installed VS 2013 Professional on each of the Windows buildslaves (production and Petri Dish). Builds are still

Re: [Wireshark-dev] Oldest version of VS supported?

2014-07-24 Thread Graham Bloice
On 24 July 2014 20:02, Graham Bloice graham.blo...@trihedral.com wrote: On 24 July 2014 19:06, Graham Bloice graham.blo...@trihedral.com wrote: On 24 July 2014 19:03, Pascal Quantin pascal.quan...@gmail.com wrote: Le 24 juil. 2014 20:00, Graham Bloice graham.blo...@trihedral.com a écrit :