Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Sultan, Hassan via Wireshark-dev
> -Original Message- > From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf > Of Alexis La Goutte > Sent: Tuesday, August 08, 2017 2:09 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Hierarchy of fields &

[Wireshark-dev] checkapi prefs

2017-08-08 Thread Dario Lombardo
I've got this error from checkAPI_epan target: prefs.c: error: found these preference variables used in more than one prefs_register_*_preference: guint *var, const char **var, , range_t **var I can't figure out what does it mean. Can anyone help?

Re: [Wireshark-dev] checkapi prefs

2017-08-08 Thread Michael Mann via Wireshark-dev
See https://code.wireshark.org/review/22974 This was added to help developer mistakes, but maybe there is a legitimate reason? (or regex in checkAPI needs tweeking) -Original Message- From: Dario Lombardo To: Developer support list for Wireshark

Re: [Wireshark-dev] checkapi prefs

2017-08-08 Thread Ahmad Fatoum
prefs_register_*_preference populates a variable with a user-supplied value. And having more than one preference populate the same variable is usually not what you want. But the actual definitions of the function do just that: They use the same variable name and similar types for the variable. I

[Wireshark-dev] TCAP SRT analysis

2017-08-08 Thread Conall Prendergast
Hi All, The TCAP SRT analysis is broken in 2.2.8 and 2.4. I have written a bug on it here . This was broken in this recent change, which does fix another broken issue in v2.2.7.

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Alexis La Goutte
On Tue, Aug 8, 2017 at 12:29 AM, Sultan, Hassan via Wireshark-dev < wireshark-dev@wireshark.org> wrote: Hi Hasan, Can you share your tools ? i can be add to wireshark for found some violation/error... Coming back on this and how to solve it, here's a suggestion I have, let me > know what you